wilderrodrigues
3c8b217262
Refactoring the LibvirtComputingResource
...
- Adding LibvirtCheckOnHostCommandWrapper and LibvirtOvsCreateTunnelCommandWrapper
- 4 unit tests added
- KVM hypervisor plugin with 16.2% coverage
2015-05-06 19:24:12 +02:00
wilderrodrigues
6748a73b82
Refactoring the LibvirtComputingResource
...
- Adding 4 new command wrappers
- 12 unit tests added
- KVM hypervisor plugin with 15.5% coverage
2015-05-06 19:24:12 +02:00
wilderrodrigues
5499eecd33
Refactoring the LibvirtComputingResource
...
- Adding 7 new command wrappers
- 10 unit tests added
- KVM hypervisor plugin with 14.8% coverage
2015-05-06 19:24:12 +02:00
wilderrodrigues
4887ce7254
Refactoring the LibvirtComputingResource
...
- Adding LibvirtOvsDestroyBridgeCommandWrapper, LibvirtOvsSetupBridgeCommandWrapper
- 4 unit tests added
- KVM hypervisor plugin with 13.9% coverage
More tests added to cover LibvirtPrepareForMigrationCommandWrapper
- Coverage of this wrapper broght from 37% to 90.6%
- 4 new tests added
2015-05-06 19:24:11 +02:00
wilderrodrigues
0d860af659
Refactoring the LibvirtComputingResource
...
- Adding LibvirtDeleteStoragePoolCommandWrapper, LibvirtGetStorageStatsCommandWrapper and LibvirtUpgradeSnapshotCommandWrapper
- 7 unit tests added
- KVM hypervisor plugin with 13.6% coverage
2015-05-06 19:24:11 +02:00
wilderrodrigues
8268d353a2
Refactoring the LibvirtComputingResource
...
- Adding LibvirtPrimaryStorageDownloadCommandWrapper
- 4 unit tests added
- KVM hypervisor plugin with 13.3% coverage
2015-05-06 19:24:11 +02:00
wilderrodrigues
4472cade2f
Refactoring the LibvirtComputingResource
...
- Adding LibvirtDestroyCommandWrapper
- 2 unit tests added
- KVM hypervisor plugin with 12.9% coverage
2015-05-06 19:24:11 +02:00
wilderrodrigues
cb4670279f
Refactoring the LibvirtComputingResource
...
- Adding LibvirtCreateCommandWrapper and LibvirtMaintainCommandWrapper
- 4 unit tests added
- KVM hypervisor plugin with 12.7% coverage
2015-05-06 19:24:10 +02:00
wilderrodrigues
6f757c6bf0
Refactoring the LibvirtComputingResource
...
- Adding LibvirtModifySshKeysCommandWrapper
- 1 unit test added
- KVM hypervisor plugin with 12.3% coverage
2015-05-06 19:24:10 +02:00
wilderrodrigues
f14c7c2074
Refactoring the LibvirtComputingResource
...
- Adding LibvirtGetVncPortCommandWrapper
- 2 unit tests added
- KVM hypervisor plugin with 12.1% coverage
2015-05-06 19:20:43 +02:00
wilderrodrigues
7319a12600
Refactoring the LibvirtComputingResource
...
- Adding LibvirtCheckConsoleProxyLoadCommandWrapper, LibvirtConsoleProxyLoadCommandWrapper, LibvirtWatchConsoleProxyLoadCommandWrapperand CitrixConsoleProxyLoadCommandWrapper
- 2 unit tests added
- KVM hypervisor plugin with 12% coverage
Refactored the CommandWrapper interface in order to remove the esecuteProxyLoadScan, which is now
implemented bu subclasses.
2015-05-06 19:20:43 +02:00
wilderrodrigues
08a9523dcd
Fixing assertion on the tests that are execting exceptions
2015-05-06 19:20:43 +02:00
wilderrodrigues
40886b337c
Refactoring the LibvirtComputingResource
...
- Adding LibvirtAttachVolumeCommandWrapper
- 3 unit tests added
- KVM hypervisor plugin with 11.7% coverage
2015-05-06 19:20:42 +02:00
wilderrodrigues
4d216f1a63
Refactoring the LibvirtComputingResource
...
- Adding LibvirtAttachIsoCommandWrapper, LibvirtAttachIsoCommandWrapper and LibvirtAttachIsoCommandWrapper
- 7 unit tests added
- KVM hypervisor plugin with 11.5% coverage
2015-05-06 19:20:42 +02:00
wilderrodrigues
be1e517615
Refactoring the LibvirtComputingResource
...
- Adding LibvirtPingTestCommandWrapper
- 3 unit tests added
- KVM hypervisor plugin with 11.2% coverage
2015-05-06 19:20:42 +02:00
wilderrodrigues
28e55462f1
Refactoring the LibvirtComputingResource
...
- Adding LibvirtMigrateCommandWrapper
- 1 unit tests added
- KVM hypervisor plugin with 10.9% coverage
2015-05-06 19:20:41 +02:00
wilderrodrigues
d730efb866
Refactoring the LibvirtComputingResource
...
- Adding LibvirtCheckHealthCommandWrapper and LibvirtPrepareForMigrationCommandWrapper
- 2 unit tests added
- KVM hypervisor plugin with 10.8% coverage
2015-05-06 19:20:41 +02:00
wilderrodrigues
54f68f519f
Removing the CheckStateCommand form the IF statement on LibvirtComputingResource
...
- It's not used and if so would cause an infinite loop.
2015-05-06 19:20:41 +02:00
wilderrodrigues
6e568125fc
Refactoring the LibvirtComputingResource
...
- Adding LibvirtGetHosStatsCommandWrapper
- 1 unit test added
- KVM hypervisor with 10.5% coverage
Tests are a bit limited on this one becuause of the current implementation. Would clean it up later in a separate branch
2015-05-06 19:20:41 +02:00
wilderrodrigues
7a90c018fb
Refactoring the LibvirtComputingResource
...
- Adding LibvirtRebootCommandWrapper and LibVirtRebootRouterCommandWrapper
- 2 unit tests added
- KVM hypervisor with 10.5% coverage
2015-05-06 19:20:40 +02:00
wilderrodrigues
51093afcf1
Refactoring the LibvirtComputingResource
...
- Adding LibvirtGetVmDiskStatsCommandWrapper
- 1 unit test
Added getConnection() to LibvirtConnectionWrapper
2015-05-06 19:20:40 +02:00
wilderrodrigues
7086d64387
Refactoring the LibvirtComputingResource
...
- Adding LibvirtGetVmStatsCommandWrapper
- 3 unit tests
Refactored the LibvirtConnectiobn by surrounding it with an wrapper.
- Make it easier to cover the static/native calls
- Added better coverage to StopCommand tests
2015-05-06 19:20:40 +02:00
wilderrodrigues
508f10527f
Refactoring the LibvirtComputingResource
...
- Adding LibvirtStopCommandWrapper
- LibvirtRequestWrapper
- 1 unit tests
Refactored the RequestWrapper to make it better.
- Changes also applied to the CitrixRequestWrapper
2015-05-06 19:20:39 +02:00
Laszlo Hornyak
58e5dca8ef
CLOUDSTACK-8335: removed ceph repository - artifact resolved from maven central
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
2015-05-01 11:10:06 +05:30
Anshul Gangwar
aa265fe88f
CLOUDSTACK-8431: [Hyper-V] Fixed VM deployment failing when the stale vhd already exists Now generating guid when the template copy from secondary to primary storage requested instead of using it same as secondary
...
this closes #214
2015-04-30 16:07:36 +05:30
Anshul Gangwar
866cc41145
CLOUDSTACK-8423: [Xenserver] Improved the performance for processing of ClusterVMMetaDataSync command which can cause slowness in DB if there are huge number of VMs
...
this closes #204
2015-04-30 14:44:36 +05:30
Anshul Gangwar
48067e5ecd
CLOUDSTACK-8420: [Hyper-V] Fixed number format exception when untagged vlan is used for Hyper-V setup Change the vlan data type to string from int and handled the untagged vlan cases
...
this closes #201
2015-04-30 14:43:22 +05:30
Anshul Gangwar
7949caf156
CLOUDSTACK-8419: [Hyper-V] corrected the wrong error message in stop command answer
...
this closes #200
2015-04-30 14:42:46 +05:30
Anshul Gangwar
f86c0a23c1
CLOUDSTACK-8418: [Hyper-V] use systemvm.iso from secondary storage and stop copying to local disk
...
this closes #198
2015-04-30 14:42:24 +05:30
Anshul Gangwar
c355810034
CLOUDSTACK-8417 : [Hyper-V] Added support for smb share path in Hyper-V settings virtual disk path
...
this closes #197
2015-04-30 14:41:50 +05:30
Anshul Gangwar
c275d6fff8
CLOUDSTACK-8414: fixed template_spool_ref is not getting updated with correct template local_path
...
this closes #195
2015-04-30 14:36:58 +05:30
Anshul Gangwar
fda627d672
CLOUDSTACK-8414: Fixed template_spool_ref table is not getting updated with correct template_size Now returning file size instead of null.
2015-04-30 14:36:39 +05:30
Rohit Yadav
1d99a38096
CLOUDSTACK-8424: enable cpu flags only for guest VMs
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-30 04:13:07 +02:00
Daan Hoogland
7b10591758
findbugs: String.split() will not return nulls by contract
2015-04-29 16:07:38 +02:00
wilderrodrigues
3b0c031b9f
Using the SSHCmdHelper instead of a SSH Session.
2015-04-29 13:05:21 +02:00
Rajani Karuturi
0b8355920e
Merge branch 'volume-upload' into master
...
This closes #206
2015-04-29 11:12:53 +05:30
Rohit Yadav
29b8800660
kvm: add VMXNET3 nic adapter to nic models
...
Linux kernel supports vmxnet3, allowing it in KVM plugin would allow us to
run ESX hosts on KVM hosts using CloudStack with vmxnet3 nic which can be
passed as VM's nicAdapter detail
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit e02d787f30 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-28 18:23:55 +02:00
Rohit Yadav
58cc569273
CLOUDSTACK-8424: Add cpu features if guest.cpu.features is set
...
This improvements checks for "guest.cpu.features" property which is a space
separated list of cpu features that is specific for a host. When added, it
will add <feature policy='require' name='{{feature-you-listed}}'/> in the
<cpu> section of the generated vm spec xml.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit ea7fd37783 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-28 13:19:49 +02:00
Likitha Shetty
04365601da
CLOUDSTACK-8412. VM migration with storage fails.
...
Update MigrateWithStorageCommand to avoid JSON deserialization error.
2015-04-28 10:22:00 +05:30
Likitha Shetty
f45e6b94ed
CLOUDSTACK-8405: Restore VM results in deletion of data disk.
...
Dont evict template when a delete command has been sent to VMware resource for deletion of volume.
2015-04-27 16:37:46 +05:30
Laszlo Hornyak
9cf31b0714
CLOUDSTACK-8335: removed libvirt.org repository
...
The only artifact resolved from libvirt.org was org.libvirt:libvirt:0.5.1
this artifact is now available from maven's default central repository
This closes #180
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-24 16:58:59 +02:00
Rohit Yadav
05e4ba7350
kvm: fallback to eu.ceph.com mvn repo as ceph.com is down
...
As suggested by Wido on the dev ML changing the repo to eu.ceph.com to avoid
build failures. Will revert if ceph.com is up again.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit c9fd57fff3 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-16 17:37:11 +05:30
Rohit Yadav
06e353e5c7
vmware: support vmfs as local storage pool type
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 752d784d92 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-16 17:36:52 +05:30
Remi Bergsma
ac06ec02eb
kvm: improve CentOS 7 support
...
CentOS 7 does not ship with ifconfig anymore. We should use ip commands instead.
This also works on older versions, like CentOS 6 and Ubuntu 12.x/14.x, that we
support.
This closes #165
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-14 16:51:14 +05:30
Rohit Yadav
ccf13ec04e
kvm: xml escape password
...
(cherry picked from commit 13de2691fd )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
2015-04-13 16:10:42 +05:30
Rohit Yadav
7949d2922d
vmware: plugin improvements
...
- use sticky chmod 1777 on the mountpoint
- remove dead code
(cherry picked from commit eea716b791 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-13 15:49:01 +05:30
Rohit Yadav
37820e15f2
CLOUDSTACK-7593: allow nic type to be fetched from vm's details
...
(cherry picked from commit 43db75c319 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
2015-04-13 15:47:03 +05:30
Daan Hoogland
cb02a32f79
findbugs: boxing/unboxing removed
2015-04-12 20:16:13 +02:00
Daan Hoogland
72b2422623
findbugs: removed identical override for CitrixResourceBase method
...
transferManagementNetwork
2015-04-12 20:10:20 +02:00
Daan Hoogland
332da26cb9
findbugs: unused retry count causing unintended useless null guard
2015-04-12 19:58:05 +02:00
KC Wang
01864ef77c
CLOUDSTACK-6697: bigswitch networking plugin update
...
1. provide compatibility with the Big Cloud Fabric (BCF) controller
L2 Connectivity Service in both VPC and non-VPC modes
2. virtual network terminology updates: VNS --> BCF_SEGMENT
3. uses HTTPS with trust-always certificate handling
4. topology sync support with BCF controller
5. support multiple (two) BCF controllers with HA
6. support VM migration
7. support Firewall, Static NAT, and Source NAT with NAT enabled option
8. add VifDriver for Indigo Virtual Switch (IVS)
This closes #151
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-09 13:02:02 +05:30
wilderrodrigues
096d1b93b0
This closes #146
...
Refactoring the NetworkUsageCommand wrapper in order to cope with new design
- Unit tests added: 100% coverage
2015-04-05 13:24:45 +02:00
wilderrodrigues
02d1cdd49a
Refactoring the MigrateVolumeCommand wrapper in order to cope with new design
...
- Unit tests added: 43.1% coverage
- It's a bit difficult to test the Xen API classes due to their static nature
2015-04-05 09:23:10 +02:00
wilderrodrigues
f6e162afe4
Refactoring the MigrateWithStorageCompleteCommand wrapper in order to cope with new design
...
- Unit tests added: 50% coverage
- It's a bit difficult to test the Xen API classes due to their static nature
2015-04-05 09:23:10 +02:00
wilderrodrigues
d5414d26b4
Refactoring the MigrateWithStorageSendCommand wrapper in order to cope with new design
...
- Unit tests added: 47.2% coverage
- It's a bit difficult to test the Xen API classes due to their static nature
2015-04-05 09:23:10 +02:00
wilderrodrigues
c5a2f926e0
Refactoring the MigrateWithStorageReceiveCommand wrapper in order to cope with new design
...
- Unit tests added: 65% coverage
- It's a bit difficult to test the Xen API classes due to their static nature
2015-04-05 09:23:09 +02:00
wilderrodrigues
858b87f01c
Refactoring the MigrateWithStorageCommand wrapper in order to cope with new design
...
- Unit tests added: 30.1% coverage
- It's a bit difficult to test the Xen API classes due to their static nature
2015-04-05 09:23:09 +02:00
wilderrodrigues
240bcb8120
Refactoring the GetGPUStatsCommand wrapper in order to cope with new design
...
- Unit tests added: 100% coverage
2015-04-05 09:23:09 +02:00
wilderrodrigues
bcee7281c6
Started refctoring the remaining XenServer resources
...
- Just cleaning the formating
2015-04-05 09:23:09 +02:00
wilderrodrigues
3f89cd6494
Adding license headers that made RAT fail
...
- Test classes affected
This closes #143
2015-04-03 10:43:30 +02:00
wilderrodrigues
3d22a16c4f
Bump priority stragety is no longer used for redundant virtual routers
...
- With the changes added by the rVPC work, the bump priority became deprecated.
This commit includes a refactor to get it removed from the following resources:
* Java classes
* domain_router table - removing the is_priority_bumpup column
* Fixing unit tests
All changes were tested with:
XenServer 6.2 running under our VMWare zone
CloudStack Management Server running on MacBook Pro
MySql running on MackBook Pro
Storage Type: Local
2015-04-02 21:50:49 +02:00
wilderrodrigues
57d0931b49
Adding more tests to cover other possibilities concerning different versions of the XenServer
...
Adding a better algorithm in order to corver deeper inheritance form the command classes
Removing some unsued variables.
2015-03-31 16:49:48 +02:00
wilderrodrigues
d93935caac
We don't need the Start, Stop, Reboot command in the CitrixRebaseClaas anymore.
2015-03-31 10:38:33 +02:00
wilderrodrigues
3ad30a01a8
Refactoring XenServer56NetworkUsageCommandWrapper in order to cope with the new design
...
- Unit tests added
CitrixResourceBase, XenServer56Resource and XenServer56FP1Resource are now done.
i
2015-03-31 10:38:33 +02:00
wilderrodrigues
f3842c81f8
Refactoring XenServer56 and 56FP1 Resources in order to cope with new FenceCommandWrapper
...
- Unit tests added
Also removed an unit test that was doing nothing.
2015-03-31 10:38:33 +02:00
wilderrodrigues
4600eef87c
Removing all private/protected/public execute() methods from CitrixResourceBase class
...
Started the refactor of the XenServer56Resource class
- Unit test added
Changing the CitrixRequestWrapper in order to cope with multiple resources classes and commands
Still have to remove few methods form CitrixResourceBase
2015-03-31 10:38:32 +02:00
wilderrodrigues
02571728c6
Refactored the remaining commands
...
- Unit tests added
In the executeRequest I needed to keep the following:
// We need this one because the StorageSubSystemCommand is from another hierarchy.
if (cmd instanceof StorageSubSystemCommand) {
return storageHandler.handleStorageCommands((StorageSubSystemCommand) cmd);
}
2015-03-31 10:38:32 +02:00
wilderrodrigues
24bbfbc1e6
Refactoring other 8 command wrapper in order to cope with the new design
...
- Advanced unit tests added for half of the commands
- Basic unit tests added for the other half
2015-03-31 10:38:32 +02:00
wilderrodrigues
fbcae54a5b
Refactoring NetworkRulesSystemVmCommand, OvsCreateTunnelCommand, OvsDestroyBridgeCommand, OvsDestroyTunnelCommand, OvsSetupBridgeCommand in order to
...
cope with new design.
- Meny unit ests added.
2015-03-31 10:38:31 +02:00
wilderrodrigues
751c14b929
Refactoring CleanupNetworkRulesCmd, OvsCreateGreTunnelCommand, OvsDeleteFlowCommand, OvsVpcPhysicalTopologyConfigCommand and OvsVpcRoutingPolicyConfigCommand
...
in order to cope with the new design.
- Meny new unit tests added that cover more than the basics!
2015-03-31 10:38:31 +02:00
wilderrodrigues
30b770aeab
Refactoring CheckSshCommand, OvsFetchInterfaceCommand and SecurityGroupRulesCommand to cope with new design.
...
- Unit Tests added
2015-03-31 10:38:30 +02:00
wilderrodrigues
74faf73408
Refactoring CheckOnHostCommand, ModifySshKeysCommand, OvsSetTagAndFlowCommand and StartCommand to cope with new design
...
- Unit tests added
2015-03-31 10:38:30 +02:00
wilderrodrigues
18470a48d0
Refactoring PingTestCommand to cope with new design
...
- Basic tests added
2015-03-31 10:38:30 +02:00
wilderrodrigues
3a70912b7c
Make methods in subclasses public.
...
Remove the if-commands that I have already refactored.
2015-03-31 10:38:29 +02:00
wilderrodrigues
637a56c3c1
Refactoring GetVncPortCommand, MaintainCommand and SetupCommand to cope with new design.
...
- Basic test added, but could not mock all the static stuff so the test is not complete yet.
Will look further into it.
2015-03-31 10:38:29 +02:00
wilderrodrigues
11d0336803
Refactoring GetStorageStatsCommand and PrimaryStorageDownloadCommand to cope with the new design
...
Fix the NPE in the constructor that was never used
- Basic tests added for all changes
2015-03-31 10:38:29 +02:00
wilderrodrigues
ea374b6a2f
Refactoring AttachIsoCommand, AttachVolumeCommand and UpgradeSnapshotCommand to cope with new design
...
- Basic tests added
2015-03-31 10:38:28 +02:00
wilderrodrigues
6c775951c7
Refactoring DeleteStoragePoolCommand, ModifyStoragePoolCommand and ResizeVolumeCommand to cope with new design
...
- Basic tests added.
2015-03-31 10:38:28 +02:00
wilderrodrigues
a06958f469
Refactoring DestroyCommand and CreateStoragePoolCommand wrappers to cope with the new design
...
- Basic tests added
s Please enter the commit message for your changes. Lines starting
2015-03-31 10:38:27 +02:00
wilderrodrigues
a70d80dfd6
Refactoring PrepareForMigrationCommand and MigrateCommand in order to cope with the new design
...
- Basic tests added
2015-03-31 10:38:27 +02:00
wilderrodrigues
cb07b0ba08
Refactoring the CitrixCheckVirtualMachineCommand toc ope with new design
...
- Added basic tests
- Added tests for RebootRouterCommand
- Removed the code from CitrixResourceBase that has already been refactored
2015-03-31 10:38:27 +02:00
wilderrodrigues
f2fab5c8c3
Refactoring the CitrixRebootCommand in order to have the new design applied
...
- Added basic tests
- Changed the way RebootCommand gets called from RebootRouterCommand
- Made a couple of methods public in the CitrixResourceBase and its subclasses
2015-03-31 10:38:27 +02:00
wilderrodrigues
9e41b8051e
Renaming files
...
- Forgot to add "Citrix" before the new command wrappers
2015-03-31 10:38:26 +02:00
wilderrodrigues
6b80c79986
Refactoring the StopCommand on CitrixResourceBase to cope with new design
...
- Added basic tests
2015-03-31 10:38:26 +02:00
wilderrodrigues
c7830efef5
Refactor the CheckHealthCommand and GetVmDiskStatsCommand classes in CitrixResourceBase
...
- Added basic tests for both wrappers
2015-03-31 10:38:26 +02:00
wilderrodrigues
8f04108e23
Refactoring the GetVmStatsCommand
...
- Added basic tests
2015-03-31 10:38:25 +02:00
wilderrodrigues
0e51379da7
Refactoring the GetHostStatsCommand
...
- Added basic tests
- Added test for when the key (Command) does not exist in the Map
2015-03-31 10:38:25 +02:00
wilderrodrigues
30e72e4a15
Refactoring the whole XsHost thing
...
Refactor the ReadyCommand
Fixing the old test
Adding basic tests for ReadyCommandWrapper
2015-03-31 10:38:25 +02:00
wilderrodrigues
c3ae8c793b
Adding the refactor of CitrixCheckConsoleProxyLoadCommandWrapper.java and CitrixWatchConsoleProxyLoadCommandWrapper.java
...
- plus basic tests
2015-03-31 10:38:24 +02:00
wilderrodrigues
4256418af9
Adding CitrixCreateCommandWrapper.java and basic unit tests
2015-03-31 10:38:24 +02:00
wilderrodrigues
a1e8778211
First piece of the refactor of the CitrisResourceBase
...
- The same pattern will be used by the other subclasses of the ServerResource interface.
2015-03-31 10:38:24 +02:00
Daan Hoogland
b6d2b62aa7
imports in test
2015-03-27 15:59:32 +01:00
Daan Hoogland
4e1997ff5a
imports :8
2015-03-27 15:38:25 +01:00
Funs
e7d7643dd7
Only one thing can come from the agent
2015-03-27 11:19:16 +01:00
Funs
d0e25d96fb
Fix paths so they also work with tests on windows.
...
Sonarcube is great, but has no context and can be wrong, in this
case File.separator is nice if you're running platform independent,
the agent on OVM3 is however NOT platform independent and will break
if we feed it windows separators.
2015-03-27 11:14:35 +01:00
Daan Hoogland
6a821730ce
Boolean -> boolean
2015-03-25 22:20:40 +01:00
Daan Hoogland
048212b117
findbugs: Boolen function should not return null
2015-03-25 21:46:47 +01:00
Daan Hoogland
724699424e
findbugs: boxing/unboxing
2015-03-25 21:20:39 +01:00
Daan Hoogland
1552c912a7
findbugs: parseLong instead of boxing/deboxing
2015-03-25 18:36:12 +01:00
Daan Hoogland
340aa9ff0f
findbugs: make default encoding explicit
2015-03-25 18:31:08 +01:00