etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
cloudstack/engine
History
Gabriel Beims Bräscher a78f676037
engine: fix network with SG disabled still has security group script adding rules on KVM (#5049) 
This PR fixes #5047 which can be reproduced on Zones with _(I) Advanced Networks, (II) Security Groups enabled for the Zone, (III)  network offering without Security Groups_; for instance, `DefaultSharedNetworkOffering` which does not list Security Group as supported service.

The issue is due to the following code inside the method `VirtualMachineManagerImpl.orchestrateReboot`:
[VirtualMachineManagerImpl.java#L3340](280c13a4bb/engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java (L3340)).

```
  final Answer rebootAnswer = cmds.getAnswer(RebootAnswer.class);
  if (rebootAnswer != null && rebootAnswer.getResult()) {
      if (dc.isSecurityGroupEnabled() && vm.getType() == VirtualMachine.Type.User) {
          List<Long> affectedVms = new ArrayList<Long>();
          affectedVms.add(vm.getId());
          _securityGroupManager.scheduleRulesetUpdateToHosts(affectedVms, true, null);
      }
      return;
  }
```
 		2021-05-31 15:52:26 +05:30
..
api Updating pom.xml version numbers for release 4.14.2.0-SNAPSHOT 2021-03-02 12:32:27 +05:30
components-api forceha: fix two issues when (1)stop vm from inside (2) force remove host (#4647) 2021-05-14 23:14:39 +05:30
network Updating pom.xml version numbers for release 4.14.2.0-SNAPSHOT 2021-03-02 12:32:27 +05:30
orchestration engine: fix network with SG disabled still has security group script adding rules on KVM (#5049) 2021-05-31 15:52:26 +05:30
schema Updating pom.xml version numbers for release 4.14.2.0-SNAPSHOT 2021-03-02 12:32:27 +05:30
service Updating pom.xml version numbers for release 4.14.2.0-SNAPSHOT 2021-03-02 12:32:27 +05:30
storage Fix npe when migrating vm with volume (#4698) (#4775) 2021-04-06 11:54:29 +05:30
pom.xml Updating pom.xml version numbers for release 4.14.2.0-SNAPSHOT 2021-03-02 12:32:27 +05:30