mirror of https://github.com/apache/cloudstack.git
66a933afab
CLOUDSTACK-9181 Prevent syntax error in checkrouter.shAdded quotes to prevent syntax errors in weird situations. Error seen in mgt server: ``` 2015-12-15 14:30:32,371 DEBUG [c.c.a.m.AgentManagerImpl] (RedundantRouterStatusMonitor-7:ctx-0dd8ef3e) Details from executing class com.cloud.agent.api.CheckRouterCommand: Status: UNKNOWN /opt/cloud/bin/checkrouter.sh: line 28: [: =: unary operator expected /opt/cloud/bin/checkrouter.sh: line 31: [: =: unary operator expected ``` Cause: ``` root@r-1191-VM:/opt/cloud/bin# ./checkrouter.sh ./checkrouter.sh: line 28: [: =: unary operator expected ./checkrouter.sh: line 31: [: =: unary operator expected Status: UNKNOWN ``` Somehow a nic was missing. After fix the script can handle this: ``` root@r-1191-VM:/opt/cloud/bin# ./checkrouter.sh Status: UNKNOWN ``` The other states are also reported fine: ``` root@r-1191-VM:/opt/cloud/bin# ./checkrouter.sh Status: MASTER ``` ``` root@r-1192-VM:/opt/cloud/bin# ./checkrouter.sh Status: BACKUP ``` While at it, I also removed the INTERFACES variable/constant as it was only used once and hardcoded the second time. Now both are hardcoded and easier to read. * pr/1296: make both check lines consistent CLOUDSTACK-9181 Prevent syntax error in checkrouter.sh Signed-off-by: Remi Bergsma <github@remi.nl> |
||
|---|---|---|
| .. | ||
| bindir | ||
| certs | ||
| conf | ||
| conf.dom0 | ||
| css | ||
| distro | ||
| images | ||
| js | ||
| libexec | ||
| patches/debian | ||
| scripts | ||
| test/python | ||
| ui | ||
| vm-script | ||
| pom.xml | ||
| systemvm-descriptor.xml | ||