cloudstack/plugins
Remi Bergsma 614ee494ee Merge pull request #700 from rafaelweingartner/master-lrg-cs-hackday-001
Removed duplicate code in CitrixResourceBase and its subclassesRemoved unnecessary duplicated code by having the body of the getPatchFiles method only in the CitrixResourceBase superclass. Given that all of its implementations consisted of the same code except for the path which contains the necessary file for that implementation. An abstract method getPatchFilePath was created in the CitrixResourceBase superclass so that each implementation may return the path containing the specific file needed by that implementation.

Test cases were created for each implementation, simple as they may be. One assert is made to verify that the path returned by each implementation corresponds to the path that was previously specified on each getPatchFiles implementation.

* pr/700:
  Removed duplicate code in CitrixResourceBase.getPatchFiles

Signed-off-by: Remi Bergsma <github@remi.nl>
2015-08-20 11:20:00 +02:00
..
acl/static-role-based Allow custom command role ACL files on classpath in Static Role API Checker. 2015-07-01 14:43:29 +02:00
affinity-group-processors Updating pom.xml version numbers for release 4.5.2-SNAPSHOT 2015-05-07 15:33:01 +02:00
alert-handlers Updating pom.xml version numbers for release 4.5.2-SNAPSHOT 2015-05-07 15:33:01 +02:00
api Updating pom.xml version numbers for release 4.5.2-SNAPSHOT 2015-05-07 15:33:01 +02:00
database/mysql-ha CLOUDSTACK-8656: debug messages on interupted exceptions 2015-07-30 16:03:10 +02:00
dedicated-resources Updating pom.xml version numbers for release 4.5.2-SNAPSHOT 2015-05-07 15:33:01 +02:00
deployment-planners Updating pom.xml version numbers for release 4.5.2-SNAPSHOT 2015-05-07 15:33:01 +02:00
event-bus coverity 1291768: file input stream not severe unless repetitive (property file usually aren't) 2015-07-09 21:30:23 +02:00
file-systems/netapp Updating pom.xml version numbers for release 4.5.2-SNAPSHOT 2015-05-07 15:33:01 +02:00
ha-planners/skip-heurestics Updating pom.xml version numbers for release 4.5.2-SNAPSHOT 2015-05-07 15:33:01 +02:00
host-allocators/random Merge branch 'PR-REVIEW-335' 2015-07-06 11:48:38 +05:30
hypervisors Merge pull request #700 from rafaelweingartner/master-lrg-cs-hackday-001 2015-08-20 11:20:00 +02:00
network-elements Refactored Nic.java for readability. 2015-08-18 14:04:48 +02:00
storage Merge pull request #654 from DaanHoogland/CLOUDSTACK-8656 2015-08-14 21:38:49 +02:00
storage-allocators/random Updating pom.xml version numbers for release 4.5.2-SNAPSHOT 2015-05-07 15:33:01 +02:00
user-authenticators Merge pull request #654 from DaanHoogland/CLOUDSTACK-8656 2015-08-14 21:38:49 +02:00
pom.xml Updating pom.xml version numbers for release 4.5.2-SNAPSHOT 2015-05-07 15:33:01 +02:00