cloudstack/plugins/hypervisors
Remi Bergsma 614ee494ee Merge pull request #700 from rafaelweingartner/master-lrg-cs-hackday-001
Removed duplicate code in CitrixResourceBase and its subclassesRemoved unnecessary duplicated code by having the body of the getPatchFiles method only in the CitrixResourceBase superclass. Given that all of its implementations consisted of the same code except for the path which contains the necessary file for that implementation. An abstract method getPatchFilePath was created in the CitrixResourceBase superclass so that each implementation may return the path containing the specific file needed by that implementation.

Test cases were created for each implementation, simple as they may be. One assert is made to verify that the path returned by each implementation corresponds to the path that was previously specified on each getPatchFiles implementation.

* pr/700:
  Removed duplicate code in CitrixResourceBase.getPatchFiles

Signed-off-by: Remi Bergsma <github@remi.nl>
2015-08-20 11:20:00 +02:00
..
baremetal Refactored Nic.java for readability. 2015-08-18 14:04:48 +02:00
hyperv Refactored NicProfile.java for readability. 2015-08-17 14:12:10 +02:00
kvm CLOUDSTACK-8749: KVM - cleanup linklocal interface based on names 2015-08-19 21:43:24 +05:30
ovm Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in OvmResourceBase.java 2015-06-22 10:50:48 +02:00
ovm3 Specify all dependency versions in pom.xml 2015-06-22 13:01:19 +02:00
simulator CLOUDSTACK-8656: class in json specified not found 2015-08-14 16:29:21 +02:00
ucs Fix findbugs warning in UcsManagerImpl.java Integer was being created to assign value to int 2015-06-15 12:09:37 +03:00
vmware Refactored Nic.java for readability. 2015-08-18 14:04:48 +02:00
xenserver Removed duplicate code in CitrixResourceBase.getPatchFiles 2015-08-17 13:26:25 -03:00