mirror of https://github.com/apache/cloudstack.git
f1ec4fddd3
Description: As part of the fix for Bug CS-13127, a new overloaded function, addProxyObject() was added to facilitate transparent db id to uuid conversions when db IDs were added to exceptions that were thrown in the Cloudstack mgmt server code. However, it turns out that there are quite many db IDs still in the code that are being directly embedded in the String message that is passed during exception creation. In this commit, we modify the default constructor of InvalidParameterValueException so that it takes a second argument of type List<IdentityProxy>. This will help developers see that there is a second parameter required, and make them look into what that parameter is about. Hopefully, this will stop db IDs from being embedded into the exception message. The parameter can be set to null though, since there are many places in the code that don't embed any DB IDs in the exception. This is still a WIP, so the older default constructor for InvalidParameterValueException has not been removed yet. When all instances of throw new InvalidParameterValueException() have been moved over to the new default constructor, the old one will be removed, else compilation will break. The reason for having to do this in batches is that there are way too many places in the code that throw exceptions, and they all cannot be covered in a single commit without it taking much time. In following commits, all other exceptions will be changed in the same way as InvalidParameterValueException. |
||
|---|---|---|
| .. | ||
| bindir | ||
| certs | ||
| conf | ||
| src | ||
| test | ||
| .classpath | ||
| .project | ||
| LICENSE | ||