mirror of https://github.com/apache/cloudstack.git
Removed unnecessary code from getGuestOsType in CitrixResourceBaseConsidering that all mapping of Guest OS Names to their respective hypervisor compatible types is made thorugh accessing a database, we've decided to remove a bit of code in the XcpOssResource class which was doing that same thing for 2 different OS's (both of which ARE in the database). That has led us to a bunch of unused parameters in the getGuestOsType method from its superclass, which we've also decided to remove. Test cases were added for four different possibilities for the platformEmulator String: one for a null String, one for a blank String, one for an empy String and one for a random case with a valid String. * pr/1262: Remove test cases duplicated code. Removed unnecessary code from getGuestOsType in CitrixResourceBase Signed-off-by: Will Stevens <williamstevens@gmail.com> |
||
|---|---|---|
| .. | ||
| acl/static-role-based | ||
| affinity-group-processors | ||
| alert-handlers | ||
| api | ||
| database | ||
| dedicated-resources | ||
| deployment-planners | ||
| event-bus | ||
| file-systems/netapp | ||
| ha-planners/skip-heurestics | ||
| host-allocators/random | ||
| hypervisors | ||
| network-elements | ||
| storage | ||
| storage-allocators/random | ||
| user-authenticators | ||
| pom.xml | ||