mirror of https://github.com/apache/cloudstack.git
17d5bfa32c
CLOUDSTACK-8868: use PasswordGenerator.generateRandomPassword() to generate systemvm passwordsgenerateRandomPassword() is supposed to create root user passwords. Right now it is only used on the guest VMs. The format of the passwords it creates are of the form "random 3-character string with a lowercase character, uppercase character, and a digit" + random n-character string with only lowercase characters". For whatever reason it was that we use generateRandomPassword() for guest VM root user passwords(maybe more secure?) we should use the same function for system VM root user passwords. Tests: manually tested that password is generated in proper format and am able to login to cpvm with the new password. ex: zD2ztm, tR8snbwhq ``` $ mvn -pl server test -Dtest=ConfigurationServerImplTest#testUpdateSystemvmPassword ------------------------------------------------------- T E S T S ------------------------------------------------------- Running com.cloud.server.ConfigurationServerImplTest log4j:WARN No appenders could be found for logger (com.cloud.utils.crypt.EncryptionSecretKeyChecker). log4j:WARN Please initialize the log4j system properly. log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info. Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.487 sec - in com.cloud.server.ConfigurationServerImplTest Results : Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 7.781 s [INFO] Finished at: 2015-09-16T14:17:07+05:30 [INFO] Final Memory: 60M/466M [INFO] ------------------------------------------------------------------------ ``` * pr/841: CLOUDSTACK-8868: change the default vm.password.length to 10 CLOUDSTACK-8868: use same method to generate passwords for system/guest vms removed commented code Signed-off-by: Remi Bergsma <github@remi.nl> |
||
|---|---|---|
| .. | ||
| cloud | ||