etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #751 from shapeblue/master-CLOUDSTACK-8766 

CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal iso/template listing

Due to aggregation of templates and isos on the UI/client side, it could result
that for each page we could end up having lesser templates/isos listed to have
the scroll shown that triggers infinite scrolling. The fix is to use similar
approach as in projects.js, to use the maximum pagesize of 500. In theory, there
is still a chance if there are 500 zones with the same template being listed
resulting in only one aggregated template which could cause the scroll to not
get shown; but in practice I believe this fix should work for most users.

(cherry picked from commit 8a1cc7aac6f3d9a0a1686e2dae8dd12b74ed9cdd)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* pr/751:
  CLOUDSTACK-8766: Fix infinite scrolling pagination for zonal iso/template listing

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This commit is contained in:
Rohit Yadav 2015-08-31 14:28:11 +05:30
parent 53cba7c741 a6e8cfde3f
commit 215a43dfaf
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ui/scripts/templates.js
View File

@ -879,6 +879,10 @@
dataProvider: function(args) {
var data = {};
listViewDataProvider(args, data);
// Due to zonal grouping, low pagesize can result lower
// aggregated items, resulting in no scroll shown
// So, use maximum pagesize
data.pagesize = 200;
var ignoreProject = false;
if (args.filterBy != null) { //filter dropdown
@ -2024,6 +2028,10 @@
dataProvider: function(args) {
var data = {};
listViewDataProvider(args, data);
// Due to zonal grouping, low pagesize can result lower
// aggregated items, resulting in no scroll shown
// So, use maximum pagesize
data.pagesize = 200;
var ignoreProject = false;
if (args.filterBy != null) { //filter dropdown