etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

coverity 1308118: more resources being opened only one closed on exception nothing was closed 

Signed-off-by: Daan Hoogland <daan@onecht.net>
This commit is contained in:
Daan Hoogland 2015-07-07 12:34:10 +02:00
parent bcc8182f2f
commit 6376503fe3
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
View File

@ -5052,12 +5052,11 @@ public abstract class CitrixResourceBase implements ServerResource, HypervisorRe
}
if (result && content != null && !content.isEmpty()) {
try {
final File file = new File(folder+"/"+fileName+".txt");
final OutputStreamWriter fw = new OutputStreamWriter(new FileOutputStream(file.getAbsoluteFile()),"UTF-8");
final BufferedWriter bw = new BufferedWriter(fw);
File file = new File(folder+"/"+fileName+".txt");
try (OutputStreamWriter fw = new OutputStreamWriter(new FileOutputStream(file.getAbsoluteFile()),"UTF-8");
BufferedWriter bw = new BufferedWriter(fw);
) {
bw.write(content);
bw.close();
s_logger.debug("created file: "+ file + " in folder:"+folder);
} catch (final IOException ex) {
s_logger.debug("Failed to create file "+ ex.getMessage());