etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix findbugs DMI_RANDOM_USED_ONLY_ONCE warning in TransportAddress.java Changed to recommended SecureRandom instead of Random 

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #416
This commit is contained in:
Rafael da Fonseca 2015-06-14 16:28:37 +02:00 committed by Rohit Yadav
parent 4e0fe469dd
commit 89a07084c5
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
framework/ipc/src/org/apache/cloudstack/framework/transport/TransportAddress.java
View File

@ -19,7 +19,7 @@
package org.apache.cloudstack.framework.transport;
import java.util.Random;
import java.security.SecureRandom;
public class TransportAddress {
public final static String LOCAL_SERVICE_NODE = "";
@ -29,6 +29,7 @@ public class TransportAddress {
private int _connectionId = LOCAL_SERVICE_CONNECTION;
private String _endpointId;
private int _magic;
private final SecureRandom randomGenerator=new SecureRandom();
public TransportAddress(String nodeId, int connectionId, String endpointId) {
assert (nodeId != null);
@ -39,7 +40,7 @@ public class TransportAddress {
_nodeId = nodeId;
_connectionId = connectionId;
_endpointId = endpointId;
_magic = new Random().nextInt();
_magic = randomGenerator.nextInt();
}
public TransportAddress(String nodeId, int connectionId, String endpointId, int magic) {