etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VmWorkJobDispatcher.java Assert isn't used in prod runtime, null is properly checked in method 

Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #446
This commit is contained in:
Rafael da Fonseca 2015-06-14 21:25:35 +02:00 committed by Daan Hoogland
parent d056c3d279
commit a2129b2940
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
engine/orchestration/src/com/cloud/vm/VmWorkJobDispatcher.java
View File

@ -71,7 +71,6 @@ public class VmWorkJobDispatcher extends AdapterBase implements AsyncJobDispatch
}
work = VmWorkSerializer.deserialize(workClz, job.getCmdInfo());
assert(work != null);
if(work == null) {
s_logger.error("Unable to deserialize VM work " + job.getCmd() + ", job info: " + job.getCmdInfo() + ", job origin: " + job.getRelated());
_asyncJobMgr.completeAsyncJob(job.getId(), JobInfo.Status.FAILED, 0, "Unable to deserialize VM work");