Commit Graph

34836 Commits

Author SHA1 Message Date
Abhishek Kumar 24da2bcf78
marvin: fix test_data for parsing failure (#7602)
PR #6512 seems to have broken the test_data.py. This PR fixes test_data.
2023-06-08 15:32:04 +05:30
Pearl Dsilva bd5d478a3a
Refactor test and change IP range (#6512)
* Refactor test and change IP range

* countdown from 254 to allow multiple pseudo public nets counting up from 0

* cleanup

* location of asserts improved

---------

Co-authored-by: dahn <daan.hoogland@gmail.com>
Co-authored-by: Daan Hoogland <daan@onecht.net>
2023-06-05 16:39:33 +02:00
dahn dffbc87278
escapes for injection prtection (#7069) 2023-01-10 11:54:51 +01:00
mrog 77df050160
Reset unusable db connections (#6725)
When the management service detects a broken database connection, it didn't do anything about it. It already has code to reset the connection, but that doesn't get used. This change causes the connection to be reset after it's found to be unusable.

Fixes #6724 (see issue for repro steps)
2022-09-13 14:12:53 +05:30
Rohit Yadav 4ed1be821c Tagging release 4.16.1.1 on branch b7415bf127.
-----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCAAdFiEEXtHhEi3F6KSkURLCSEJIIQ7j2IQFAmLQBOkACgkQSEJIIQ7j
 2IS+nRAAl8qEGHMCtbh64Uc517UwsATEZwEqm+s5cWrbi6GpkuJ00ITnchgK1QvY
 q9NQudL548oYWB8pvmeql8eeVJFGx4loh8e32GXdW5dNDcmIC/0YZ7VJFokPuHf6
 79GEDfcui5A15mvIL8DyTSHlZd/6x3LKusfM5Nu3f88B75yy1AkfxH8JcVTM8P9/
 ijtVTpy8zWkBWO+nnFUiwRjcQStOwNKd1jHxoapJIpFlNcUZw2DkRlaVIV7uU+ne
 Z7Y4JAJHzvki4ewkl/F5XwkRPiZlEMXVgEAb4dUmt5hg4GCWQvuDvHDio4fQ6Ws1
 CSNdiSV5rKMxa/fcE4l/oxvZ5oGxA7afbyJWo6Y4/s+UENKmZ3LiehkTptuOTSh0
 rgBTUKO7ZPtYuqD6kwaKYoxL431zYRJsdF1TUnts4nJTQQsWn6JlA3oTsX7nxlte
 qdxRtqmE7NTcpNH/+sU8MDKBYaHEqF3VOfzhw5Ta8ztQhebrGMHPJX0i3ypDBAll
 QEVH+cMpIoo5MQZWRFnIeKW/uTZuEZAMcJ8a/AS7gHSjLtiNGJExE5qvVXVnP8Im
 PruZSmk1ZovQ/XbtN0SD0DDS93CppYFH6fJRAeq6yqkEnYUm+dxFkBvEZqp8nr/X
 Z3vySZlH08+iz3fLlpbkGJRZSUfFXYKrGyZjLaFvKIf0FpedfOM=
 =/arX
 -----END PGP SIGNATURE-----

Merge tag '4.16.1.1' into 4.16

Tagging release 4.16.1.1 on branch b7415bf127.
2022-07-18 19:34:32 +05:30
Rohit Yadav ebfdef5777 Updating pom.xml version numbers for release 4.16.1.1
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-07-14 17:28:08 +05:30
Rohit Yadav b7415bf127 saml: Safer DocumentBuilderFactory and ParserPool configuration
This implements safer DocumentBuilderFactory and ParserPool utilities
to be used throughout the codebase to prevent potential XXE exploits.

References:
https://cheatsheetseries.owasp.org/cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.html
https://www.blackhat.com/docs/us-15/materials/us-15-Wang-FileCry-The-New-Age-Of-XXE-java-wp.pdf

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 8e0e68ef368ebe2793ef80e2c3821eaecb47b593)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-07-14 16:58:08 +05:30
Pearl Dsilva 15a2cc6c68
Specify vm snapshot uuid in response over db id in the async job response (#6449) 2022-06-10 07:45:11 -03:00
Nicolas Vazquez b1c8b5ab37
[KVM] Fix VM migration error due to VNC password on libvirt limiting versions (#6404)
* [KVM] Fix VM migration error due to VNC password on libvirt limiting versions

* Fix passwd value

* Simplify implementation
2022-05-23 08:12:49 -03:00
Nicolas Vazquez dc975dff95
[KVM] Enable IOURING only when it is available on the host (#6399)
* [KVM] Disable IOURING by default on agents

* Refactor

* Remove agent property for iouring

* Restore property

* Refactor suse check and enable on ubuntu by default

* Refactor irrespective of guest OS

* Improvement

* Logs and new path

* Refactor condition to enable iouring

* Improve condition

* Refactor property check

* Improvement

* Doc comment

* Extend comment

* Move method

* Add log
2022-05-23 08:11:14 -03:00
Nicolas Vazquez 363a2cff82
Backport: kvm: truncate vnc password to 8 chars (#6244) (#6402)
* kvm: truncate vnc password to 8 chars (#6244)

This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt.

* Use lang3 string utils

Co-authored-by: Wei Zhou <weizhou@apache.org>
2022-05-20 11:36:43 -03:00
Nicolas Vazquez b62b5c96e8
Prevent NPE on reboot stopped VM and startVM output with null displayname (#6397)
* Prevent NPE on reboot stopped VM

* Use VM UUID instead of VM ID

* Apply suggestion

* Refactor and fix start VM output

* Use format instead of concatenation
2022-05-20 11:31:47 -03:00
Nicolas Vazquez 006473ca19
Log exception on keystore build for custom certificate (#6394)
* Log exception on keystore build for custom certificate

* Refactor
2022-05-18 10:29:00 -03:00
Suresh Kumar Anaparti d373f973ba
Update VM name, when the new name provided in updateVirtualMachine API in different case. (#6379) 2022-05-12 07:15:19 -03:00
Pearl Dsilva 556f9dac0f
ui: Network offerings not listed if listVPCs not available in the account Role (#6354) 2022-05-04 23:14:47 -03:00
Nicolas Vazquez efb1f2b719
UI: Fix templates page redirection after delete job is finished (#6345) 2022-05-03 13:59:47 -03:00
Nicolas Vazquez 5fa8fa5580
Fix upload volume format (#6297) 2022-04-22 17:19:30 -03:00
Suresh Kumar Anaparti b2338f7158
Updated reset configuration, to return the updated config value in the response (#6284) 2022-04-19 17:07:51 -03:00
Nicolas Vazquez 365966dd0a
UI: Fix custom unconstrained for a zone does not show CPU speed (#6285) 2022-04-19 09:48:26 -03:00
Wei Zhou bbb4ffa593
UI: fix dedicate public ip range to domain (#6258) 2022-04-14 01:19:23 -03:00
Nicolas Vazquez fbf77978e1
Fix: Allow disabling the login attempts mechanism for disabling users (#6254)
* Fix: Allow disabling the login attempts mechanism for disabling users

* Refactor
2022-04-14 01:11:43 -03:00
slavkap 42a92dcdd3
Extract the IO_URING configuration into the agent.properties (#6253)
When using advanced virtualization the IO Driver is not supported. The
admin will decide if want to enable/disable this configuration from
agent.properties file. The default value is true
2022-04-13 08:43:35 -03:00
Wei Zhou 91a5f0e285
server: honor global setting system.vm.default.hypervisor as first option when deploy VRs (#6160) 2022-04-13 07:22:22 -03:00
Wei Zhou 19a7774cab
VR: add rules for traffic between static nat and private gateway static routes (#6153) 2022-04-12 13:26:51 -03:00
Pearl Dsilva b6072fc826
Allow expunging a VM on a deleted host when using host cache and ConfigDrive userdata service (#6234) 2022-04-11 11:19:37 -03:00
dahn ee2ded8200
potential null pointer in condition; AYAI9l8k5Irk9_td-cXb (#6237)
Co-authored-by: Daan Hoogland <dahn@onecht.net>
2022-04-11 16:07:11 +05:30
Abhishek Kumar e7071ec196
server: increment deviceid while importing vm data volumes (#6123)
Fixes #6121

deviceId for a volume/disk is never used by CloudStack VMware hypervisor plugin. Still it would be correct to increment value for each data volume/disk, behaviour similar to adding data volumes/disks.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-04-08 15:24:10 +05:30
Wei Zhou c61ea9f96d
VR: Do not add iptables rules for the revoked ip addresses (#6189) 2022-04-06 00:16:47 -03:00
Wei Zhou 47454eca7d
VR: add '-m <protocol>' for tcp or udp protocol (#6188) 2022-04-06 00:16:12 -03:00
Abhishek Kumar 66a6671e0b
ui,refactor: fix missing label in update network form (#6181)
updateinsequence param for updateNetwork API wasn't have correponding label in UI.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-04-01 13:12:50 -03:00
Wei Zhou ee27708ffb
SAML: replace first number with random alphabet if request ID starts with a number (#6165) 2022-03-29 23:59:44 -03:00
Nicolas Vazquez a69ab3b28f
Ensure configdrive path is edited properly during live migration (#6173) 2022-03-29 10:09:08 +02:00
Pearl Dsilva 908f594f00
configDrive: Fix failure to delete (unstarted) VM (#6146)
* configDrive: Fix failure to delete (unstarted)VM

* Address comments

* Address comments
2022-03-29 09:56:54 +02:00
Pearl Dsilva bcd1a3274a
api: Fix reset configuration (#6168) 2022-03-29 09:54:34 +02:00
Wei Zhou f4b9ab034b
UI: fix create l2 network offering with userdata (#6174) 2022-03-28 23:32:10 -03:00
Michael fb43076f9e
Fix linux native bridge for SUSE in cloudutils (#6134)
* fix linux native bridge for SUSE

* apply suggestion
2022-03-23 13:42:15 -03:00
Pearl Dsilva f8b648b938
Fix migration of VM with volume on Ubuntu (#6116)
* Fix migration of VM with volume on Ubuntu

* address comment
2022-03-20 23:14:24 -03:00
Pearl Dsilva 4be99fe971
api: Allow updating VM settings when custom contrained offering is used (#6136) 2022-03-18 09:09:40 +01:00
Pearl Dsilva 75b54171ae
Travis - fix test failures observed (#6119) 2022-03-16 07:03:14 -03:00
Wei Zhou 6ff378f6a3
travis: run nosetests-2.7 (#6113) 2022-03-14 11:19:12 -03:00
Nicolas Vazquez 067c1de080
Fix get upload params NPE (#6079) 2022-03-10 09:33:50 -03:00
Wei Zhou 3a456f1b31
server: mark volume snapshots as Destroyed if it does not exist on primary and secondary storage when delete a volume (#6057)
* server: mark volume snapshots as Destroyed in some cases when delete a volume in QCOW2 format

when delete a volume in QCOW2 format, if volume snapshot does not exist on primary and secondary storage, mark the snapshot as Destroyed.

* Update #6057: remove check on volume format
2022-03-10 08:49:03 -03:00
Pearl Dsilva 00c1bdb365
UI: Reload page on closing Bulk Action modal (#6077) 2022-03-09 13:31:04 -03:00
David Jumani c2bcad8571
ui: Set icon to osdisplayname to avoid multiple api calls (#6075) 2022-03-09 07:00:09 -03:00
Nicolas Vazquez 7fbfd4c6ea
UI: Fix navigation to domains (#6072) 2022-03-09 06:54:55 -03:00
David Jumani 6b913a76cf
ui: Add user initials as avatar if no icon present (#6070)
* ui: Add user avatar if no icon

* set initials to uppercase
2022-03-08 12:55:00 -03:00
Nicolas Vazquez e4d70d4214
UI: Fix Autogenview cleared resource (#6066) 2022-03-08 07:53:22 -03:00
Wei Zhou 84f19d8f36
UI: update vm with userdata (#6051)
* UI: update vm with userdata

* Update ui/src/views/compute/EditVM.vue

Co-authored-by: David Jumani <dj.davidjumani1994@gmail.com>

* Update #6051: small fixes

Co-authored-by: David Jumani <dj.davidjumani1994@gmail.com>
2022-03-07 07:59:52 -03:00
Suresh Kumar Anaparti 2820a36f86
Check the network access when deploying VM in Advanced Security Group. (#6050)
* Check the network access when deploying VM in Advanced Security Group.

* Removed comment

* Removed redundant network access check, owner access check already exists
2022-03-06 10:07:57 -03:00
Nicolas Vazquez c366511294
UI: Missing message on VM import for not found networks (#6055) 2022-03-04 14:22:18 -03:00