wilderrodrigues
527d6ee77b
Making possible to update KVM hosts password in the database via the API
...
- Make sure the doUpdateHostPassword() method returns the result from the answer, not always true
- Added the LibvirtUpdateHostPasswordCommandWrapper class, which will handle the changes in the KVM agent
That's will be further implemented in the future. The command will avoid the agent to complain about Unsupported command
- Added a test to make sure the current implementation of the comment works
- If changes in the future, it will also require changes. In that way, we make sure nobody will break it
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
This closes #527
2015-06-29 09:59:12 +02:00
Daan Hoogland
8a8849354c
findbugs: masking fields removed
2015-06-24 12:24:12 +02:00
Daan Hoogland
e8984d16ed
findbugs: move assert to a place where it still makes sense
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2015-06-23 23:27:03 +02:00
Rafael da Fonseca
fe4f0b1a58
Specify all dependency versions in pom.xml
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #497
2015-06-22 13:01:19 +02:00
Rafael da Fonseca
83488e01af
Reduce about 1k String objects from being instantiated
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-22 13:01:19 +02:00
Rafael da Fonseca
9d19191bc6
Root cause of failure is memory abuse in XenTest.java class ;) This should fix it
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-22 13:01:19 +02:00
Rafael da Fonseca
301a7b9a7e
Specify all external dependencies in pom Upgrade to lang3 and change usage of deprecated xmlparse method
...
Add another missing dependency
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-22 13:01:19 +02:00
Rafael da Fonseca
1603f722c4
Cleanup some lint checker warning in base classes
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-22 13:01:18 +02:00
Rafael da Fonseca
540b163cfc
Resolve unsafe cast warnings reported by lint checker Add some debug config to compiler plugin
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-22 13:01:18 +02:00
Rafael da Fonseca
0d8c64ea56
Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in OvmResourceBase.java
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #502
2015-06-22 10:50:48 +02:00
Rafael da Fonseca
dc359c505e
Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in BareMetalResourceBase.java
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #501
2015-06-22 10:50:12 +02:00
Daan Hoogland
bbb165a037
findbugs: use preferred encoding explicitly
2015-06-20 10:36:15 +02:00
Daan Hoogland
9eff27a080
findbugs: static member should be final
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
This closes #495
2015-06-20 00:57:59 +02:00
Daan Hoogland
871ba9c521
findbugs: ignored return value should have been returned down stack
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
This closes #494
2015-06-20 00:57:01 +02:00
Daan Hoogland
e3407a3939
findbugs: encoding using preferred Charset
2015-06-19 23:03:05 +02:00
Sanjay Tripathi
9044a02d9a
VM Snapshot Usage for DATA disk is reported as the size of the DATA disk instead of the actual snapshot size.
...
This closes #485
2015-06-19 15:55:21 +05:30
Daan Hoogland
0952580096
findbugs: try-with-resource to circumvent not handling an exception on
...
close
2015-06-17 12:41:04 +02:00
Daan Hoogland
6da6c5f762
findbugs: log unhandled exception as warning
2015-06-17 12:35:39 +02:00
Sanjay Tripathi
d702b63bfb
CLOUDSTACK-8569: The latter snapshot export for the same volume will fail is 2 snapshot exports are queued
...
This closes #469
2015-06-17 15:27:03 +05:30
Sanjay Tripathi
47278556f5
CLOUDSTACK-8567 Migrating primary storage causes name_label field to blank.
...
This closes #468
2015-06-17 14:46:51 +05:30
Daan Hoogland
41c1fddaee
findbugs: better message and fallback to defaultCharset
2015-06-16 11:57:15 +02:00
Rafael da Fonseca
0851e4e54b
Catch encoding exception
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #464
2015-06-16 11:24:51 +02:00
Rafael da Fonseca
9f2ebdf443
Fix findbugs encoding issue in VmwareStorageProcessor.java Any encoding would do fine as it's just used to generate a UUID. Sticking with UTF-8 for consistency
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #460
2015-06-16 08:56:33 +02:00
Rafael da Fonseca
9bb920af65
Fix findbugs warning in VmwareStorageManagerImpl.java Any encoding would do fine as it's just used to generate a UUID. Sticking with UTF-8 for consistency
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #461
2015-06-16 08:53:56 +02:00
Rafael da Fonseca
3d48af41a8
Fix findbugs encoding issue in VmwareResource.java Key file should be UTF-8 encoded in VR
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #462
2015-06-16 08:51:54 +02:00
Wido den Hollander
4b4c52ea77
CLOUDSTACK-8560: Stat the resulting image after copying from template and return the size
...
This way we update the DB with the actual size of the disk after deployment from template
2015-06-15 17:55:56 +02:00
Rafael da Fonseca
be474f95a1
Fixed 4 findbugs warnings in CitrixResourceBase.java Unnecessary boxing/unboxing of primitive values
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #425
2015-06-15 12:09:39 +03:00
Rafael da Fonseca
16ddd498d5
Fix findbugs warning in UcsManagerImpl.java Integer was being created to assign value to int
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #424
2015-06-15 12:09:37 +03:00
Rafael da Fonseca
9ba4e9cb86
Fix findbugs warning in OvmResourceBase.java CreatePrivateTemplateAnswer constructor takes long as physicalSize parameter, Long was being created instead
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #423
2015-06-15 12:09:36 +03:00
Rafael da Fonseca
9d2fef0de8
Fix findbugs warning in HypervDirectConnectResource.java Two boxed Longs were being created instead of simple long
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #422
2015-06-15 12:09:34 +03:00
Rafael da Fonseca
30457556f9
Fix findbugs warning in BareMetalResourceBase.java Boxed Integer was being instantiated to assign to an int variable
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #421
2015-06-15 12:09:32 +03:00
Rafael da Fonseca
85ad1b7e0f
Fix 3 findbugs encoding warnings in VmwareStorageProcessor.java Ova templates and metadata should be written to file in UTF-8 Fix warning in UUID generation
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #411
2015-06-15 12:09:13 +03:00
Rafael da Fonseca
ccd7d41ee3
Resolve findbugs encoding warning
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #392
2015-06-15 12:07:55 +03:00
Rafael da Fonseca
967da97f51
Fix 2 findbugs warnings in VmwareStorageManagerImpl.java Template files and metadata should be written to file in UTF-8
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #410
2015-06-15 12:06:19 +03:00
Rafael da Fonseca
11fec86ba3
Fix 1 findbugs warning in VmwareResource.java
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #409
2015-06-15 12:06:11 +03:00
Rafael da Fonseca
474065e98b
Fix findbugs encoding warning in VmwareServerDiscoverer.java Input string should only contain safe characters, since it's derived from a Long object. This just gets rid of the findbugs warning
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #408
2015-06-15 12:06:01 +03:00
Rafael da Fonseca
f8b364b7c7
Was safe either way as this piece of code should only run in linux, this just gets rid of the findbugs warning
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #402
2015-06-15 12:04:47 +03:00
Rafael da Fonseca
3299f23ea2
Fix findbugs encoding warning in LibvirtCreatePrivateTemplateFromVolumeCommandWrapper Libvirt templates should be written in UTF-8, default was already doing that so this just gets rid of the findbugs warning
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #401
2015-06-15 12:04:24 +03:00
Rafael da Fonseca
b869a16332
Remove unused import to fix checkstyle warning
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #400
2015-06-15 12:04:19 +03:00
Rafael da Fonseca
949e97dec6
Fix findbugs warning in LibvirtConsoleProxyLoadCommandWrapper Encoding is now specified in both server and clients for the console proxy getstatus command For some reason, findbugs did not detect unsafe encoding issue in ConsoleProxyResource.java, is properly specified now though... CitrixConsoleProxyLoadCommandWrapper was specifying system default encoding for operation, should be ok because default for xenserver is UTF-8 since it's linux based, but it's best to specify exact encoding set on the server end to be consistent
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-06-15 12:04:18 +03:00
Rafael da Fonseca
cc6d28fc98
Fix another findbugs encoding warning in CitrixResourceBase In this case, using default encoding is desired, since the purpose is to read shell command output, which uses the platform's default encoding. This gets rid of the findbugs warning.
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #396
2015-06-15 11:59:48 +03:00
Rafael da Fonseca
faa38ad416
Fix findbugs encoding warning in CitrixResourceBase Output of text files should be UTF-8, this is the default for linux, will now always use the same format for every platform
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #395
2015-06-15 11:59:38 +03:00
Sateesh Chodapuneedi
5e41a830a5
This closes #373
...
CLOUDSTACK-3317 - DVS does not support management\storage network
Added support for Management and Storage Network traffic over VMware DVS in CloudStack deployments. Also added support for storage VLAN over dvPortGroup.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
CLOUDSTACK-3317 - DVS does not support management\storage network
Use non-zero dvport count while updating dvportgroups of system traffic.
Updated configuration compare logic to avoid update dvportgroup operation unless required.
This would help improve speed in vm/network deployment as the update calls would reduce. Also improved logging.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
Adding unit tests in class HypervisorHostHelperTest
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
Added license header to new file being added to repo/branch.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2015-06-10 02:07:40 +05:30
Daan Hoogland
b272d7717e
Revert "Fix 2 findbugs high priority warnings"
...
This reverts commit 1ca74dac26 .
2015-06-08 10:01:19 +02:00
Rafael da Fonseca
e8c7069f73
Fix findbugs high priority warning VmwareStorageManagerImpl.java:1023, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE, Priority: High Redundant nullcheck of datastoreVolumePath, which is known to be non-null in com.cloud.hypervisor.vmware.manager.VmwareStorageManagerImpl.getVolumePathInDatastore(DatastoreMO, String)
...
Assertion is not used in runtime, correct way is throw and handle exception without killing app
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #362
2015-06-08 09:40:50 +02:00
Rafael da Fonseca
38c269d71e
Fix performance issue reported by findbugs (unnescessary boxing/unboxing) VmwareResource.java:693, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High VmwareResource.java:4769, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.hypervisor.vmware.resource.VmwareResource.getNetworkStats(String)
...
Now op is faster and takes up less memory
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #365
2015-06-08 09:32:52 +02:00
Rafael da Fonseca
1ca74dac26
Fix 2 findbugs high priority warnings
...
VmwareResource.java:315, MS_SHOULD_BE_FINAL, Priority: High
com.cloud.hypervisor.vmware.resource.VmwareResource.s_serviceContext isn't final but should be
VmwareResource.java:331, MS_SHOULD_BE_FINAL, Priority: High
com.cloud.hypervisor.vmware.resource.VmwareResource.s_powerStatesTable isn't final but should be
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #363
2015-06-08 09:24:07 +02:00
wilderrodrigues
93845afd53
Using a try-wioth resrouce block as suggested in @DaanHoogland review.
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #355
2015-06-04 12:34:05 +02:00
wilderrodrigues
7f4e2c7cf0
Renaming the variable from "s" to "script"
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-04 12:34:05 +02:00
wilderrodrigues
6138d9a690
Coverity issue 1116812 - Replacing concatenation with optionsBuffer.append(option.getKey()).append('=').append(option.getValue()).append(',');
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-04 12:34:05 +02:00
wilderrodrigues
9ff38486a1
Coverity issue 1116677 - Avoiding catching only Exception. Makes the code too britle. - Catching the QemuImgException and throwing it to be caught further in the code - Surrounding the output stream with try/catch and throwing it to be further handled in the code. Closing the output stream quietly.
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-04 12:34:05 +02:00
wilderrodrigues
6271663682
Formatting the code - Adding final modifier and indenting the code
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-04 12:34:04 +02:00
wilderrodrigues
fe78c76691
Coverity issue: 1012179 - Commenting out unused variable.
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-04 12:34:03 +02:00
wilderrodrigues
159d8c2c97
Formatting the code - Adding final modifier to attributes and indenting the code.
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-04 12:34:03 +02:00
Daan Hoogland
3d4d152753
CID 1302976 Scanner in try-with-resource
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #352
2015-06-04 00:09:40 +02:00
Daan Hoogland
109b6e94d3
CID 1302974: Scanner in try-with-resource
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #353
2015-06-04 00:09:16 +02:00
Rohit Yadav
f341246888
CLOUDSTACK-8530: KVM hosts without active agents should be in Disconnected state
...
KVM hosts which are actuall up, but if their agents are shutdown should be put
in disconnected state. This would avoid getting the VMs HA'd and other commands
such as deploying a VM will exclude that host and save us from errors.
The improvement is that, we first try to contact the KVM host itself. If it fails
we assume that it's disconnected, and then ask its KVM neighbours if they can
check its status. If all of the KVM neighbours tell us that it's Down and we're
unable to reach the KVM host, then the host is possibly down. In case any of the
KVM neighbours tell us that it's Up but we're unable to reach the KVM host then
we can be sure that the agent is offline but the host is running.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
This closes #340
2015-06-02 13:27:16 +02:00
wilderrodrigues
607a63b12d
Mocking the Connect object used in the LibvirtMigrateCommandWrapper
...
When executing the tests in an environment where Libvirt is also installed, it
caused errors.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #342
2015-06-01 21:11:25 +02:00
wilderrodrigues
b267c5fc5a
Replacing real IPs by 127.0.0.1. - It was causing problems in some environments - The Ips should have been removed in a previous commit, but some of them were missed
...
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
This closes #325
2015-05-29 11:25:40 +02:00
Jayapal
b616522088
CLOUDSTACK-8324: Corrected the file paths for xenserver command files
...
This closes #315
2015-05-28 17:02:09 +05:30
Jayapal
6e96fc6f38
CLOUDSTACK-8324: Updated import and added ResourceWrapper annotation
2015-05-28 15:56:37 +05:30
Jayapal
3a8d1f7c55
CLOUDSTACK-8324: Added unit test cases for GetVmIpAddressCommand
2015-05-28 15:56:37 +05:30
Jayapal
e407986183
CLOUDSTACK-8324: Added config drive support for xenserver
2015-05-28 15:51:50 +05:30
Jayapal
7984ae5283
CLOUDSTACK-8324: Resource base changes for vm ip fetch
2015-05-28 15:42:08 +05:30
wilderrodrigues
b155129ae8
Fixing the packaging of the Xen resource tests - The package declaration of all Test classes was point to a package that was not represented as a directory - For example: Class A had "package b.c.d;" as declaration, but the class A was under directory "c"
...
Maven was bulding the project and executing the tests just fine because it uses "-sourcepath". However,
with IDEs and javac it would fail.
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
This closes #317
2015-05-27 16:06:33 +02:00
wilderrodrigues
ce9014d2ec
Fix the NPE tht was being caught by the executeRequest() method. - The LibvirtUtilitiesHelper should have been injected, but it did not work on the Agent side. Due to that, when sending a StartCommand we were experiencing NPE, which made impossible to get SSVM/CPVM started. - The LibvirtUtilitiesHelper class is now being instantiated withing the LibvirtComputingResource
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #318
2015-05-27 13:19:57 +02:00
Rohit Yadav
cde6ef94b8
CLOUDSTACK-8247: Pull average Cpu util report between polling
...
Pull average Cpu util report between polling intervals instead of since boot
instead of using values since uptime
(cherry picked from commit 04176eaf17 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
This closes #297
2015-05-25 15:52:00 +02:00
Rohit Yadav
9dcfbceae7
kvm: for disabling pxe, pass empty file
...
Passing the file argument to the xml break for EL 7.1, the fix removes
the argument as just passing rombar='off' with its file arg to be empty string.
This closes #290
(cherry picked from commit aafa0c80b3 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-05-25 00:31:32 +02:00
Rafael da Fonseca
79d24ae218
Fix xenserver tests for travis
2015-05-23 16:14:09 +02:00
Rohit Yadav
d7f4498f76
kvm: Strip trailing comma for qemu-img convert options
...
Fix trailing comma for qemu-img convert options, Qemu 2.0+ not tolerant to it
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 90ac1aba13 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-05-22 13:33:54 +01:00
Rohit Yadav
c37060a1ff
CLOUDSTACK-8338: Fix hypervisor stats reporting for KVM on EL7
...
EL7 has a different output to 'free', use /proc/meminfo instead of a tool to be
more consistent across distros
(cherry picked from commit 212a05a345 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
2015-05-22 12:10:54 +01:00
wilderrodrigues
add4277720
CLOUDSTACK-8502
...
Added CitrixStorageSubSystemCommandWrapper to complete the CitrixResourceBase refactor.
- All 101 unit tests are green
2015-05-21 13:59:49 +02:00
wilderrodrigues
3efdc6c356
CLOUDSTACK-8502
...
Using Annotations on the Libvirt wrappers in order to increase maintainability
- All wrappers modified
- All 143 unit tests are green
2015-05-21 13:37:27 +02:00
wilderrodrigues
7ff1a81cee
CLOUDSTACK-8502
...
Using Annotations on the Citrix wrappers in order to increase maintainability
- All wrappers modified
- All 100 unit tests are green
2015-05-21 13:36:55 +02:00
wilderrodrigues
14c123e082
Merge branch 'fix/libvirt_unittests_timeout' of https://github.com/schubergphilis/cloudstack
...
This closes #270
2015-05-20 15:56:13 +02:00
wilderrodrigues
982a0235a0
CLOUDSTACK-8486
...
Removing real IPs from the tests because they cause a long running time for LibvirtComputingResourceTest
- In a local machine it takes 1.977s, but in a KVM test environment it's taking 257.879 sec
2015-05-20 14:52:08 +02:00
Wido den Hollander
3894d34b2c
CLOUDSTACK-8489: Set smbios information for guest
...
This allows a guest to easily detect that it is running inside CloudStack
and see which UUID it has.
2015-05-20 13:28:56 +02:00
wilderrodrigues
ab7473eea0
Changing the JUnit runner in order to avoid problems with Java 8 - All tests passed using different approaches - Maven with parameters: -Dmaven.compiler.source=1.8 -Dmaven.compiler.target=1.8 - Maven without parameters
...
All builds were executed using javac 1.8.0_31
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #266
2015-05-20 09:53:46 +01:00
wilderrodrigues
0cdb4b6108
Fixing the testGetHostStatsCommand test under LibvirtComputingResourceTest. - Removed the expected value from the Test annotation - Mocking the bash path in order to avoid environment/OS issues
...
Fixing typo on LibvirtRequestWrapper
- Replace linbvirtCommands by libvirtCommands on LibvirtRequestWrapper
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #255
2015-05-18 20:07:02 +02:00
wilderrodrigues
c7d2e444d2
Fixing license header in a file added during the LibVirt refactor
...
- New class is MigrateKVMAsync
2015-05-13 11:56:43 +02:00
wilderrodrigues
f575206ad4
Fixing testModifySshKeysCommand in the LibvirtComputingResourceTest class
...
- The test was okay, but when running in an environment where a /root/.ssh/id_rsa existed, it would return true then fail
- We now mock the calls to methods that return the key paths, instead of relying in the static variables
2015-05-08 19:53:03 +02:00
wilderrodrigues
74ad48db55
Refactoring the LibvirtComputingResource
...
- Adding LibvirtStartCommandWrapper
- 8 unit tests added
- KVM hypervisor plugin with 23.2% coverage
2015-05-06 19:24:16 +02:00
wilderrodrigues
09656ca84e
Refactoring the LibvirtComputingResource
...
- Adding LibvirtNetworkElementCommandWrapper and LibvirtStorageSubSystemCommandWrapper
- 2 unit tests added
- KVM hypervisor plugin with 22.2% coverage
I also refactored the StorageSubSystemCommand interface into an abstract class
- Remove the pseudo-multiple-inheritance implementation
- The StorageSubSystemCommand was an interface, not related to the Command class
and its implementation were extending the Command class anyway. The whole structure is better now.
2015-05-06 19:24:16 +02:00
wilderrodrigues
08106e34d0
Refactoring the LibvirtComputingResource
...
- Adding LibvirtResizeVolumeCommandWrapper
- 5 unit tests added
- KVM hypervisor plugin with 22.1% coverage
2015-05-06 19:24:15 +02:00
wilderrodrigues
ae505e7bef
Refactoring the LibvirtComputingResource
...
- Addin LibvirtPvlanSetupCommandWrapper
- 6 unit tests added
- KVM hypervisor plugin with 21% coverage
From the 6 tests added, 2 were extra tests to increase the coverage of the LibvirtStopCommandWrapper
- Increased from 35% to 78.7%
2015-05-06 19:24:15 +02:00
wilderrodrigues
7fd43f33d3
Refactoring the LibvirtComputingResource
...
- 5 unit tests added
- KVM hypervisor plugin with 20.1% coverage
2015-05-06 19:24:15 +02:00
wilderrodrigues
0b1b2b6d92
Refactoring the LibvirtComputingResource
...
- Adding LibvirtCopyVolumeCommandWrapper
Refactoring the LibvirtUtilitiesHelper
- Changing method name
Did not add any test to this commit due to the refactor mentioned abot.
Will proceed and add the tests
i# Please enter the commit message for your changes. Lines starting
2015-05-06 19:24:15 +02:00
wilderrodrigues
885b9e45d7
Renaming LibvirtConnectionWrapper to LibvirtUtilitiesHelper
...
- Gave it a better, more suggestive, name since I now added other methods to the class.
- It makes easier to mock objects and get a better coverage of the classes
2015-05-06 19:24:14 +02:00
wilderrodrigues
b3913ca1fb
Refactoring the LibvirtComputingResource
...
- Adding LibvirtCreatePrivateTemplateFromSnapshotCommandWrapper
- 5 unit tests added
- KVM hypervisor plugin with 19.5% coverage
2015-05-06 19:24:14 +02:00
wilderrodrigues
bcf78d3b43
Refactoring the LibvirtComputingResource
...
- Adding LibvirtBackupSnapshotCommandWrapper, LibvirtCreatePrivateTemplateFromVolumeCommandWrapper and LibvirtManageSnapshotCommandWrapper
- 3 unit tests added
- KVM hypervisor plugin with 18.3% coverage
Less tests added to those classes because the code is quite complex and way too long.
The tests added are just covering the new flow, to make sure it works fine. I will come back to those classes later.
2015-05-06 19:24:13 +02:00
wilderrodrigues
52d9f0c206
Refactoring the LibvirtComputingResource
...
- Adding LibvirtNetworkUsageCommandWrapper, LibvirtPlugNicCommandWrapper and LibvirtUnPlugNicCommandWrapper
- 9 unit tests added
- KVM hypervisor plugin with 18.3% coverage
2015-05-06 19:24:13 +02:00
wilderrodrigues
ff7ae9ca0c
Refactoring the LibvirtComputingResource
...
- Adding LibvirtCreateVolumeFromSnapshotCommandWrapper, LibvirtFenceCommandWrapper and LibvirtSecurityGroupRulesCommandWrapper
- 6 unit tests added
- KVM hypervisor plugin with 17.2% coverage
2015-05-06 19:24:13 +02:00
wilderrodrigues
3c8b217262
Refactoring the LibvirtComputingResource
...
- Adding LibvirtCheckOnHostCommandWrapper and LibvirtOvsCreateTunnelCommandWrapper
- 4 unit tests added
- KVM hypervisor plugin with 16.2% coverage
2015-05-06 19:24:12 +02:00
wilderrodrigues
6748a73b82
Refactoring the LibvirtComputingResource
...
- Adding 4 new command wrappers
- 12 unit tests added
- KVM hypervisor plugin with 15.5% coverage
2015-05-06 19:24:12 +02:00
wilderrodrigues
5499eecd33
Refactoring the LibvirtComputingResource
...
- Adding 7 new command wrappers
- 10 unit tests added
- KVM hypervisor plugin with 14.8% coverage
2015-05-06 19:24:12 +02:00
wilderrodrigues
4887ce7254
Refactoring the LibvirtComputingResource
...
- Adding LibvirtOvsDestroyBridgeCommandWrapper, LibvirtOvsSetupBridgeCommandWrapper
- 4 unit tests added
- KVM hypervisor plugin with 13.9% coverage
More tests added to cover LibvirtPrepareForMigrationCommandWrapper
- Coverage of this wrapper broght from 37% to 90.6%
- 4 new tests added
2015-05-06 19:24:11 +02:00
wilderrodrigues
0d860af659
Refactoring the LibvirtComputingResource
...
- Adding LibvirtDeleteStoragePoolCommandWrapper, LibvirtGetStorageStatsCommandWrapper and LibvirtUpgradeSnapshotCommandWrapper
- 7 unit tests added
- KVM hypervisor plugin with 13.6% coverage
2015-05-06 19:24:11 +02:00
wilderrodrigues
8268d353a2
Refactoring the LibvirtComputingResource
...
- Adding LibvirtPrimaryStorageDownloadCommandWrapper
- 4 unit tests added
- KVM hypervisor plugin with 13.3% coverage
2015-05-06 19:24:11 +02:00
wilderrodrigues
4472cade2f
Refactoring the LibvirtComputingResource
...
- Adding LibvirtDestroyCommandWrapper
- 2 unit tests added
- KVM hypervisor plugin with 12.9% coverage
2015-05-06 19:24:11 +02:00
wilderrodrigues
cb4670279f
Refactoring the LibvirtComputingResource
...
- Adding LibvirtCreateCommandWrapper and LibvirtMaintainCommandWrapper
- 4 unit tests added
- KVM hypervisor plugin with 12.7% coverage
2015-05-06 19:24:10 +02:00
wilderrodrigues
6f757c6bf0
Refactoring the LibvirtComputingResource
...
- Adding LibvirtModifySshKeysCommandWrapper
- 1 unit test added
- KVM hypervisor plugin with 12.3% coverage
2015-05-06 19:24:10 +02:00
wilderrodrigues
f14c7c2074
Refactoring the LibvirtComputingResource
...
- Adding LibvirtGetVncPortCommandWrapper
- 2 unit tests added
- KVM hypervisor plugin with 12.1% coverage
2015-05-06 19:20:43 +02:00
wilderrodrigues
7319a12600
Refactoring the LibvirtComputingResource
...
- Adding LibvirtCheckConsoleProxyLoadCommandWrapper, LibvirtConsoleProxyLoadCommandWrapper, LibvirtWatchConsoleProxyLoadCommandWrapperand CitrixConsoleProxyLoadCommandWrapper
- 2 unit tests added
- KVM hypervisor plugin with 12% coverage
Refactored the CommandWrapper interface in order to remove the esecuteProxyLoadScan, which is now
implemented bu subclasses.
2015-05-06 19:20:43 +02:00
wilderrodrigues
08a9523dcd
Fixing assertion on the tests that are execting exceptions
2015-05-06 19:20:43 +02:00
wilderrodrigues
40886b337c
Refactoring the LibvirtComputingResource
...
- Adding LibvirtAttachVolumeCommandWrapper
- 3 unit tests added
- KVM hypervisor plugin with 11.7% coverage
2015-05-06 19:20:42 +02:00
wilderrodrigues
4d216f1a63
Refactoring the LibvirtComputingResource
...
- Adding LibvirtAttachIsoCommandWrapper, LibvirtAttachIsoCommandWrapper and LibvirtAttachIsoCommandWrapper
- 7 unit tests added
- KVM hypervisor plugin with 11.5% coverage
2015-05-06 19:20:42 +02:00
wilderrodrigues
be1e517615
Refactoring the LibvirtComputingResource
...
- Adding LibvirtPingTestCommandWrapper
- 3 unit tests added
- KVM hypervisor plugin with 11.2% coverage
2015-05-06 19:20:42 +02:00
wilderrodrigues
28e55462f1
Refactoring the LibvirtComputingResource
...
- Adding LibvirtMigrateCommandWrapper
- 1 unit tests added
- KVM hypervisor plugin with 10.9% coverage
2015-05-06 19:20:41 +02:00
wilderrodrigues
d730efb866
Refactoring the LibvirtComputingResource
...
- Adding LibvirtCheckHealthCommandWrapper and LibvirtPrepareForMigrationCommandWrapper
- 2 unit tests added
- KVM hypervisor plugin with 10.8% coverage
2015-05-06 19:20:41 +02:00
wilderrodrigues
54f68f519f
Removing the CheckStateCommand form the IF statement on LibvirtComputingResource
...
- It's not used and if so would cause an infinite loop.
2015-05-06 19:20:41 +02:00
wilderrodrigues
6e568125fc
Refactoring the LibvirtComputingResource
...
- Adding LibvirtGetHosStatsCommandWrapper
- 1 unit test added
- KVM hypervisor with 10.5% coverage
Tests are a bit limited on this one becuause of the current implementation. Would clean it up later in a separate branch
2015-05-06 19:20:41 +02:00
wilderrodrigues
7a90c018fb
Refactoring the LibvirtComputingResource
...
- Adding LibvirtRebootCommandWrapper and LibVirtRebootRouterCommandWrapper
- 2 unit tests added
- KVM hypervisor with 10.5% coverage
2015-05-06 19:20:40 +02:00
wilderrodrigues
51093afcf1
Refactoring the LibvirtComputingResource
...
- Adding LibvirtGetVmDiskStatsCommandWrapper
- 1 unit test
Added getConnection() to LibvirtConnectionWrapper
2015-05-06 19:20:40 +02:00
wilderrodrigues
7086d64387
Refactoring the LibvirtComputingResource
...
- Adding LibvirtGetVmStatsCommandWrapper
- 3 unit tests
Refactored the LibvirtConnectiobn by surrounding it with an wrapper.
- Make it easier to cover the static/native calls
- Added better coverage to StopCommand tests
2015-05-06 19:20:40 +02:00
wilderrodrigues
508f10527f
Refactoring the LibvirtComputingResource
...
- Adding LibvirtStopCommandWrapper
- LibvirtRequestWrapper
- 1 unit tests
Refactored the RequestWrapper to make it better.
- Changes also applied to the CitrixRequestWrapper
2015-05-06 19:20:39 +02:00
Laszlo Hornyak
58e5dca8ef
CLOUDSTACK-8335: removed ceph repository - artifact resolved from maven central
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
2015-05-01 11:10:06 +05:30
Anshul Gangwar
aa265fe88f
CLOUDSTACK-8431: [Hyper-V] Fixed VM deployment failing when the stale vhd already exists Now generating guid when the template copy from secondary to primary storage requested instead of using it same as secondary
...
this closes #214
2015-04-30 16:07:36 +05:30
Anshul Gangwar
866cc41145
CLOUDSTACK-8423: [Xenserver] Improved the performance for processing of ClusterVMMetaDataSync command which can cause slowness in DB if there are huge number of VMs
...
this closes #204
2015-04-30 14:44:36 +05:30
Anshul Gangwar
48067e5ecd
CLOUDSTACK-8420: [Hyper-V] Fixed number format exception when untagged vlan is used for Hyper-V setup Change the vlan data type to string from int and handled the untagged vlan cases
...
this closes #201
2015-04-30 14:43:22 +05:30
Anshul Gangwar
7949caf156
CLOUDSTACK-8419: [Hyper-V] corrected the wrong error message in stop command answer
...
this closes #200
2015-04-30 14:42:46 +05:30
Anshul Gangwar
f86c0a23c1
CLOUDSTACK-8418: [Hyper-V] use systemvm.iso from secondary storage and stop copying to local disk
...
this closes #198
2015-04-30 14:42:24 +05:30
Anshul Gangwar
c355810034
CLOUDSTACK-8417 : [Hyper-V] Added support for smb share path in Hyper-V settings virtual disk path
...
this closes #197
2015-04-30 14:41:50 +05:30
Anshul Gangwar
c275d6fff8
CLOUDSTACK-8414: fixed template_spool_ref is not getting updated with correct template local_path
...
this closes #195
2015-04-30 14:36:58 +05:30
Anshul Gangwar
fda627d672
CLOUDSTACK-8414: Fixed template_spool_ref table is not getting updated with correct template_size Now returning file size instead of null.
2015-04-30 14:36:39 +05:30
Rohit Yadav
1d99a38096
CLOUDSTACK-8424: enable cpu flags only for guest VMs
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-30 04:13:07 +02:00
Daan Hoogland
7b10591758
findbugs: String.split() will not return nulls by contract
2015-04-29 16:07:38 +02:00
wilderrodrigues
3b0c031b9f
Using the SSHCmdHelper instead of a SSH Session.
2015-04-29 13:05:21 +02:00
Rajani Karuturi
0b8355920e
Merge branch 'volume-upload' into master
...
This closes #206
2015-04-29 11:12:53 +05:30
Rohit Yadav
29b8800660
kvm: add VMXNET3 nic adapter to nic models
...
Linux kernel supports vmxnet3, allowing it in KVM plugin would allow us to
run ESX hosts on KVM hosts using CloudStack with vmxnet3 nic which can be
passed as VM's nicAdapter detail
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit e02d787f30 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-28 18:23:55 +02:00
Rohit Yadav
58cc569273
CLOUDSTACK-8424: Add cpu features if guest.cpu.features is set
...
This improvements checks for "guest.cpu.features" property which is a space
separated list of cpu features that is specific for a host. When added, it
will add <feature policy='require' name='{{feature-you-listed}}'/> in the
<cpu> section of the generated vm spec xml.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit ea7fd37783 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-28 13:19:49 +02:00
Likitha Shetty
04365601da
CLOUDSTACK-8412. VM migration with storage fails.
...
Update MigrateWithStorageCommand to avoid JSON deserialization error.
2015-04-28 10:22:00 +05:30
Likitha Shetty
f45e6b94ed
CLOUDSTACK-8405: Restore VM results in deletion of data disk.
...
Dont evict template when a delete command has been sent to VMware resource for deletion of volume.
2015-04-27 16:37:46 +05:30
Laszlo Hornyak
9cf31b0714
CLOUDSTACK-8335: removed libvirt.org repository
...
The only artifact resolved from libvirt.org was org.libvirt:libvirt:0.5.1
this artifact is now available from maven's default central repository
This closes #180
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-24 16:58:59 +02:00
Rohit Yadav
05e4ba7350
kvm: fallback to eu.ceph.com mvn repo as ceph.com is down
...
As suggested by Wido on the dev ML changing the repo to eu.ceph.com to avoid
build failures. Will revert if ceph.com is up again.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit c9fd57fff3 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-16 17:37:11 +05:30
Rohit Yadav
06e353e5c7
vmware: support vmfs as local storage pool type
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 752d784d92 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-16 17:36:52 +05:30
Remi Bergsma
ac06ec02eb
kvm: improve CentOS 7 support
...
CentOS 7 does not ship with ifconfig anymore. We should use ip commands instead.
This also works on older versions, like CentOS 6 and Ubuntu 12.x/14.x, that we
support.
This closes #165
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-14 16:51:14 +05:30
Rohit Yadav
ccf13ec04e
kvm: xml escape password
...
(cherry picked from commit 13de2691fd )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
2015-04-13 16:10:42 +05:30
Rohit Yadav
7949d2922d
vmware: plugin improvements
...
- use sticky chmod 1777 on the mountpoint
- remove dead code
(cherry picked from commit eea716b791 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-13 15:49:01 +05:30
Rohit Yadav
37820e15f2
CLOUDSTACK-7593: allow nic type to be fetched from vm's details
...
(cherry picked from commit 43db75c319 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
2015-04-13 15:47:03 +05:30
Daan Hoogland
cb02a32f79
findbugs: boxing/unboxing removed
2015-04-12 20:16:13 +02:00
Daan Hoogland
72b2422623
findbugs: removed identical override for CitrixResourceBase method
...
transferManagementNetwork
2015-04-12 20:10:20 +02:00
Daan Hoogland
332da26cb9
findbugs: unused retry count causing unintended useless null guard
2015-04-12 19:58:05 +02:00
KC Wang
01864ef77c
CLOUDSTACK-6697: bigswitch networking plugin update
...
1. provide compatibility with the Big Cloud Fabric (BCF) controller
L2 Connectivity Service in both VPC and non-VPC modes
2. virtual network terminology updates: VNS --> BCF_SEGMENT
3. uses HTTPS with trust-always certificate handling
4. topology sync support with BCF controller
5. support multiple (two) BCF controllers with HA
6. support VM migration
7. support Firewall, Static NAT, and Source NAT with NAT enabled option
8. add VifDriver for Indigo Virtual Switch (IVS)
This closes #151
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-09 13:02:02 +05:30
wilderrodrigues
096d1b93b0
This closes #146
...
Refactoring the NetworkUsageCommand wrapper in order to cope with new design
- Unit tests added: 100% coverage
2015-04-05 13:24:45 +02:00
wilderrodrigues
02d1cdd49a
Refactoring the MigrateVolumeCommand wrapper in order to cope with new design
...
- Unit tests added: 43.1% coverage
- It's a bit difficult to test the Xen API classes due to their static nature
2015-04-05 09:23:10 +02:00
wilderrodrigues
f6e162afe4
Refactoring the MigrateWithStorageCompleteCommand wrapper in order to cope with new design
...
- Unit tests added: 50% coverage
- It's a bit difficult to test the Xen API classes due to their static nature
2015-04-05 09:23:10 +02:00
wilderrodrigues
d5414d26b4
Refactoring the MigrateWithStorageSendCommand wrapper in order to cope with new design
...
- Unit tests added: 47.2% coverage
- It's a bit difficult to test the Xen API classes due to their static nature
2015-04-05 09:23:10 +02:00
wilderrodrigues
c5a2f926e0
Refactoring the MigrateWithStorageReceiveCommand wrapper in order to cope with new design
...
- Unit tests added: 65% coverage
- It's a bit difficult to test the Xen API classes due to their static nature
2015-04-05 09:23:09 +02:00
wilderrodrigues
858b87f01c
Refactoring the MigrateWithStorageCommand wrapper in order to cope with new design
...
- Unit tests added: 30.1% coverage
- It's a bit difficult to test the Xen API classes due to their static nature
2015-04-05 09:23:09 +02:00
wilderrodrigues
240bcb8120
Refactoring the GetGPUStatsCommand wrapper in order to cope with new design
...
- Unit tests added: 100% coverage
2015-04-05 09:23:09 +02:00
wilderrodrigues
bcee7281c6
Started refctoring the remaining XenServer resources
...
- Just cleaning the formating
2015-04-05 09:23:09 +02:00
wilderrodrigues
3f89cd6494
Adding license headers that made RAT fail
...
- Test classes affected
This closes #143
2015-04-03 10:43:30 +02:00
wilderrodrigues
3d22a16c4f
Bump priority stragety is no longer used for redundant virtual routers
...
- With the changes added by the rVPC work, the bump priority became deprecated.
This commit includes a refactor to get it removed from the following resources:
* Java classes
* domain_router table - removing the is_priority_bumpup column
* Fixing unit tests
All changes were tested with:
XenServer 6.2 running under our VMWare zone
CloudStack Management Server running on MacBook Pro
MySql running on MackBook Pro
Storage Type: Local
2015-04-02 21:50:49 +02:00
wilderrodrigues
57d0931b49
Adding more tests to cover other possibilities concerning different versions of the XenServer
...
Adding a better algorithm in order to corver deeper inheritance form the command classes
Removing some unsued variables.
2015-03-31 16:49:48 +02:00
wilderrodrigues
d93935caac
We don't need the Start, Stop, Reboot command in the CitrixRebaseClaas anymore.
2015-03-31 10:38:33 +02:00
wilderrodrigues
3ad30a01a8
Refactoring XenServer56NetworkUsageCommandWrapper in order to cope with the new design
...
- Unit tests added
CitrixResourceBase, XenServer56Resource and XenServer56FP1Resource are now done.
i
2015-03-31 10:38:33 +02:00
wilderrodrigues
f3842c81f8
Refactoring XenServer56 and 56FP1 Resources in order to cope with new FenceCommandWrapper
...
- Unit tests added
Also removed an unit test that was doing nothing.
2015-03-31 10:38:33 +02:00
wilderrodrigues
4600eef87c
Removing all private/protected/public execute() methods from CitrixResourceBase class
...
Started the refactor of the XenServer56Resource class
- Unit test added
Changing the CitrixRequestWrapper in order to cope with multiple resources classes and commands
Still have to remove few methods form CitrixResourceBase
2015-03-31 10:38:32 +02:00
wilderrodrigues
02571728c6
Refactored the remaining commands
...
- Unit tests added
In the executeRequest I needed to keep the following:
// We need this one because the StorageSubSystemCommand is from another hierarchy.
if (cmd instanceof StorageSubSystemCommand) {
return storageHandler.handleStorageCommands((StorageSubSystemCommand) cmd);
}
2015-03-31 10:38:32 +02:00
wilderrodrigues
24bbfbc1e6
Refactoring other 8 command wrapper in order to cope with the new design
...
- Advanced unit tests added for half of the commands
- Basic unit tests added for the other half
2015-03-31 10:38:32 +02:00
wilderrodrigues
fbcae54a5b
Refactoring NetworkRulesSystemVmCommand, OvsCreateTunnelCommand, OvsDestroyBridgeCommand, OvsDestroyTunnelCommand, OvsSetupBridgeCommand in order to
...
cope with new design.
- Meny unit ests added.
2015-03-31 10:38:31 +02:00
wilderrodrigues
751c14b929
Refactoring CleanupNetworkRulesCmd, OvsCreateGreTunnelCommand, OvsDeleteFlowCommand, OvsVpcPhysicalTopologyConfigCommand and OvsVpcRoutingPolicyConfigCommand
...
in order to cope with the new design.
- Meny new unit tests added that cover more than the basics!
2015-03-31 10:38:31 +02:00
wilderrodrigues
30b770aeab
Refactoring CheckSshCommand, OvsFetchInterfaceCommand and SecurityGroupRulesCommand to cope with new design.
...
- Unit Tests added
2015-03-31 10:38:30 +02:00
wilderrodrigues
74faf73408
Refactoring CheckOnHostCommand, ModifySshKeysCommand, OvsSetTagAndFlowCommand and StartCommand to cope with new design
...
- Unit tests added
2015-03-31 10:38:30 +02:00
wilderrodrigues
18470a48d0
Refactoring PingTestCommand to cope with new design
...
- Basic tests added
2015-03-31 10:38:30 +02:00
wilderrodrigues
3a70912b7c
Make methods in subclasses public.
...
Remove the if-commands that I have already refactored.
2015-03-31 10:38:29 +02:00
wilderrodrigues
637a56c3c1
Refactoring GetVncPortCommand, MaintainCommand and SetupCommand to cope with new design.
...
- Basic test added, but could not mock all the static stuff so the test is not complete yet.
Will look further into it.
2015-03-31 10:38:29 +02:00
wilderrodrigues
11d0336803
Refactoring GetStorageStatsCommand and PrimaryStorageDownloadCommand to cope with the new design
...
Fix the NPE in the constructor that was never used
- Basic tests added for all changes
2015-03-31 10:38:29 +02:00
wilderrodrigues
ea374b6a2f
Refactoring AttachIsoCommand, AttachVolumeCommand and UpgradeSnapshotCommand to cope with new design
...
- Basic tests added
2015-03-31 10:38:28 +02:00
wilderrodrigues
6c775951c7
Refactoring DeleteStoragePoolCommand, ModifyStoragePoolCommand and ResizeVolumeCommand to cope with new design
...
- Basic tests added.
2015-03-31 10:38:28 +02:00
wilderrodrigues
a06958f469
Refactoring DestroyCommand and CreateStoragePoolCommand wrappers to cope with the new design
...
- Basic tests added
s Please enter the commit message for your changes. Lines starting
2015-03-31 10:38:27 +02:00
wilderrodrigues
a70d80dfd6
Refactoring PrepareForMigrationCommand and MigrateCommand in order to cope with the new design
...
- Basic tests added
2015-03-31 10:38:27 +02:00
wilderrodrigues
cb07b0ba08
Refactoring the CitrixCheckVirtualMachineCommand toc ope with new design
...
- Added basic tests
- Added tests for RebootRouterCommand
- Removed the code from CitrixResourceBase that has already been refactored
2015-03-31 10:38:27 +02:00
wilderrodrigues
f2fab5c8c3
Refactoring the CitrixRebootCommand in order to have the new design applied
...
- Added basic tests
- Changed the way RebootCommand gets called from RebootRouterCommand
- Made a couple of methods public in the CitrixResourceBase and its subclasses
2015-03-31 10:38:27 +02:00
wilderrodrigues
9e41b8051e
Renaming files
...
- Forgot to add "Citrix" before the new command wrappers
2015-03-31 10:38:26 +02:00
wilderrodrigues
6b80c79986
Refactoring the StopCommand on CitrixResourceBase to cope with new design
...
- Added basic tests
2015-03-31 10:38:26 +02:00
wilderrodrigues
c7830efef5
Refactor the CheckHealthCommand and GetVmDiskStatsCommand classes in CitrixResourceBase
...
- Added basic tests for both wrappers
2015-03-31 10:38:26 +02:00
wilderrodrigues
8f04108e23
Refactoring the GetVmStatsCommand
...
- Added basic tests
2015-03-31 10:38:25 +02:00
wilderrodrigues
0e51379da7
Refactoring the GetHostStatsCommand
...
- Added basic tests
- Added test for when the key (Command) does not exist in the Map
2015-03-31 10:38:25 +02:00
wilderrodrigues
30e72e4a15
Refactoring the whole XsHost thing
...
Refactor the ReadyCommand
Fixing the old test
Adding basic tests for ReadyCommandWrapper
2015-03-31 10:38:25 +02:00
wilderrodrigues
c3ae8c793b
Adding the refactor of CitrixCheckConsoleProxyLoadCommandWrapper.java and CitrixWatchConsoleProxyLoadCommandWrapper.java
...
- plus basic tests
2015-03-31 10:38:24 +02:00
wilderrodrigues
4256418af9
Adding CitrixCreateCommandWrapper.java and basic unit tests
2015-03-31 10:38:24 +02:00
wilderrodrigues
a1e8778211
First piece of the refactor of the CitrisResourceBase
...
- The same pattern will be used by the other subclasses of the ServerResource interface.
2015-03-31 10:38:24 +02:00
Daan Hoogland
b6d2b62aa7
imports in test
2015-03-27 15:59:32 +01:00
Daan Hoogland
4e1997ff5a
imports :8
2015-03-27 15:38:25 +01:00
Funs
e7d7643dd7
Only one thing can come from the agent
2015-03-27 11:19:16 +01:00
Funs
d0e25d96fb
Fix paths so they also work with tests on windows.
...
Sonarcube is great, but has no context and can be wrong, in this
case File.separator is nice if you're running platform independent,
the agent on OVM3 is however NOT platform independent and will break
if we feed it windows separators.
2015-03-27 11:14:35 +01:00
Daan Hoogland
6a821730ce
Boolean -> boolean
2015-03-25 22:20:40 +01:00
Daan Hoogland
048212b117
findbugs: Boolen function should not return null
2015-03-25 21:46:47 +01:00
Daan Hoogland
724699424e
findbugs: boxing/unboxing
2015-03-25 21:20:39 +01:00
Daan Hoogland
1552c912a7
findbugs: parseLong instead of boxing/deboxing
2015-03-25 18:36:12 +01:00
Daan Hoogland
340aa9ff0f
findbugs: make default encoding explicit
2015-03-25 18:31:08 +01:00
Daan Hoogland
a4c23b170e
findbugs: just in case we run on windows, use save expression
2015-03-25 18:27:56 +01:00
Daan Hoogland
bff8a8e9cd
findbugs: set explicit default charset
2015-03-25 18:22:07 +01:00
Rohit Yadav
694b723899
CLOUDSTACK-8312: Fix NPE regression, copy template can have NULL volume size
...
The copy command reply can have null size returned, so check and set values
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 53ca0b1861 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-20 17:27:14 +05:30
Rohit Yadav
3c429ee6b5
Merge remote-tracking branch 'sbp/feature/persisten-systemvm-redundant-vpc-REBASE'
...
This closes #118
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-17 15:44:57 +05:30
wilderrodrigues
84ba06b87d
Fix: the update_config.py was not parsing the incoming guest net configuration properly
...
Added comments to the CitrixResourceBase class: do not destroy the cd-rom
2015-03-16 11:39:49 +01:00
wilderrodrigues
2bb79b8115
Adding some info to the update_config.py
2015-03-16 11:39:49 +01:00
wilderrodrigues
edd839ab10
Fix: allow multiple VIFs per Mac Address
...
Fix: RTNETLINK errors
- Management Server health check trying to create already existing interface
- Changes on update_config.py, cs_guestnetwork.py, merger.py
Fix: replace RRouTER_LOG in the CsRedundant.py per log file location
Fix: Guest Net address association during Router restart
- Changes on NicProfileHelper, NicProfileHelperImpl
Fix: aggregationExecution() method on VirtualNetworkApplianceManagerImpl
- Do not send an AggregationControlCommand to a non-configured router
Some classes have been formatted.
2015-03-16 11:39:48 +01:00
wilderrodrigues
33b0ce816b
Make sure we can plug the nic in 2 routers with the same mac address
...
The still some work to do on the prepareNetworkElementCommand() method.
2015-03-16 11:39:16 +01:00
afornie
c4de33d682
Fix compilation problem only visible upon simulator build
2015-03-16 11:35:38 +01:00
Hugo Trippaers
9514f259f6
Removed useless array from SetStaticRoutesCmd.
2015-03-16 11:34:59 +01:00
Rajani Karuturi
843f6b1691
CLOUDSTACK-5236 : ability to identify where the user is from (ex. LDAP)
...
Added a source column to the user table.
Source now has only two values UNKNOWN,LDAP with UNKNOWN being the
default and is an enum is com.cloud.User.
When the source is UNKNOWN, the old method of authenticating against all
the available authenticators is used. If a source is available, only
that particular authenticator will be used.
added overloaded methods in AccountService to createUserAccount and
createUser with source specified.
(cherry picked from commit 5da733072e )
2015-03-16 14:53:53 +05:30
Rohit Yadav
c8901a7990
utils: use a better extended implementation of SSLSocketFactory
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit b4a5a32a74 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-13 17:32:07 +05:30
Sanjay Tripathi
3d411dc616
Fixed simulator and vmware NPE issue.
2015-03-13 14:59:34 +05:30
Rohit Yadav
2e26e97fe8
ovm3: fix rat license, use license header that satisfies RAT
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-12 15:12:12 +05:30
Likitha Shetty
bdd28a45ed
CLOUDSTACK-8319. For both 'MigrateVolume' and 'MigrateVMWithVolumes, ensure VM's vconfiguration files are migrated along with VM's root volume.
2015-03-12 11:57:02 +05:30
Likitha Shetty
adc836cc5e
CLOUDSTACK-8318. Storage vMotion support for VMFS.
...
MigrateVMWithVolumes-
1. If ESXi host version is below 5.1, ensure destination datastore(s) is mounted on the source host, then migrate the storage and then finally migrate the VM.
If destination storage(s) is not mounted on the source host,
- In case of NFS storage mount the storage(s).
- In case of VMFS storage fail the request for migration.
2. If EXi host version is 5.1 or above, simultaneously migrate the VM and its storage to the destination host and storage(s) respectively for both NFS and VMFS storage.
2015-03-12 11:57:01 +05:30
Funs
c27c69438b
hypervisors: add OVM3 plugin that supports OVM 3.2.1/3.3.x
...
This is a plugin that puts in ovm3 support ranging from 3.3.1 to 3.3.2. Basic
functionality is in here, advanced networking etc..
Snapshots only work when a VM is stopped now due to the semantics of OVM's raw
image implementation (so snapshots should work on a storage level underneath the
hypervisor shrug)
This closes #113
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-12 11:33:42 +05:30
Laszlo Hornyak
9a38b2f7de
CLOUDSTACK-8304: disable snapshots from non-snapshot repositories
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
This closes #100
2015-03-10 17:19:09 +05:30
Sanjay Tripathi
520d96724a
CLOUDSTACK-8312: The storage usage of "Primary Storage Allocated" is incorrect.
2015-03-10 16:52:25 +05:30
Daan Hoogland
d14a994689
findbugs: make use of default charset explicit
2015-03-07 20:14:24 +01:00
punith-cloudbyte
ff7ef985f1
NFS support for VMware-managed storage
...
Signed-off-by: Mike Tutkowski <mike.tutkowski@solidfire.com>
2015-03-05 17:39:10 -07:00
Jayapal
619f014255
CLOUDSTACK-8298: Update copying large size VR config file in xenserver
...
When there is large size VR configuration (aggregate commands) copying data to VR using vmops plugin was failed
because of the ARG_MAX size limitation. The configuration data size is around 300KB.
Updated this to create file in host by scp with file contents. This will create file in host.
Then copy the file from the host to VR using hte vmops createFileInDomr method.
In host file get created in /tmp/ with name VR-<UUID>.cfg, once it copied to VR this file will be removed.
2015-03-04 11:52:10 +05:30
Marcus Sorensen
57cd7f3db5
LibvirtComputingResource: Support 'Oracle Linux 7' as pv guest
...
Change-Id: Ib3fd2fec7434564e937ac5b6b3cfee472a5fdc98
2015-03-03 10:44:12 -08:00
Sanjay Tripathi
736c7d7668
CLOUDSTACK-8296 VMs cannot be migrated with XenMotion as network is not available.
2015-03-03 13:14:04 +05:30
Laszlo Hornyak
0fda5a03a4
CLOUDSTACK-8292: fix for java 1.8 compilation
...
Refactored to use the XPatch expressions to check the generated domain xml rathern than string comparison.
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2015-02-28 20:11:46 +01:00
Rohit Yadav
a75ff23131
CLOUDSTACK-8273: fix baremetal account creation
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit e000646790 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalVlanManagerImpl.java
2015-02-27 15:55:09 +05:30
Rohit Yadav
6df2fe7a8a
CLOUDSTACK-8273: refactor baremetal user name to utils, restrict baremetal user
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit cb08707add )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
server/src/com/cloud/user/AccountManagerImpl.java
2015-02-26 17:47:01 +05:30
Marcus Sorensen
77d11eb1a3
LibvirtComputingResource: Fix coverity scan, recent bugfixes revealed a potential unhandled null in getResizeScriptType
...
Change-Id: I5715a4424646261f2c43cd5e0a16fd72dd12c753
2015-02-23 16:56:19 -08:00
Daan Hoogland
e13d45e2c6
catch specific exception and log clear message on error
2015-02-21 12:32:29 +01:00
Marcus Sorensen
6c05d9f572
CLOUDSTACK-8263: KVM - virsh resize doesnt refresh libvirt's view of the volume size, refresh pool
...
Change-Id: I5ea54f7389d72b57bb625e4d87b45b65eb0c96cd
2015-02-18 12:55:53 -08:00
Marcus Sorensen
9bf2626e57
CLOUDSTACK-8263: KVM - use virsh instead of libvirt for resizing qcow2, as libvirt bindings are insufficient
...
Change-Id: I08246219cb1469a46dc6a9ec76a8c3a67b0b8bf6
2015-02-17 18:09:41 -08:00
Marcus Sorensen
ed8184a5b2
CLOUDSTACK-8263: KVM - notify qemu process of resized volume for libvirt-resized storage
...
Change-Id: Iddd8bb068855d3565075d3ecf7c6c0f074d00e1a
2015-02-17 14:25:55 -08:00
Mike Tutkowski
5e142f59ef
CLOUDSTACK-8233 kvmtimer fix
2015-02-08 17:48:06 -07:00
Rohit Yadav
083a4950a9
Fix typos
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit af278fe1ab )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-06 15:54:01 +05:30
Rohit Yadav
06437dadf5
CLOUDSTACK-8220: Let's have a separate XenServer 6.5 resource
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-06 14:44:10 +05:30
Daan Hoogland
a2ddabde06
Merge branch 'feature/minvrversion' of https://github.com/DaanHoogland/cloudstack
2015-02-04 21:51:15 +01:00
Mike Tutkowski
6cd2b53790
Adding in the license text
2015-02-03 18:22:18 -07:00
Marcus Sorensen
ca2c3c30e2
Dynamic storage adaptor for KVM
2015-02-03 12:08:24 -07:00
Rohit Yadav
d5db87f381
CLOUDSTACK-8198: Use random local storage UUID
...
Earlier host addition of multiple hosts with local storage failed due to
same local storage UUID being used where the storage path is same.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit bf17f640c6 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-03 22:36:46 +05:30
Daan Hoogland
b586439c9f
CLOUDSTACK-8197 create MinVRVersion config item
2015-02-03 13:18:15 +01:00
Koushik Das
6ff8752fd0
volume-upload: gc thread to clean partially uploaded files
...
Fixed multiple issues in the template code path
2015-01-31 17:25:19 +05:30
Koushik Das
3e857bde08
volume-upload: management server polling and upload status from agent
...
Fixed some issues with the polling logic to handle scenarios when SSVM is destroyed/down.
Also changed the status of the volume_store_ref entries so that subsequent operations work fine.
2015-01-31 17:02:18 +05:30
Marcus Sorensen
65e8e50dec
LibvirtComputingResource: GuestOSName for OracleLinux
2015-01-29 08:28:55 -07:00
Marcus Sorensen
fa76b3c9f5
LibvirtComputingResource: make Oracle linux support virtio
...
Conflicts:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
2015-01-28 23:41:33 -07:00
Rohit Yadav
9635e17701
hyperv: fix maven warning, add version to exec plugin
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-23 18:41:09 +05:30
Marcus Sorensen
35ede0418a
CLOUDSTACK-8177
...
KVM: disable tickpolicy for kvmclock. Newer libvirt enforces that
kvmclock cannot accept parameters.
2015-01-23 02:46:16 -07:00
Marcus Sorensen
455998ce95
LibvirtComputingResource: Expose KVMStoragePoolManager
...
KVMStoragePoolManager is a singleton in practice, any plugin
or extension of LibvirtComputingResource will need to act on
the specific instance of KVMStoragePoolManager that LibvirtComputingResource
has initialized. Therefore, expose this variable for those who
wish to call storage commands from plugins or extensions.
Conflicts:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
2015-01-23 02:45:54 -07:00
Mike Tutkowski
f983e6ed82
Un-plug any remaining VBDs and PBDs
2015-01-22 17:36:04 -07:00
Rohit Yadav
664186f483
CLOUDSTACK-8160: use preferable protocols
...
(cherry picked from commit debfcdef78 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-21 18:04:45 +05:30
Mike Tutkowski
0f84e042b9
Adding support for creating a volume from a snapshot when the snapshot is on managed storage
2015-01-20 15:24:33 -07:00
Wei Zhou
71103772b7
CLOUDSTACK-7219: Cannot display Cluster Settings for missing commit 95e41fdf0d
2015-01-16 10:56:25 +01:00
Koushik Das
627f5a62dc
volume upload: management server polling and upload status from agent
...
MS polling logic to query status for volumes that are uploaded
2015-01-14 10:19:12 +05:30
Daan Hoogland
1a8fe82580
no extranous log4j files
2015-01-08 17:36:17 +01:00
Kishan Kavala
85bd96c6b2
While deploying Vm with DataDisk in LXC, if the rbd image mapping on the host fails, deploy Vm should fail
2015-01-07 15:09:57 +05:30
Hugo Trippaers
ec32ea30f7
Housekeeping, properly declare required maven version and update build plugin versions to recent versions
2015-01-06 11:58:58 +01:00
Daan Hoogland
2c9cc1ecde
CID-1261666 added null check
2015-01-05 16:05:57 +01:00
Daan Hoogland
54e5f28ace
CID-1261669 added comment to clarify false positive
2015-01-05 15:43:51 +01:00
Likitha Shetty
25a4f0dc53
CLOUDSTACK-8136. [VMware] Create VM snapshot fails if a previous attempt to take the snapshot failed.
...
While looking for an ongoing VM snapshot task, check the task status to identify if the task is still running.
2014-12-30 14:19:48 +05:30
Likitha Shetty
13bdc1cef4
CLOUDSTACK-8134. Worker VMs don't have MS id set in vCenter annotation 'cloud.vm.workertag'.
...
Correctly register node info for a newly created VMware context.
2014-12-30 11:52:56 +05:30
Likitha Shetty
15b348632d
CLOUDSTACK-8129. Cold migration of VM across VMware DCs leaves the VM behind in the source host.
...
If VM has been cold migrated across different VMware DCs, then unregister the VM from source host.
2014-12-26 11:07:30 +05:30
Likitha Shetty
5227ae2275
CLOUDSTACK-8128. VM with Datadisk fails to start when storage is put into maintenance.
...
While migrating a volume from primary to seocndary use a worker VM to perform the operations if the VM associated with the volume is stopped.
2014-12-24 16:57:37 +05:30
Likitha Shetty
974b0180dd
CLOUDSTACK-8126. Cold Migration of VM is not working as expected. In case a VM is cold migrated across clusters then VM fails to start.
...
1. If a VM by the same name exists on a different cluster in the VMware DC, unregister the existing VM and continue with the VM start.
2. If VM start succeeds, delete VM files associated with the unregistered VM.
3. If VM start fails, re-register the unregistered VM.
2014-12-24 15:07:08 +05:30
Likitha Shetty
1c0bf32170
CLOUDSTACK-8123. VM re-install fails.
...
While moving root disk into VM folder during restore, look for folder based on vCenter name.
2014-12-24 14:01:20 +05:30
Likitha Shetty
ac491c9607
CLOUDSTACK-8121. Data disk properties are not updated upon Creation/Deletion of VM snapshots.
...
Update the path and size of data volumes after snapshot creation/deletion by correctly trimming only the snapshot postfix of a disk.
2014-12-24 13:04:12 +05:30
Likitha Shetty
4d7ede535d
CLOUDSTACK-8119. Propagate error message to UI for attach/detach volume failure operations.
...
For AttachVolume/DetachVolume API command, improve user error message in case of RuntimeException by throwing the exception instead of 'Unexpected Exception'.
2014-12-24 11:29:03 +05:30
Likitha Shetty
ddcae8a930
CLOUDSTACK-8118. Root volume migration fails with 'No such disk device' in case of vCenter 5.5 setup.
...
If an exact match is being done while locating disk chain by name, don't trim snapshot postfix appended to the disk name.
2014-12-24 10:19:22 +05:30
Likitha Shetty
cb211f18d1
CLOUDSTACK-8113. VM migration fails with "Message: No such disk device: " error.
...
Consolidate VM disks once VM/volumes are migrated.
2014-12-23 14:28:17 +05:30
Likitha Shetty
33179cce56
CLOUDSTACK-8112. CS allows creation of VM's with the same Display name when vm.instancename.flag is set to true.
...
Before registering a VM check if a different CS VM with same name exists in vCenter.
2014-12-23 13:48:01 +05:30
Likitha Shetty
647532376f
CLOUDSTACK-8111. NFS secondary storage repetitively mounted on CS server with ESXi hypervisors.
...
Fix cleanup of NFS mounts on management server during server starup by correcting how mount points are listed for a management server.
2014-12-23 13:23:43 +05:30
Likitha Shetty
51ee90074d
CLOUDSTACK-8110. VM name in vCenter should be VM's DisplayName if global config 'vm.instancename.flag' is set.
2014-12-23 11:42:26 +05:30
Likitha Shetty
507d9d337d
CLOUDSTACK-8109. Extract Template is failing.
...
Fix the OVA path that is returned once an OVA is packaged using a META file.
2014-12-23 10:44:10 +05:30
Saksham Srivastava
1df0453d27
CLOUDSTACK-8088: VM scale up is failing in vmware with Unable to execute ScaleVmCommand due to java.lang.NullPointerException
2014-12-18 14:27:55 +05:30
Rajani Karuturi
7e030ee72d
volume upload: persisting the template metadata
...
on calling GetUploadParamsForTemplate, persisting the metadata to db
validating the account limits and incrementing the appropriate limits
encoded the metadata on management server using preshared key
2014-12-16 11:52:09 +05:30
Sateesh Chodapuneedi
aa84b05491
CLOUDSTACK-5933 Problem with VMware snapshot when datastore has a space in its name
...
Handling spaces in datastore name while extracting vmdk base name
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2014-12-09 05:34:41 +05:30
Sateesh Chodapuneedi
bca015306e
CLOUDSTACK-7803 Storage live migration of instance may not happen if instance has ISO attached.
...
BUG-ID:CLOUDSTACK-7803
Summary:Ensure secondary storage is mounted on target host.
Reviewed-By:Rajesh
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2014-12-09 03:27:31 +05:30
Mike Tutkowski
3ac8f8d601
Fixing an issue related to figuring out the name of a datastore that is backed by managed storage
2014-12-08 14:26:31 -07:00
Wei Zhou
4eedfe53fc
CLOUDSTACK-2823: pass cmdline info to system vms for 30 times
2014-12-08 15:45:29 +01:00
Jayapal
8f8e311110
CLOUDSTACK-8030: Updated router to come up egress default ALLOW
...
On default iptables rules are updated to add ACCEPT egress traffic.
If the network egress default policy is false, CS remove ACCEPT and adds the DROP rule which
is egress default rule when there are no other egress rules.
If the CS network egress default policy is true, CS won't configure any default rule for egress because
router already came up to accept egress traffic. If there are already egress rules for network then the
egress rules get applied on VR.
For isolated network with out firewall service, VR default allows egress traffic (guestnetwork --> public network)
2014-12-08 11:32:01 +05:30
Rajani Karuturi
b6c86bdb75
changed commons-io version to the latest stable 2.4
...
also updated version numbers in all the poms its used.
2014-11-28 17:01:16 +05:30
Wei Zhou
daa57f67d6
CLOUDSTACK-6893: fix enum ValueOf issue which causes systemvm fail to start
...
(cherry picked from commit 63ff5a7cbc )
(cherry picked from commit d0e0edca11 )
2014-11-27 16:58:08 +01:00
Koushik Das
4798db0de1
CLOUDSTACK-7960: [Automation] Creation of Volume from Snapshot fails due to StringIndexOutOfBoundsException
...
Fixed the appropriate CopyCommand handler in simulator plugin
2014-11-26 17:30:44 +05:30
Koushik Das
bf56584528
CLOUDSTACK-7973: Proper handler for FenceCommand in simulator
...
Added a proper handler for FenceCommand in simulator
2014-11-26 17:30:33 +05:30
Harikrishna Patnala
9585aa0b51
CLOUDSTACK-6465: vmware.reserve.mem is missing from cluster level settings
...
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
(cherry picked from commit eae733817b )
2014-11-25 15:55:54 +05:30
Laszlo Hornyak
3577423da9
removed executable flags from java classes
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-11-23 19:49:01 +01:00
Laszlo Hornyak
b2023d04ba
Simplification on Properties handling
...
- Added method to create properties and load contents from file
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-11-23 19:48:56 +01:00
Saksham Srivastava
4ff3130bec
CLOUDSTACK-7950: AttachIsoCmd shoud give correct messge when trying to attach vmwaretools installer iso on non supported guestvm deployed by ISO
2014-11-20 13:04:14 +05:30
Sanjay Tripathi
dda2994936
CLOUDSTACK-7940: Exception printed completely on the UI. Not in a readable format.
2014-11-19 15:59:03 +05:30
Anshul Gangwar
055f6ad318
CLOUDSTACK-7932: Fixed wrong semantics for isVmAlive() method in HypervInvestigator
...
Findbugs will report error on this as it is expecting true/false for Boolean value.
But we have diffrent meaning for null so it is false positive case from findbug
This closes #39
2014-11-18 13:37:36 +05:30
Daan Hoogland
7aa64b9efa
CID-1254838 catch individual exceptions types
2014-11-17 15:09:03 +01:00
Santhosh Edukulla
ef6ec7b276
Fixed few coverity issues like invalid boxing unboxing issues, resource leaks, null dereferences
2014-11-13 17:26:24 +05:30
Likitha Shetty
b8fdda0a34
BUG-ID: CLOUDSTACK-7102. Volume migration fails with 'VM i-2-3-VM does not exist in VMware datacenter' expection.
...
Look for a VM in vCenter based on both the vCenter name and CS internal name (required in case 'vm.instancename.flag' is enabled).
During Attach Volume and Volume Migration, for lookup and other operations use VM's name as obtained from vCenter instead of using the name set in the agent command.
2014-11-13 12:58:56 +05:30
Wido den Hollander
69ee01af9d
CLOUDSTACK-3383: Fetch CPU utilization more reliable.
...
This should fix that we can't gather CPU statistics on hypervisors
> Ubuntu 12.04
2014-11-12 09:54:54 +01:00
Mike Tutkowski
5c388a5c80
Add properties file in same folder as template
2014-11-11 17:03:08 -07:00
Daan Hoogland
abff49d5b3
CID-1250770 pass through mkdirs() return value
2014-11-11 10:32:46 +01:00
Mike Tutkowski
18091e9642
Adding support for backend snapshots to Xenserver625StorageProcessor
2014-11-10 22:41:00 -07:00
Santhosh Edukulla
94ee16a719
Fixed the wrong if else statement
2014-11-10 22:33:19 +05:30
Bharat Kumar
ea99ff1c86
CLOUDSTACK-7763 Reservations for VMware VMs remain after dynamic scaling
2014-11-10 14:30:42 +05:30
Sanjay Tripathi
6a6d4d876f
CLOUDSTACK-7868: Failed storage.PrimaryStorageDownloadCommand leaves corrupt VDIs in primary storage.
2014-11-08 13:43:56 +05:30
Mike Tutkowski
455ffc3342
Create a template from a SAN snapshot
2014-11-06 10:33:23 -07:00
Sanjay Tripathi
b844155240
CLOUDSTACK-7842: Wrong size column is getting updated with snapshot physical size in snapshot_store_ref table.
...
Also fixed the issue that snapshot size with hypervisor XS >= 6.2.5 is not getting updated in snapshot_store_ref table.
2014-11-05 16:42:28 +05:30
Frank Zhang
62c5cefb82
CLOUDSTACK-7834
...
Web UI shows all DHCP/PXE providers in cloud when admin click DHCP/PXE IP for A zone
2014-11-03 16:43:09 -08:00
Anthony Xu
aa84770347
if attach volume fails, destroy the VBD device
2014-11-03 11:20:37 -08:00
Santhosh Edukulla
1aef5cba66
Fixed Coverity Issues
2014-11-03 16:45:30 +05:30
amoghvk
efc9632c1b
CLOUDSTACK:6915 search including removed
2014-10-31 15:47:18 -07:00
Logan Barfield
3a52a83fae
Fixed root disk resize on deploy for RBD.
...
Signed-off-by: Wido den Hollander <wido@widodh.nl>
2014-10-31 22:17:27 +01:00
punith-cloudbyte
09a62b8389
new managed nfs storage adapter
...
Signed-off-by: Mike Tutkowski <mike.tutkowski@solidfire.com>
2014-10-30 16:07:59 -06:00
Anthony Xu
b8d6396409
don't need to check if pv driver is updated, old pv driver should work
2014-10-30 10:27:34 -07:00
Hugo Trippaers
4ebaf0a583
Bump master version to 4.6.0-SNAPSHOT after branching 4.5.0-SNAPSHOT
2014-10-29 14:54:23 +01:00
Hugo Trippaers
f5353d30f5
Merge branch 'bugfix/CID-1249800'
2014-10-29 09:42:05 +01:00
Hugo Trippaers
320544fa51
CID-1249800 Fix a coverity bug, but disable the code its used in as it
...
needs rethinking
2014-10-29 09:38:40 +01:00
Hugo Trippaers
ab980cd3b7
CID-1249801 This should be a string comparison, not an object comparison
2014-10-29 09:24:19 +01:00
Frank Zhang
2ae40237a4
CLOUDSTACK-7795
...
Fix multiple baremetal rct configuraitons
2014-10-27 15:14:08 -07:00
Anthony Xu
95b9be0cb6
allow reentrance of disassociate ip , if vif is gone, return success
2014-10-27 11:07:51 -07:00
Mike Tutkowski
b1ffd88a42
Save off the UUID of the VDI before detaching its SR
2014-10-21 16:01:15 -06:00
Mike Tutkowski
0cea0346ae
Support for back-end snapshots on primary storage
2014-10-21 16:01:14 -06:00
Anthony Xu
45611a0f83
don't need to check if pv driver is updated, old pv driver should work
2014-10-21 11:14:15 -07:00
Edison Su
1a98992c5a
fix kvm issue, for windows sever 2008, it will crash without hyperv enlightment featre enabled
2014-10-21 10:32:29 -07:00
Daan Hoogland
1de0cb7094
restore barematel work after merge
2014-10-17 10:24:01 +02:00
Daan Hoogland
148efbb73f
Merge remote-tracking branch 'origin/4.5' into merge-master
...
Conflicts:
engine/schema/src/com/cloud/upgrade/dao/Upgrade441to450.java
plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalManagerImpl.java
plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalVlanManager.java
plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalVlanManagerImpl.java
plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalKickStartServiceImpl.java
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
setup/db/db/schema-441to450.sql
test/integration/component/test_deploy_vgpu_vm.py
tools/marvin/marvin/config/test_data.py
2014-10-16 12:29:37 +02:00
Sanjay Tripathi
80e0c99189
Removed duplicate code and unused imports which was causing build failure.
2014-10-16 13:53:32 +05:30
Sanjay Tripathi
176e0d47bb
CLOUDSTACK-6650: Reorder Cluster list in deployment planner to protect
...
GPU enabled hosts from non-GPU VM deployment.
Cluster reordering is based on the number of unique host tags in a cluster,
cluster with most number of unique host tags will put at the end of list.
Hosts with GPU capability will get tagged with implicit tags defined by
global config param 'implicit.host.tags' at the time os host discovery.
Also added FirstFitPlannerTest unit test file.
2014-10-14 17:55:37 +05:30
Sanjay Tripathi
e4a8bbcdf4
CLOUDSTACK-6650: Reorder Cluster list in deployment planner to protect
...
GPU enabled hosts from non-GPU VM deployment.
Cluster reordering is based on the number of unique host tags in a cluster,
cluster with most number of unique host tags will put at the end of list.
Hosts with GPU capability will get tagged with implicit tags defined by
global config param 'implicit.host.tags' at the time os host discovery.
Also added FirstFitPlannerTest unit test file.
2014-10-14 17:53:50 +05:30
Santhosh Edukulla
0a9742f914
Fixed few coverity issues
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-10-14 17:16:50 +05:30
Frank Zhang
49c01e2ae4
Don't do chmod -R when mounting secondary storage for vmware
...
It causes extreme long vm start time when managment server has slow connection to secondary storage
2014-10-13 12:06:37 -07:00
Anthony Xu
95c7ffbd46
fixed NPE on calculating vm snasphot volume size
2014-10-13 10:49:45 -07:00
Damodar
50185b7c3a
CLOUDSTACK-7648: There are new VM State Machine changes introduced which were missed to capture the usage events
2014-10-13 14:42:00 +05:30
Edison Su
1c1485e0f0
disable parallel for xenserver. Also for vmware, if full.clone is enabled and migratecommand will have the behavor of start/stop command
...
(cherry picked from commit d233f39c82 )
2014-10-13 00:39:33 -04:00
Edison Su
6e9d3b62b3
if guest network type is vlan://untagged, and traffic label is used, kvm agent needs to honor traffic label
...
(cherry picked from commit 5ff1ece2be )
2014-10-13 00:38:57 -04:00
Edison Su
52c6c90eda
fix build
...
(cherry picked from commit 6a5e4306f2 )
2014-10-13 00:38:40 -04:00
Edison Su
27924d1f92
if libvirt version is < 10.10(below rhel 6.5), won't set nic throttling
...
(cherry picked from commit 6dc6e8a900 )
2014-10-13 00:38:25 -04:00
Edison Su
0fd9c43ea2
vmware resource code needs to honor the timeout value send
...
(cherry picked from commit 15a2ea7c7e )
2014-10-13 00:38:10 -04:00
Wido den Hollander
3b65a5928b
kvm: Add better logging when fetching a volume from libvirt
...
Clearly show if a volume is found and if not, that the pool is being refreshed
and the fetch is tried again.
Due to my commit b53a9dcc9f the chance of a volume
not being found is slightly bigger, but the performance gain is enormous on larger
deployments.
This is why we clearly have to log that we are refreshing the pool information
when a volume is not found.
It could be that a volume is created on host A and a few seconds later host B tries
to access the volume. In that case host B's libvirt doesn't know about the volume
yet and has to refresh the pool before it does.
(cherry picked from commit 4ee82f1f40 )
2014-10-13 00:37:54 -04:00
amoghvk
da73d735b2
Revert "CLOUDSTACK-6650: Reorder Cluster list in deployment planner to protect"
...
This reverts commit d910b4ff14 since it is causing encryption/decryption issues with RPM builds
(cherry picked from commit fbcab01ff0 )
2014-10-13 00:37:34 -04:00
Santhosh Edukulla
0df43197d9
Fixed few coverity issues
...
(cherry picked from commit 45597766a5 )
2014-10-13 00:30:01 -04:00
Nitin Mehta
c8c9f1dd3a
Revert "CLOUDSTACK-7533: Wrong download URL is generated when using multiple SSVMs in a zone. The public ip of the url would sometime point to the wrong ssvm when the url was created on another one."
...
This reverts commit f3b5a6ebc7 .
Reverting since a better fix is available with CLOUDSTACK-6478
(cherry picked from commit 9e7fbae52f )
2014-10-13 00:29:00 -04:00
Hugo Trippaers
5990ed4610
Move the PrepareKickstartPxeServerCommand to the core api so other
...
modules can use it.
(cherry picked from commit b6401b04f22b0a5b686c7c477da4c6e0fd18df84)
Conflicts:
plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalKickStartServiceImpl.java
2014-10-13 00:22:50 -04:00
Anthony Xu
3540828d44
added more log for create vm snapshot
...
(cherry picked from commit 70efe1507c )
2014-10-13 00:16:35 -04:00
Sanjay Tripathi
47d2a578ee
CLOUDSTACK-6650: Reorder Cluster list in deployment planner to protect
...
GPU enabled hosts from non-GPU VM deployment.
Cluster reordering is based on the number of unique host tags in a cluster,
cluster with most number of unique host tags will put at the end of list.
Hosts with GPU capability will get tagged with implicit tags defined by
global config param 'implicit.host.tags' at the time os host discovery.
Also added FirstFitPlannerTest unit test file.
(cherry picked from commit 39fe766c2b )
2014-10-13 00:15:03 -04:00
Likitha Shetty
4b581bfa5f
BUG-ID: CLOUDSTACK-7662. Resize of detached volume fails.
...
Support offline volume resize on ESX by creating a worker VM to attach the unattached volume to and then resize it.
(cherry picked from commit 65ed25b7a6 )
2014-10-13 00:14:22 -04:00
Likitha Shetty
9f653d7404
BUG-ID: CLOUDSTACK-7653. VM's are not getting deleted from hypervisor after deleting from UI when using zone wide primary storage.
...
While expunging a volume, CS chooses the endpoint to perform delete operation by selecting any host that has the storage containing the volume mounted on it.
Instead, if the volume to be deleted is attached to a VM, the endpoint chosen by CCP should be the host that contains the VM.
(cherry picked from commit f1e3e83bbf )
2014-10-13 00:09:06 -04:00
Likitha Shetty
e338cdd1ed
BUG-ID: CLOUDSTACK-7652. [VMware] 'SOAPFaultException: The object has already been deleted or has not been completely created' exceptions.
...
If CCP thread local context which is used to handle connections to a vCenter is being re-used, validate that the context corresponds to the right vCenter API session.
(cherry picked from commit 6b06970366 )
2014-10-13 00:08:48 -04:00
Wido den Hollander
83967c93c5
CLOUDSTACK-7641: Do not always ask libvirt to refresh a storage pool
...
On larger (especially RBD) storage pools this can take a lot of
time slowing operations like creating volumes down.
The getStorageStats command will still ask a pool to be refreshed so
that the management server has accurate information about the storage pools.
On larger deployments, with thousands of volumes in one pool, this should
significantly improve storage related operations
(cherry picked from commit b53a9dcc9f )
2014-10-13 00:05:40 -04:00
Rohit Yadav
5309aa3dd9
CID-1222206: Remove DLS from XenServer56FP1Resource
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit b3946802e3 )
2014-10-12 23:59:05 -04:00
Rohit Yadav
a420028d67
XenServer56FP1Resource: remove unused import
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 410092bbe1 )
2014-10-12 23:57:25 -04:00
Devdeep Singh
e0317eeec4
CLOUDSTACK-7494. Migration of a vm fails on Hyper-V. In an earlier commit as part of
...
cleaning up vmsync changes, checkvirtualmachine command was updated to return the
power state of the vm. The change was missed for Hyper-V. This caused migration to
fail on cloudstack even though it used to succeed on the hypervisor. Updated the
hyper-v agent code to return the cloudstack equivalent power state for check virtual
machine answer.
(cherry picked from commit 5350e61187 )
2014-10-12 23:40:37 -04:00
David Nalley
ffe846673c
more revert cleanup
2014-10-12 23:31:17 -04:00
David Nalley
ac48aa8e0c
cleaning up some from a revert
2014-10-12 23:30:04 -04:00
Edison Su
d233f39c82
disable parallel for xenserver. Also for vmware, if full.clone is enabled and migratecommand will have the behavor of start/stop command
2014-10-09 17:14:57 -07:00
Edison Su
5ff1ece2be
if guest network type is vlan://untagged, and traffic label is used, kvm agent needs to honor traffic label
2014-10-09 16:43:00 -07:00
Edison Su
6a5e4306f2
fix build
2014-10-09 16:38:23 -07:00
Edison Su
6dc6e8a900
if libvirt version is < 10.10(below rhel 6.5), won't set nic throttling
2014-10-09 16:36:22 -07:00
Edison Su
15a2ea7c7e
vmware resource code needs to honor the timeout value send
2014-10-09 16:28:20 -07:00
Wido den Hollander
4ee82f1f40
kvm: Add better logging when fetching a volume from libvirt
...
Clearly show if a volume is found and if not, that the pool is being refreshed
and the fetch is tried again.
Due to my commit b53a9dcc9f the chance of a volume
not being found is slightly bigger, but the performance gain is enormous on larger
deployments.
This is why we clearly have to log that we are refreshing the pool information
when a volume is not found.
It could be that a volume is created on host A and a few seconds later host B tries
to access the volume. In that case host B's libvirt doesn't know about the volume
yet and has to refresh the pool before it does.
2014-10-10 01:00:54 +02:00
amoghvk
fbcab01ff0
Revert "CLOUDSTACK-6650: Reorder Cluster list in deployment planner to protect"
...
This reverts commit d910b4ff14 since it is causing encryption/decryption issues with RPM builds
2014-10-09 15:39:19 -07:00
Sanjay Tripathi
d910b4ff14
CLOUDSTACK-6650: Reorder Cluster list in deployment planner to protect
...
GPU enabled hosts from non-GPU VM deployment.
Cluster reordering is based on the number of unique host tags in a cluster,
cluster with most number of unique host tags will put at the end of list.
Hosts with GPU capability will get tagged with implicit tags defined by
global config param 'implicit.host.tags' at the time os host discovery.
Also added FirstFitPlannerTest unit test file.
2014-10-07 16:49:38 +05:30
Santhosh Edukulla
45597766a5
Fixed few coverity issues
2014-10-07 12:19:39 +05:30
Frank Zhang
01dada100a
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-10-06 16:03:19 -07:00
Nitin Mehta
9e7fbae52f
Revert "CLOUDSTACK-7533: Wrong download URL is generated when using multiple SSVMs in a zone. The public ip of the url would sometime point to the wrong ssvm when the url was created on another one."
...
This reverts commit f3b5a6ebc7 .
Reverting since a better fix is available with CLOUDSTACK-6478
2014-10-06 15:00:32 -07:00
amoghvk
0ef6cd36c4
Revert "CLOUDSTACK-6650: Reorder Cluster list in deployment planner to protect"
...
This reverts commit 39fe766c2b .
2014-10-02 13:28:52 -07:00
Anthony Xu
70efe1507c
added more log for create vm snapshot
2014-10-01 16:18:28 -07:00
Sanjay Tripathi
39fe766c2b
CLOUDSTACK-6650: Reorder Cluster list in deployment planner to protect
...
GPU enabled hosts from non-GPU VM deployment.
Cluster reordering is based on the number of unique host tags in a cluster,
cluster with most number of unique host tags will put at the end of list.
Hosts with GPU capability will get tagged with implicit tags defined by
global config param 'implicit.host.tags' at the time os host discovery.
Also added FirstFitPlannerTest unit test file.
2014-10-01 17:25:41 +05:30
Likitha Shetty
65ed25b7a6
BUG-ID: CLOUDSTACK-7662. Resize of detached volume fails.
...
Support offline volume resize on ESX by creating a worker VM to attach the unattached volume to and then resize it.
2014-10-01 15:41:50 +05:30
Hugo Trippaers
783ed9be98
"Fixing" a Coverity/Findbugs finding.
2014-09-30 14:42:08 +02:00
Hugo Trippaers
ec56ee9eb8
Merge branch 'bugfix/CID-1241966'
2014-09-30 14:21:14 +02:00
Likitha Shetty
f1e3e83bbf
BUG-ID: CLOUDSTACK-7653. VM's are not getting deleted from hypervisor after deleting from UI when using zone wide primary storage.
...
While expunging a volume, CS chooses the endpoint to perform delete operation by selecting any host that has the storage containing the volume mounted on it.
Instead, if the volume to be deleted is attached to a VM, the endpoint chosen by CCP should be the host that contains the VM.
2014-09-30 15:20:15 +05:30
Likitha Shetty
6b06970366
BUG-ID: CLOUDSTACK-7652. [VMware] 'SOAPFaultException: The object has already been deleted or has not been completely created' exceptions.
...
If CCP thread local context which is used to handle connections to a vCenter is being re-used, validate that the context corresponds to the right vCenter API session.
2014-09-30 15:20:14 +05:30
Hugo Trippaers
586e00cee1
CID-1241965 Fix potential NPE
2014-09-30 11:43:02 +02:00
Wido den Hollander
b53a9dcc9f
CLOUDSTACK-7641: Do not always ask libvirt to refresh a storage pool
...
On larger (especially RBD) storage pools this can take a lot of
time slowing operations like creating volumes down.
The getStorageStats command will still ask a pool to be refreshed so
that the management server has accurate information about the storage pools.
On larger deployments, with thousands of volumes in one pool, this should
significantly improve storage related operations
2014-09-28 20:51:10 +02:00
Frank Zhang
44a4158c48
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-09-25 10:35:49 -07:00
Rohit Yadav
410092bbe1
XenServer56FP1Resource: remove unused import
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-25 17:12:40 +02:00
Rohit Yadav
b3946802e3
CID-1222206: Remove DLS from XenServer56FP1Resource
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-25 16:48:27 +02:00
Hugo Trippaers
3a5401f8f9
Merge branch 'bugfix/CID-1240106'
2014-09-24 09:07:20 +02:00
Frank Zhang
9425f06d77
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-09-23 11:37:26 -07:00
Hugo Trippaers
c20336c1ab
CID-1240107 Remove unused variable
2014-09-23 11:06:41 +02:00
Frank Zhang
b8795d8879
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-09-22 15:56:57 -07:00
Frank Zhang
6655d8f5b0
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-09-22 15:24:54 -07:00
Frank Zhang
6155d3ecaa
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-09-22 13:57:32 -07:00
Devdeep Singh
5350e61187
CLOUDSTACK-7494. Migration of a vm fails on Hyper-V. In an earlier commit as part of
...
cleaning up vmsync changes, checkvirtualmachine command was updated to return the
power state of the vm. The change was missed for Hyper-V. This caused migration to
fail on cloudstack even though it used to succeed on the hypervisor. Updated the
hyper-v agent code to return the cloudstack equivalent power state for check virtual
machine answer.
2014-09-20 19:06:11 +05:30
Mike Tutkowski
18e5aa116e
Fixing an issue around VMware system templates
2014-09-18 19:38:59 -06:00
Frank Zhang
b11e3bc60a
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-09-18 16:54:37 -07:00
Frank Zhang
8b89494a35
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-09-18 16:54:37 -07:00
Daan Hoogland
7f440854f7
CLOUDSTACK-7184 retry-wait loop config to deal with network glitches
...
(cherry picked from commit a29f954a26 )
Conflicts:
engine/orchestration/src/com/cloud/agent/manager/DirectAgentAttache.java
2014-09-18 12:55:05 +02:00
Daan Hoogland
dec9133dcd
CLOUDSTACK-7184: xenheartbeat gets passed timeout and interval
...
(cherry picked from commit 4d065b9a3a )
Conflicts:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/discoverer/XcpServerDiscoverer.java
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
server/src/com/cloud/configuration/Config.java
server/src/com/cloud/configuration/ConfigurationManagerImpl.java
server/src/com/cloud/resource/DiscovererBase.java
2014-09-18 12:51:10 +02:00
Rohit Yadav
b1d0df16cf
CID-1116258: Guard _storagePools using synchronized in KVMStoragePoolManager
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-18 11:48:11 +02:00
Rohit Yadav
e1842a9d53
CID-1199715: Remove dead code from LibvirtStorageAdaptor
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-17 16:30:42 +02:00
imduffy15
2648912afa
Fix CID-1222222
2014-09-16 11:26:46 +01:00
Kishan Kavala
f0e82f340a
CLOUDSTACK-7543: Attach RBD disk for LXC during start. Moved rbd map code seperate method. When adding block device, qemu driver should not be used for LXC
2014-09-15 10:15:54 +05:30
Kishan Kavala
4f3de024de
Add script to ensure cgroups are not co-mounted in rhel7/lxc. If required, script will unmount co-mounted cgroups and remount them seperately
2014-09-11 14:34:40 +05:30
Nitin Mehta
f3b5a6ebc7
CLOUDSTACK-7533: Wrong download URL is generated when using multiple SSVMs in a zone. The public ip of the url would sometime point to the wrong ssvm when the url was created on another one.
...
Fix the bug by removing the command CreateEntityDownloadURLCommand from the host delegation. This results in same ssvm for creating the symlink on ssvm and same public ip being used for generating the url on MS.
2014-09-10 17:46:33 -07:00
Frank Zhang
e06fa18ed2
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-09-10 14:43:41 -07:00
Anshul Gangwar
a400eecf6c
CLOUDSTACK-7503: Fixed few coverity issues
2014-09-10 11:33:01 +05:30
Anthony Xu
fcf2c1b6bc
CLOUDSTACK-7505:
...
if VM is created from ISO, don't change platform metadat for VM on XS
2014-09-09 14:02:37 -07:00
Frank.Zhang
10544e287b
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-09-05 16:28:34 -07:00
Frank.Zhang
c301bd1c94
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-09-05 16:28:33 -07:00
Kishan Kavala
41fdc418ff
CLOUDSTACK-7472: Disable kvmclock for LXC
2014-09-05 19:38:55 +05:30
Kishan Kavala
6f7c4863a2
CLOUDSTACK-7473: Vm migration is not supported for LXC. When host is put in maintenance mode, stop the Vms instead of migrating
2014-09-04 20:59:19 +05:30
Rajani Karuturi
17164c3c83
Fixed CLOUDSTACK-6942: LXC: optimize template copy to primary
...
saving LXC template as tar to primary and extracting it only when
required.
This would improve the template copy time.
Reviewed By: Kishan Kavala
2014-09-04 14:56:29 +05:30
Fred Clift
355eb72c7d
make virtual router /latest/.htaccess file be static - no longer dynamically generate it, remove code that managed the file previously
...
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
2014-09-04 04:22:27 -04:00
Anthony Xu
5811ebeee7
if VM scale is disable, don't set any scale option for VM
2014-09-03 14:40:00 -07:00
Hugo Trippaers
dc3f0cbc63
Improve the handling of the findbug exclude files
2014-09-03 10:41:22 +02:00
Kishan Kavala
718fd5f39f
CLOUDSTACK-7445: Number whitespaces in "rbd showmapped" command varies in plain format. Use regex in grep to workaround.
2014-08-27 16:13:35 +05:30
Kishan Kavala
30ecf935e8
CLOUDSTACK-7315: Set LXC volumes format as DIR. Use rm command to delete LXC volumes. Libvirt delete volume does not handle directories
2014-08-26 13:57:48 +05:30
Kishan Kavala
656fc69f39
remove trailing comma in options sent to qemu-img
2014-08-22 15:39:04 +05:30
Mike Tutkowski
3773ff060e
Update to volume-resize logic
2014-08-21 20:18:20 -06:00
Anthony Xu
b7f5e95c8f
map XS 6.5 betas to the same resource, that all XS 6.5 betas will use the same resource and guest os list
2014-08-21 16:57:19 -07:00
Wido den Hollander
ab7c1f34d6
kvm: Do not print the whole exception when pool is not found in libvirt
...
This causes the logs to be filled with Exceptions which aren't nice for
users to read
2014-08-20 14:00:29 +02:00
Wido den Hollander
1ed0fe4ee7
kvm: Throw a proper exception when pool could not be fetched from libvirt
...
Otherwise NULL is returned and leads to a NPE further up the chain.
2014-08-20 13:39:52 +02:00
Likitha Shetty
7dbff9b42c
CLOUDSTACK-7371. [VMware] Enabling primary storage maintenance fails when storages are across cluster.
...
1. While destroying a ROOT volume do the lookup of the associated VM under the DC and not just cluster.
2. In case of VMware, during VM start if a volume is being recreated no need to detach the old volume because
we now expunge it immediately and don't wait for the storage cleanup task to run.
2014-08-20 10:51:18 +05:30
Likitha Shetty
8bb4022f37
CLOUDSTACK-4587. System VMs fail to start when the primary storage that has the System VMs is put into maintenance.
...
During VM start while configuring its disk devices, obtain the matching disk for a volume in storage
using both the volume's path and volume's datastore information.
2014-08-20 10:51:18 +05:30
Anthony Xu
dbe950a27e
avoid creating same primary storage multiple times for XenServer
2014-08-18 17:55:34 -07:00
Anthony Xu
81c5e184ba
clean up XenServer resource code
2014-08-18 17:25:10 -07:00
Wido den Hollander
eeac81838f
kvm: Return capitalized NONE when no disk cache mode is set
...
This caused Instances not to start under rare circumstances
2014-08-18 23:58:50 +02:00
Sateesh Chodapuneedi
a1d0925f90
CLOUDSTACK-7360 [vmware] Add host to existing cluster fails if the cluster is using Nexus 1000v as backend for atleast one traffic type.
...
While adding host to existing cluster which is using Nexus 1000v as a network backend, skip validation of Nexus VSM as it was already done while adding that cluster.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2014-08-18 07:18:13 +05:30
Anshul Gangwar
1c688f40e1
CLOUDSTACK-7277: [Hyper-V] For vmsync first VMs are listed and their power state is
...
determined. To exclude hosted system we filter the result on Caption='Virtual Machine'
but this string is locale dependent so it may not not work properly for locales other
than english. To overcome this now we started using ProcessId >= 0 filter
2014-08-18 11:38:29 +05:30
Anshul Gangwar
d1796c5f58
CLOUDSTACK-7235: [Hyper-V] In case of any exception in ModifyStoragePoolCommand, now we are returning appropriate error
2014-08-18 11:38:29 +05:30
Anshul Gangwar
0ecc9f79af
CLOUDSTACK-7234: stop sending smb credentials to Hyper-v agent
2014-08-18 11:38:29 +05:30
Anthony Xu
2be02d1f51
added XS 6.5 beta1 support, will change the version after XS 6.5 is released
2014-08-15 11:45:24 -07:00
Anthony Xu
90fe6d8087
removed trailing space
2014-08-13 11:09:38 -07:00
Sateesh Chodapuneedi
6a4a11ed71
CLOUDSTACK-7334. [VMware] AddHost command fails if there is a space in the VMware DC/Cluster name.
...
URL decode vCenter path during cluster discovery.
2014-08-13 16:24:14 +05:30
Hugo Trippaers
328599ae0b
Don't depend on static paths especially if we are already checking that
...
location using the getResource call.
2014-08-13 09:02:04 +02:00
Edison Su
a1bee2cb61
measure how long it takes to create a snaphsot
2014-08-12 15:13:42 -07:00
amoghvk
d1d722f9bd
CLOUDSTACK-7295: VMs is Stopped state have no host ID, resulting in NPE
2014-08-11 14:56:58 -07:00
Santhosh Edukulla
fd96ad02d7
Fixed few coverity reported issues around concurrency, null checks
2014-08-11 16:55:23 +05:30
Santhosh Edukulla
f9e11540c7
Fixed few coverity issues
2014-08-11 16:02:19 +05:30
Min Chen
9866c648eb
CLOUDSTACK-7260: Management server not responding after some time for
...
Vmware due to Oom (cannot create native thread).
2014-08-05 17:36:53 -07:00
Frank.Zhang
12ad254069
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
add missing license header
2014-08-05 11:11:02 -07:00
Frank.Zhang
1ee7e0c77e
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-08-04 15:00:44 -07:00
Frank.Zhang
44dff6c426
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-08-04 15:00:44 -07:00
Frank.Zhang
66fff6c574
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-08-04 15:00:43 -07:00
Anthony Xu
0fe1d4bb27
got VBD statistics from RRD
2014-08-04 13:57:18 -07:00
Damodar
b73fe32519
Fixing Coverity Issues(2nd) in CitrixResourceBase.java
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-08-04 17:30:43 +05:30
Likitha Shetty
f803100813
CLOUDSTACK-6969. Data Volume Shrink operation failing with "Unexpected Exception".
...
For ResizeVolume API command -
1. If hypervisor resource throws an exception, handle the NPE thrown by the job framework.
2. Improve user error message in case of RuntimeException by throwing the exception instead of 'Unexpected Exception'.
2014-08-01 16:23:47 +05:30
Sateesh Chodapuneedi
96a6e673a3
CLOUDSTACK-7078 CLONE - [VMWARE]System VM's are failed to start with Nexus enabled Zone Since introducing pool of session contexts we no more have a dedicated context for each VMware hypervisor host. Hence vsm credentials stored in session context cannot be retrieved always correctly. Fix is to register the vsm credentials after fetching context and the context gets recycled after use.
...
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2014-07-31 16:31:41 +05:30
Anthony Xu
b5c132582a
vmsync returns PowerState for simulator
2014-07-31 10:37:13 -07:00
Santhosh Edukulla
44709111a3
Added Coverity Fixes
2014-07-31 15:01:30 +05:30
Anthony Xu
521b2840b2
new vmsync for simulator
2014-07-30 15:10:51 -07:00
Anthony Xu
680d4202de
CLOUDSTACK-7204:
...
fixed build for simulator
2014-07-30 10:59:00 -07:00
Anthony Xu
ecf100e4ed
fixed build for vmware
2014-07-28 17:37:31 -07:00
Anthony Xu
330c4ba578
completed the new vmsync TODOs in the code.
...
removed old vmsync logic
2014-07-28 12:51:37 -07:00
Wido den Hollander
7542ffc482
CLOUDSTACK-6181: Set the correct flags when resizing RBD
2014-07-26 11:39:28 +02:00
Sheng Yang
abc0b40acb
CLOUDSTACK-7124: Fix semicolon caused VPN programming issue on Xen
2014-07-25 16:56:35 -07:00
Santhosh Edukulla
3f6d5e392f
Fixed Coverity Issues Reported
2014-07-25 16:43:29 +05:30
Damodar
0a5940c9a8
Coverity: Fixing some of the coverity issues reported in CitrixResourceBase.java.
...
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
2014-07-25 15:34:20 +05:30
Likitha Shetty
786285ab54
CLOUDSTACK-7174. [VMware] Recreating System VMs fails if global config 'vm.instancename' is set to true.
...
Append VM's name in vCenter with the hostname only for User VMs.
2014-07-24 13:05:45 +05:30
amoghvk
c804660c74
CLOUDSTACK-7168: Revert "Fixed Coverity Issues reported" that broke CI
...
This reverts commit 4523490d44 .
2014-07-23 11:37:36 -07:00
Wido den Hollander
173909e99d
CLOUDSTACK-6181: Allow RBD volumes to be resized
...
We don't need an external script to investigate the format of the RBD volume,
we only have to ask Libvirt to resize the volume and that will ask librbd to
do so.
2014-07-22 22:28:34 +02:00
Hugo Trippaers
1d2124dcbf
Fix NPE reported on IRC, provide the user an informative error message
2014-07-22 17:45:24 +02:00
Santhosh Edukulla
4523490d44
Fixed Coverity Issues reported
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-07-22 18:03:36 +05:30
Kishan Kavala
7d3f381d94
Set mapped device path while detaching rbd disk
2014-07-22 17:50:58 +05:30
Likitha Shetty
b3e4c6d6dc
CLOUDSTACK-7150. [VMware] Global config 'vm.instancename' is not honored.
...
If global config 'vm.instancename' is set to true, VM name in vCenter should be '<instance_name>-<vm_hostname>'.
2014-07-22 11:59:53 +05:30
Suresh Ramamurthy
03de9cc335
CLOUDSTACK-6845 : NuageVsp Network plugin
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-07-21 10:49:49 +02:00
Anthony Xu
d05549e16b
XS task object may disappear, change the log level
2014-07-18 16:05:54 -07:00
Marcus Sorensen
849049a2f0
KVM: Allow changing VM video card via agent.properties. This change in
...
LibvirtVMDef can also be leveraged to add the option to service offering
or template hardware selection (as nic and disk types do).
2014-07-18 16:52:51 -06:00
Edison Su
9fb93fe5b3
CLOUDSTACK-7110: introduced by c1116142a3, if it's a data volume, mgt server doesn't send image format to agent
2014-07-18 12:03:10 -07:00
Hugo Trippaers
c1aed55583
More rat fixes
2014-07-18 11:52:27 +02:00
Hugo Trippaers
5651a13cfd
Remove duplicated code
2014-07-18 09:28:42 +02:00
Joris van Lieshout
e8c32c7f5b
Disable inband management of openvswitch on the link local network. You don't want instances connected to this network to be able to talk to the openvswitch management interface.
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-07-15 13:35:02 +02:00
amoghvk
3d8dd1c921
Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/cloudstack
2014-07-14 17:30:12 -07:00
Amogh Vasekar
c30821f703
CLOUDSTACK-6671: Missing patch in master
2014-07-14 17:00:08 -07:00
amoghvk
62e63a1bf7
CLOUDSTACK-6358: Missing patches in master for VMware
2014-07-14 16:54:10 -07:00
Amogh Vasekar
09069fcc87
CLOUDSTACK-6358: Add missing patches in master for KVM
2014-07-14 16:51:55 -07:00
amoghvk
6831ed4026
CLOUDSTACK-6358: Missing patches in master branch
2014-07-14 15:17:58 -07:00
Kelven Yang
5143fe404b
When instance.name.flag is set to true, append user-supplied name with legacy prefix to VM name appears in vCenter.
2014-07-14 14:53:51 -07:00
Edison Su
e1095b0110
revert the change made by commit: a600d840
2014-07-14 14:10:16 -07:00
ynojima
e7392cdac6
Remove "--output" option from qemu-img info command call
...
since the option is not supported by qemu-img in CentOS 6.3
2014-07-13 00:33:16 -06:00
Koushik Das
e85d1f911c
Some minor fixes in simulator code
2014-07-09 13:20:28 +05:30
Kelven Yang
362f875a3f
Detach disks before cleaning up of VMware worker VM.
2014-07-08 14:47:22 -07:00
Frank.Zhang
62e005b97e
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-07-07 16:06:33 -07:00
Frank.Zhang
65497b69c7
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-07-07 14:52:45 -07:00
Frank.Zhang
ce1b633daf
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-07-07 11:46:55 -07:00
Frank.Zhang
7b444183db
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-07-07 11:37:38 -07:00
Likitha Shetty
8cf94c9ec1
CLOUDSTACK-7069. [VMware] While setting 'numCoresPerSocket' property for a Virtual Machine in VMware
...
add a check to ensure the vSphere version is 5.0 or above.
2014-07-07 14:36:58 +05:30
Likitha Shetty
4f969057b2
CLOUDSTACK-7030. After the restart of MS in a clustered MS pool, not all hung worker VMs are recycled.
...
Recycle worker VMs that originally belonged to other management servers too because in case of MS restart, the owner MS might change.
2014-07-07 13:38:47 +05:30
Koushik Das
a413536f90
Added a simulator based test for VM sync
2014-07-07 12:57:55 +05:30
Hugo Trippaers
b9145beab6
Fix CID 1116267 Don't modify the set while the iterator is still in use.
2014-07-04 16:48:28 +02:00
Santhosh Edukulla
a600d8408e
Fixed Resource Leaks, null dereferences, few other issues reported by coverity
2014-07-04 16:17:58 +05:30
Santhosh Edukulla
97d296bfbd
Fixed Coverity reported performance issues like inefficient string concatenations, wrong boxing or unboxing types, inefficent map element retrievals
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-07-01 22:06:25 +02:00
Koushik Das
4f5df54d5c
Some fixes in the simulator
...
1. Fixed JSON response deserialization. While creating a mock a JSON can be passed which will be deserialized into a response object and returned from agent layer.
For e.g. for a mock corresponding to StopCommand, a response like "{"com.cloud.agent.api.StopAnswer":{"result":false,"wait":0}}" can be passed.
2. Ability to mock PingCommand (returned as part of getCurrentStatus() agent method). As a part of this a mocked VM state report can be returned.
For e.g. {"com.cloud.agent.api.PingRoutingWithNwGroupsCommand":{"newGroupStates":{},"newStates":{},"_hostVmStateReport":{"v-2-VM":{"state":"PowerOn","host":"SimulatedAgent.e6df7732-69b2-429b-9b6a-3e24dddfa2e0"},"i-2-5-VM":{"state":"PowerOff","host":"SimulatedAgent.e6df7732-69b2-429b-9b6a-3e24dddfa2e0"}},"_gatewayAccessible":true,"_vnetAccessible":true,"hostType":"Routing","hostId":3,"contextMap":{},"wait":0}}
2014-07-01 15:26:12 +05:30
Mike Tutkowski
03b1e86bde
CLOUDSTACK-7003
2014-06-30 10:17:50 -06:00
Anthony Xu
d5fea10222
Cs tries to destroy vlan object on XS host when destroying VM, if the VLAN object is being used, CS expects the exception, lower the log level here
2014-06-27 15:13:57 -07:00
Anthony Xu
54d7e8dcd3
Destroy unplugged VIFs before creating a VIF for a VM, and reuse the device id
2014-06-27 15:00:49 -07:00
Sanjay Tripathi
69e86cb459
CLOUDSTACK-6453: [GPU] Windows 2012 Server instance created with vGPU offering is not coming up after installing PV drivers.
2014-06-27 15:58:42 +05:30
Sateesh Chodapuneedi
71f76edf71
CLOUDSTACK-6996 Adding cluster to legacy zone failed
...
Lookup zone_id field in legacy_zones table to search the table for legacy zone.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2014-06-27 14:01:39 +05:30
Hugo Trippaers
cd0ef09344
Fix typo and add the right exception to the error map.
2014-06-25 15:51:28 +02:00
Kelven Yang
f756d4aa33
Make job info universally available across management server and resource agents
2014-06-24 16:28:22 -07:00
Mike Tutkowski
3d9eaf0753
Fixed some spacing issues from 4d6c682f18
2014-06-24 15:27:06 -06:00
Santhosh Edukulla
b2283d7a28
Fixed few resource leaks and added secstoragefirewallcfg command support to simulator
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-06-24 23:19:47 +02:00
punith-cloudbyte
4d6c682f18
supporting nfs protocol and resize feature for managed storage for xenserver
...
resize feature refactored
Signed-off-by: Mike Tutkowski <mike.tutkowski@solidfire.com>
2014-06-24 15:16:45 -06:00
Daan Hoogland
be028974da
Revert "CLOUDSTACK-6967: Now with module!"
...
This reverts commit 189972bc7c .
Conflicts:
plugins/hypervisors/ovm3
2014-06-24 10:23:49 +02:00
Daan Hoogland
91e300eb82
Revert "CLOUDSTACK-6967 merge problem resolution"
...
This reverts commit 4610c76fa9 .
2014-06-24 10:21:03 +02:00
Daan Hoogland
d69e14323a
Revert "rats"
...
This reverts commit aa1ce9a363 .
2014-06-24 10:21:01 +02:00
Daan Hoogland
aa1ce9a363
rats
2014-06-23 16:39:10 +02:00
Funs Kessen
4610c76fa9
CLOUDSTACK-6967 merge problem resolution
2014-06-23 15:08:51 +02:00
Funs
189972bc7c
CLOUDSTACK-6967: Now with module!
...
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
(cherry picked from commit 1516b041bc )
2014-06-23 12:39:23 +02:00
Funs
8a485b9b59
CLOUDSTACK-6967: Initial OVM3 drop
...
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
(cherry picked from commit ed47763e25 )
Conflicts:
api/src/com/cloud/network/NetworkService.java
api/src/org/apache/cloudstack/api/ApiConstants.java
api/src/org/apache/cloudstack/api/command/admin/usage/AddTrafficTypeCmd.java
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotObject.java
plugins/pom.xml
server/src/com/cloud/network/NetworkServiceImpl.java
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
server/test/com/cloud/vpc/MockNetworkManagerImpl.java
ui/scripts/docs.js
2014-06-23 12:39:10 +02:00
Damodar Reddy
5cbb182c6d
CLOUDSTACK-6636: [Windows] Can not create Template from ROOT snapshot on Windows management server with Xen/NFS storage type. This change is only for XenServer with NFS Storage Server. Will fix remaining when we touch them.
...
Signed-off-by: Koushik Das <koushik@apache.org>
2014-06-19 09:35:26 +05:30
Murali Reddy
70a114c3a8
CLOUDSTACK-6925: [OVS] get rid custom logic to create bridges on hosts
...
in the XenServer pool for GRE tunnel networks
Fix uses XenServer recommended way
Network.other_config:assume_network_is_shared=true
which ensures bridge is created automatically on hosts in the pool for
GRE tunnel networks. Fix also gets rid of error prone custom logic that ensures
bridge is created by plugging a VIF into the dom0 and connected to
GRE tunnel network.
Conflicts:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
2014-06-17 17:54:12 +05:30
Girish chaudhari
591148c464
CLOUDSTACK-5150 - set the template size from source
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
(cherry picked from commit 883d8f1119 )
2014-06-17 13:44:04 +02:00
Mike Tutkowski
42d00cae58
SolidFire (shared-access) Provider
2014-06-16 12:15:29 -06:00
Anshul Gangwar
b43036d10e
CLOUDSTACK-6872: [hyperv] removed the redundant connectToRemote, DisconnectRemote methods which in turn fixes this bug. connectToRemote was used to connect to share, but once the share is domain joined we don't need this method as we already have required permissions
2014-06-13 13:26:30 +05:30
Murali Reddy
f4d4e3ffe4
CLOUDSTACK-6755: [OVS] Can't create more than 7 GRE tunnel networks in
...
xen cluster
XenServer does not create a bridge automatically when VIF from domU is connected
to internal network. So there is logic to force bridge creation by
creating VIF in dom0 connected to GRE tunnel network. But there is no
logic to delete the VIF after bridge gets created. So this fix ensure
VIF is delted when atleast there is one domU VIF connected to the
network.
2014-06-12 14:22:56 +05:30
Hugo Trippaers
cd4723794e
Fix a few coverity findings
2014-06-11 14:06:16 +02:00
Tim Mackey
a8212d9ef4
Cleanup of Xen and XenServer terms. Cloned xen plugin creating a xenserver plugin, then removed xen plugin
...
Signed-off-by: Tim Mackey <tmackey@gmail.com>
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
2014-06-07 04:50:23 -04:00
Wido den Hollander
84cfb47281
kvm: Use getStoragePool after createStoragePool when we create a libvirt pool
...
This removes some redundant code
2014-05-28 10:34:20 +02:00
Marcus Sorensen
7ce3034299
CLOUDSTACK-6790: Disable PXE ROM for system vm nics
2014-05-27 16:52:26 -06:00
Marcus Sorensen
f3a0d257b8
CLOUDSTACK-6788: Add agent property to optionally disable kvmclock on guests
2014-05-27 16:16:41 -06:00
Wido den Hollander
48899e4c81
CLOUDSTACK-6783: Return a proper LibvirtStoragePool object after creating the pool
...
In situations where libvirt lost the storage pool the KVM Agent will re-create the
storage pool in libvirt.
This could be then libvirt is restarted for example.
The object returned internally was missing essential information like the sourceDir
aka the Ceph pool, the monitor IPs, cephx information and such.
In this case the first operation on this newly created pool would fail. All operations
afterwards would succeed.
2014-05-27 16:21:07 +02:00
Anshul Gangwar
26fa623ffd
CLOUDSTACK-6663: Fixed Hyper-V agent fails to start on some setups. During startup agent tries
...
to get nic info of 0.0.0.0. To get it, it iterates through all nics and return the last NIC in
the list if it doesn't match with any IP address. In case last NIC doesn't have unicastAddress,
Hyper-V agent will fail to start. We don't need IP address during initialization. It get
initialized with startupcommand later.
2014-05-27 12:03:11 +05:30
Murali Reddy
63f6888588
CLOUDSTACK-6668: OVS distributed routing: ensure bridge is deleted when
...
last VM from the VPC is deleted on a host
OVS distributed routing: ensure bridge is deleted when last VM from the
VPC is deleted on a host. This fix ensures that bridge is
destroyed.
2014-05-14 16:41:56 +05:30
Sanjay Tripathi
35cd61c463
CLOUDSTACK-6649: CS is not giving the system-wide capacity for GPU reosurce.
2014-05-14 15:05:28 +05:30
Sheng Yang
10de19e4dd
CLOUDSTACK-6607: Correct the result of VpcNetworkUsage
...
Blank or not shouldn't be used to indicate command is failure or not.
2014-05-12 18:50:41 -07:00
Devdeep Singh
5ba5da3696
CLOUDSTACK-6622: After a volume was live migrated, the destination smb storage path was added to
...
the folder column. For an smb share the smb credentials are in the query string of the path.
Before adding the path, smb shares query string should be cleaned up.
2014-05-09 16:31:34 +05:30
Anshul Gangwar
b82e26253c
CLOUDSTACK-6620: Fixed null pointer exception in hyperv agent in getting vmstats, when all vms are deleted from outside
2014-05-09 16:31:25 +05:30
Anshul Gangwar
7916542d99
CLOUDSTACK-6399: When there are no vms running on hyperv host, then agent was returning null. In
...
that case cloudstack was not doing anything and not updating the state of the vms to stopped.
Now the agent returns empty list of hostvmstatereport. Management server will then update the
vm state to stopped (instead of not acting upon the return state).
2014-05-09 16:31:06 +05:30
Harikrishna Patnala
3f26eeb6ed
CLOUDSTACK-6551: [Automation] Failed to revert vm snapshot in xen
2014-05-08 16:35:53 +05:30
Jayapal
d4f167032b
Fixed vpc private gateway backend issues
2014-05-07 16:33:46 +05:30
Rajesh Battala
dacb541950
Fixed windows line ending issues
2014-05-07 15:13:46 +05:30
Koushik Das
c9a09f548c
CLOUDSTACK-6579: used_bytes column of storage_pool table is no longer used and should be removed
...
For now correctly setting used_bytes. Also fixed the corresponding simulator code
2014-05-06 20:27:41 +05:30
Rajesh Battala
f9cf2c241b
CLOUDSTACK-6518 [Hyper-V] Efficient way of finding the empty nic in VR/VpcVR to configure VPC entities
2014-05-05 12:56:42 +05:30
Bharat Kumar
99b4cf788e
Cloudstack-5077: reserve cpu and memory only when vmware.reserve.cpu/mem are set to true. Insted of setting the ovecommit values to one on upgrade, we popultate them from the global values.
...
Conflicts:
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java
engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
2014-05-05 11:39:10 +05:30
Mike Tutkowski
8ac7784db2
CLOUDSTACK-6170 Corrected an issue related to the "Reinstall VM" command and managed storage with VMware
2014-05-02 18:41:59 -06:00
Sateesh Chodapuneedi
5bc72ea250
CLOUDSTACK-6317 [VMware] Tagged VLAN support broken for Management/Control/Storage traffic
...
Check if switch name detected from traffic label for management, storage, control traffic is null before falling back to default value.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2014-05-02 18:25:29 +05:30
Wido den Hollander
a7004db7c8
rbd: Create snapshot for cloning operations only when it is required
...
We used to create the snapshot after the copy from Secondary Storage,
but it could be that we never use the snapshot.
Now we check if the snapshot exists prior to performing the cloning operation
2014-05-02 11:55:34 +02:00
Wido den Hollander
3962577329
CLOUDSTACK-4549: Do not force RBD snapshot backups to RAW format
...
Since we use qemu-img to copy from RBD to Secondary Storage we no
longer have to force to RAW images, but can stick with QCOW2
When the snapshot backups are QCOW2 format they can easily be deployed
again when restoring from a backup
2014-05-01 21:03:11 +02:00
Wido den Hollander
c1116142a3
kvm: Better handle different volume formats when creating a volume
...
The KVMStorageProcessor no longer has a hardcoded if-statement which sets
RBD volumes to RAW, this is now handled in the LibvirtStorageAdapter
The Management Server still sends QCOW2 as format. That's a fix for later.
2014-05-01 21:03:11 +02:00
Anthony Xu
b3491bcbac
removed unused command ClusterSyncCommand
2014-05-01 11:45:19 -07:00
Anthony Xu
282c9da68e
disable XS event
2014-04-29 11:34:00 -07:00
Koushik Das
8d92d00c87
CLOUDSTACK-4371: [Performance Testing] Basic zone with 20K Hosts, management server restart leaves the hosts in disconnected state for very long time
...
Fixed simulator code to handle local storage during host reconnect
2014-04-29 11:11:25 +05:30
Mike Tutkowski
cbf0a559af
CLOUDSTACK-6170 Needed to add logic for XS 6.2 + XS62ESP1 + XS62ESP1004
2014-04-28 23:32:17 -06:00
Sanjay Tripathi
c36d221a30
Fix log messages for vgpu creation.
2014-04-26 17:28:27 +05:30
Mike Tutkowski
06bbcde458
Organized an algorithm a bit more
2014-04-25 11:57:54 -06:00
Sanjay Tripathi
cf4db845ff
CLOUDSTACK-6452: Failed to Live Migrate VM across clusters with Xenserver 6.2.5.
2014-04-25 16:39:40 +05:30
Murali Reddy
42b5e1858c
incorporate change in getGuestNicModel signature, while handling OVS in
...
OvsVifDriver
2014-04-25 15:41:02 +05:30
Murali Reddy
8e4391bff3
CLOUDSTACK-6505: XenServer bridge for the OVS tunnel network gets reset
...
on the hosts in the xenserver cluster
this fix ensures that brige is created only once so that openflow rules
configured on the bridge are not lost.
2014-04-25 15:02:18 +05:30
Murali Reddy
771abe4286
fix KVM plug-in for OVS tunnel network. Fix addreses two issues.
...
fix mismatch of ovs-host-setup, ovs_host_setup used Libvirt resource and
scripts
plug the nic to OVS bridges created for the tunnel network.
Conflicts:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/OvsVifDriver.java
2014-04-25 15:02:17 +05:30
Murali Reddy
095151c98a
add support for sequence numner in the VPC topology updates and VPC
...
routing policy updates
Conflicts:
setup/db/db/schema-430to440.sql
2014-04-25 15:02:17 +05:30
Anshul Gangwar
6511b96088
CLOUDSTACK-6504: removed warnings coming in building hyper-v agent code
2014-04-25 14:46:06 +05:30
Anshul Gangwar
1dc76a2743
CLOUDSTACK-6470: while stopping vm in hyper-v, now we are first trying to shutdown it gracefully before turning it off forcefully
2014-04-25 14:45:37 +05:30
Marcus Sorensen
6ca4e3acb6
CLOUDSTACK-6500: Make KVM agent aware of rootDiskController
...
and nicAdapter parameters passed in StartCommand, provided
by template details
2014-04-24 19:01:33 -06:00
Mike Tutkowski
a7e267b416
CLOUDSTACK-6170 (VMware root-disk support for managed storage)
2014-04-24 15:03:05 -06:00
Mike Tutkowski
db9de2e39b
CLOUDSTACK-6488 Fixed an issue where the "path" field was not being set properly in the DB when the volume had a snapshot taken of it
2014-04-23 18:30:19 -06:00
Anthony Xu
e0e226869d
CLOUDSTACK-6438
...
CLOUDSTACK-6442
XAPI plugins must be copied to XS master first.
2014-04-23 15:32:36 -07:00
Mike Tutkowski
523913a315
CLOUDSTACK-6469
2014-04-22 22:52:33 -06:00
Anthony Xu
4cb3e553d5
enable XS event for XS 6.2 + SP1 + FOX
2014-04-22 11:43:43 -07:00
Mike Tutkowski
1bb31412fc
CLOUDSTACK-6170 (VMware root-disk support for managed storage)
2014-04-21 22:22:50 -06:00
Anshul Gangwar
455d2b3284
CLOUDSTACK-6411: removing license header from nuget.config and agent settings file, with
...
the header they are not getting loaded properly. Added an exception to not to do rat
checks on these files.
2014-04-21 14:10:17 +05:30
Koushik Das
bcc640d138
Changed mode from 755 to 644 for simulator related files
2014-04-21 13:41:05 +05:30
Mike Tutkowski
c0910cbdb9
CLOUDSTACK-6170 (VMware root-disk support for managed storage)
2014-04-19 10:41:42 -06:00
Sheng Yang
4620c27ebf
CLOUDSTACK-6047: Make aggregation command timeout configurable
...
In case some environments has different performance or we found some commands
would took too long to execute, one global configuration item is introduced to
specify "time out in seconds per one command in aggregation commands".
By default it's 3 seconds. If admin feel it's too long, it can be adjust to as
low as 1 seconds, which runs still well in my machine.
Conflicts:
setup/db/db/schema-430to440.sql
2014-04-18 23:36:19 -07:00
Koushik Das
b088821c61
CLOUDSTACK-6445: Simulator enhancements
...
Refer FS - https://cwiki.apache.org/confluence/display/CLOUDSTACK/Simulator+enhancements
2014-04-18 16:44:21 +05:30
Wido den Hollander
c9b22af6c7
kvm: Add more log lines around storage pool operations
2014-04-17 17:42:17 +02:00
Anthony Xu
b1dfeb9cf4
destroy event when the task is done
2014-04-15 17:12:23 -07:00
Chris Suich
6d18654958
CLOUDSTACK-6422: Fixed errors with simulator VM snapshot delete and revert
2014-04-15 17:23:28 -04:00
Anshul Gangwar
55f53e13e8
CLOUDSTACK-6401: [hyper-v] fixed correct host state, if host is up and hyper-v agent is down then the host state will be shown as up(actual host state) in cloudstack
2014-04-15 14:37:05 +05:30
Anshul Gangwar
3ec7497e1e
CLOUDSTACK-6400: [hyper-v] [vmsync] fixed occasionally VM is not deleted from back-end when it is stopped from Hyper-V manager and then destroyed-expunged from CS and returning only power VMs for vmsync
2014-04-15 14:36:55 +05:30
Anshul Gangwar
0aa6cc60c7
CLOUDSTACK-6398:[hyper-v] changed auto shutdown and startup actions of VMs to shutdown and nothingauto shutdown and startup actions of VMs to shutdown and nothing so that they are consistent with cloudstack auto shudown and startup behavior
2014-04-15 14:36:37 +05:30
Ding Yuan
c031eb7d38
CLOUDSTACK-6242: exception handling improvements
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-04-15 08:07:15 +02:00
Koushik Das
5e90b75c98
CLOUDSTACK-6402: Fix StopCommand so that VMs are not removed accidentally as part of vmsync
...
Added a new flag 'checkBeforeCleanup' to StopCommand based on which check is done to see if VM is running in HV host.
If VM is running then in this case it is not stopped and the operation bails out.
Also modified the MS code to call the StopCommand with appropriate value for the flag based on the context.
Currently it is only set to 'true' when called from the new vmsync logic based on powerstate of VM. For rest it
is set to 'false' meaning no change in behaviour.
2014-04-14 16:52:37 +05:30
Koushik Das
5f53dced5e
CLOUDSTACK-6363: [Automation] jetty server is going OOM for simulator
2014-04-14 09:39:51 +05:30
Wido den Hollander
8d2baf8017
rbd: Use qemu-img to backup up a RBD snapshot to Secondary Storage
...
This reduces the amount of time and storage it takes dramatically. We no longer
do a full copy, but a sparse copy. The destination image is still in RAW
format, but we only copy over used blocks.
Qemu is also better in doing this then us doing it in Java code.
2014-04-11 14:00:08 +02:00
Marcus Sorensen
11f5bdd78d
CLOUDSTACK-6191 Add support for specifying volume provisioning
...
type (thin, sparse, fat) in disk/compute offerings.
Submitted-by: Yoshikazu Nojima <mail@ynojima.net>
Reviewed-by: Marcus Sorensen, Mike Tutowski
2014-04-10 09:23:04 -06:00
Wido den Hollander
4ba688f07d
kvm: Add more debugging information when a volume is deleted.
...
There was no clear reference of libvirt being instructed to remove
the volume
2014-04-10 14:33:49 +02:00
Kishan Kavala
85072cb6b9
CLOUDSTACK-6371: Set snapshot size in copycommand answer during snapshot backup
2014-04-10 14:45:14 +05:30
Wido den Hollander
0615d4e6a5
rbd: Check if a snapshot is protected before trying to unprotect
...
Otherwise a RBDException will be thrown with the message that the snapshot
isn't protected.
modified: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
2014-04-10 05:30:06 +02:00
Sanjay Tripathi
a195205d11
CLOUDSTACK-6366: add vgpuTypes details in vgpu_types table.
2014-04-09 18:23:50 +05:30
Harikrishna Patnala
ecc71518a9
CLOUDSTACK-6253: Optimizing VR alerts getting algorithm In addition to this a new configuration parameter is added router.alerts.check.interval defaulted to 30minutes to check for alerts in Virtual Router
2014-04-09 18:12:20 +05:30
Anshul Gangwar
ade4d44de4
CLOUDSTACK-6262: Fixed network throttling in hyper-v, Now network rate parameter is honored in hyper-v. Network rate parameter now set the max bandwidth of nic on hyper-v
2014-04-09 13:10:30 +05:30
Anthony Xu
8d1c90684f
make sure volumeUuid is not full path
2014-04-08 16:34:59 -07:00
Anthony Xu
8f9d87c6d9
Destroy unplugged VIFs before creating a VIF for a VM
2014-04-08 16:15:06 -07:00
Murali Reddy
855fac1811
CLOUDSTACK-6356: OVS: tunnel networks does not work across the XenServer
...
clusers
across the poll members an internal network created is visible to al the
members but bridge is not necessariliy created. This fix enables
plugging a temp VIF connected to internal network to dom0 and then
unplug-it. this action creates a bridge on the host of the network.
2014-04-08 19:07:38 +05:30
Anshul Gangwar
1dfe4c19b5
CLOUDSTACK-6289: fixed storage migration failing in case of hyper-v if there are multiple disks attached to VM
2014-04-08 14:39:13 +05:30
Anshul Gangwar
e644ac1653
CLOUDSTACK-6325: [hyper-v] fixed cleaning of bin and obj directories when building with mono, they were not cleaning up and resulting in use of stale dlls in some cases
2014-04-08 14:37:21 +05:30
Anshul Gangwar
f40e8a835c
CLOUDSTACK-6326: fixed password visible in plain text in some of commands in Hyper-v Agent logs
2014-04-08 14:37:13 +05:30
Sheng Yang
e8227c88d8
CLOUDSTACK-6314: Use SSH commands for Xen VR execution
...
Instead of XAPI, which would make XenServer unnecessary busy.
2014-04-07 13:38:14 -07:00
Wido den Hollander
6da087e601
rbd: Add some more debugging while deleting a physical disk
2014-04-07 06:20:57 +02:00
Anthony Xu
ecbaa11f09
clean up xenserver resource code
2014-04-04 16:02:49 -07:00
Anthony Xu
15c142326f
clean up xenserver resource code
2014-04-04 14:14:22 -07:00
Sanjay Tripathi
60c58c5cac
CLOUDSTACK-6339: Getting exception while adding XenServer625 host.
2014-04-04 12:30:33 +05:30
Sanjay Tripathi
3666df4d34
CLOUDSTACK-6268: Unable to get GPU stats, You tried to call a method that does not exist.
2014-04-04 10:21:03 +05:30
Koushik Das
af1eba2708
CLOUDSTACK-6286: [Automation] VM deployment is failing in simulator
...
Added AggregationContolCommand to simulator
2014-04-03 11:45:53 +05:30
Abhinandan Prateek
228aa07153
Revert "CLOUDSTACK-6286: added FinishAggregationCommand and StartAggregationCommand to simulator"
...
This reverts commit 1586f419dc . Reverting as the commit that includes the two classes is missing.
2014-04-03 10:21:16 +05:30
Alex Huang
e9c81c78b9
Applied Tina's patches for removing the xapi jar
2014-04-02 14:00:56 -07:00
Abhinandan Prateek
9ddfbe1128
CLOUDSTACK-6286: added FinishAggregationCommand and StartAggregationCommand to simulator
2014-04-02 20:38:19 +05:30
Anshul Gangwar
24820d20d3
CLOUDSTACK-6288: Changing default ImageFormat to vhdx for hyper-v and allowing registration of vhdx format templates.
...
Signed-off-by: Devdeep Singh <devdeep@gmail.com>
2014-04-01 14:00:24 +05:30
Mike Tutkowski
06c0486d0b
CLOUDSTACK-6170 (VMware root-disk support for managed storage)
2014-04-01 00:09:53 -06:00
Mike Tutkowski
21455222e4
CLOUDSTACK-6170 (VMware root-disk support for managed storage)
2014-03-31 21:20:43 -06:00
Sheng Yang
b2ffd86570
CLOUDSTACK-6309: Fix timeout in KVM when execute VR commands
...
Timeout is in seconds rather than milliseconds.
2014-03-31 11:30:06 -07:00
Mike Tutkowski
1577e75a3d
CLOUDSTACK-6170 (VMware root-disk support for managed storage)
2014-03-31 00:13:30 -06:00
Anthony Xu
58b2b6b9e1
Add support for XS6.2 Fox hotfix
2014-03-28 16:45:16 -07:00
Anthony Xu
d4d5cabb50
fix build
2014-03-28 16:34:50 -07:00
Edison Su
25a6234a5b
fix build
2014-03-28 16:24:45 -07:00
Edison Su
578d2f62f1
fix devcloud reboot issue: should not start heartbeat for devcloud
...
Conflicts:
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
2014-03-28 16:24:36 -07:00
edison
d1d855fef4
CLOUDSTACK-5857: for some reasons, delete secondary pool failed during copy template from secondary storage to primary storage, but the volume is already copied to primary storage, we didn't clean up the volume on primary storage, then all the following copy the same template to primary storage failed, as we are always using the same uuid when creating a new volume, libvirt complaining that the volume already exists.
...
Current fix is ignoring "the delete secondary storage error".
2014-03-28 16:23:34 -07:00
edison
f79ba98cce
CLOUDSTACK-5370: delete snapshot on primary storage in case of backup snapshot failed.
2014-03-28 16:22:41 -07:00
edison
a8bfb3dd00
CLOUDSTACK-5737: ignore umount secondary storage failure during backup snapshot
2014-03-28 16:22:24 -07:00
Edison Su
a1762a6e7e
CLOUDSTACK-5264: add delta snapshot for existing xenserver
...
Conflicts:
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerStorageProcessor.java
2014-03-28 16:22:05 -07:00
Edison Su
e656201fee
CLOUDSTACK-5395: mark snapshot_store_ref as destroyed in case of backup snapshot failed
...
Conflicts:
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerStorageProcessor.java
2014-03-28 16:21:22 -07:00
Edison Su
a72222dd46
fix devcloud: after devcloud vm itself reboot, local storage's name label is changed to orignal
...
Conflicts:
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpOssResource.java
2014-03-28 16:21:04 -07:00
Edison Su
b9855968a8
fix devcloud: user template's guest os type is changed
...
Conflicts:
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpOssResource.java
2014-03-28 16:20:15 -07:00
Edison Su
731ccb8219
fix devcloud router start
...
Conflicts:
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpOssResource.java
2014-03-28 16:16:51 -07:00
Edison Su
b1bba4b3fb
CLOUDSTACK-5737: isExternalSnapshot should return true for CLVM and RBD only
2014-03-28 16:14:59 -07:00
Mike Tutkowski
0879ab812e
CLOUDSTACK-6170 (VMware root-disk support for managed storage)
2014-03-28 13:15:04 -06:00
Anthony Xu
d68e13fcbd
Revert "change below file names for consistency"
...
This reverts commit f8996fe837 .
2014-03-28 12:05:25 -07:00
Anthony Xu
f8996fe837
change below file names for consistency
...
Xenserver625Resource.java -> XenServer625Resource.java
Xenserver625StorageProcessor.java -> XenServer625StorageProcessor.java
2014-03-28 11:48:50 -07:00
Daan Hoogland
8b62b2cb92
findbugs: exclude known spiffy hacks a.k.a. false positives
2014-03-28 14:28:10 +01:00
Marcus Sorensen
7390f99afb
CLOUDSTACK-6292: Fix live migration of KVM when vnc ip address
...
changes
Submitted-by: Yoshikazu Nojima
2014-03-27 16:45:42 -06:00
Anthony Xu
6356f5fdb0
add more log for creating XS pool network
2014-03-27 15:31:59 -07:00
Anthony Xu
73a2aa1aa4
Fixed a typo
2014-03-27 10:58:23 -07:00
Santhosh Edukulla
3060f884ab
Added fix for CLOUDSTACK-6269
...
Added fix for CLOUDSTACK-6269.More details inside the bug
Signed-off-by: Santhosh Edukulla <Santhosh.Edukulla@citrix.com>
2014-03-27 14:53:43 +05:30
Kishan Kavala
fe7b753b03
CLOUDSTACK-6122: Map rbd image on host before attaching to Vm
2014-03-27 14:53:36 +05:30
Anthony Xu
2dc1c7bec8
get rrd through http directly instead of xapi plugins
2014-03-26 18:04:41 -07:00
Anthony Xu
ff1c0647fc
in XS, joining a host to a XS pool may not work as expected, especially when there are multiple nics, binding devices.
...
admin needs to check if the right nics are binded togather, if network are propagated to the new host correctly before adding this host to CS.
2014-03-26 16:25:26 -07:00
Anthony Xu
c9edb7ecfe
set nosubdir for NFS SR
2014-03-26 14:56:58 -07:00
Anthony Xu
6de28bb1a4
in XenServer, host eject may fail due to diffent reasons, it's hard for CS to handle all failure.
...
in CS, removing a host means CS will not manage the host, admin needs to eject the host from XS pool outside of CS
2014-03-26 14:22:49 -07:00
Anthony Xu
a596edbdf6
make sure XS host is enabled when creating XAPI connection
2014-03-25 11:20:16 -07:00
Anthony Xu
88c1da679c
check_heartbeat and pingtest execute through ssh, not XAPI, because XAPI may hang when master host is downi
2014-03-25 10:44:20 -07:00
Anthony Xu
d14f66f58d
when start vm times out, check VM status, if it is running , return succeed.
...
change XAPI timeout to 60 second.
2014-03-24 17:15:08 -07:00
Anthony Xu
bf48309e14
addHostCmd will try to load all hosts in a pool
2014-03-24 16:06:26 -07:00
Wido den Hollander
9763faf85e
rbd: Use qemu-img to convert from QCOW2 templates to RBD directly.
...
This saves the step of writing to a temporary image in /tmp first before
writing to RBD.
This is possible due to a new version in librbd. With the rbd_default_format
setting we can now force qemu-img to create format 2 RBD images.
This is available since Ceph version 0.67.5 (Dumpling).
2014-03-24 16:35:13 +01:00
Rajani Karuturi
07365c3dab
simulator manager impl changes to handle SetMonitorServiceCommand This fixes some of the test cases in the integration test test_assign_vm.py when run against a simulator
...
Signed-off-by: Koushik Das <koushik@apache.org>
2014-03-20 14:44:23 +05:30
Sheng Yang
1d3a6eaa50
CLOUDSTACK-6047: Fix timeout issue when try to execute aggregated commands
...
Add executeInVR() with timeout interface to VirtualRouterDeployer
AggregationControlCommand with Action.Finish may take longer than normal command
since it would execute all the commands in one execution, and it may result in
SSH timeout for SshHelper or other mechanism communicate with VR.
Introduce an new executeInVR() interface with added timeout period for waiting
FinishAggregationCommand to complete execution.
2014-03-18 17:43:59 -07:00
Marcus Sorensen
d638d04cbf
CLOUDSTACK-6181: Merge of resize root feature (resize-root branch)
2014-03-14 07:17:33 -06:00
Hugo Trippaers
4402685e11
Update master to 4.5.0-SNAPSHOT
2014-03-14 14:55:26 +01:00
Rajesh Battala
6a4927f660
Fixed all findbugs in hyperv plugin code
2014-03-14 17:36:43 +05:30
Rajesh Battala
4523f5d8de
CLOUDSTACK-6106 Agent side changes for VPC on Hyper-V
2014-03-14 17:36:43 +05:30
Rajesh Battala
1b4325d2c8
CLOUDSTACK-6106 supporting VPC VR on Hyper-V
2014-03-14 17:36:43 +05:30
Murali Reddy
9a97ba76d3
findbug fixes, added some comments, bug fixes
2014-03-14 16:56:39 +05:30
Murali Reddy
e487b24bb6
couple of bug fixes
2014-03-14 16:56:38 +05:30
Murali Reddy
36541a2f4c
adding distributed routing support for KVM OVS
...
some check style error fixes
2014-03-14 16:56:38 +05:30
Murali Reddy
423a748807
adds hypervisor script to convert JSON routing polcies (ACL) config in
...
to flow rules and applies them on the bridge
add event subscriber in OvsTunnelManager, that listens to
replaceNetworkAcl events. On event sends the updated policy info to all
the hosts in the VPC
2014-03-14 16:56:37 +05:30
Murali Reddy
2c7786992f
some bug fixes
2014-03-14 16:56:37 +05:30
Murali Reddy
e045883c52
introduce OvsNetworkTopologyGuru that has convinenace functions to
...
- get the hosts on which VPC spans given vpc id
- get the VM's in the VPC
- get the hosts on which a network spans
- get the VPC's to which a hosts is part of
- get VM's of a VPC on a hosts
introduces capability to build a physical toplogy representation of a
VPC. This json file is encapsulated in
OvsVpcPhysicalTopologyConfigCommand, and is used to send full topology
to hypervisor hosts. On hypervisor this json config can be used to setup
tunnels, configure bridge, add flow rules etc
Ovs GURU, to use different broasdcast scheme VS://vpcid.gerkey for the
networks in VPC that use distributed routing
each VIF and tunnel interface to carry the network UUID in other/options
config
2014-03-14 16:56:37 +05:30
Devdeep Singh
2aff39f8c7
CLOUDSTACK-6143: Storage motion support for hyper-v. With these changes a volume on a shared
...
storage pool (SMB) and attached to a running vm can be live migrated to another shared storage
pool. Also a vm and its volumes can be live migrated to another host and storage pool respectively.
2014-03-14 16:27:58 +05:30
Kelven Yang
5a75a3e1f9
Give graceful state transition period to live with race-condition on VM startup time
2014-03-13 16:59:56 -07:00
Alena Prokharchyk
6c23e201ad
1) More fixes for the problems found by findBugs
...
2) Corrected some logging in MidoNetPublicNetworkGuru - removed .toString method call on the objects in the log body as toString is called on the object by default when use log4j
2014-03-13 16:05:45 -07:00
Kishan Kavala
6d4b979c4d
CLOUDSTACK-6122: LXC systemVms run on KVM. If they are not included in the VmState report, MS assumes that system Vms are not running. MS will stop these Vms and spin new ones. So on LXC hosts, KVM Vms also have to be included in the Vmlist
2014-03-11 23:49:28 +05:30
Marcus Sorensen
c874e20c24
CLOUDSTACK-6225: Check libvirt version and volume format before
...
adding flag VIR_STORAGE_VOL_RESIZE_ALLOCATE to resize volume
libvirt call
2014-03-11 11:13:12 -06:00
Sanjay Tripathi
c7d31fe288
CLOUDSTACK-4760 : Enabling GPU support for XenServer.
...
CLOUDSTACK-4762 : Enabling VGPU support for XenServer.
This feature is to enable the GPU-passthrough and vGPU functionality,
with the help of this feature, admins/users will be able to leverage
the GPU graphics unit power by deploying a virtul machine with GPU or
vGPU support or by changing the service offering of an existing VM
at any later point of time. There GPU/vGPU enabled VMs are able to run
graphical applications.
For now, this feature is only supported with XenServer hypervisor but
can be extended to add the support of other hypervisors.
2014-03-11 15:44:51 +05:30
Rajesh Battala
540d020aa5
CLOUDSTACK-6179 Execute VR commands on Virtual Resource when commands received to Hyper-V
2014-03-11 13:10:13 +05:30
Alena Prokharchyk
466825a167
Fixed nonoss build
2014-03-10 15:29:18 -07:00
Mike Tutkowski
cb26b4c337
CLOUDSTACK-6170
2014-03-07 23:52:01 -07:00
Anthony Xu
38c0dd87a9
vbdmectics may not exist after host reboot
2014-03-05 16:04:34 -08:00
Anthony Xu
ab1d3af460
Use seperate path to sync VM metadata for XS
...
VM status sync only does VM status sync
2014-03-05 15:44:50 -08:00
Mike Tutkowski
b06e66c50a
CLOUDSTACK-6170
2014-03-05 13:55:12 -07:00
Marcus Sorensen
e5449e29c9
CLOUDSTACK-6203: KVM Migration fixes. Moved migration to a thread
...
so we can monitor it and potentially take action to make migration
complete if admin has defined such.
2014-03-05 12:24:04 -07:00
Marcus Sorensen
fb0b2eb267
CLOUDSTACK-6192: Return failure on StartCommand and PrepareForMigrationCommand
...
when connectPhysicalDisk fails, rather than continuing on
2014-03-04 14:18:51 -07:00
Wido den Hollander
1f9649bc3b
kvm: Fix a NullPointerException which occurs when storage pool creation fails
...
Also make the logging around creating a RBD storage pool a bit better when creating
that fails.
2014-03-04 16:03:11 +01:00
Rajani Karuturi
9be51e1961
added mock handlers for VpnUsersCfgCommand and RemoteAccessVpnCfgCommand in the simulator
...
Signed-off-by: Koushik Das <koushik@apache.org>
2014-03-04 14:31:03 +05:30
Rajani Karuturi
8e2c4c8105
added delete iso api to the simulator in the smoke tests, this will fix test_03_delete_iso when run against a simulator
...
Signed-off-by: Koushik Das <koushik@apache.org>
2014-03-04 14:12:30 +05:30
wrodrigues
9045e41483
fix for Find Bugs findings on troubling issues: returning null when expected is boolean; adding 6 unit tests and fix 1 in the KVMFencer; comparing objects with == instead of equals()
...
Signed-off-by: Daan Hoogland <dhoogland@schubergphilis.com>
2014-03-03 07:57:13 +01:00
Kelven Yang
b21662f890
make sure XS report VM state even if there is no running VM on the host.
2014-02-28 15:35:59 -08:00
Kelven Yang
57a00a8172
Let ESX host timeout to reflect disconnect status in vCenter into CloudStack.
2014-02-28 15:35:59 -08:00
Kelven Yang
24e64ac62a
let PingTestCommand support host-ping in addition to ping user VM via VR. Reviewed-By: self
2014-02-28 15:35:59 -08:00
Kelven Yang
414b1cbb22
let KVM only report running VM to workaround the problem when KVM still keeps stopped-VM around in some cases
2014-02-28 15:35:59 -08:00
Kelven Yang
bfb7835a21
Temporarily disable event-based VM state management at XS resource level. Wait to enable it when other changes in XS is ready
2014-02-28 15:35:58 -08:00
Kelven Yang
18b5fb5a3c
do not shutdown alien VMs upon host startup. Send StopCommand for out-of-band stopped VM to restore legacy XS/KVM behave
2014-02-28 15:35:58 -08:00
Kelven Yang
90ea3249a8
disable cluster-scope report from XS resource
2014-02-28 15:35:57 -08:00
Jayapal
cb1c287433
CLOUDSTACK-6183: Unplug the nic when all the ips from the public subnet is released
2014-02-28 16:46:57 +05:30
Min Chen
a6f17675d4
CLOUDSTACK-6175:s3.singleupload.max.size option not applicable for
...
backup snapshot on KVM.
2014-02-26 15:13:49 -08:00
Likitha Shetty
88b5761647
CLOUDSTACK-6146. [VMware] [ESXi 5.5] Live VM migration of an already migrated VM (with storage) across clusters fails
...
In vCenter 5.5, once a volume is migrated the VMDKs are renamed to match the name of the VM.
Update volume path for every volume belonging to the VM to the corresponding new disk filename.
Conflicts:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
plugins/hypervisors/vmware/src/org/apache/cloudstack/storage/motion/VmwareStorageMotionStrategy.java
2014-02-26 13:45:44 +05:30
Likitha Shetty
0926bf57f4
CLOUDSTACK-6146. [VMware] [ESXi 5.5] Live storage migration of an already migrated volume fails
...
In vCenter 5.5, once a volume is migrated the VMDKs are renamed to match the name of the VM.
If a volume has been renamed upon migration update its volumePath to that of the new disk filename.
Conflicts:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
2014-02-26 13:45:43 +05:30
Min Chen
b484b48201
Provide separate option for Windows Server 2012 R2 as
...
an OS type when registering template.
2014-02-25 16:09:29 -08:00
Mandar Barve
b0c6d47347
- Updated APICommand annotation to add new flags that indicate if API request or response carry sensitive info - Updated all API classes with the new annotation flag values as per the API's sensitivity - Updated server code to check response annotation before audit logging
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
(cherry picked from commit df270d6387c362b960064ee5123c14782e767a19)
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-02-25 22:59:10 +01:00
Wido den Hollander
abf3c055c2
templates: Add FreeBSD 10 template
...
With VirtIO enabled on KVM. FreeBSD 10 supports VirtIO for both the
network and the disks. This frees us from IDE and E1000 which should
also improve performance.
2014-02-25 14:56:24 +01:00
Niels de Vos
14689d7810
Gluster should store volumes in qcow2 format
...
By default all network disks are in RAW format. Gluster works fine with
QCOW2 which has some advantages.
Disks are by default in QCOW2 format. It is possible to run into
a mismatch, where the disk is in QCOW2 format, but QEMU gets started
with format=raw. This causes the virtual machines to lockup on boot.
Failures to start a virtual machine can be verified by checking the log
of the virtual machine, and compare the output of 'qemu-img info'.
In /var/log/libvirt/qemu/<VM>.log find the URL for the drive:
-drive file=gluster+tcp://...,format=raw,..
Compare this with the 'qemu-img info' output of the same file, mounted
under /mnt/<pool-uuid>/<img-uuid>:
# qemu-img info /mnt/<pool-uuid>/<img-uuid>
...
file format: qcow2
...
This change makes passes the format when creating a disk located on RBD
(RAW only) and Gluster (QCOW2).
Signed-off-by: Niels de Vos <ndevos@redhat.com>
2014-02-25 12:08:46 +01:00
Hugo Trippaers
52c4f00b26
Findbugs: Fix potential NPE
2014-02-24 14:07:33 +01:00
Hugo Trippaers
6b61fd7d09
Fix CID 1186644: ES: Checking String equality using == or !=
2014-02-24 14:06:40 +01:00
Rajesh Battala
f960ada36e
CLOUDSTACK-6159 Fixed creating volumes(Root, DataDisk) with uuid in primary store
2014-02-23 09:21:30 +05:30
Marcus Sorensen
4fcd0b1a1f
if libvirt fails to attach disks, call disconnectPhysicalDisk to clean up
2014-02-20 15:43:27 -07:00
Niels de Vos
fe83a85436
Add support for Primary Storage on Gluster using the libvirt backend
...
The support for Gluster as Primary Storage is mostly based on the
implementation for NFS. Like NFS, libvirt can address a Gluster environment
through the 'netfs' pool-type.
2014-02-20 14:52:01 +01:00
Sheng Yang
5332f67ae8
CLOUDSTACK-6047: Make sure every commands to VR resource is NetworkElementCommand
2014-02-19 19:46:49 -08:00
Nitin Mehta
c969aa2595
CLOUDSTACK-6134:
...
If volume already exists for the vm - register the vm in the inventory and start it.
2014-02-18 18:24:33 -08:00
Hugo Trippaers
24309f6001
Prevent a ClassCastException when the answer is not a SetupAnswer (which happends when something goes wrong while connecting)
2014-02-18 12:37:36 +01:00
Sheng Yang
6bde675f87
Remove SetupGuestNetworkAnswer
...
It's unnecessary and not different from Answer itself.
2014-02-14 18:10:05 -08:00
Sheng Yang
161e7d93ca
CLOUDSTACK-5779: Fix missing clean up period for VR
2014-02-14 18:10:00 -08:00
Hugo Trippaers
97bad4f9b3
Fix checkstyle and license issues
2014-02-14 18:37:47 +01:00
Hugo Trippaers
d4d49578dc
Findbugs : Fix a number of potential NPEs and minor findings
2014-02-14 18:37:45 +01:00
Sander Botman
16aa73c2c8
Fixing some of the scary bugs possible null pointer: created testSetNicDevIdIfCorrectVifIsNotNull
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:44 +01:00
Likitha Shetty
db91e54bf3
CLOUDSTACK-6112. Adding VPC router to a guest network fails with StringIndexOutOfBoundsException.
2014-02-14 17:01:27 +05:30
Marcus Sorensen
df77c4310a
CLOUDSTACK-6103: Pass VM iso information along with
...
PrepareForMigrationCommand, so that destination hypervisor can
mount pool. This further exposed an issue for KVM where iso
was not getting cleaned up upon successful migration, fixed as well.
2014-02-14 00:34:48 -07:00
Marcus Sorensen
7064972997
Fix someone's broken push due to bad checkstyle (VMwareGuru.java unused imports)
2014-02-12 16:26:33 -07:00
Likitha Shetty
9f597ef130
CLOUDSTACK-6056. Enabling static NAT rule for a portable public IP fails with error "Failed to enable static nat".
...
router.extra.public.nics isn't being honoured and so when an ip that is acquired from the additional VLAN range
is being configured it failed.
2014-02-12 15:53:45 +05:30
Anshul Gangwar
b86d45b003
CLOUDSTACK-6054: Changes for making vmsync work for hyper-v. Made changes to PingCommand and
...
StartupCommand to return the state of all vms on the host.
2014-02-11 12:19:41 +05:30
Laszlo Hornyak
bdf50f6d24
Remove assertion
...
The assertion is built on the assumption that cpuinfo_max_freq is readable by user, which may not be universaly true.
2014-02-10 19:56:54 +01:00
Laszlo Hornyak
ab15653d68
Revert "Temporarily ignore getCpuSpeed test"
...
This reverts commit e4a91d3610 .
2014-02-10 19:40:37 +01:00
Laszlo Hornyak
e4a91d3610
Temporarily ignore getCpuSpeed test
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-02-09 23:13:55 +01:00
Laszlo Hornyak
55b6b6d50b
Boolean expression simplification
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-02-09 19:19:20 +01:00
Laszlo Hornyak
d6a6e8dfa5
Minor Boolean expression simplification
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-02-09 19:05:28 +01:00
Laszlo Hornyak
74a3cb4d5e
String concatenation cleanup
...
Replaced string concatenation in loop with StringBuilder
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-02-09 19:01:45 +01:00
Laszlo Hornyak
8e3ae40ba2
removed self-assignment
...
It must have been a copy-paste from the other constructor.
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-02-09 18:46:36 +01:00
Laszlo Hornyak
d22b65f45f
replaced Integer reference comparsion with .equals
...
By default only the Integers between -128..127 are cached (unless overridden by java.lang.Integer.IntegerCache.high system property)
If the inbound or outbound values are higher, the reference comparison won't work.
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-02-09 18:39:03 +01:00
Laszlo Hornyak
3e3ded75f4
safely close resource with java 1.7 resource block
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-02-09 18:27:54 +01:00
Laszlo Hornyak
5e4fec9eca
removed unused variables
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-02-09 16:55:27 +01:00
Laszlo Hornyak
e52a276104
cleanup in LibvirtComputingResource
...
- minor resource leak cleaned up
- cpu-speed reading method extracted
- test added
- logging added in case of exception
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-02-09 16:50:10 +01:00
Wido den Hollander
1baebebda6
test: Expand LibvirtDomainXMLParserTest with Interface test
2014-02-06 14:40:40 +01:00
Wido den Hollander
41c7e22eee
test: Add test for LibvirtDomainXMLParser
...
A couple of changes where made to other classes as well to add
some features to allow more extensive testing.
2014-02-06 14:23:25 +01:00
Rajesh Battala
7f780f26f9
Fixed agent code to handle untagged public vlan while parsing the vlan id
2014-02-05 23:44:14 +05:30
Devdeep Singh
a24263fe81
CLOUDSTACK-6030: Encrypt the primary and secondary smb storage password when it is stored in the db.
2014-02-05 15:44:09 +05:30
Alex Huang
7f34282dfa
Removed references to secondarystoragevmmanager from code that doesn't use it.
2014-02-05 01:39:15 +00:00
Min Chen
929099518d
Fix trailing whitespace.
2014-02-04 15:42:39 -08:00
Min Chen
39efee285f
CLOUDSTACK-6027:CreateVolume from snapshot is failing with S3 on Vmware.
2014-02-04 15:08:28 -08:00
Min Chen
9b21da65d1
CLOUDSTACK-6025:CreateTemplate from snapshot in NFS is failing , after
...
migarting to S3 datastore.
2014-02-04 11:01:51 -08:00
Daan Hoogland
0839fbce67
CLOUDSTACK-6023 vcpus should not be higher then xen specifies
2014-02-04 18:41:53 +01:00
Wido den Hollander
3989d6c481
kvm: Resize volumes using libvirt
...
This saves us a lot of code and libvirt is probably a better
place to do this.
libvirt-java now has the support we want, so we can now resize volumes
with libvirt.
(C)LVM volumes can't be resized using libvirt, so we have to
invoke a resize script for that.
2014-02-04 14:26:51 +01:00
Min Chen
30695d7f93
CLOUDSTACK-6019:CreateVolume from snapshot in NFS is throwing Warning
...
"sync snapshot from cache to region wide store failed for image store
test".
2014-02-03 16:41:04 -08:00
Wido den Hollander
5ae12f31b7
rbd: Set client timeout to 30 seconds.
...
By default the client_mount_timeout setting in librados is 300 seconds,
but that causes the connect to the Ceph cluster to block for 5 minutes
if the Ceph cluster is not available.
This patch is not ideal, but it mitigates the problem for now.
At a later point all this librados/librbd code should go back to libvirt
again, but the current versions of libvirt in the distributions are
to old for all the features we require.
For now this should prevent the CloudStack agent blocking for 5 minutes
when the Ceph cluster isn't available.
This is also tracked at the Ceph tracker: http://tracker.ceph.com/issues/6507
2014-02-03 16:07:00 +01:00
Likitha Shetty
06f79a881c
CLOUDSTACK-5994. Hitting IndexOutOfBoundsException in GetVmStatsCommand after upgrade.
...
To obtain network read/write statistics, multiply sample duration with the
average of the particular performance metric obtained over the sample period.
2014-01-30 18:31:38 +05:30
Marcus Sorensen
05189361b7
CLOUDSTACK-5968 last patch fixes setting low currentMemory during
...
overprovision, this one explicitly tells libvirt we dont want a
balloon device (won't use it anyway, and will just suck up a percent
of vm memory)
2014-01-28 11:51:23 -07:00
Marcus Sorensen
1530c162e5
CLOUDSTACK-5968 create vm.memballoon.disable agent parameter
2014-01-28 10:44:44 -07:00
Hugo Trippaers
3bd38eb17e
Findbugs finding : Incorrect use of equality
2014-01-28 08:58:28 +00:00
Likitha Shetty
4583bac05b
CLOUDSTACK-5796. [VMware] Size column is not getting updated in snapshot_store_ref table when a snapshot is backed up in secondary storage.
...
Calculate and update the size of a backed up snapshot. This snapshot size is in turn used to update the secondary_storage count for an account.
2014-01-28 09:21:05 +05:30
Rajesh Battala
39447cce6e
CLOUDSTACK-5941 User Vm deployment on HyperV is failing due to change in the userdata script location and moved to json model
2014-01-28 07:03:08 +05:30
Rajesh Battala
807dc09138
CLOUDSTACK-5561 Support of multiple public vlans on VR running in HyperV
2014-01-28 07:03:08 +05:30
Marcus Sorensen
daeea46da0
CLOUDSTACK-5956 remove persist flag during live migration
2014-01-27 11:04:05 -07:00
Laszlo Hornyak
884e8c6510
replaced Long instantiation with parseLong
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-01-25 16:11:51 +01:00
Sheng Yang
3c955c3659
CLOUDSTACK-5779: Make VmwareResource use VirtualRoutingResource
2014-01-24 19:57:52 -08:00
Sheng Yang
069bc3686e
CLOUDSTACK-5779: Make CitrixResource to use VirtualRoutingResource
2014-01-24 18:28:31 -08:00
Sheng Yang
285f23f11b
CLOUDSTACK-5779: Generalize calling to execute or create file for KVM
2014-01-24 18:28:25 -08:00
Sheng Yang
2d3022594c
CLOUDSTACK-5779: Generalize calling to execute or create file for Vmware
2014-01-24 18:28:00 -08:00
Sheng Yang
2d100f1269
CLOUDSTACK-5779: Generalize calling to execute or create file for Xen
2014-01-24 18:27:55 -08:00
Devdeep Singh
aab881be21
CLOUDSTACK-5942: The agent at places logs the password of the user. It should mask the
...
password from the message string before writing to the log. Made a change to do so.
2014-01-24 15:04:00 +05:30
Wido den Hollander
dad98ef4de
test: Add UnitTest for LibvirtSecretDef
2014-01-23 21:09:25 +01:00
Hugo Trippaers
50b6de4714
Findbugs finding : Fix potential NPE
2014-01-23 16:14:56 +00:00
Hugo Trippaers
5e0d61bf98
Findbugs finding: Fix object comparison with == instead of equals
2014-01-23 15:53:26 +00:00
Hugo Trippaers
ecdee7da9a
Findbugs finding: Fix incorrect comparison, <VbdType>.equalsi(<String>) will always be false and should be <VbdType>.equals(<VbdType>)
2014-01-23 15:43:50 +00:00
Jayapal
4b3784a98e
CLOUDSTACK-5938 Failing add host in security group enabled zone, when CSP is not installed
2014-01-23 18:14:12 +05:30
Santhosh Edukulla
f999a01837
Added Fix for CLOUDSTACK-5875
...
Added fix for exception and listing. Mentioned details under bug.
Post the fix, simulator works fine.
Signed-off-by: Santhosh Edukulla <Santhosh.Edukulla@citrix.com>
Signed-off-by: Koushik Das <koushik@apache.org>
2014-01-23 17:11:33 +05:30
Devdeep Singh
538092b73e
Hyper-V agent should log to the event viewer. Changed the default
...
log appender for the agent.
2014-01-23 13:45:55 +05:30
Hugo Trippaers
c2da280347
Add a zipped version of the hyperv image that we can store in the archives on the jenkins server
2014-01-23 09:06:33 +01:00
Anshul Gangwar
b2de225f54
CLOUDSTACK-5703: putting rdp server port value in host details
2014-01-23 10:54:08 +05:30
Anshul Gangwar
5941ac46d2
CLOUDSTACK-5344 commit for console proxy rdp for hyperv
2014-01-23 10:54:08 +05:30
Wido den Hollander
5747b80124
test: Add UnitTest for Libvirt Storage Pool definitions
2014-01-22 21:52:39 +01:00
Hugo Trippaers
532bf4b190
Get rid of compiler warnings and dead code in plugin-hypervisor-vmware
2014-01-22 09:55:38 +01:00
Anthony Xu
cae19d0b5a
fix build
2014-01-21 19:34:54 -08:00
Sheng Yang
1767ddac77
CLOUDSTACK-5779: Update vmdata command in Vmware
...
To use Gson rather than copy a file to it, follow the same as Xen and KVM.
2014-01-21 18:59:30 -08:00
Anthony Xu
b79f949e1b
CLOUDSTACK-5923: CS doesn't do master switch for XS any more, CS will depend on XS HA to do master switch, XS HA needs to be enabled.
...
Conflicts:
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerConnectionPool.java
2014-01-21 18:54:53 -08:00
Wido den Hollander
f7ee27cd1c
test: Add Unit Test for LibvirtVMDef DiskDef
2014-01-22 00:04:29 +01:00
Sheng Yang
d4e069ecc8
Fix noredist build issue
...
Introduced by:
commit ac65f8fddf
Author: Hugo Trippaers <htrippaers@schubergphilis.com>
Date: Mon Jan 20 18:03:02 2014 +0100
CLOUDSTACK-5884 make getTargetSwitch(NicTO nicTo) do all the work to select
switch name, type and vlan token. Change preference to use the tags set on the
physical network.
2014-01-21 11:31:40 -08:00
Sheng Yang
e88cc488e5
CLOUDSTACK-5779: Move loadbalancer to use routerProxy
2014-01-20 18:48:46 -08:00
Hugo Trippaers
ac65f8fddf
CLOUDSTACK-5884 make getTargetSwitch(NicTO nicTo) do all the work to select switch name, type and vlan token. Change preference to use the tags set on the physical network.
...
Conflicts:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
2014-01-20 18:09:01 +01:00
Mike Tutkowski
37332ad9d4
CLOUDSTACK-5873: [Automation] Failed to attach volume to VM, if the vm is created with option startvm=false
2014-01-18 18:07:10 -07:00
Sheng Yang
0ea1c7dfc4
CLOUDSTACK-5779: Move firewall to use routerProxy
2014-01-17 12:36:42 -08:00
Sheng Yang
ce67e24d0a
CLOUDSTACK-5779: Move ipAlias to use routerProxy
2014-01-17 12:36:42 -08:00
Devdeep Singh
e9e5b84747
CLOUDSTACK-5894: A template created from a volume on hyper-v became unusable after
...
the management server was restarted. The template.properties file created for the
template has the format field in upper-case. This caused the template service to
not to recognise the format and it removed the entry from the template_store_ref
table in db. Fixed the format field in the templatee.properties.
2014-01-17 19:17:17 +05:30
Saksham Srivastava
06f8c1de75
CLOUDSTACK-5692: obscure passwords when using cifs as storage
2014-01-17 14:00:24 +05:30
Likitha Shetty
008b029a29
CLOUDSTACK-5891.[VMware] If a template has been registered and "cpu.corespersocket=X" template details have been added for it,
...
then any instance deployed from that template should have X cores per socket
2014-01-17 11:00:48 +05:30
Sheng Yang
0cdf0f6f67
CLOUDSTACK-5779: Moving bumpUpPriority, edithosts.sh, dnsmasq.sh to use routeProxy
2014-01-16 16:03:09 -08:00
Sheng Yang
b703b43d7c
CLOUDSTACK-5779: Refactor mechanism for calling routerProxy in CitrixResource
2014-01-16 16:02:53 -08:00
Mike Tutkowski
e9c9887ee0
CLOUDSTACK-5873: [Automation] Failed to attach volume to VM, if the vm is created with option startvm=false
2014-01-16 12:20:54 -07:00
Mike Tutkowski
3ef560d925
CLOUDSTACK-5873: [Automation] Failed to attach volume to VM, if the vm is created with option startvm=false
2014-01-16 12:15:18 -07:00
Anshul Gangwar
823abe6a23
CLOUDSTACK-5880: Communication between management server and hyper-v agent should be secure.
2014-01-16 14:48:28 +05:30
Jayapal
a41c9b9631
CLOUDSTACK-5867 Fixed service monitor command path
2014-01-16 11:29:03 +05:30
Alex Huang
68b8891c62
Removed all reminants of the IdentityService. Created the KeysManager to move the management
...
of keys out of management server
2014-01-14 13:11:35 -08:00
Devdeep Singh
f58d77c8d1
CLOUDSTACK-5689: System vm creation on local storage fails for hyper-v. A
...
null pointer exception was getting generated when a VolumeTO object was
serialized to create an answer object. If a local storage is used the uri
field will be null. Added null checks for the same.
2014-01-14 19:55:00 +05:30
Likitha Shetty
a957d52a3c
CLOUDSTACK-5707. Hitting multiple 'User unauthenticated' exceptions when vCenter is upgraded to 5.5 from 5.1.
...
We hit these excptions whenever a management server held session that was with the old 5.1 vCenter server
is used to make resource calls to the new 5.5 vCenter.
Validate a vCenter session context before it is being used to make a resource call.
And if the context is invalid then discard the context and retrieve a new one.
During the invalidation of an old context handle the context disconnect better
by catching the appropriate exception and returning a newly created context.
Conflicts:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareContextFactory.java
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareSecondaryStorageResourceHandler.java
vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java
2014-01-14 09:38:50 +05:30
Devdeep Singh
641f85cf6f
CLOUDSTACK-5657: Run the service as an account (hyper-v admin on host) so
...
that migration can work across hosts.
2014-01-10 17:08:01 +05:30
Devdeep Singh
db2b025608
CLOUDSTACK-5639: If path field in the TO already has the complete path, do
...
not try to generate the path.
2014-01-10 16:37:43 +05:30
Mike Tutkowski
a354d969ce
Merge from 4.3: CLOUDSTACK-5823: Taking a VMware snapshot doesn't work
2014-01-09 23:10:40 -07:00
Mike Tutkowski
929838c8eb
Merge from 4.3: CLOUDSTACK-5662: XenServer can't discover iSCSI targets with different credentials
2014-01-09 22:42:14 -07:00
Mike Tutkowski
6944bf9bba
Merge from 4.3: CLOUDSTACK-5662: XenServer can't discover iSCSI targets with different credentials
2014-01-09 22:02:43 -07:00
Mike Tutkowski
ae35782ccd
Merge from 4.3: CLOUDSTACK-5662: XenServer can't discover iSCSI targets with different credentials
2014-01-09 21:36:34 -07:00
Min Chen
64b8d1044d
CLOUDSTACK-5819:extractTemplate fails with Vmware host on migration of
...
NFS to S3.
2014-01-09 15:08:23 -08:00
Mike Tutkowski
8b6e89c012
Merge from 4.3: CLOUDSTACK-4810: Enable hypervisor snapshots for CloudStack-managed storage (for XenServer and VMware)
2014-01-09 15:44:02 -07:00
Devdeep Singh
7dc4c5cb5d
CLOUDSTACK-5795: Template.properties file wasn't created when a template
...
was created from a volume. Added a post creation change to create the file
with the necessary information.
2014-01-09 10:52:34 +05:30
Marcus Sorensen
0911b73c83
CLOUDSTACK-5430: NPE can be thrown in disconnectPhysicalDiskViaVmSpec in
...
certain failure scenarios. This can only be triggered if other bugs allow
pools to be deleted while VMs are using them.
2014-01-08 09:42:19 -07:00
Hugo Trippaers
8ddcc9ba80
Set unique gre key for every network.
...
Set interface id to nic uuid when creating the vif.
2014-01-08 16:00:59 +01:00
Devdeep Singh
3116f51a26
CLOUDSTACK-5788, CLOUDSTACK-5789: Attaching upload volume and download
...
volume was failing for hyper-v. Copy command answer was failing while
creating the answer object. Fixing the issue.
2014-01-06 16:36:03 +05:30
Likitha Shetty
bc677e2a99
CLOUDSTACK-5782. [VMware] Snapshot creation on a detached volume failes with NPE.
...
For a detached volume, don't try to find the associated VM on the hypervisor/peer hypervisor host.
By default create a worker VM to perform snapshot operations.
Conflicts:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
2014-01-06 14:34:15 +05:30
Sanjay Tripathi
3ad0e8fb47
CLOUDSTACK-5701: physical size is not getting updated in snapshot_store_ref table.
2014-01-06 11:36:43 +05:30
Rajesh Battala
cd43921fda
CLOUDSTACK-5658 CLOUDSTACK-5563 deploying VM from template created from volumes fails
2014-01-03 17:25:54 +05:30
Devdeep Singh
e59420c514
CLOUDSTACK-5691: Fix for attaching an uploaded volume to instance running
...
on hyperv. There were multiple issues here. Upload volume was actually
failing because the post download check for vhd on the cifs share was
unsuccessful. Also the agent code wasn't parsing the volume path correctly.
Fixed it too.
2014-01-03 16:55:28 +05:30
Hugo Trippaers
725bed43b4
Wei Zhou found another statement that was effected by commit 3a999e7 in
...
OvsVifDriver.isBridgeExists.
2014-01-02 15:12:11 +01:00
Hugo Trippaers
c024a93826
Commit 3a999e7 changed the return values for the Script.execute function, this introduced a bug in the openvswitch bridge detection code.
2014-01-02 13:40:06 +01:00
Likitha Shetty
50c2119a84
CLOUDSTACK-5704. OVA files exist for templates created from volumes.
...
Don't package the OVF and VMDK files into OVA after a template is created from volume.
Since packaging process contains reading and writing from the NFS mount, it doubles the amount of data that needs to be moved around
Conflicts:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
2014-01-02 16:39:07 +05:30
Devdeep Singh
faa503d6fc
CLOUDSTACK-5605: Fixing GetStorage stats command for hyper-v. The agent
...
wasn't looking up the share path correctly for reading the stats of a smb
share.
2014-01-01 14:33:33 +05:30
Marcus Sorensen
c99f0f925b
CLOUDSTACK-5697 - public ip ranges should allow VNI rather than only working with untagged
2013-12-31 16:09:52 -07:00
Sateesh Chodapuneedi
d50517e931
Fixing check style errors in HypervDirectConnectResource.java.
2013-12-31 07:16:35 +05:30
Sateesh Chodapuneedi
68e0bf39d0
Fix check style error.
2013-12-31 07:04:17 +05:30
Rajesh Battala
fe11fa89ee
CLOUDSTACK-5687 [Hyper-V] Remote Access VPN fails with Unsupported command while trying to configure VPN users
2013-12-31 12:36:16 +05:30
Sateesh Chodapuneedi
6ba9754201
CLOUDSTACK-5447 [Automation] Volume migration failing with NullPointerException in vmware and KVM.
...
Instead of injecting object of VolumeOrchestrationService into VmwareResource, we now populate the command object (MigrateVolumeCommand here) with required information. Thus we dont need volume orchestration service to query that information from resource.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
2013-12-31 06:31:43 +05:30
Devdeep Singh
785931b6f0
CLOUDSTACK-5560: Reattach of data disk fails for hyperv. When a data disk
...
is attached a hard disk drive is created on the scsi controller. On detach
the data disk is removed from the drive but the disk drive is left behind.
On reattach the agent was again trying to create a disk drive while it was
already present. Fixed the agent code to look up for disk drive while
attaching and if one is not found then only to create the drive for
attaching a data disk.
2013-12-30 16:53:43 +05:30
Devdeep Singh
069f8aeed5
CLOUDSTACK-5659: Creation of vm from iso failing with wrong file format.
...
The agent was always creating a disk with image format vhdx, but the
cloudstack management server defaults to image format vhd for hyperv.
Updated the agent code to be consistent with what cs expects. All disks
are now created with image format vhd.
2013-12-30 12:00:26 +05:30
Sateesh Chodapuneedi
9ca34f14a2
CLOUDSTACK-5666 Cant remove a nic when a vm is in the Stopped state
...
When VM is not running, existing code is unable to retrieve associated cluster's Id. Now we will try to get this information using previous host where the VM was running.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
Conflicts:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java
2013-12-28 09:13:58 +05:30
Sateesh Chodapuneedi
db99146187
CLOUDSTACK-5661 [VMware] DetachIsoCmd succeeds even though cdrom is locked by VM as cdrom is mounted
...
DetachISO is succeeding even though detach opeartion is failing as cdrom is locked by VM as it was mounted inside VM.
Detect if cdrom is locked or not. If locked fail detach operation and warn user to unmount before detaching the iso/cdrom device.
Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
Conflicts:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
2013-12-28 02:36:53 +05:30
Devdeep Singh
865330d440
CLOUDSTACK-5610: Host doesn't go to Down/Alert state even though it is powered off. VM
...
deployment fails because of that as cloudstack tries to deploy it on a host which is
ctually down. An investigator wasn't present for hyper-v; so cloudstack wasn't able to
determine the status of the host. Wrote an investigator for hyper-v which checks with
other hosts in the cluster for the status of the host being investigated.
2013-12-27 16:35:23 +05:30
Devdeep Singh
cdf2a1161b
CLOUDSTACK-5649: Vms are stopped and not migrated from a host when the
...
host is put in maintenance mode. The migrate flag wasn't set to true in
the maintain answer. This caused cloudstack to not to schedule a migration
work item for vms on the host. Made a change to set the migrate flag to
true in migrate answer.
2013-12-27 15:21:14 +05:30
Rajesh Battala
ea09c0435f
CLOUDSTACK-5193 [Hyper-V] VHDs not deleted post VM destroy and expunge
2013-12-27 14:59:57 +05:30
Rajesh Battala
31969e993e
CLOUDSTACK-5595 add vlan to storage nic to vnic for ssvm
2013-12-27 14:59:31 +05:30
Rajesh Battala
3f59780e91
CLOUDSTACK-5584 fix the issue to configure the systemvm's in hyperv consistently
2013-12-27 14:58:56 +05:30
Rajesh Battala
67d1a88880
CLOUDSTACK-5603 support Monitoring VR services when VR running on Hyper-V
2013-12-27 14:55:16 +05:30
Rajesh Battala
84bf5b3e55
added support to run hyperv agent on 0.0.0.0 and startuprouting command will discover the ip details and send in response
2013-12-27 14:43:25 +05:30
Marcus Sorensen
bb8b2805b6
CLOUDSTACK-5432: KVM - LibvirtStorageAdaptor only needs to disconnectPhysicalDiskByPath
...
for ISO-based disks. At least, that's how it was in 4.2, so restoring to that functionality.
2013-12-26 23:14:23 -07:00
Marcus Sorensen
8455a0677a
CLOUDSTACK-5654: Don't pass empty string to BroadcastDomainType.Vlan.toUri
...
when attempting to parse VLAN/VNI from bridge's physical ethernet device
2013-12-26 16:52:33 -07:00
Devdeep Singh
1a033eddae
CLOUDSTACK-5308, CLOUDSTACK-5542: Copy command didn't handle the scenario
...
when a volume is copied to secondary storage for template creation.
Updated the command to handle it.
2013-12-26 15:32:41 +05:30
Devdeep Singh
38d6c2ea60
CLOUDSTACK-5639: Cold storage migration doesn't work for hyper-v. Made
...
changes to make sure CopyCommand honours requests for volume copy from
primary to secondary storage and vice versa.
2013-12-25 15:23:48 +05:30
Devdeep Singh
216554d574
CLOUDSTACK-5210: Fix the sockets reported by the hyperv agent.
2013-12-23 13:25:22 +05:30
Devdeep Singh
74cb4b1c5a
CLOUDSTACK-5555: Fixing booting a vm on hyperv with data disk. Made
...
changes to attach a data disk on scsi controller when a vm is being
created.
2013-12-20 17:12:59 +05:30
Marcus Sorensen
7644b92a8b
account for vxlan interfaces named vx<vni>
2013-12-19 17:42:42 -07:00
Edison Su
62bb5d8848
fix checkstyle
2013-12-19 15:05:58 -08:00
Edison Su
8caf52c6bc
add xenserver 6.2.0 hotfix support, to optimize vdi copy
...
add xenserver hot fix
Conflicts:
api/src/com/cloud/vm/VirtualMachineName.java
core/src/com/cloud/host/HostInfo.java
core/src/org/apache/cloudstack/storage/to/SnapshotObjectTO.java
deps/XenServerJava/src/com/xensource/xenapi/VDI.java
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
engine/storage/src/org/apache/cloudstack/storage/endpoint/DefaultEndPointSelector.java
engine/storage/src/org/apache/cloudstack/storage/image/db/SnapshotDataStoreDaoImpl.java
plugins/hypervisors/xen/src/com/cloud/hypervisor/XenServerGuru.java
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerPoolVms.java
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerStorageProcessor.java
server/src/com/cloud/configuration/Config.java
2013-12-19 14:15:41 -08:00
Marcus Sorensen
95364a4022
CLOUDSTACK-5531
...
Initial support for vhd, raw, vmdk image formats on KVM. Tested all formats with local and CLVM.
2013-12-16 14:32:51 -07:00
Likitha Shetty
fa2f18d2a2
CLOUDSTACK-4875. Vmware vCenter 5.5 - System VM deployment fails During VM deployment.
...
When base template is being cloned to create VM ROOT disk, get the disk path i.e. base file name
of the VM's ROOT disk from vCenter
2013-12-17 18:31:15 +05:30
Devdeep Singh
3604f87c8d
CLOUDSTACK-5217: Attach volume fails with NPE. Made changes to make sure
...
the hypervisor product version is reported on startup. Also made changes
to fix attach and detach volume on scsi controller.
2013-12-17 16:28:08 +05:30
Devdeep Singh
759d484d9a
CLOUDSTACK-5489: Query the user name and add it to the command while mounting a cifs share.
2013-12-17 14:19:32 +05:30
Marcus Sorensen
2f53295151
CLOUDSTACK-5521: Create multi-core topology when deploying KVM virtual machines with many cores
2013-12-16 16:12:43 -07:00
Min Chen
46d1e1afb2
CLOUDSTACK-5446:KVM-Secondary Store down-Even after secondary store is
...
brought back up after being down for few hours,snapshot jobs do not get
triggered with reason "there is other active snapshot tasks on the
instance to which the volume is attached".
2013-12-13 22:04:29 -08:00
Devdeep Singh
86dadaaec4
CLOUDSTACK-5489: Cloud user doesn't have permissions to copy systemvm.iso to secondary.
...
Make sure when a cifs (secondary) is mounted, uid is set for the user who owns the files
and directories on the filesystem.
2013-12-13 17:32:34 +05:30
Devdeep Singh
db2b8d9b0d
CLOUDSTACK-5311: Fix the host version reported by the hyper-v agent. Also updated the hypervisor
...
capabilities for hyper-v.
2013-12-13 10:28:17 +05:30