Commit Graph

34882 Commits

Author SHA1 Message Date
Harikrishna Patnala 74a15a5c23 system_use column is now moved from disk_offering table to service_offering table, because it is applicable only to service offering.
There is a left over usage of system_use when user tries to list disk offering. Now we deleted that reference.
2022-02-21 18:20:09 +05:30
SadiJr e7082d9384
Fix Usage event when a volume in allocated state is deleted (#5901)
Co-authored-by: SadiJr <sadi@scclouds.com.br>
2022-02-21 10:06:47 +01:00
Wei Zhou 5d1e54a4ab
server: fix host anti-affinity when start batch vms (#6002) 2022-02-21 09:54:03 +01:00
Wei Zhou b8ce07475d
UI: fix network list when assign vm to other accounts in project view (#6009)
* UI: fix network list when assign vm to other accounts in project view

* PR#5009: return [] if empty result
2022-02-20 21:52:44 -03:00
Nicolas Vazquez e662535dce
UI: Fix move VM out of a project (#6010)
* Fix move VM out of a project

* Improve
2022-02-20 21:51:25 -03:00
SadiJr 50955432d4
[Veeam] Change the VM assign flow logic in a Backup Offering (#5903)
Co-authored-by: SadiJr <sadi@scclouds.com.br>
2022-02-18 19:05:30 +01:00
Pearl Dsilva d311f88d35
Allow scaling VM to a service offering having different storage tags (#5996) 2022-02-18 17:39:00 +01:00
Pearl Dsilva 72a77d553d
UI: Fix issue while listing projects in the Project Menu - DashBoard (#6006) 2022-02-18 10:28:29 -03:00
Hoang Nguyen 9eefc76fc5
UI: Filter menu UX improvements (#5994)
* fix filter menu

* fixes

* fixes

* fixes
2022-02-17 23:19:59 -03:00
Pearl Dsilva 550c810538
[VMware] Support for removal of NIC on IP disassociation on the VR (#5985)
* [VMware] Support for removal of NIC on IP disassociation on the VR

* address comments - extract code + add appropriate operation name in logs

* Do not remove/unplug nic on removal of static nat on last IP (Public NIC)

* address comments

* address comment
2022-02-17 22:44:03 -03:00
Nicolas Vazquez f96f6faf24
Improve messages on adding hosts errors (#5988)
* Improve messages on adding hosts errors

* Remove unreachable code

* Improve error logs

* Apply suggestions

* Improve error msg
2022-02-17 21:51:30 -03:00
nvazquez f74e87fbf8
Merge branch '4.16' 2022-02-17 21:49:12 -03:00
Wei Zhou ac794a0c85
ui: minor change with help text on dashboard (#6003) 2022-02-17 21:48:37 -03:00
Suresh Kumar Anaparti 545f85936a
Merge branch '4.16' into main 2022-02-17 14:28:26 +05:30
Wei Zhou c543f5f546
server: reapply checkVmProfileAndHost to check guest os preference (#6000) 2022-02-17 14:25:13 +05:30
SadiJr 478e24493e
Block remove of VM which has backup offering (#5457)
Co-authored-by: SadiJr <sadi@scclouds.com.br>
2022-02-17 09:17:53 +01:00
davidjumani d82cd5569a
Respect VM UEFI details on first boot (#5990)
* Update settings only if API call is successful

* Validate template UEFI detail settings

* Read boot mode and type from vm details

* Cleanup

* Honour boot type over templae settings

* Addressing comments

* Explicitly thow exception
2022-02-16 23:44:33 -03:00
Nicolas Vazquez ed30683e52
[Simulator] Add zone wide storage (#5986)
* [Simulator] Add zone wide storage

* Refactor
2022-02-16 22:50:55 -03:00
Pearl Dsilva ee947e1310
[marvin, VMware] Fix repeated test failures observed on 'main' branch (#5992)
* [marvin, VMware] Fix test_06_disk_offering_strictness_false observed on 'main' branch

* Fix test

* update config only if false

* reset full clone setting to original values
2022-02-16 13:46:03 -03:00
JoaoJandre 59dda5b129
Added a log line to HttpUploadServerHandler (#5983)
* Added a log line to HttpUploadServerHandler

* Removed \n

* Address review

Co-authored-by: dahn <daan.hoogland@gmail.com>

Co-authored-by: Joao <JoaoJandre@gitlab.com>
Co-authored-by: dahn <daan.hoogland@gmail.com>
2022-02-16 08:43:42 -03:00
Suresh Kumar Anaparti d4f40ecc6a
Fixed strings import issue (#5998)
* Fixed strings import issue in KubernetesClusterResourceModifierActionWorker

* Use isNoneEmpty
2022-02-15 13:32:41 -03:00
Suresh Kumar Anaparti b50542a11c
Merge branch '4.16' into main 2022-02-15 19:26:04 +05:30
Pearl Dsilva e0a5df50ce
CKS Enhancements and SystemVM template upgrade improvements (#5863)
* This PR/commit comprises of the following:
- Support to fallback on the older systemVM template in case of no change in template across ACS versions
- Update core user to cloud in CKS
- Display details of accessing CKS nodes in the UI - K8s Access tab
- Update systemvm template from debian 11 to debian 11.2
- Update letsencrypt cert
- Remove docker dependency as from ACS 4.16 onward k8s has deprecated support for docker - use containerd as container runtime

* support for private registry - containerd

* Enable updating template type (only) for system owned templates via UI

* edit indents

* Address comments and move cmd from patch file to cloud-init runcmd

* temporary change

* update k8s test to use k8s version 1.21.5 (instead of 1.21.3 - due to https://github.com/kubernetes/kubernetes/pull/104530)

* support for private registry - containerd

* Enable updating template type (only) for system owned templates via UI

* smooth upgrade of cks clusters

* update pom file with temp download.cloudstack.org testing links

* fix pom

* add cgroup config for containerd

* add systemd config for kubelet

* add additional info during image registry config

* update to official links
2022-02-15 18:27:14 +05:30
davidjumani b1bb22d984
ui: Pass rootdisksize only if template is not deployasis (#5995) 2022-02-15 09:07:19 -03:00
Nicolas Vazquez 97d42e9980
Fix: allow executing CopyCommand operations in parallel when it is set (#5960)
* Invoke the hypervisor guru instead of the guru cycle

* Refactor

* Remove unused import

* Refactor error
2022-02-14 23:52:45 -03:00
Nicolas Vazquez fe03e306ac
Fix attach volume error for VM - different scope for VM volume and volume disk offering (#5982)
* Fix attach volume error for VM on different storage pool

* Fix typo

* Refactor
2022-02-13 11:06:44 -03:00
Pearl Dsilva 9f23fbe7b6
[Simulator] Fix NPE in SolidFireHostListener (#5955)
* [Simulator] Fix NPE in SolidFireHostListener

* address comments

* Update plugins/storage/volume/solidfire/src/main/java/org/apache/cloudstack/storage/datastore/provider/SolidFireSharedHostListener.java

Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>

Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>
2022-02-12 08:32:19 -03:00
JoaoJandre 7aa9d3cd51
UI: fix delete domain (#5882)
Co-authored-by: Joao <JoaoJandre@gitlab.com>
2022-02-11 16:45:16 -03:00
JoaoJandre b489b5828e
[UI] Added account field to upload volume (#5914)
* [UI] Added account field to upload volume

* Add license

Co-authored-by: dahn <daan.hoogland@gmail.com>

Co-authored-by: Joao <JoaoJandre@gitlab.com>
Co-authored-by: dahn <daan.hoogland@gmail.com>
2022-02-11 16:30:56 -03:00
Bryan Lima 47a170757a
[UI] Addressing Dynamically Scale of KVM VMs (#5923)
* Externalize config to increment or not VM metrics in memory

* UI fix for dynamically scale of KVM VMs

Co-authored-by: SadiJr <17a0db2854@firemailbox.club>
Co-authored-by: SadiJr <31869303+SadiJr@users.noreply.github.com>
Co-authored-by: SadiJr <sadijacinto@gmail.com>
Co-authored-by: José Flauzino <jose.wilson.vf@gmail.com>
2022-02-11 16:29:37 -03:00
elShiaLabeouf 2c0adabad6
Added customization options for menu and dashboard elements (#5937) 2022-02-11 15:34:06 -03:00
davidjumani a094dbc76e
Add option to infer boot type and mode from template (#5974)
* Add option to infer boot type and mode from template

* Rename to defaultBootType and mode
2022-02-11 15:28:59 -03:00
JoaoJandre 2d8f070ea4
When creating a new firewall egress rule, the source and destination CIDRs were not being trimmed, this commit changes this to trim both CIDRs from the user input. (#5867)
Co-authored-by: Joao <JoaoJandre@gitlab.com>
2022-02-11 14:06:01 -03:00
JoaoJandre bcd0979a5a
Fixed possible blank domain UUID amd created new unit tests. (#5835)
Co-authored-by: Joao <JoaoJandre@gitlab.com>
2022-02-11 14:05:01 -03:00
Suresh Kumar Anaparti 48b1e73573
Merge branch '4.16' into main 2022-02-11 22:32:37 +05:30
dahn 8db598bc0f
set pod after migration (#5972)
Co-authored-by: Daan Hoogland <dahn@onecht.net>
2022-02-11 18:47:45 +05:30
Nicolas Vazquez 7f0a322b7d
[Vmware] Prevent NPE on template registration if guest OS is removed (#5980) 2022-02-11 07:36:59 -03:00
Suresh Kumar Anaparti 212a4dedfc
Merge branch '4.16' into main 2022-02-10 20:56:52 +05:30
sureshanaparti 5297b52d98
Improve the guest OS hypervisor mappings addition on upgrade. (#5911)
- This removes the hardcoded guest os ids 305 - 329 in upgrade path 4.14.0 to 4.15.0, and 330 - 349 in upgrade path 4.15.0.0 to 4.15.1.0.
2022-02-10 14:43:03 +01:00
Nicolas Vazquez a3bb84b495
[VMware] Update SCSI controllers for VMs (#5910) 2022-02-10 14:36:34 +01:00
dahn 122b018057
Quota test fixes (#5959)
* fixes and cleanups on quota integration test

* text changes in exception messages

Co-authored-by: Daan Hoogland <dahn@onecht.net>
Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>
2022-02-10 18:57:21 +05:30
nvazquez e9d8d7942d
Merge branch '4.16' 2022-02-10 09:48:49 -03:00
davidjumani bc93163eec
ui: Allow domain admin to configure subdomain limits (#5978) 2022-02-10 07:55:45 -03:00
sureshanaparti 5db62c15a4
Removed duplicate import for StringUtils (#5975) 2022-02-10 13:44:15 +05:30
dahn a6d9fa61b9
Role escalation prevention (#5879)
* prevent role access escallation

* hierarchy issue fixed

* create api list in account manager for checking new account access

* full api list check

* strange role restriction removed for BareMetal

* add role check on upfdate account as well

* more selective use of api checkers

* error msg and var name

Co-authored-by: Daan Hoogland <dahn@onecht.net>
2022-02-10 11:50:27 +05:30
Suresh Kumar Anaparti 850714c1fc
Merge branch '4.16' into main 2022-02-10 10:57:29 +05:30
slavkap 4ffb949a58
Fix of revert RBD snapshots (#5544)
* Fix of revert RBD snapshots

If snapshot is taken only on Primary storage with the option "snapshot.backup.to.secondary" set to true, when you set this option to false the revert will fail. Added check if the snapshot is not on Secondary to check for it on Primary

* Check if snapshot is on primary storage

Will check first if the snapshot is on Primary storage, if not will
return Image as data store

* Fix unit tests

* removed unused method's params

* Formatted error message and added the snapshot ID to it

* Return to the old logic, the fix will only apply to RBD

* Formatted Exception's messages
2022-02-10 10:22:21 +05:30
Abhishek Kumar f88f934274
api, server: fix add-remove vpn user without vpn owner (#5850)
* api, server: fix add-remove vpn user without vpn owner

Fixes #5711

ACS should not add a new user in Add state when the owner account does not have VPN access.
While removing VPN user ACS should not fail completely when owner account ahs no VPN.

* change , fixes

* remove unused method

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-02-10 10:07:23 +05:30
Yashika 38181b2afa
Optional chaining used to enhance readability (#5961)
* Optional chaining used to enhance readability

* Added Suggested change

Co-authored-by: YashikaSarkar <65132044+YashikaSarkar@users.noreply.github.com>
2022-02-10 01:27:54 -03:00
Pearl Dsilva 640118ce2b
Add disk space in systemVM template registration script (#5956) 2022-02-10 09:50:12 +05:30