Daan Hoogland
|
1532203e36
|
findbugs: decoding String using preferred Charset
|
2015-06-19 14:22:19 +02:00 |
Daan Hoogland
|
9d1c38e7e7
|
findbugs: encoding string with preferred Charset
|
2015-06-19 14:19:54 +02:00 |
Daan Hoogland
|
ee3085db47
|
findbugs: repeated condition removed
|
2015-06-19 13:54:38 +02:00 |
Sanjeev Neelarapu
|
964deb0245
|
VM deployments from ISO and attaching ISOs to vm are not supported in LXC. So no point in running iso tests for LXC Bug-Id: CS-42250 Reviewed-By: Shweta
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #487
|
2015-06-19 13:41:41 +03:00 |
Sowmya Krishnan
|
a764d2c09d
|
Move tests to maint/ folder and added few error checking
|
2015-06-19 15:51:39 +05:30 |
Sanjay Tripathi
|
84d4c9bf4c
|
Recurring snapshot issue post upgrade from 3.0.7 to 4.5
This closes #486
|
2015-06-19 16:03:42 +05:30 |
Sanjay Tripathi
|
9044a02d9a
|
VM Snapshot Usage for DATA disk is reported as the size of the DATA disk instead of the actual snapshot size.
This closes #485
|
2015-06-19 15:55:21 +05:30 |
Sanjay Tripathi
|
92a9ee097d
|
AsyncJob reports 'Successful' even if RevertToVMSnapshot operation fails.
This closes #484
|
2015-06-19 15:48:21 +05:30 |
Abhinandan Prateek
|
bcfb8240e1
|
CLOUDSTACK-8570:Exception in calculating reserved capacity for dynamic service offering
|
2015-06-19 09:30:33 +05:30 |
Daan Hoogland
|
797a7f05ff
|
use version in branchname if branch is master
|
2015-06-19 00:01:43 +02:00 |
Daan Hoogland
|
b9dd67c383
|
CLOUDSTACK-8545 port of the fix to not reboot routers on out of band migration persé
|
2015-06-18 16:42:08 +02:00 |
Rafael da Fonseca
|
931cb95022
|
Fix 2 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warnings in ConfigurationManagerImpl.java
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #476
|
2015-06-18 13:37:39 +03:00 |
Rafael da Fonseca
|
b678b47793
|
Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warning in ConfigurationServerImpl.java
Remove checkstyle reported trailing space
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #477
|
2015-06-18 13:36:44 +03:00 |
Jayapal
|
59e6596fef
|
Fixed issue in adding vm SG rules on vm reboot for xenserver 6.5
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #479
|
2015-06-18 13:32:00 +03:00 |
Daan Hoogland
|
ba5b6b152e
|
findbugs: deal with all the encoding issues in a unified way further getBytes() calls can getBytes(StringUtils.getPrefferedCharset()) instead
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #467
This closes #467
|
2015-06-18 12:13:26 +02:00 |
Gaurav Aradhye
|
897ea3db76
|
CLOUDSTACK-8527: Skipping VPC tests on HyperV
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #458
|
2015-06-18 12:12:46 +02:00 |
pritisarap12
|
a5a1818d2a
|
CLOUDSTACK-8555: Skip resize volume operation for HyperV
Signed-off-by: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
This closes #465
|
2015-06-18 15:23:52 +05:30 |
ramamurtis
|
5c5d445d32
|
CLOUDSTACK-8548: Message translations in Japanese and Chinese
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
This closes #380
|
2015-06-18 14:56:29 +05:30 |
Rafael da Fonseca
|
5d258fa163
|
Fix 2 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warnings in DatabaseConfig.java
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
This closes #478
|
2015-06-18 14:36:26 +05:30 |
Rafael da Fonseca
|
2993291e7c
|
Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warning in AsyncJobDaoImpl.java
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>
This closes #475
|
2015-06-18 14:35:52 +05:30 |
Rafael da Fonseca
|
b84093f691
|
Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warning in PrimaryDataStoreDaoImpl.java
Remove trailing spaces that checkstyle complained about
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #474
|
2015-06-17 22:46:58 +02:00 |
Rafael da Fonseca
|
1407033cc2
|
Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warning in UserVmDaoImpl.java detail field was vulnerable
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #473
|
2015-06-17 22:38:19 +02:00 |
Daan Hoogland
|
f3afcb089f
|
CLOUDSTACK-8537 test for the sake of testing the fix seems so trivial but no testing is available for it at all. when bugs arise test extension should be the start point here.
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #357
|
2015-06-17 20:47:57 +02:00 |
Daan Hoogland
|
968e71ad0e
|
CLOUDSTACK-8537 refactor registerSSHKeyPair() for legibility and testability reasons
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
|
2015-06-17 20:47:57 +02:00 |
Daan Hoogland
|
9f02531212
|
CLOUDSTACK-8537 add check for unique public key and account on ssh keypair registration
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
|
2015-06-17 20:47:57 +02:00 |
Sanjeev Neelarapu
|
64361d2b71
|
In case of vm deployment failure vm cleanup was not handled properly Corrected few script issues
This closes #472
|
2015-06-17 17:38:35 +05:30 |
Erik Weber
|
5e96d13944
|
CLOUDSTACK-8455: Use the correct label to display extractable checkbox
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #471
|
2015-06-17 13:14:54 +02:00 |
Daan Hoogland
|
0952580096
|
findbugs: try-with-resource to circumvent not handling an exception on
close
|
2015-06-17 12:41:04 +02:00 |
Daan Hoogland
|
6da6c5f762
|
findbugs: log unhandled exception as warning
|
2015-06-17 12:35:39 +02:00 |
Sanjeev Neelarapu
|
17ddb4b100
|
Skip VPC tests on LXC
This closes #470
|
2015-06-17 15:51:44 +05:30 |
Rafael da Fonseca
|
85afa63f24
|
Re-run travis
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #456
|
2015-06-17 12:18:01 +02:00 |
Rafael da Fonseca
|
b34ad4a22c
|
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in IpAddressManagerImpl.java Assert isn't used in prod runtime
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
|
2015-06-17 12:18:00 +02:00 |
Rafael da Fonseca
|
441a13252a
|
Re-run travis
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #454
|
2015-06-17 12:15:23 +02:00 |
Rafael da Fonseca
|
9f7c379a88
|
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in RpcProviderImpl.java Assert isn't used in prod runtime
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
|
2015-06-17 12:15:23 +02:00 |
Rafael da Fonseca
|
ce506000cd
|
Re-run travis
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #453
|
2015-06-17 12:14:31 +02:00 |
Rafael da Fonseca
|
4a333e452a
|
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in AgentManagerImpl.java Assert isn't used in prod runtime
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
|
2015-06-17 12:14:31 +02:00 |
Rafael da Fonseca
|
acab743aa1
|
Re-run travis
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #452
|
2015-06-17 12:13:46 +02:00 |
Rafael da Fonseca
|
380ac0cf24
|
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in ServiceOfferingVO.java Assert isn't used in prod runtime
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
|
2015-06-17 12:13:46 +02:00 |
Rafael da Fonseca
|
5a3e57e6b2
|
Re-run travis
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #450
|
2015-06-17 12:12:41 +02:00 |
Rafael da Fonseca
|
b3d49d9135
|
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in DataCenterVO.java Assert isn't used in prod runtime
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
|
2015-06-17 12:12:41 +02:00 |
Rafael da Fonseca
|
eaa4eba74d
|
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in EngineHostVO.java Assert isn't used in prod runtime, null is checked in method
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #448
|
2015-06-17 12:10:45 +02:00 |
Rafael da Fonseca
|
a2129b2940
|
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VmWorkJobDispatcher.java Assert isn't used in prod runtime, null is properly checked in method
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #446
|
2015-06-17 12:08:19 +02:00 |
Rafael da Fonseca
|
d056c3d279
|
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VirtualMachineManagerImpl.java Removed two unnecessary null checks as this piece of code will only run if answer is not null, as satified in condition stated in line #1253
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #445
|
2015-06-17 12:07:54 +02:00 |
Sanjay Tripathi
|
d702b63bfb
|
CLOUDSTACK-8569: The latter snapshot export for the same volume will fail is 2 snapshot exports are queued
This closes #469
|
2015-06-17 15:27:03 +05:30 |
Sanjay Tripathi
|
47278556f5
|
CLOUDSTACK-8567 Migrating primary storage causes name_label field to blank.
This closes #468
|
2015-06-17 14:46:51 +05:30 |
Daan Hoogland
|
2e792075ee
|
update of the findbugs lib
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #459
|
2015-06-17 10:25:33 +02:00 |
Daan Hoogland
|
41c1fddaee
|
findbugs: better message and fallback to defaultCharset
|
2015-06-16 11:57:15 +02:00 |
Rafael da Fonseca
|
0851e4e54b
|
Catch encoding exception
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #464
|
2015-06-16 11:24:51 +02:00 |
Rafael da Fonseca
|
9f2ebdf443
|
Fix findbugs encoding issue in VmwareStorageProcessor.java Any encoding would do fine as it's just used to generate a UUID. Sticking with UTF-8 for consistency
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #460
|
2015-06-16 08:56:33 +02:00 |
Rafael da Fonseca
|
9bb920af65
|
Fix findbugs warning in VmwareStorageManagerImpl.java Any encoding would do fine as it's just used to generate a UUID. Sticking with UTF-8 for consistency
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #461
|
2015-06-16 08:53:56 +02:00 |