Commit Graph

25504 Commits

Author SHA1 Message Date
Wido den Hollander 72ba98b1b8 Validate IPv4 address using Apache Commons Validator 2014-11-24 14:43:48 +01:00
Wido den Hollander 87a7810ade Fix UnitTest ApiServlet 2014-11-24 11:48:13 +01:00
Wido den Hollander 4bd49df3f5 Use InetAddress for passing Remote Address instead of String 2014-11-21 12:10:35 +01:00
David Bierce 83656a6ea8 Occasionally the while loop can exit with no data (Probably recieving an EOF) before receiveing CMDline data from the certial port. Continue looping until cmdline is populated
Signed-off-by: Edison Su <sudison@gmail.com>
2014-11-20 11:00:09 -08:00
Keiichi Yusa 7884c750a2 CLOUDSTACK-7951
Limit amount of memory used by cloudstack-agent jsvc.

Signed-off-by: Edison Su <sudison@gmail.com>
2014-11-20 10:19:57 -08:00
Min Chen 5fa7801b20 CLOUDSTACK-7954:ListTags API is ignoring the resourceID and displaying
all the tags of all resources.
2014-11-20 09:46:00 -08:00
Min Chen 7de9d2f002 Revert "BUG-ID: CS-27662: ListTags API is ignoring the resourceID and displaying"
This reverts commit 3014fd0089.
2014-11-20 09:44:55 -08:00
Min Chen 3014fd0089 BUG-ID: CS-27662: ListTags API is ignoring the resourceID and displaying
all the tags of all resources.
Reviewed-by: Frank
2014-11-20 09:31:29 -08:00
Rohit Yadav d2d448c401 schema: Add upgrade path from 4.3.2 to 4.5.0
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 91d448ff45)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-11-20 14:30:54 +05:30
Syed 8ea7902075 CLOUDSTACK-7952: Remove private key from SslCertResponse (listSslCerts)
Signed-off-by: Will Stevens <wstevens@cloudops.com>
2014-11-20 03:46:03 -05:00
Saksham Srivastava 4ff3130bec CLOUDSTACK-7950: AttachIsoCmd shoud give correct messge when trying to attach vmwaretools installer iso on non supported guestvm deployed by ISO 2014-11-20 13:04:14 +05:30
Frank Zhang 3dfe532e42 CLOUDSTACK-7629
addBaremetalRct() API call is not available in cloudstackAPI library in marvin.
2014-11-19 17:00:43 -08:00
Anthony Xu 02e22dba7d CLOUDSTACK-7742:
root cause:
when vmsync reports system VM is down, CCP doesn't release the VM resource before starting it.
fix:
make sure cleanup is called for a VM when it is reported as Stopped
2014-11-19 16:30:56 -08:00
Edison Su 4140811549 CLOUDSTACK-7947:
double check if parent snapshot is removed or not, when creating new
snapshot

Reviewed-by: Min
2014-11-19 16:13:05 -08:00
Edison Su 2ccecce515 CLOUDSTACK-7946:
fix compile
2014-11-19 16:09:30 -08:00
Edison Su 67113ff0b2 CLOUDSTACK-7946:
remove leftover state in volume and snapshot table in case of mgt server
shutdown during storage operation.
Reviewed-by: Min
2014-11-19 16:06:37 -08:00
Edison Su c05cda0d28 CLOUDSTACK-7945:
set removed field in snapshots table in case of snaphsot failure.

Reviewed-by: Frank
2014-11-19 15:58:47 -08:00
Edison Su 0e3aebbb9d CLOUDSTACK-5446:
delete all the leftover snapshots on primary storage in case of snapshot
errors, after a new backup snapshot is finished
2014-11-19 15:53:06 -08:00
Jessica Wang e32eec8b3e CLOUDSTACK-7613: UI > Infrastructure > CPU Sockets > add a new row for "XenServer 6.5.0". 2014-11-19 15:12:50 -08:00
Sheng Yang bb352da302 CLOUDSTACK-7944: Ensure ipv6 is enabled in sysctl.conf
The booting sequence result in change of IPv6 related sysctl options was
overrided by sysctl.conf which is loaded later.

So this patch would patch sysctl.conf in VR as well, ensure IPv6 would be
enabled during booting period otherwise the network setup may not work, result
in IPv6 VM deployment failure.
2014-11-19 14:49:18 -08:00
Jessica Wang 7b6f49617d CLOUDSTACK-7943: UI > storage > volume > create template action > add "XenServer Tools Version 6.1+" checkbox. Default it as its VM's "XenServer Tools Version 6.1+" property. 2014-11-19 12:04:46 -08:00
Jessica Wang b11380eebe CLOUDSTACK-7943: UI > dialog widget > checkbox field > isChecked property > if isChecked property is a funciton, pass "args" along when calling isChecked() function. 2014-11-19 12:04:16 -08:00
Saksham Srivastava f0a4a639de CLOUDSTACK-7941: CloudStack should log IP address of actual client even if a ReverseProxy is there 2014-11-19 16:07:10 +05:30
Sanjay Tripathi dda2994936 CLOUDSTACK-7940: Exception printed completely on the UI. Not in a readable format. 2014-11-19 15:59:03 +05:30
Kishan Kavala 4e896938ee BUG-ID: CLOUDSTACK-5324 when router requires upgrade throw ResourceUnavailableException with scope VirtualRouter. API willl return generic Network Unavailable error.
Reviewed-By: Damoder
2014-11-19 09:46:56 +05:30
Chandan Purushothama 20a8852db1 CLOUDSTACK-7928 : Fixed the script 'test_vpc_vm_life_cycle.py' - Removed the Invalid test cases for Stopped VPC VR Scenario 2014-11-18 19:19:44 -08:00
vetrivelc 5327038c16 Missing label id and removed duplicate label.ids.
Signed-off-by: vetrivelc <vetrivel.chinnasamy@citrix.com>
2014-11-18 14:03:13 -08:00
Jessica Wang 880ab4392d CLOUDSTACK-6624: UI > create network offering > cloudStack does NOT support specifyIpRanges for isolated network - fix a bug that wrongly sends "specifyIpRanges=true" to createNetworkOffering API. 2014-11-18 13:52:01 -08:00
Jessica Wang 0e2299d933 CLOUDSTACK-7498: UI > ISO > Register ISO action > a javascript error "osTypeObjs is not defined" comes and goes. 2014-11-18 12:02:00 -08:00
Prachi Damle c5399cdef0 CLOUDSTACK-5853 cannot deploy vm with differing service storage tag and data disk storage tag
Changes:
- Reverting Marcus's fix since this issue has already fixed by https://issues.apache.org/jira/browse/CLOUDSTACK-5426
2014-11-18 09:47:23 -08:00
Prachi Damle 48553d7434 CLOUDSTACK-7559 After migrating root volume to other cluster wide storage, start VM is not running the VM with root disk from new storage.
Changes:
- During VM start, do not use the last host Id, if the host's cluster does not match the cluster provided in the deployment plan.
2014-11-18 09:47:20 -08:00
Daan Hoogland f2ccee7a03 name convention adherence 2014-11-18 16:52:46 +01:00
Daan Hoogland 6bc0defa1d CID-1254832 tyr-with-resource 2014-11-18 15:48:31 +01:00
Hugo Trippaers 22ad646aca CID-1114601/CID-1114602 Fix ignored return values and remove duplicate code 2014-11-18 15:05:09 +01:00
Hugo Trippaers 7e58a278a0 CID-1232335/CID-1232336 Fix potential XSS 2014-11-18 14:40:13 +01:00
Hugo Trippaers 302d5195d4 Merge branch 'bugfix/CID-1254835' 2014-11-18 14:31:33 +01:00
Hugo Trippaers fe0168f6d2 CID-1116546 Fix resource leak 2014-11-18 14:30:55 +01:00
Hugo Trippaers e1d4a329c4 Package name should reflect the location on the filesystem or viseversa 2014-11-18 14:12:44 +01:00
Hugo Trippaers 16de4a7176 Fix for potential NPE 2014-11-18 14:12:14 +01:00
Daan Hoogland 638da54fce CID-1254833 refactor condition to include null-case 2014-11-18 12:12:00 +01:00
Hugo Trippaers ef30300281 CID-1254834 secStorageVm can only be null in a special case 2014-11-18 09:37:35 +01:00
Hugo Trippaers 8560cc3b01 CID-1254835 proxy can only be null in a special case 2014-11-18 09:30:37 +01:00
Anshul Gangwar 31876fb588 CLOUDSTACK-7929: While creating network offering if one specifies negative value for network rate then we will convert that value to 0 i.e. unlimited
This closes #40
2014-11-18 13:39:08 +05:30
Anshul Gangwar 055f6ad318 CLOUDSTACK-7932: Fixed wrong semantics for isVmAlive() method in HypervInvestigator
Findbugs will report error on this as it is expecting true/false for Boolean value.
But we have diffrent meaning for null so it is false positive case from findbug

This closes #39
2014-11-18 13:37:36 +05:30
Anshul Gangwar b008d78b57 CLOUDSTACK-7930, CLOUDSTACK-7931: Do not allow to set invalid values for global settings which are of type integer and float
This closes #41
2014-11-18 13:36:21 +05:30
Brian Federle bfe53d1b2b VM wizard: Add 'showStep' event
For UI plugin development, allow moving though VM wizard steps via
custom event hook, cloudStack.instanceWizard.showStep (attached to
wizard DOM object), passing the specified target step index

Example:

$wizard.trigger('cloudStack.instanceWizard.showStep', {
  index: 2 // Show step 2 of wizard
  refresh: true // (Optional) Force refresh of step if data loaded
});
2014-11-17 15:14:51 -08:00
Chandan Purushothama e712ac78d0 CLOUDSTACK-7810 : Fixed the script 'test_vpc_vm_life_cycle.py' 2014-11-17 17:35:13 -08:00
Jessica Wang eba7cc78da CLOUDSTACK-7927: UI > Infrastructure > Primary Storage > detailView > add "View Volumes" link that will list all volumes under this primary storage when being clicked. 2014-11-17 13:06:43 -08:00
Daan Hoogland 7aa64b9efa CID-1254838 catch individual exceptions types 2014-11-17 15:09:03 +01:00
Daan Hoogland 7b9e4a820b CID-1254842 use boxed constant instead of true 2014-11-17 14:59:47 +01:00