etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
28,037 Commits 326 Branches 325 Tags 885 MiB
Commit Graph

1787 Commits

Author SHA1 Message Date
Maneesha P 1f09b8c3bf Fixed Coverity issue "Dereference null return value" 
added a not null check and a CloudRuntimeException in case of null

Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>

This closes #617
 2015-07-23 15:46:17 +05:30
Wido den Hollander d1f76a2a84 CLOUDSTACK-8628: kvm: Disable Fencing when no NFS storage pools are present 
On NFS we write a heartbeat, but without those we can not safely
fence off a host.

If we fence without knowing about a heartbeat we can cause a split-brain situation.

Signed-off-by: Wido den Hollander <wido@widodh.nl>
 2015-07-17 12:33:11 +02:00
Likitha Shetty f5ed824ea2 CLOUDSTACK-8598. CS reports volume migration as successful but the volume is not migrated in vCenter.. For the following disk operations - migration, snapshot creation, resize, detach and template creation, CS should do an exact disk match between volume path and vCenter disk name. If the exact matching fails to find a disk, CS should fall back to the old method of partial matching on a trimmed disk. 
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>

This closes #543
 2015-07-16 10:44:58 +02:00
Funs ca68bb0ef7 xenserver: Improved message for peeples to actually see what the problem is. 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #576
 2015-07-15 18:24:39 +05:30
Daan Hoogland e62d952375 coverity 1311706: to generic exeption handling on xapi call 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-07-14 13:41:09 +02:00
Daan Hoogland c53959513e findbugs: create wrapper to deal with static field 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #573
 2015-07-14 11:50:39 +02:00
Daan Hoogland 10853bfa8a adhere to naming conventions for enums 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-07-14 11:50:39 +02:00
Wido den Hollander 63688e70a0 kvm: More verbose logging around storage pools in the Agent 2015-07-13 16:53:26 +02:00
Wido den Hollander 24f8e66e93 kvm: Write Libvirt instead of LibVirt 2015-07-13 16:22:33 +02:00
Wido den Hollander 7c37ba73a3 kvm: Add more verbose logging about what is happening with Libvirt connections 2015-07-13 16:21:41 +02:00
Jayapal deb694c201 CLOUDSTACK-8324: Added migration changes for config drive 2015-07-10 09:39:27 +05:30
Daan Hoogland 6376503fe3 coverity 1308118: more resources being opened only one closed on exception nothing was closed 
Signed-off-by: Daan Hoogland <daan@onecht.net>
 2015-07-09 21:30:23 +02:00
Daan Hoogland bcc8182f2f findbugs: write to static from instance these are the trivial cases of ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD as reported by findbugs 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #539
 2015-07-09 15:01:58 +02:00
weingartner 25e9918c57 Amend last commit, used 4 spaces in code formatting instead of 1 tab character. 
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>

This closes #560
 2015-07-09 13:37:59 +02:00
weingartner 50c4836c9f Cleaned class “com.cloud.hypervisor.xenserver.resource.XcpOssResource” that seemed to be forgotten during the evolution of the ACS. It was removed a few methods that were already coded properly in its parent class “com.cloud.hypervisor.xenserver.resource.CitrixResourceBase”. It was also removed some methods that seemed to cause weird behaviors. The methods removed/fixed are detailed as follows: • com.cloud.hypervisor.xenserver.resource.XcpOssResource.fillHostInfo(Connection, StartupRoutingCommand) – it was removed, because it always added the string “, hvm” to the host capabilities. Therefore, if one uses XCP hypervisor it could cause a lot of trouble when deploying HVM virtual machines in an environment that has PV and HVM clusters. The method is already properly coded in parent class. • com.cloud.hypervisor.xenserver.resource.XcpOssResource.launchHeartBeat(Connection) – It was removed. It was not performing anything and always returns a true value. The method of parent class is properly coded and works for XCP environments. The heartbeat plugin exists in XCP environment. • com.cloud.hypervisor.xenserver.resource.XcpOssResource.initializeLocalSR(Connection) – it was removed. The method of the parent class works properly for XCP environments. • com.cloud.hypervisor.xenserver.resource.XcpOssResource.createPatchVbd(Connection, String, VM) – It was removed. This method causes a bug in XCP environments, because of its half-implementation, it was not possible to migrate system VMs. The parent class implementation works properly for XCP. • com.cloud.hypervisor.xenserver.resource.XcpOssResource.execute(NetworkUsageCommand) – removed, hence it was already coded into parent class and its respective wrappers (“com.cloud.hypervisor.xenserver.resource.wrapper.xcp.XcpServerNetworkUsageCommandWrapper”). BTW: I noticed that the class XcpServerNetworkUsageCommandWrapper and XenServer56NetworkUsageCommandWrapper are almost the same, with the exception that XenServer56NetworkUsageCommandWrapper deals with VPC. I believe that those wrappers could be converted into one, and moved to parent. I am not doing that here because I do not have a XCP environment with advanced networking to test it. • com.cloud.hypervisor.xenserver.resource.XcpOssResource.executeRequest(Command) – removed, hence it is not needed anymor. • com.cloud.hypervisor.xenserver.resource.XcpOssResource.execute(StopCommand) – I did not understand that method. It seemed weird and its removal did not change any behavior of the environment I tested it with. 
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
 2015-07-09 13:37:59 +02:00
Daan Hoogland 31c6b14dd4 Merge branch 'improvement/CLOUDSTACK-8607' change the host password on the host itself via the updateHostPassword API 
- Make sure the new password replaces the old one in the queue
    - Updated the patch files for XenServer
    - Updated the script path on LibvirtComputing class
    - Adding update_host_passwd to VRScripts
    - Add implementation to CitrixUpdateHostPasswordCommandWrapper
    - Improve testUpdateHostPasswordCommand() unit test on CitrixRequestWrapperTest
    - Adding update_host_passwd.sh script
    - Adding the host IP address as an instance variable on UpdateHostPasswordCommand
    - Improving the Unit Test (LibvirtComputingResourceTest) to get it covering the new code
    - Make sure doUpdateHostPassword() doesn't get called if flag is set to false
    - Do not update XenServer hosts if the cluster ID is not informed

    This closes #559
 2015-07-06 16:15:22 +02:00
wilderrodrigues e348e76eee CLOUDSTACK-8607 - Improving unit tests 
- Adding more unit tests as suggested by Daan and Rajani.
   - Mocking SshHelper and the Script classes, used by Citrix and Libvirt resources respectively.
 2015-07-06 14:58:17 +02:00
wilderrodrigues 86297e70be CLOUDSTACK-8607 - Make sure the new password replaces the old one in the queue 
- Added log info to show details of the operation
   - Renamed the addPwdToQueue to replaceOldPasswdInQueue
 2015-07-04 11:33:52 +02:00
wilderrodrigues efa34361df CLOUDSTACK-8607 - Changed update script to return exit code based on the result 
- Changed location of the update_host_passwd script
   - Updated the patch files for XenServer
   - Updated the script path on LibvirtComputing class
   - Removed the hostIP from the LibvirtUpdateHostPasswordCommandWrapper execute() method
 2015-07-03 14:29:57 +02:00
Kishan Kavala 3a19a8916e BUG-ID:CLOUDSTACK-7472: kvmclock fix for LXC is not required after fixing CLOUDSTACK-8177 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #557
 2015-07-03 15:21:18 +05:30
wilderrodrigues 0dd02ce043 CLOUDSTACK-8607 - Adding support to update host passwd on XenServer hypervisors 
- Adding update_host_passwd to VRScripts
   - Add accessor method to host password on CitrixResourceBase
   - Add implementation to CitrixUpdateHostPasswordCommandWrapper
   - Improve testUpdateHostPasswordCommand() unit test on CitrixRequestWrapperTest
   - Add line to patch files on xenserver directory

Concerning the LibVirt change:

   - I forgot to assing the return of the getDefaultHypervisorScriptsDir() method to the hypervisorScriptsDir variable
 2015-07-03 10:24:44 +02:00
wilderrodrigues 47c7a1083f CLOUDSTACK-8607 - Adding update_host_passwd.sh script 
- Modifying the LibvirtUpdateHostPasswordCommandWrapper in order to execute the script on the host
   - Adding the script path to LibvirtComputingResource
   - Adding the host IP address as an instance variable on UpdateHostPasswordCommand
   - Improving the Unit Test (LibvirtComputingResourceTest) to get it covering the new code
 2015-07-02 14:54:51 +02:00
Likitha Shetty 9463356ca6 CLOUDSTACK-8600. Upon detaching a disk, delete VM folder if empty. 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #545
 2015-07-01 14:53:23 +02:00
Likitha Shetty 299c07c3e1 CLOUDSTACK-8597. Failed to migrate volume from zone-wide to cluster-wide storage. While live migrating a volume, CS chooses the endpoint to perform the migration by selecting any host that has the storage containing the volume mounted on it. Instead, if the volume is attached to a running VM, the endpoint chosen by CS should be the host that contains the VM. 
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>

This closes #541
 2015-07-01 12:33:26 +02:00
wilderrodrigues 527d6ee77b Making possible to update KVM hosts password in the database via the API 
- Make sure the doUpdateHostPassword() method returns the result from the answer, not always true
   - Added the LibvirtUpdateHostPasswordCommandWrapper class, which will handle the changes in the KVM agent
     That's will be further implemented in the future. The command will avoid the agent to complain about Unsupported command
   - Added a test to make sure the current implementation of the comment works
     - If changes in the future, it will also require changes. In that way, we make sure nobody will break it

Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>

This closes #527
 2015-06-29 09:59:12 +02:00
Daan Hoogland 8a8849354c findbugs: masking fields removed 2015-06-24 12:24:12 +02:00
Daan Hoogland e8984d16ed findbugs: move assert to a place where it still makes sense 
Signed-off-by: Daan Hoogland <daan@onecht.net>
 2015-06-23 23:27:03 +02:00
Rafael da Fonseca fe4f0b1a58 Specify all dependency versions in pom.xml 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #497
 2015-06-22 13:01:19 +02:00
Rafael da Fonseca 83488e01af Reduce about 1k String objects from being instantiated 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-22 13:01:19 +02:00
Rafael da Fonseca 9d19191bc6 Root cause of failure is memory abuse in XenTest.java class ;) This should fix it 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-22 13:01:19 +02:00
Rafael da Fonseca 301a7b9a7e Specify all external dependencies in pom Upgrade to lang3 and change usage of deprecated xmlparse method 
Add another missing dependency

Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-22 13:01:19 +02:00
Rafael da Fonseca 1603f722c4 Cleanup some lint checker warning in base classes 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-22 13:01:18 +02:00
Rafael da Fonseca 540b163cfc Resolve unsafe cast warnings reported by lint checker Add some debug config to compiler plugin 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-22 13:01:18 +02:00
Rafael da Fonseca 0d8c64ea56 Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in OvmResourceBase.java 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #502
 2015-06-22 10:50:48 +02:00
Rafael da Fonseca dc359c505e Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in BareMetalResourceBase.java 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #501
 2015-06-22 10:50:12 +02:00
Daan Hoogland bbb165a037 findbugs: use preferred encoding explicitly 2015-06-20 10:36:15 +02:00
Daan Hoogland 9eff27a080 findbugs: static member should be final 
Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #495
 2015-06-20 00:57:59 +02:00
Daan Hoogland 871ba9c521 findbugs: ignored return value should have been returned down stack 
Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #494
 2015-06-20 00:57:01 +02:00
Daan Hoogland e3407a3939 findbugs: encoding using preferred Charset 2015-06-19 23:03:05 +02:00
Sanjay Tripathi 9044a02d9a VM Snapshot Usage for DATA disk is reported as the size of the DATA disk instead of the actual snapshot size. 
This closes #485
 2015-06-19 15:55:21 +05:30
Daan Hoogland 0952580096 findbugs: try-with-resource to circumvent not handling an exception on 
close
 2015-06-17 12:41:04 +02:00
Daan Hoogland 6da6c5f762 findbugs: log unhandled exception as warning 2015-06-17 12:35:39 +02:00
Sanjay Tripathi d702b63bfb CLOUDSTACK-8569: The latter snapshot export for the same volume will fail is 2 snapshot exports are queued 
This closes #469
 2015-06-17 15:27:03 +05:30
Sanjay Tripathi 47278556f5 CLOUDSTACK-8567 Migrating primary storage causes name_label field to blank. 
This closes #468
 2015-06-17 14:46:51 +05:30
Daan Hoogland 41c1fddaee findbugs: better message and fallback to defaultCharset 2015-06-16 11:57:15 +02:00
Rafael da Fonseca 0851e4e54b Catch encoding exception 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #464
 2015-06-16 11:24:51 +02:00
Rafael da Fonseca 9f2ebdf443 Fix findbugs encoding issue in VmwareStorageProcessor.java Any encoding would do fine as it's just used to generate a UUID. Sticking with UTF-8 for consistency 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #460
 2015-06-16 08:56:33 +02:00
Rafael da Fonseca 9bb920af65 Fix findbugs warning in VmwareStorageManagerImpl.java Any encoding would do fine as it's just used to generate a UUID. Sticking with UTF-8 for consistency 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #461
 2015-06-16 08:53:56 +02:00
Rafael da Fonseca 3d48af41a8 Fix findbugs encoding issue in VmwareResource.java Key file should be UTF-8 encoded in VR 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #462
 2015-06-16 08:51:54 +02:00
Wido den Hollander 4b4c52ea77 CLOUDSTACK-8560: Stat the resulting image after copying from template and return the size 
This way we update the DB with the actual size of the disk after deployment from template
 2015-06-15 17:55:56 +02:00