Commit Graph

22565 Commits

Author SHA1 Message Date
Brian Federle c64bfa5d85 Merge branch 'master' into ui-restyle 2014-02-20 11:15:26 -08:00
Hugo Trippaers 19b15a1bdc Fix parameter index in getCount function. 2014-02-20 15:13:29 +01:00
Niels de Vos fe83a85436 Add support for Primary Storage on Gluster using the libvirt backend
The support for Gluster as Primary Storage is mostly based on the
implementation for NFS. Like NFS, libvirt can address a Gluster environment
through the 'netfs' pool-type.
2014-02-20 14:52:01 +01:00
Sheng Yang ca683958d8 CLOUDSTACK-6047: Fix typo 2014-02-19 21:15:46 -08:00
Sheng Yang d429be75a7 CLOUDSTACK-6047: Fix fail to enable VPN 2014-02-19 21:05:51 -08:00
Sheng Yang 3bbbda887f CLOUDSTACK-6047: Introduce VR resource unit test 2014-02-19 19:47:20 -08:00
Sheng Yang 711b308370 CLOUDSTACK-6047: Introduce QueryCommand
QueryCommand is a kind of command which request the state rather than configure.
QueryCommands need to be executed immediately and cannot be aggregated.
2014-02-19 19:47:14 -08:00
Sheng Yang 8b341b0639 CLOUDSTACK-6047: Add generic wrapper for group answer needed commands 2014-02-19 19:47:09 -08:00
Sheng Yang 43b414416c CLOUDSTACK-6047: Introduce GroupedAnswer
In some cases, Network Element need multiple answer in one, then introduced e.g.
IpAssocAnswer, SetFirewallAnswer, etc. But in fact they are basically the same.

So introduce GroupedAnswer for them.
2014-02-19 19:47:04 -08:00
Sheng Yang ebf7ee40b1 CLOUDSTACK-6047: Generalize execution in VirtualRoutingResource 2014-02-19 19:46:59 -08:00
Sheng Yang 8fccb8c077 CLOUDSTACK-6047: Separate VR command generation and execution 2014-02-19 19:46:55 -08:00
Sheng Yang 5332f67ae8 CLOUDSTACK-6047: Make sure every commands to VR resource is NetworkElementCommand 2014-02-19 19:46:49 -08:00
Nitin Mehta c171e2c3e4 CLOUDSTACK-4744: Enhance root admin API updateVolume with chaininfo parameter as a part of "Better control over first party objects" feature. 2014-02-19 18:01:18 -08:00
Jessica Wang c93b0967ef CLOUDSTACK-6140: UI - template - detailView - move fields that are used more often to the top. 2014-02-19 15:31:02 -08:00
Brian Federle b01720d936 listView: Fix 'addRow' event being triggered under wrong scope 2014-02-19 14:36:23 -08:00
Hugo Trippaers 5e717cbb89 Fixed on master for jenkins buildslave 2014-02-19 16:21:43 +01:00
Hugo Trippaers fefddc0624 Dynamically detect the current branch and remove the build date from the systemvm name. This makes it easier to push them to the download location automagically. 2014-02-19 09:36:03 +01:00
Antonio Fornie 808c6df6d7 Fix and add some Rest unit and IT tests. Fix by adding a missing type of RoutingConfig.
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-19 09:30:57 +01:00
Girish Shilamkar b70af44ecf CLOUDSTACK-4840: Add missed testcase in previous commit 2014-02-19 11:17:22 +05:30
Nitin Mehta c969aa2595 CLOUDSTACK-6134:
If volume already exists for the vm - register the vm in the inventory and start it.
2014-02-18 18:24:33 -08:00
Hugo Trippaers 24309f6001 Prevent a ClassCastException when the answer is not a SetupAnswer (which happends when something goes wrong while connecting) 2014-02-18 12:37:36 +01:00
Hugo Trippaers f1139848e5 Slight optimization, don't run checkstyle on container or non-java projects. 2014-02-18 12:24:11 +01:00
Hugo Trippaers 594b51c629 Fixup the license headers in the utils project. All files now use the same license header and this is enforced by the maven-license-check plugin. 2014-02-18 12:08:36 +01:00
Ashutosh K 860b020950 CLOUDSTACK-4840: Adding first set of test cases for Multiple IPs per NIC feature 2014-02-18 15:51:57 +05:30
Hugo Trippaers a369647bca Fix license headers 2014-02-18 10:16:31 +01:00
Antonio Fornie 510972abde Nvp and rest refactoring and more tests
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-18 09:51:54 +01:00
John Kinsella dda47dbd67 package.sh: cleaning up formatting
No logic changes made. Tested no syntax errors added.
2014-02-17 10:51:34 -08:00
John Kinsella 9dd57c22b0 CLOUDSTACK-6129: removing hard-coded script names
Replacing whatami with $0 which is how UNIX shell scripts should get the
script's name.

BUG-ID: CLOUDSTACK-6129
Bugfix-for:
Reviewed-by:
Reported-by:
Signed-off-by: John Kinsella <jlk@stratosec.co> 1392660036 -0800
2014-02-17 10:00:36 -08:00
John Kinsella 9f72443bb1 CLOUDSTACK-6123: Ensuring no color in grep output 2014-02-15 21:26:40 -08:00
Sheng Yang 2b1b4352bc Revert "CLOUDSTACK-5779: Fix missing clean up period for VR"
This reverts commit 161e7d93ca.

Duplicate code, bad memory...
2014-02-14 19:40:00 -08:00
Sheng Yang cc8eebeca5 CLOUDSTACK-5779: Fix VR commands which didn't use accessIp to VR 2014-02-14 19:20:00 -08:00
Sheng Yang deb55acd14 CLOUDSTACK-6047: Made VR scripts name to constant string 2014-02-14 18:10:11 -08:00
Sheng Yang 6bde675f87 Remove SetupGuestNetworkAnswer
It's unnecessary and not different from Answer itself.
2014-02-14 18:10:05 -08:00
Sheng Yang 161e7d93ca CLOUDSTACK-5779: Fix missing clean up period for VR 2014-02-14 18:10:00 -08:00
Jessica Wang e1e16a2301 CLOUDSTACK-6120: UI > listView widget > sorting order > fire only one sorting API call(updateXXXXXXX&sortKey=n&id=UUID) for items who have the same UUID.
e.g. An Template/ISO of multiple zones have the same UUID.
2014-02-14 12:55:53 -08:00
Hugo Trippaers 443acac927 Fix functional issue introduced by some findbug changes. 2014-02-14 18:37:47 +01:00
Hugo Trippaers 97bad4f9b3 Fix checkstyle and license issues 2014-02-14 18:37:47 +01:00
Daan Hoogland 15fa2ef8df findbugs: check for system template id == -> equals() 2014-02-14 18:37:47 +01:00
Daan Hoogland 0d7a96526c error message containing array content instead of array 2014-02-14 18:37:47 +01:00
wrodrigues 3199de69fe Fixes on Contrail and Mon InMemory plugins; adding comments about the changes.
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:47 +01:00
Antonio Fornie cbea6d26e8 Fix and test GroupBy SQL query creation
Signed-off-by: Ian Southam <isoutham@schubergphilis.com>
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:46 +01:00
Miguel Ferreira 8649fa005a Fix findbugs findings in cloud-plugin-network-elb
Findings:
    - comparing Longs by reference
    - possible null pointer dereference

Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:46 +01:00
Ian Southam 5a6ad11fa2 findbugs findings
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:46 +01:00
Ian Southam 33c2c87287 Findbugs finding
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:46 +01:00
miguelaferreira 1237bf3222 Fix findbugs findings in cloudstack-service-console-proxy-rdpclient
Findings:
- 32 int shifted by an amount not in range -31..31:
	The shifts by 32 bits don't actually have any effect on the value
	(as shown by the tests)
- possible null pointer dereference
- repeated conditional test
- field only ever set to null
	All other uses of the field were to check if it was null,
	which it was, so it was removed

Other actions:
- Upgrade jUnit to version 4
- Add PowerMock dependency

Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:46 +01:00
Hugo Trippaers ef2ced7564 Fix findbugs findings in cloud-plugin-network-ovs
OvsTunnelManagerImpl.java:456, RC_REF_COMPARISON, Priority: High

Serveral low priority fixes
2014-02-14 18:37:46 +01:00
Hugo Trippaers cc6938e3a8 Findbugs : Fix several "of concern" findings. 2014-02-14 18:37:46 +01:00
Hugo Trippaers 091694ceb2 Findbugs : NP_NULL_PARAM_DEREF_NONVIRTUAL fixed 2014-02-14 18:37:45 +01:00
Hugo Trippaers 26b32141a8 Findbugs : Fixes for several findings
Made a comment on the use of ConcurrentHashMap for _agent
Conflicts:
	engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
2014-02-14 18:37:45 +01:00
Hugo Trippaers 9b841af529 Findbugs : A map can't retrieve an object by index, so get(0) would
return null. Changed to retrieve the first entry in the map.

Removed the ExecutionException try catch, this would prevent the
unittest from giving accurate information on exceptions. Avoid catching
checked exceptions in a unittest, use expected keyword on @Test instead.
2014-02-14 18:37:45 +01:00