etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
22,375 Commits 325 Branches 325 Tags 885 MiB
Commit Graph

22375 Commits

Author SHA1 Message Date
wrodrigues 0ff943337c fixing FindBugs scariest for replaceFirst() method call that does not assign the return value 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:44 +01:00
Sander Botman 16aa73c2c8 Fixing some of the scary bugs possible null pointer: created testSetNicDevIdIfCorrectVifIsNotNull 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-02-14 18:37:44 +01:00
vetrivelc e171cb181c Fixed-Hardcoding-Issues 2014-02-14 07:44:54 -08:00
Likitha Shetty db91e54bf3 CLOUDSTACK-6112. Adding VPC router to a guest network fails with StringIndexOutOfBoundsException. 2014-02-14 17:01:27 +05:30
Marcus Sorensen ce6539bd43 add new devcloud-kvm config 2014-02-09 00:20:01 -07:00
Marcus Sorensen df77c4310a CLOUDSTACK-6103: Pass VM iso information along with 
PrepareForMigrationCommand, so that destination hypervisor can
mount pool. This further exposed an issue for KVM where iso
was not getting cleaned up upon successful migration, fixed as well.
 2014-02-14 00:34:48 -07:00
Brian Federle 63c22a1508 Session expire: show overlay on dialog to prevent clicking in UI 2014-02-13 15:06:09 -08:00
Brian Federle 0ea93d6904 Form dialog UI: Support on cancel action 
If args.cancel is passed to createForm widget, call it when cancel button is
clicked.

Example:

createForm: {
    cancel: function() { ... },
    ...
}
 2014-02-13 14:33:53 -08:00
Daan Hoogland 8e4d020cf8 remove nic with dhcp and tests 
Signed-off-by: Alena Prokharchyk <alena.prokharchyk@citrix.com>
 2014-02-13 10:39:02 -08:00
Jayapal 3136401d40 CLOUDSTACK-6083 corrected firewall rule cidr load issue 2014-02-13 14:42:38 +05:30
Marcus Sorensen b77b55f040 CLOUDSTACK-6089: Use resource tag's key to determine match in 
equals() method for ResourceTagResponse
 2014-02-12 17:00:10 -07:00
Marcus Sorensen 7064972997 Fix someone's broken push due to bad checkstyle (VMwareGuru.java unused imports) 2014-02-12 16:26:33 -07:00
Marcus Sorensen d33798f0d9 CLOUDSTACK-6089: Implement equals() method for ResourceTagResponse 
so that the java Set can properly determine if a ResourceTagResponse
is unique. This ensures we don't get duplicate resource tags showing
up any time a UserVmResponse is crafted (which can be quite often
due to the way the responses are crafted).
 2014-02-12 16:10:48 -07:00
Likitha Shetty 9f597ef130 CLOUDSTACK-6056. Enabling static NAT rule for a portable public IP fails with error "Failed to enable static nat". 
router.extra.public.nics isn't being honoured and so when an ip that is acquired from the additional VLAN range
is being configured it failed.
 2014-02-12 15:53:45 +05:30
Gaurav Aradhye 9174020d9a CLOUDSTACK-6066: Improved migration code to handle scenarios 
according to hypervisor type
 2014-02-12 10:04:39 +05:30
Laszlo Hornyak 351ccf3755 Cleanup in UriUtils.getUpdateUri 
- String instantiation replaced with StringBuilder and empty string constant

Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-02-11 20:44:57 +01:00
Laszlo Hornyak 59364ee9a4 Added test for UriUtils.getUpdateUri 
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-02-11 20:43:49 +01:00
Hugo Trippaers 6c770958f1 Fix unittest issue when you are in a locale that uses comma for decimal separation. 2014-02-11 14:45:45 +01:00
Daan Hoogland ea5f318c9d pass isSourceNat to second ip on the same network 2014-02-11 14:12:00 +01:00
Jayapal 21d2e89dc1 CLOUDSTACK-5966 enable/disable global setting for service monitor in VR 
corrected merged lines in sql file
 2014-02-11 16:24:21 +05:30
Jayapal 11c5574b05 CLOUDSTACK-5966 enable/disable global setting for service monitor in VR 2014-02-11 15:35:02 +05:30
Anshul Gangwar b86d45b003 CLOUDSTACK-6054: Changes for making vmsync work for hyper-v. Made changes to PingCommand and 
StartupCommand to return the state of all vms on the host.
 2014-02-11 12:19:41 +05:30
Darren Shepherd c1cfaa2d1c Contrail Event Interceptor fix 
When project/domains are created,  our plugin code won't get invoked. Our
contrail plugin uses Event infrastructure provided by cloudstack to
receive these events and handle them accordingly. It is must to create
domains/projects before creating a virtual network/vm object in contrail
implementation. Hence our plugin must need a way to get notified about
project/domain events.
 2014-02-10 22:43:38 -07:00
Alena Prokharchyk e0de79b170 Resource metadata: by default, all metadata is set with display=true (meaning that the detail is avaialble for display to the regular user). If admin wants to set a specific detail to be false, he has to specify it explicitly in addResourceDetail command 2014-02-10 12:05:59 -08:00
Brian Federle 13bf1ec5da Disable root disk size field -- not supported in backend 2014-02-10 11:53:07 -08:00
Laszlo Hornyak bdf50f6d24 Remove assertion 
The assertion is built on the assumption that cpuinfo_max_freq is readable by user, which may not be universaly true.
 2014-02-10 19:56:54 +01:00
Laszlo Hornyak ab15653d68 Revert "Temporarily ignore getCpuSpeed test" 
This reverts commit e4a91d3610.
 2014-02-10 19:40:37 +01:00
Jayapal 37c4015d4d CLOUDSTACK-6040: Updated the ip addr validation in create port forwarding 2014-02-10 14:28:33 +05:30
Ashutosh K 899ad17393 CLOUDSTACK-5978: Changes in get_template function to make it 
independent of ostype passed through test case
 2014-02-10 12:38:09 +05:30
Gaurav Aradhye d44c850445 CLOUDSTACK-5959: Fixed cascading failures in portable IP test cases 2014-02-10 12:34:17 +05:30
Devdeep Singh 306ffa0218 CLOUDSTACK-6053: While adding a primary or secondary of type smb the password wasn't 
encoded. This cause createStoragePool or addImageStore command to fail if special
characters were present. Updated the code to pass user, password and domain as part
of details while adding primary or secondary. Also made changes on server side to
handle it.
 2014-02-10 10:29:09 +05:30
Laszlo Hornyak e4a91d3610 Temporarily ignore getCpuSpeed test 
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-02-09 23:13:55 +01:00
Laszlo Hornyak 8ed9162de7 Cleanup in UriUtils.encodeURIComponent 
- StringBuffer replaced with StringBuilder
- nullcheck of tokens array removed since String.split does not return null
- unit test added

Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-02-09 21:57:07 +01:00
Laszlo Hornyak 8d801bffab Replaced String concatenation in loop 
Replaced String concatenation in loop with StringBuilder
Unit test added

Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-02-09 21:27:28 +01:00
Laszlo Hornyak 55b6b6d50b Boolean expression simplification 
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-02-09 19:19:20 +01:00
Laszlo Hornyak d6a6e8dfa5 Minor Boolean expression simplification 
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-02-09 19:05:28 +01:00
Laszlo Hornyak 74a3cb4d5e String concatenation cleanup 
Replaced string concatenation in loop with StringBuilder

Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-02-09 19:01:45 +01:00
Laszlo Hornyak 8e3ae40ba2 removed self-assignment 
It must have been a copy-paste from the other constructor.

Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-02-09 18:46:36 +01:00
Laszlo Hornyak d22b65f45f replaced Integer reference comparsion with .equals 
By default only the Integers between -128..127 are cached (unless overridden by java.lang.Integer.IntegerCache.high system property)
If the inbound or outbound values are higher, the reference comparison won't work.

Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-02-09 18:39:03 +01:00
Laszlo Hornyak 3e3ded75f4 safely close resource with java 1.7 resource block 
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-02-09 18:27:54 +01:00
Laszlo Hornyak 5e4fec9eca removed unused variables 
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-02-09 16:55:27 +01:00
Laszlo Hornyak e52a276104 cleanup in LibvirtComputingResource 
- minor resource leak cleaned up
- cpu-speed reading method extracted
- test added
- logging added in case of exception

Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
 2014-02-09 16:50:10 +01:00
Marcus Sorensen c39ec1eb8f CLOUDSTACK-6062: nic device ids don't always correspond to 
'eth' device numbers, but vpc scripts require it. Now we match
based on mac.
 2014-02-07 14:59:40 -07:00
Brian Federle 3384633834 Instances UI: Fix case where 'list host' is visible for stopped VM 2014-02-07 11:09:18 -08:00
Hugo Trippaers b6db18fae4 Slightly improve the error message to make it clean what the problem actually is 2014-02-07 14:10:02 +01:00
Min Chen bac2c1e5b4 CLOUDSTACK-6049: Give priority to cache stores where data object is 
already there instead of randomly picking one in case there are multiple
cache stores in the scope.
 2014-02-06 17:19:24 -08:00
Jessica Wang 04766c6d47 CLOUDSTACK-6048: UI > Infrastructure > socket > listing > (1) remove LXC, OVM. 
(2) change XenServer label to differentiate XenServer version.
 2014-02-06 16:55:39 -08:00
Min Chen 621276715a CLOUDSTACK-6046:CreateVolume from snapshot is failing with S3 as 
secondary storage and zone-wide primary storage.
 2014-02-06 15:36:26 -08:00
Alena Prokharchyk 782c530685 Revert "CLOUDSTACK-6003 fixing plus refactoring dispatcher" as it breaks API dispatching for commands having Map<String,String> as a parameter type 
This reverts commit 447430c3df.

Conflicts:
	api/src/org/apache/cloudstack/api/BaseCmd.java
	server/src/com/cloud/api/ApiDispatcher.java
	server/src/com/cloud/network/as/AutoScaleManagerImpl.java
	server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
 2014-02-06 14:46:58 -08:00
Brian Federle 916728634b CLOUDSTACK-6044: Primary storage list: truncate long values 2014-02-06 09:50:41 -08:00