etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
29,860 Commits 323 Branches 325 Tags 862 MiB
Commit Graph

29860 Commits

Author SHA1 Message Date
Daan Hoogland 9f02531212 CLOUDSTACK-8537 add check for unique public key and account on ssh keypair registration 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-17 20:47:57 +02:00
Sanjeev Neelarapu 64361d2b71 In case of vm deployment failure vm cleanup was not handled properly Corrected few script issues 
This closes #472
 2015-06-17 17:38:35 +05:30
Erik Weber 5e96d13944 CLOUDSTACK-8455: Use the correct label to display extractable checkbox 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #471
 2015-06-17 13:14:54 +02:00
Daan Hoogland 0952580096 findbugs: try-with-resource to circumvent not handling an exception on 
close
 2015-06-17 12:41:04 +02:00
Daan Hoogland 6da6c5f762 findbugs: log unhandled exception as warning 2015-06-17 12:35:39 +02:00
Sanjeev Neelarapu 17ddb4b100 Skip VPC tests on LXC 
This closes #470
 2015-06-17 15:51:44 +05:30
Rafael da Fonseca 85afa63f24 Re-run travis 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #456
 2015-06-17 12:18:01 +02:00
Rafael da Fonseca b34ad4a22c Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in IpAddressManagerImpl.java Assert isn't used in prod runtime 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-17 12:18:00 +02:00
Rafael da Fonseca 441a13252a Re-run travis 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #454
 2015-06-17 12:15:23 +02:00
Rafael da Fonseca 9f7c379a88 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in RpcProviderImpl.java Assert isn't used in prod runtime 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-17 12:15:23 +02:00
Rafael da Fonseca ce506000cd Re-run travis 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #453
 2015-06-17 12:14:31 +02:00
Rafael da Fonseca 4a333e452a Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in AgentManagerImpl.java Assert isn't used in prod runtime 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-17 12:14:31 +02:00
Rafael da Fonseca acab743aa1 Re-run travis 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #452
 2015-06-17 12:13:46 +02:00
Rafael da Fonseca 380ac0cf24 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in ServiceOfferingVO.java Assert isn't used in prod runtime 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-17 12:13:46 +02:00
Rafael da Fonseca 5a3e57e6b2 Re-run travis 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #450
 2015-06-17 12:12:41 +02:00
Rafael da Fonseca b3d49d9135 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in DataCenterVO.java Assert isn't used in prod runtime 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-17 12:12:41 +02:00
Rafael da Fonseca eaa4eba74d Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in EngineHostVO.java Assert isn't used in prod runtime, null is checked in method 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #448
 2015-06-17 12:10:45 +02:00
Rafael da Fonseca a2129b2940 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VmWorkJobDispatcher.java Assert isn't used in prod runtime, null is properly checked in method 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #446
 2015-06-17 12:08:19 +02:00
Rafael da Fonseca d056c3d279 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VirtualMachineManagerImpl.java Removed two unnecessary null checks as this piece of code will only run if answer is not null, as satified in condition stated in line #1253 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #445
 2015-06-17 12:07:54 +02:00
Sanjay Tripathi d702b63bfb CLOUDSTACK-8569: The latter snapshot export for the same volume will fail is 2 snapshot exports are queued 
This closes #469
 2015-06-17 15:27:03 +05:30
Sanjay Tripathi 47278556f5 CLOUDSTACK-8567 Migrating primary storage causes name_label field to blank. 
This closes #468
 2015-06-17 14:46:51 +05:30
Daan Hoogland 2e792075ee update of the findbugs lib 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #459
 2015-06-17 10:25:33 +02:00
Daan Hoogland 41c1fddaee findbugs: better message and fallback to defaultCharset 2015-06-16 11:57:15 +02:00
Rafael da Fonseca 0851e4e54b Catch encoding exception 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #464
 2015-06-16 11:24:51 +02:00
Rafael da Fonseca 9f2ebdf443 Fix findbugs encoding issue in VmwareStorageProcessor.java Any encoding would do fine as it's just used to generate a UUID. Sticking with UTF-8 for consistency 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #460
 2015-06-16 08:56:33 +02:00
Rafael da Fonseca 9bb920af65 Fix findbugs warning in VmwareStorageManagerImpl.java Any encoding would do fine as it's just used to generate a UUID. Sticking with UTF-8 for consistency 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #461
 2015-06-16 08:53:56 +02:00
Rafael da Fonseca 3d48af41a8 Fix findbugs encoding issue in VmwareResource.java Key file should be UTF-8 encoded in VR 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #462
 2015-06-16 08:51:54 +02:00
Rafael da Fonseca 6dbf476755 Fix css syntax error in cloudstack3.css 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #463
 2015-06-15 23:07:03 +02:00
Rafael da Fonseca 34d097f349 Fix 4 findbugs warnings in JuniperSrxResource Data should be read and written in UTF-8 to the SRX Buffers were being used for reading but not for writing, PrintWriter was auto-flushing and code was explicitly flushing again, causing unnecessary operation to be performed. 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #399
 2015-06-15 21:49:43 +03:00
Wido den Hollander 5fe06962ad Merge branch 'CLOUDSTACK-8560' 2015-06-15 17:58:27 +02:00
Wido den Hollander 4b4c52ea77 CLOUDSTACK-8560: Stat the resulting image after copying from template and return the size 
This way we update the DB with the actual size of the disk after deployment from template
 2015-06-15 17:55:56 +02:00
Rafael da Fonseca ae328a6588 Fix 2 findbugs STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE warnings in BaseCmd.java Dateformat objects are not threadsafe and should be defined as instance variables Both INPUT_FORMAT and NEW_INPUT_FORMAT are only used in ParamProcessWorker.java and doesn't makes it more readable to declare in own class 
Add missing import statement

Removed extraneous file

Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #457
 2015-06-15 16:32:30 +02:00
Wido den Hollander 3e3c11ffca CLOUDSTACK-8559: IP Source spoofing should not be allowed 
We did not verify if the packets leaving an Instance had the correct
source address.

Any IP packet not matching the Instance IP(s) will be dropped
 2015-06-15 15:05:53 +02:00
Rafael da Fonseca 34a791c295 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in UserVmJoinVO.java Assert isn't used in prod runtime 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #455
 2015-06-15 12:28:05 +03:00
Rafael da Fonseca 874aa8d15a Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in HostVO.java Assert isn't used in prod runtime 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #451
 2015-06-15 12:28:00 +03:00
Rafael da Fonseca 0dc25905d2 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in NetworkOrchestrator.java If answer is null, method will throw ConnectionException in line 3016 as satisfied by condition stated in line 3014 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #449
 2015-06-15 12:27:54 +03:00
Rafael da Fonseca 1b79a8e1d6 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in EngineDataCenterVO.java Assert isn't used in prod runtime, null is checked in method 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #447
 2015-06-15 12:24:04 +03:00
Rafael da Fonseca 0f4aac7359 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in AgentManagerImpl.java Assert isn't used in runtime, null is properly checked in method 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #444
 2015-06-15 12:17:53 +03:00
Rafael da Fonseca 117870c121 Fix 3 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warnings in Upgrade410to420.java There was no risk of sql injection here, nor any need to use PreparedStatement, still this fixes the warnings 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #443
 2015-06-15 12:17:51 +03:00
Rafael da Fonseca 4eaa613a0b Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warning in Upgrade30xBase.java There was no risk of sql injection here, nor any need to use PreparedStatement, still, this fixes the warning 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #442
 2015-06-15 12:17:49 +03:00
Rafael da Fonseca 869cc0c9f2 Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warning in Upgrade2214to30.java There was no risk of sql injection here, nor any need to use PreparedStatement, still this fixes the warninG 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #441
 2015-06-15 12:17:47 +03:00
Rafael da Fonseca 7a57ce3334 Fix findbugs NS_DANGEROUS_NON_SHORT_CIRCUIT warning in NetworkServiceImpl.java 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #440
 2015-06-15 12:10:10 +03:00
Rafael da Fonseca 3d1dde7a31 Remove accidental ~ character :) 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #439
 2015-06-15 12:10:08 +03:00
Rafael da Fonseca a670f984d8 Fix findbugs warning HE_EQUALS_USE_HASHCODE in Ip4Address.java When overriding equals(), hashCode() must also be overriden do comply with the directive that equal objects must have equal hashcodes Without this implementation, usage of these kinds of objects in hashmaps for example, will be broken 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-06-15 12:10:07 +03:00
Rafael da Fonseca 1bd3286263 Fix 2 findbugs warnings in ApiResponseHelper.java ints were being boxed just to call .toString() 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #438
 2015-06-15 12:10:04 +03:00
Rafael da Fonseca ea7f4bd254 Fix findbugs warning in NetworkServiceImpl.java Integer was being boxed just to call toString() 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #437
 2015-06-15 12:10:02 +03:00
Rafael da Fonseca a4659d009e Fix findbugs warning in Script.java Unnecessary boxing/unboxing of int value 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #436
 2015-06-15 12:10:00 +03:00
Rafael da Fonseca 14f761a976 Fix findbugs warning in NetUtils.java Unnecessary boxing/unboxing of primitive value 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #435
 2015-06-15 12:09:58 +03:00
Rafael da Fonseca ec280189f4 Fix findbugs warning in ProjectManagerImpl.java Unnecessary boxing/unboxing of primitive value 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #434
 2015-06-15 12:09:57 +03:00
Rafael da Fonseca 4d31ed9342 Fix findbugs warning in NetworkUsageManagerImpl.java Unnecessary boxing/unboxing of long value to create Date 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #433
 2015-06-15 12:09:54 +03:00