1237bf3222
Fix findbugs findings in cloudstack-service-console-proxy-rdpclient
...
Findings:
- 32 int shifted by an amount not in range -31..31:
The shifts by 32 bits don't actually have any effect on the value
(as shown by the tests)
- possible null pointer dereference
- repeated conditional test
- field only ever set to null
All other uses of the field were to check if it was null,
which it was, so it was removed
Other actions:
- Upgrade jUnit to version 4
- Add PowerMock dependency
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:46 +01:00
ef2ced7564
Fix findbugs findings in cloud-plugin-network-ovs
...
OvsTunnelManagerImpl.java:456, RC_REF_COMPARISON, Priority: High
Serveral low priority fixes
2014-02-14 18:37:46 +01:00
cc6938e3a8
Findbugs : Fix several "of concern" findings.
2014-02-14 18:37:46 +01:00
091694ceb2
Findbugs : NP_NULL_PARAM_DEREF_NONVIRTUAL fixed
2014-02-14 18:37:45 +01:00
26b32141a8
Findbugs : Fixes for several findings
...
Made a comment on the use of ConcurrentHashMap for _agent
Conflicts:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
2014-02-14 18:37:45 +01:00
9b841af529
Findbugs : A map can't retrieve an object by index, so get(0) would
...
return null. Changed to retrieve the first entry in the map.
Removed the ExecutionException try catch, this would prevent the
unittest from giving accurate information on exceptions. Avoid catching
checked exceptions in a unittest, use expected keyword on @Test instead.
2014-02-14 18:37:45 +01:00
d4d49578dc
Findbugs : Fix a number of potential NPEs and minor findings
2014-02-14 18:37:45 +01:00
e0a4b7c891
Findbugs - Long equality fix.
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:45 +01:00
39cfc4968c
AJH Findbugs [8] - Added .toString() to enum.
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:45 +01:00
b8c228e151
AJH Findbugs [9] - Added object to map rather than string
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:45 +01:00
f414018a60
adding fix and unit tests for cloud-engine-api scariest
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:44 +01:00
0ff943337c
fixing FindBugs scariest for replaceFirst() method call that does not assign the return value
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:44 +01:00
16aa73c2c8
Fixing some of the scary bugs possible null pointer: created testSetNicDevIdIfCorrectVifIsNotNull
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-14 18:37:44 +01:00
e171cb181c
Fixed-Hardcoding-Issues
2014-02-14 07:44:54 -08:00
db91e54bf3
CLOUDSTACK-6112. Adding VPC router to a guest network fails with StringIndexOutOfBoundsException.
2014-02-14 17:01:27 +05:30
ce6539bd43
add new devcloud-kvm config
2014-02-09 00:20:01 -07:00
df77c4310a
CLOUDSTACK-6103: Pass VM iso information along with
...
PrepareForMigrationCommand, so that destination hypervisor can
mount pool. This further exposed an issue for KVM where iso
was not getting cleaned up upon successful migration, fixed as well.
2014-02-14 00:34:48 -07:00
63c22a1508
Session expire: show overlay on dialog to prevent clicking in UI
2014-02-13 15:06:09 -08:00
0ea93d6904
Form dialog UI: Support on cancel action
...
If args.cancel is passed to createForm widget, call it when cancel button is
clicked.
Example:
createForm: {
cancel: function() { ... },
...
}
2014-02-13 14:33:53 -08:00
8e4d020cf8
remove nic with dhcp and tests
...
Signed-off-by: Alena Prokharchyk <alena.prokharchyk@citrix.com>
2014-02-13 10:39:02 -08:00
3136401d40
CLOUDSTACK-6083 corrected firewall rule cidr load issue
2014-02-13 14:42:38 +05:30
b77b55f040
CLOUDSTACK-6089: Use resource tag's key to determine match in
...
equals() method for ResourceTagResponse
2014-02-12 17:00:10 -07:00
7064972997
Fix someone's broken push due to bad checkstyle (VMwareGuru.java unused imports)
2014-02-12 16:26:33 -07:00
d33798f0d9
CLOUDSTACK-6089: Implement equals() method for ResourceTagResponse
...
so that the java Set can properly determine if a ResourceTagResponse
is unique. This ensures we don't get duplicate resource tags showing
up any time a UserVmResponse is crafted (which can be quite often
due to the way the responses are crafted).
2014-02-12 16:10:48 -07:00
9f597ef130
CLOUDSTACK-6056. Enabling static NAT rule for a portable public IP fails with error "Failed to enable static nat".
...
router.extra.public.nics isn't being honoured and so when an ip that is acquired from the additional VLAN range
is being configured it failed.
2014-02-12 15:53:45 +05:30
9174020d9a
CLOUDSTACK-6066: Improved migration code to handle scenarios
...
according to hypervisor type
2014-02-12 10:04:39 +05:30
351ccf3755
Cleanup in UriUtils.getUpdateUri
...
- String instantiation replaced with StringBuilder and empty string constant
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-02-11 20:44:57 +01:00
59364ee9a4
Added test for UriUtils.getUpdateUri
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-02-11 20:43:49 +01:00
6c770958f1
Fix unittest issue when you are in a locale that uses comma for decimal separation.
2014-02-11 14:45:45 +01:00
ea5f318c9d
pass isSourceNat to second ip on the same network
2014-02-11 14:12:00 +01:00
21d2e89dc1
CLOUDSTACK-5966 enable/disable global setting for service monitor in VR
...
corrected merged lines in sql file
2014-02-11 16:24:21 +05:30
11c5574b05
CLOUDSTACK-5966 enable/disable global setting for service monitor in VR
2014-02-11 15:35:02 +05:30
b86d45b003
CLOUDSTACK-6054: Changes for making vmsync work for hyper-v. Made changes to PingCommand and
...
StartupCommand to return the state of all vms on the host.
2014-02-11 12:19:41 +05:30
c1cfaa2d1c
Contrail Event Interceptor fix
...
When project/domains are created, our plugin code won't get invoked. Our
contrail plugin uses Event infrastructure provided by cloudstack to
receive these events and handle them accordingly. It is must to create
domains/projects before creating a virtual network/vm object in contrail
implementation. Hence our plugin must need a way to get notified about
project/domain events.
2014-02-10 22:43:38 -07:00
e0de79b170
Resource metadata: by default, all metadata is set with display=true (meaning that the detail is avaialble for display to the regular user). If admin wants to set a specific detail to be false, he has to specify it explicitly in addResourceDetail command
2014-02-10 12:05:59 -08:00
13bf1ec5da
Disable root disk size field -- not supported in backend
2014-02-10 11:53:07 -08:00
bdf50f6d24
Remove assertion
...
The assertion is built on the assumption that cpuinfo_max_freq is readable by user, which may not be universaly true.
2014-02-10 19:56:54 +01:00
ab15653d68
Revert "Temporarily ignore getCpuSpeed test"
...
This reverts commit e4a91d3610
2014-02-10 19:40:37 +01:00
37c4015d4d
CLOUDSTACK-6040: Updated the ip addr validation in create port forwarding
2014-02-10 14:28:33 +05:30
899ad17393
CLOUDSTACK-5978: Changes in get_template function to make it
...
independent of ostype passed through test case
2014-02-10 12:38:09 +05:30
d44c850445
CLOUDSTACK-5959: Fixed cascading failures in portable IP test cases
2014-02-10 12:34:17 +05:30
306ffa0218
CLOUDSTACK-6053: While adding a primary or secondary of type smb the password wasn't
...
encoded. This cause createStoragePool or addImageStore command to fail if special
characters were present. Updated the code to pass user, password and domain as part
of details while adding primary or secondary. Also made changes on server side to
handle it.
2014-02-10 10:29:09 +05:30
e4a91d3610
Temporarily ignore getCpuSpeed test
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-02-09 23:13:55 +01:00
8ed9162de7
Cleanup in UriUtils.encodeURIComponent
...
- StringBuffer replaced with StringBuilder
- nullcheck of tokens array removed since String.split does not return null
- unit test added
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-02-09 21:57:07 +01:00
8d801bffab
Replaced String concatenation in loop
...
Replaced String concatenation in loop with StringBuilder
Unit test added
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-02-09 21:27:28 +01:00
55b6b6d50b
Boolean expression simplification
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-02-09 19:19:20 +01:00
d6a6e8dfa5
Minor Boolean expression simplification
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-02-09 19:05:28 +01:00
74a3cb4d5e
String concatenation cleanup
...
Replaced string concatenation in loop with StringBuilder
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-02-09 19:01:45 +01:00
8e3ae40ba2
removed self-assignment
...
It must have been a copy-paste from the other constructor.
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-02-09 18:46:36 +01:00
d22b65f45f
replaced Integer reference comparsion with .equals
...
By default only the Integers between -128..127 are cached (unless overridden by java.lang.Integer.IntegerCache.high system property)
If the inbound or outbound values are higher, the reference comparison won't work.
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-02-09 18:39:03 +01:00
miguelaferreira
Hugo Trippaers
Alex Hitchins
wrodrigues
Sander Botman
vetrivelc
Likitha Shetty
Marcus Sorensen
Brian Federle
Daan Hoogland
Jayapal
Gaurav Aradhye
Laszlo Hornyak
Anshul Gangwar
Darren Shepherd
Alena Prokharchyk
Ashutosh K
Devdeep Singh