etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
27,829 Commits 325 Branches 325 Tags 885 MiB
Commit Graph

1691 Commits

Author SHA1 Message Date
Daan Hoogland 582687fb3f 4.4.4 to 4.5.2 upgrade 
Conflicts:
	engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #529
 2015-06-26 00:07:44 +02:00
Daan Hoogland 8a8849354c findbugs: masking fields removed 2015-06-24 12:24:12 +02:00
wilderrodrigues 5557ad5588 Offer a getDurationInMillis() method in the Profiler utility class 
- New implementation uses nanoseconds. Due to that, the places where the Profiler is used as a Monitor and/or
     a stopwatch will suffer with the difference in the return
   - Also added a getDuration(), which returns the time in nanoseconds in case someone wants to use it instead
   - Added an extra test to check if the getDuration() works fine with nanoseconds
   - Fixed the test that checks the time in milliseconds: I added an error margin to cover the test better

Signed-off-by: Daan Hoogland <daan@onecht.net>
 2015-06-24 09:36:40 +02:00
Rafael da Fonseca 53e42fb45e Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warning in Upgrade410to420.java 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #505
 2015-06-22 10:55:29 +02:00
Rafael da Fonseca 58eac0b49d Fix 2 more findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in Upgrade218to22.java 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #500
 2015-06-22 10:49:35 +02:00
Rafael da Fonseca f038a740a5 Fix 2 findbugs occurences of DM_BOXED_PRIMITIVE_FOR_PARSING in Upgrade218to22.java 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #499
 2015-06-22 10:48:49 +02:00
Daan Hoogland c45c9bfeef findbugs UC useless condition not sure what findbugs means yet, but this should at least turn both warnings into one. 
Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #490
 2015-06-19 15:53:09 +02:00
Sanjay Tripathi 84d4c9bf4c Recurring snapshot issue post upgrade from 3.0.7 to 4.5 
This closes #486
 2015-06-19 16:03:42 +05:30
Rafael da Fonseca b84093f691 Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warning in PrimaryDataStoreDaoImpl.java 
Remove trailing spaces that checkstyle complained about

Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #474
 2015-06-17 22:46:58 +02:00
Rafael da Fonseca 1407033cc2 Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warning in UserVmDaoImpl.java detail field was vulnerable 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #473
 2015-06-17 22:38:19 +02:00
Daan Hoogland 9f02531212 CLOUDSTACK-8537 add check for unique public key and account on ssh keypair registration 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-17 20:47:57 +02:00
Rafael da Fonseca ce506000cd Re-run travis 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #453
 2015-06-17 12:14:31 +02:00
Rafael da Fonseca 4a333e452a Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in AgentManagerImpl.java Assert isn't used in prod runtime 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-17 12:14:31 +02:00
Rafael da Fonseca acab743aa1 Re-run travis 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #452
 2015-06-17 12:13:46 +02:00
Rafael da Fonseca 380ac0cf24 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in ServiceOfferingVO.java Assert isn't used in prod runtime 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-17 12:13:46 +02:00
Rafael da Fonseca 5a3e57e6b2 Re-run travis 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #450
 2015-06-17 12:12:41 +02:00
Rafael da Fonseca b3d49d9135 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in DataCenterVO.java Assert isn't used in prod runtime 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-17 12:12:41 +02:00
Rafael da Fonseca eaa4eba74d Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in EngineHostVO.java Assert isn't used in prod runtime, null is checked in method 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #448
 2015-06-17 12:10:45 +02:00
Rafael da Fonseca a2129b2940 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VmWorkJobDispatcher.java Assert isn't used in prod runtime, null is properly checked in method 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #446
 2015-06-17 12:08:19 +02:00
Rafael da Fonseca d056c3d279 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VirtualMachineManagerImpl.java Removed two unnecessary null checks as this piece of code will only run if answer is not null, as satified in condition stated in line #1253 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #445
 2015-06-17 12:07:54 +02:00
Rafael da Fonseca 874aa8d15a Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in HostVO.java Assert isn't used in prod runtime 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #451
 2015-06-15 12:28:00 +03:00
Rafael da Fonseca 0dc25905d2 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in NetworkOrchestrator.java If answer is null, method will throw ConnectionException in line 3016 as satisfied by condition stated in line 3014 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #449
 2015-06-15 12:27:54 +03:00
Rafael da Fonseca 1b79a8e1d6 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in EngineDataCenterVO.java Assert isn't used in prod runtime, null is checked in method 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #447
 2015-06-15 12:24:04 +03:00
Rafael da Fonseca 0f4aac7359 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in AgentManagerImpl.java Assert isn't used in runtime, null is properly checked in method 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #444
 2015-06-15 12:17:53 +03:00
Rafael da Fonseca 117870c121 Fix 3 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warnings in Upgrade410to420.java There was no risk of sql injection here, nor any need to use PreparedStatement, still this fixes the warnings 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #443
 2015-06-15 12:17:51 +03:00
Rafael da Fonseca 4eaa613a0b Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warning in Upgrade30xBase.java There was no risk of sql injection here, nor any need to use PreparedStatement, still, this fixes the warning 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #442
 2015-06-15 12:17:49 +03:00
Rafael da Fonseca 869cc0c9f2 Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warning in Upgrade2214to30.java There was no risk of sql injection here, nor any need to use PreparedStatement, still this fixes the warninG 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #441
 2015-06-15 12:17:47 +03:00
Rafael da Fonseca e409bc3e60 Fix findbugs warning in Upgrade421to430.java Was creating Integer to assign to int 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #419
 2015-06-15 12:09:27 +03:00
Rafael da Fonseca a299674831 Fix 4 findbugs warnings in Upgrade218to22.java Was creating boxed Integers when only int is required 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #418
 2015-06-15 12:09:26 +03:00
wilderrodrigues c3b4c7a9cf Coverity issue 1116509 - Assigning the the new returned ResultSet to the rs variable in order to get it closed in the finally block 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-04 12:34:04 +02:00
wilderrodrigues abe0990259 Formatting the code - Adding final modifier and indenting the code 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-04 12:34:04 +02:00
Rajani Karuturi b31b8425df CLOUDSTACK-8525: NPE while updating the state of the volume after deletion 
The volume is already deleted (may be by the cleanup thread) and hence
the NPE. Added a not null check for the volumevo and returning false
from the state transition

This closes #321
 2015-06-03 11:45:02 +05:30
Rohit Yadav 6c1dde8f86 schema: Encode URL safe random vnc password string 
/+= may break on some environments, url safe encoded passwords will have -_,
characters which are more acceptable

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 19cc5eb9e6)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-06-01 14:23:42 +02:00
Jayapal 69ea932897 CLOUDSTACK-8324: Config drive changes for xenserver 2015-05-28 15:51:50 +05:30
Jayapal e407986183 CLOUDSTACK-8324: Added config drive support for xenserver 2015-05-28 15:51:50 +05:30
Jayapal 733ac2b728 CLOUDSTACK-8324: Added vm ip fetch logic 2015-05-28 15:42:08 +05:30
Jayapal 70934e8c1a CLOUDSTACK-8324: Skip ip allocation for external dhcp 2015-05-28 15:42:07 +05:30
Milamber 87d4086a64 CLOUDSTACK-6181 Specify GB for the value of rootdisksize parameter. Add some Bytes/GB for log or exception messages. Fix Gb->GB. 2015-05-23 17:52:21 +01:00
Koushik Das 1cd2e9bc44 Merge branch 'CLOUDSTACK-8301' of https://github.com/apache/cloudstack 2015-05-22 09:47:59 +05:30
Abhinandan Prateek 4222364bea CLOUDSTACK-8491: Host maintenance fails if a vm on it is running a custom service offering VM 2015-05-21 10:56:33 +05:30
Koushik Das d423df66cc CLOUDSTACK-8301: Enable configuring local storage use for system VMs at zone level 
Code cleanup, added helper method to get default system offering based on "system.vm.use.local.storage".
 2015-05-19 21:32:14 +05:30
Koushik Das 3f7e31ed05 CLOUDSTACK-8301: Enable configuring local storage use for system VMs at zone level 
Made system.vm.use.local.storage a zone level configuration.
 2015-05-19 21:32:14 +05:30
Devdeep Singh a99c9d0e68 Implementation for the ability to disable a storage pool for provisioning 
... of new volumes. Following changes are implemented 1. Disable or enable a pool with the
updateStoragePool api. A new 'enabled' parameter added for the same. 2. When a
pool is disabled the state of the pool is updated to 'Disabled' in the db. On
enabling it is updated back to 'Up'. Alert is raised when a pool is disabled or
enabled. 3. Updated other storage providers to also honour the disabled state.
4. A disabled pool is skipped by allocators for provisioing of new volumes. 5.
Since the allocators skip a disabled pool for provisioning of volumes, the
volumes are also not listed as a destination for volume migration.

FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Disabling+Storage+Pool+for+Provisioning

This closes #257

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-05-19 11:16:49 +01:00
Koushik Das 5f66679df3 CLOUDSTACK-8452: Exclude non-routing hosts from getting rebalanced as part of agent LB 
For agent LB, only routing hosts needs to be considered
 2015-05-08 10:48:39 +05:30
Mike Tutkowski ac2bccd2a2 Removing unused imports 2015-05-07 13:52:25 -06:00
Daan Hoogland 1c408dec37 Merge branch '4.5' after 4.5.1 vote passes 2015-05-07 16:03:26 +02:00
Rohit Yadav 4ba72a877c Updating pom.xml version numbers for release 4.5.2-SNAPSHOT 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-05-07 15:33:01 +02:00
Rohit Yadav 069aa4e5f3 CLOUDSTACK-8433: remove awsapi db usage and add upgrade cleanup path 
- Removes awsapi db properties usage across codebase
- Removes references from spring xmls, test cases and TransactionLegacy
- Adds sql command to drop database cloudbridge in schema-451to460-cleanup.sql

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-05-06 15:22:04 +02:00
Rohit Yadav 0eb4eb2370 Updating pom.xml version numbers for release 4.5.1 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-05-04 12:17:03 +02:00
Koushik Das 23bde8ea7a CLOUDSTACK-8438: Proper enforcement of hypervisor capability "max. guest limit" 
VMs in transition states - Starting, Stopping, Migrating - are also taken into account for enforcing "max. guest limit"

(cherry picked from commit 3100fc1554)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-05-03 15:56:10 +02:00