Commit Graph

23203 Commits

Author SHA1 Message Date
Prachi Damle 2e5b529157 CLOUDSTACK-6560: IAM - Admin user is denied permission to create Egress rule for a user's network
Changes:
- CS 4.3 handled Network entity in two ways:
a) Specified "UseNetwork" access and did a strict check w.r.t who can use this network. Regular users and Domain Admin went through the strict check. Root admin got access always.
b) Specified "null" access and that meant admins can access this network for the calling API that passes null access.

- Fixing CS 4.4 IAM to handle this behavior:
a) "UseNetwork" is mapped to "UseEntry" and IAM check will be done only for domain admin and regular users when this access is specified. Root Admin is grated access.
b) If "null" access is specified, root and domain admin both are granted access. Regular users still go through IAM.
2014-05-01 16:07:52 -07:00
Prachi Damle e89c628843 CLOUDSTACK-6558 IAM - Admin user is able to deploy VM in a regular user's Security Group.
Changes:
- Even for SecurityGroup, go through IAM to do permission checks for all type of accounts
2014-05-01 16:07:50 -07:00
Brian Federle 430d14b676 CLOUDSTACK-6438: Filter out existing IPs in dropdown 2014-05-01 15:49:37 -07:00
Brian Federle 7daabf6515 CLOUDSTACK-6438: WIP: Add filtering to check against existing IPs 2014-05-01 15:49:33 -07:00
Brian Federle 0b03609c45 CLOUDSTACK-6438: WIP: If VM has additional IPs, keep showing in add screen 2014-05-01 15:49:28 -07:00
Min Chen 6435b261de CLOUDSTACK-6556: Deploy VM failing with error "does
not have permission to access resource Ntwk".
2014-05-01 15:07:36 -07:00
Min Chen f0edfc7ac5 CLOUDSTACK-6535: IAM:MS:API createVMSnapshot doesn't preserve access
rights.
2014-05-01 12:13:59 -07:00
Wido den Hollander 355f1a2a75 CLOUDSTACK-4549: Do not force RBD snapshot backups to RAW format
Since we use qemu-img to copy from RBD to Secondary Storage we no
longer have to force to RAW images, but can stick with QCOW2

When the snapshot backups are QCOW2 format they can easily be deployed
again when restoring from a backup

Conflicts:

	plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
2014-05-01 21:04:04 +02:00
Min Chen 4415aee1e9 CLOUDSTACK-6556: [Automation] Deploy VM failing with error "does not
have permission to access resource Ntwk".
2014-05-01 11:33:41 -07:00
Min Chen ef2616bfda CLOUDSTACK-6443: [Automation] Two Test Cases failed on "test_volumes.py"
- AttributeError: VirtualMachine instance has no attribute 'hostid'.
2014-05-01 10:05:16 -07:00
Daan Hoogland 9c2768756c CLOUDSTACK-6549: ommission due to insufficient tests in CLOUDSTACK-6231 2014-05-01 09:42:54 +02:00
Prachi Damle e14c2ec724 CLOUDSTACK-6517: IAM - Admin is allowed to create PortFowarding rule for a regular user, when admin does not have " UseEntry" permission for IpAddress.
Changes:
- IAM was applying ordering on accessTypes. Thus if an account had Operate, he got USe access as well. So even if IAM schema did not have 'UseEntry" permission for IpAddress, some other 'OperateEntry' permission on IpAddress was letting this operation go through.
- Fixed IAM to NOT do ordering of access types anymore. IAm will perform strict accessType check only.
- This fix is needed so that admin does not get permission to USE resources from other account just becase he has OPERATE access on those resources due to some other APIs.

- However due to this fix, we break backwards compatibilty with CS 4.3.
- CS 4.3 allowed root admin to do the createPF operation for a user by passing in networkId of the user.
- Same was the case for domain admins within their domains
- Why this worked was due to CS 4.3 simply returning true for root admin/domain admin

- So to maintain backwards compatibilty, we are adding the logic to return "true" for root admin and domain admin just like CS 4.3.
- Exception is: For Network, AffinityGroup and Templates, we still call IAM even for root admin/domain admin, since thats what CS 4.3 did. Just for these 3 resource_types, it used to perform access checks even for root admin/domain admin.
2014-04-30 11:58:21 -07:00
Min Chen 42b803dd4b CLOUDSTACK-6502:Remove trailing whitespaces. 2014-04-30 10:20:12 -07:00
Min Chen 412793f9b4 CLOUDSTACK-6513: remove commented code. 2014-04-30 10:03:06 -07:00
Daan Hoogland 3852afa717 CLOUDSTACK-6231: network acl item cidrs loaded from a seperate table 2014-04-30 14:55:56 +02:00
Min Chen 3af2f6d141 CLOUDSTACK-6513: templateFilter=shared should not show self-owned
template.
2014-04-29 19:02:57 -07:00
Min Chen 7309146f9f CLOUDSTACK-6513: Optimize code by removing deprecated utility to
QueryManagerImpl as private method just used for listTemplates and
listAffinityGroups to avoid misuse by new list APIs.
2014-04-29 18:33:10 -07:00
Min Chen 0767060b1f CLOUDSTACK-6532:Affinity Groups - As admin user, not able to list all
affinity groups available for regular users by passing account and
domainId paramater. This is to revert IAM way of implementing
listAffinityGroupsCmd, will bring it back when we have implemented real
impersonation.
2014-04-29 18:08:00 -07:00
Min Chen b2b59ed83a CLOUDSTACK-6533: IAM - Templates - Public templates do not have
permissions to be used by ROOT group.
2014-04-29 11:49:16 -07:00
Anthony Xu 1b74f3f3c8 disable XS event 2014-04-29 11:48:12 -07:00
Rajesh Battala d55bf1efae Removed Epoch tag/number from the cloud.spec to fix the rpm installation of Management Server, Agent and awsapi 2014-04-29 17:19:39 +05:30
Rajani Karuturi 08ec6ebdda Fixed CLOUDSTACK-6509 Cannot import multiple LDAP/AD users into a cloudstack account
Conflicts:
	api/src/com/cloud/user/AccountService.java
	plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
	plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java

Signed-off-by: Koushik Das <koushik@apache.org>
2014-04-29 14:38:32 +05:30
Mike Tutkowski 934056097a CLOUDSTACK-6170 Needed to add logic for XS 6.2 + XS62ESP1 + XS62ESP1004 2014-04-28 23:31:08 -06:00
Koushik Das de114f5548 CLOUDSTACK-4371: [Performance Testing] Basic zone with 20K Hosts, management server restart leaves the hosts in disconnected state for very long time
Fixed simulator code to handle local storage during host reconnect
2014-04-29 09:59:33 +05:30
Nitin Mehta 3e7ea4e8d9 CLOUDSTACK-6530: Populate the first class entities in the context to be available for publishing more information for the event bus, checking the displayable property etc. 2014-04-28 18:16:13 -07:00
Daan Hoogland 69add34ad0 CLOUDSTACK-6485: private gateway network should not be associated with vpc
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-04-28 14:55:06 +02:00
Sanjay Tripathi 6f7f9996f2 CLOUDSTACK-6480: Creating Service Offering with Implict Dedication planner
fails with message:  "Please specify the pciDevice and vgpuType correctly".
2014-04-28 11:24:41 +05:30
Sanjay Tripathi 5a49bb2db7 Fix log messages for vgpu creation. 2014-04-26 17:26:37 +05:30
Min Chen a4cb8d1146 CLOUDSTACK-6513: IAM - Templates - When templates are listed with
templatefilter="shared" is used , we see public templates also being
included in the list. This commit reverts listTemplates behavior to 4.3
old logic without using consistent interpretation of list parameters
adopted in new IAM model.
2014-04-25 17:25:16 -07:00
Amogh Vasekar 7694bee83f In 4.3, SSL was turned off by default.
However, for SSVM, the value from configuration server overrides the default in Config.java. Work around is to change in global properties.

Local testing, checking a fresh install has the above property false by default.

Signed-off-by: Nitin Mehta<nitin.mehta@citrix.com>
(cherry picked from commit 05802004e2)
2014-04-25 14:50:37 -07:00
Min Chen 092b4be8d9 CLOUDSTACK-6512:IAM - Not able to list shared networks in the Vm
deployment flow. This commit is to revert
ec5ee761d9 to still use old logic for
listNetworks to keep old behavior instead of new IAM model.
2014-04-25 14:35:38 -07:00
Mike Tutkowski 6dfa742eb8 CLOUDSTACK-6170 Updated logic to more accurately calculate how much space is currently allocated for a managed storage pool 2014-04-25 12:30:38 -06:00
Murali Reddy a176576c34 CLOUDSTACK-6431: OVS migrating vm to a new host added to the cluster
does not create gre tunnel port on the new host

ensure OveElement gets a chance to setup tunnel network on the host
before VM is migrated.
2014-04-25 17:21:30 +05:30
Sanjay Tripathi 0f755ee4fc CLOUDSTACK-6452: Failed to Live Migrate VM across clusters with Xenserver 6.2.5. 2014-04-25 16:38:03 +05:30
Murali Reddy 380998aa4f CLOUDSTACK-6507: ensure sequence numbers are honoured while processing
OvsVpcPhysicalTopologyConfigCommand and OvsVpcRoutingPolicyConfigCommand

fix ensures only latest updates are applied (new openflow rules) to the
bidge enabled for distributed routing.
2014-04-25 14:46:25 +05:30
Murali Reddy 771d1346d1 CLOUDSTACK-6505: XenServer bridge for the OVS tunnel network gets reset
on the hosts in the xenserver cluster

this fix ensures that brige is created only once so that openflow rules
configured on the bridge are not lost.
2014-04-25 14:46:25 +05:30
Anshul Gangwar 66f8e0e1b5 CLOUDSTACK-6504: removed warnings coming in building hyper-v agent code 2014-04-25 14:08:41 +05:30
Anshul Gangwar 4a85e22264 CLOUDSTACK-6470: while stopping vm in hyper-v, now we are first trying to shutdown it gracefully before turning it off forcefully 2014-04-25 14:05:41 +05:30
Min Chen 4f2a20f7b3 CLOUDSTACK-6502:IAMGroup.list and IAMPolicy.list in marvin base.py are
not working.
2014-04-24 18:20:13 -07:00
Min Chen 5728ed33e9 CLOUDSTACK-6501:IAM - DomainAdmin - When listVirtualMachines is used
with listall=true and account and domainId , Vms owned by the account
account is not listed.
2014-04-24 18:14:25 -07:00
Nitin Mehta b8a1cbe81a CLOUDSTACK-6499:
Made changes so that uploading custom certificate works for ssvm.
    1. Reboot ssvm only when private key is passed meaning the server cert is passed. This is because while uploading the server cert is the last to be uploaded. And we want to propagate the entire chain once uploading is done.
    2. Change the SecStorageSetupCommand sent to ssvm so that it also carries the root cert apart from having the chain and the server cert and key.
    3. Change ssvm agent code to be able to configure root cert to the java key store.
    4. Change ssvm configure ssl script to insert the chain certs correctly.
    5. Fix order of chain certificates for apache webserver in SSVM
    6. Remove double encoding and decoding for uploadCustomCertificate API from UI and server code respectively, so that API call without UI works fine
    7. Java 1.7 - disable using SNI since copyTemplate doesnt work for SSL.
2014-04-24 17:20:41 -07:00
Brian Federle beb26237bc Create form: Store passed JSON object in select options, for plugin use 2014-04-24 15:07:41 -07:00
Gabor Apati-Nagy 83e5ea9812 CLOUDSTACK-6255
UI for supporting region level VPC, distributed routing enabled VPC and
stretched L2 neworks
2014-04-24 15:06:21 -07:00
Alena Prokharchyk 98d9b8fc3f CLOUDSTACK-6436: listResourceDetails - don't return entries set with display=false, by default 2014-04-24 14:32:10 -07:00
Mike Tutkowski a542b6fd82 CLOUDSTACK-6170 (VMware root-disk support for managed storage) 2014-04-24 15:02:11 -06:00
Prachi Damle 81adee346c CLOUDSTACK-6458: IAM - When a domain is deleted , the group created for this domian is not removed.
Changes:
- When domain is deleted, IAM service will not find it unless it selects using 'removed' column
2014-04-24 12:42:40 -07:00
Prachi Damle bc3a8378d0 CLOUDSTACK-6458: IAM - When a domain is deleted , the group created for this domian is not removed.
Changes:
- When domain is deleted or is removed during account cleanup, send message to IAM to remove the domain group
2014-04-24 11:39:26 -07:00
Brian Federle 38c99ffdab List view, dialog VM select: Widen name field to better fit IP subselect box 2014-04-24 11:34:04 -07:00
Rajani Karuturi f7f84fba89 checkstyle fix for commit 8e2e8e5e8a
improved ldap logging. added stacktrace in debug level incase of exceptions.

Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2014-04-24 17:33:52 +05:30
Rajesh Battala ce3b5814a8 CLOUDSTACK-6338 [Automation] Failed to NetScaler Device with error 2014-04-24 17:15:04 +05:30