53e42fb45e
Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warning in Upgrade410to420.java
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #505
2015-06-22 10:55:29 +02:00
58eac0b49d
Fix 2 more findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in Upgrade218to22.java
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #500
2015-06-22 10:49:35 +02:00
f038a740a5
Fix 2 findbugs occurences of DM_BOXED_PRIMITIVE_FOR_PARSING in Upgrade218to22.java
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #499
2015-06-22 10:48:49 +02:00
c45c9bfeef
findbugs UC useless condition not sure what findbugs means yet, but this should at least turn both warnings into one.
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
This closes #490
2015-06-19 15:53:09 +02:00
84d4c9bf4c
Recurring snapshot issue post upgrade from 3.0.7 to 4.5
...
This closes #486
2015-06-19 16:03:42 +05:30
b84093f691
Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warning in PrimaryDataStoreDaoImpl.java
...
Remove trailing spaces that checkstyle complained about
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #474
2015-06-17 22:46:58 +02:00
1407033cc2
Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warning in UserVmDaoImpl.java detail field was vulnerable
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #473
2015-06-17 22:38:19 +02:00
9f02531212
CLOUDSTACK-8537 add check for unique public key and account on ssh keypair registration
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-17 20:47:57 +02:00
ce506000cd
Re-run travis
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #453
2015-06-17 12:14:31 +02:00
4a333e452a
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in AgentManagerImpl.java Assert isn't used in prod runtime
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-17 12:14:31 +02:00
acab743aa1
Re-run travis
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #452
2015-06-17 12:13:46 +02:00
380ac0cf24
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in ServiceOfferingVO.java Assert isn't used in prod runtime
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-17 12:13:46 +02:00
5a3e57e6b2
Re-run travis
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #450
2015-06-17 12:12:41 +02:00
b3d49d9135
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in DataCenterVO.java Assert isn't used in prod runtime
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-17 12:12:41 +02:00
eaa4eba74d
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in EngineHostVO.java Assert isn't used in prod runtime, null is checked in method
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #448
2015-06-17 12:10:45 +02:00
a2129b2940
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VmWorkJobDispatcher.java Assert isn't used in prod runtime, null is properly checked in method
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #446
2015-06-17 12:08:19 +02:00
d056c3d279
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VirtualMachineManagerImpl.java Removed two unnecessary null checks as this piece of code will only run if answer is not null, as satified in condition stated in line #1253
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #445
2015-06-17 12:07:54 +02:00
874aa8d15a
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in HostVO.java Assert isn't used in prod runtime
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #451
2015-06-15 12:28:00 +03:00
0dc25905d2
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in NetworkOrchestrator.java If answer is null, method will throw ConnectionException in line 3016 as satisfied by condition stated in line 3014
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #449
2015-06-15 12:27:54 +03:00
1b79a8e1d6
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in EngineDataCenterVO.java Assert isn't used in prod runtime, null is checked in method
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #447
2015-06-15 12:24:04 +03:00
0f4aac7359
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in AgentManagerImpl.java Assert isn't used in runtime, null is properly checked in method
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #444
2015-06-15 12:17:53 +03:00
117870c121
Fix 3 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warnings in Upgrade410to420.java There was no risk of sql injection here, nor any need to use PreparedStatement, still this fixes the warnings
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #443
2015-06-15 12:17:51 +03:00
4eaa613a0b
Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warning in Upgrade30xBase.java There was no risk of sql injection here, nor any need to use PreparedStatement, still, this fixes the warning
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #442
2015-06-15 12:17:49 +03:00
869cc0c9f2
Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warning in Upgrade2214to30.java There was no risk of sql injection here, nor any need to use PreparedStatement, still this fixes the warninG
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #441
2015-06-15 12:17:47 +03:00
e409bc3e60
Fix findbugs warning in Upgrade421to430.java Was creating Integer to assign to int
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #419
2015-06-15 12:09:27 +03:00
a299674831
Fix 4 findbugs warnings in Upgrade218to22.java Was creating boxed Integers when only int is required
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #418
2015-06-15 12:09:26 +03:00
c3b4c7a9cf
Coverity issue 1116509 - Assigning the the new returned ResultSet to the rs variable in order to get it closed in the finally block
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-04 12:34:04 +02:00
abe0990259
Formatting the code - Adding final modifier and indenting the code
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-04 12:34:04 +02:00
b31b8425df
CLOUDSTACK-8525: NPE while updating the state of the volume after deletion
...
The volume is already deleted (may be by the cleanup thread) and hence
the NPE. Added a not null check for the volumevo and returning false
from the state transition
This closes #321
2015-06-03 11:45:02 +05:30
6c1dde8f86
schema: Encode URL safe random vnc password string
...
/+= may break on some environments, url safe encoded passwords will have -_,
characters which are more acceptable
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 19cc5eb9e6
2015-06-01 14:23:42 +02:00
69ea932897
CLOUDSTACK-8324: Config drive changes for xenserver
2015-05-28 15:51:50 +05:30
e407986183
CLOUDSTACK-8324: Added config drive support for xenserver
2015-05-28 15:51:50 +05:30
733ac2b728
CLOUDSTACK-8324: Added vm ip fetch logic
2015-05-28 15:42:08 +05:30
70934e8c1a
CLOUDSTACK-8324: Skip ip allocation for external dhcp
2015-05-28 15:42:07 +05:30
87d4086a64
CLOUDSTACK-6181 Specify GB for the value of rootdisksize parameter. Add some Bytes/GB for log or exception messages. Fix Gb->GB.
2015-05-23 17:52:21 +01:00
1cd2e9bc44
Merge branch 'CLOUDSTACK-8301' of https://github.com/apache/cloudstack
2015-05-22 09:47:59 +05:30
4222364bea
CLOUDSTACK-8491: Host maintenance fails if a vm on it is running a custom service offering VM
2015-05-21 10:56:33 +05:30
d423df66cc
CLOUDSTACK-8301: Enable configuring local storage use for system VMs at zone level
...
Code cleanup, added helper method to get default system offering based on "system.vm.use.local.storage".
2015-05-19 21:32:14 +05:30
3f7e31ed05
CLOUDSTACK-8301: Enable configuring local storage use for system VMs at zone level
...
Made system.vm.use.local.storage a zone level configuration.
2015-05-19 21:32:14 +05:30
a99c9d0e68
Implementation for the ability to disable a storage pool for provisioning
...
... of new volumes. Following changes are implemented 1. Disable or enable a pool with the
updateStoragePool api. A new 'enabled' parameter added for the same. 2. When a
pool is disabled the state of the pool is updated to 'Disabled' in the db. On
enabling it is updated back to 'Up'. Alert is raised when a pool is disabled or
enabled. 3. Updated other storage providers to also honour the disabled state.
4. A disabled pool is skipped by allocators for provisioing of new volumes. 5.
Since the allocators skip a disabled pool for provisioning of volumes, the
volumes are also not listed as a destination for volume migration.
FS: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Disabling+Storage+Pool+for+Provisioning
This closes #257
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-05-19 11:16:49 +01:00
5f66679df3
CLOUDSTACK-8452: Exclude non-routing hosts from getting rebalanced as part of agent LB
...
For agent LB, only routing hosts needs to be considered
2015-05-08 10:48:39 +05:30
ac2bccd2a2
Removing unused imports
2015-05-07 13:52:25 -06:00
1c408dec37
Merge branch '4.5' after 4.5.1 vote passes
2015-05-07 16:03:26 +02:00
4ba72a877c
Updating pom.xml version numbers for release 4.5.2-SNAPSHOT
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-05-07 15:33:01 +02:00
069aa4e5f3
CLOUDSTACK-8433: remove awsapi db usage and add upgrade cleanup path
...
- Removes awsapi db properties usage across codebase
- Removes references from spring xmls, test cases and TransactionLegacy
- Adds sql command to drop database cloudbridge in schema-451to460-cleanup.sql
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-05-06 15:22:04 +02:00
0eb4eb2370
Updating pom.xml version numbers for release 4.5.1
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-05-04 12:17:03 +02:00
23bde8ea7a
CLOUDSTACK-8438: Proper enforcement of hypervisor capability "max. guest limit"
...
VMs in transition states - Starting, Stopping, Migrating - are also taken into account for enforcing "max. guest limit"
(cherry picked from commit 3100fc1554
2015-05-03 15:56:10 +02:00
3100fc1554
CLOUDSTACK-8438: Proper enforcement of hypervisor capability "max. guest limit"
...
VMs in transition states - Starting, Stopping, Migrating - are also taken into account for enforcing "max. guest limit"
2015-05-01 12:49:56 +05:30
866cc41145
CLOUDSTACK-8423: [Xenserver] Improved the performance for processing of ClusterVMMetaDataSync command which can cause slowness in DB if there are huge number of VMs
...
this closes #204
2015-04-30 14:44:36 +05:30
2133c302f4
CLOUDSTACK-8413: Fixed resource tags on disk are lost when migrate to another storage
...
During cold volume migration we are duplicating volume entry in volumes table.
When migration is complete, we update the uuid of new entry and expunge the older entry.
This results in removal of resource tags on volume as its resource id still pointing to older volume.
As part of fix while updating uuid for volume, we are updating resource_id for tags also.
This closes #194
2015-04-30 14:34:20 +05:30
6c649ce3ae
CLOUDSTACK-8411. Unable to delete an uploaded volume after CCP fails to attach the volume to a VM.
...
Correctly update the status of an uploaded volume upon failure to attach it to a VM.
(cherry picked from commit 10a106f5d8
2015-04-29 16:50:40 +02:00
e1db982d6b
CLOUDSTACK-8410. ESXi host stuck disconnects frequently.
...
During ping task, while scanning and updating status of all VMs on the host that are stuck in a transitional state
and are missing from the power report, do so only for VMs that are not removed.
(cherry picked from commit de7173a0ed
2015-04-29 16:50:40 +02:00
0b8355920e
Merge branch 'volume-upload' into master
...
This closes #206
2015-04-29 11:12:53 +05:30
10a106f5d8
CLOUDSTACK-8411. Unable to delete an uploaded volume after CCP fails to attach the volume to a VM.
...
Correctly update the status of an uploaded volume upon failure to attach it to a VM.
2015-04-28 09:52:06 +05:30
de7173a0ed
CLOUDSTACK-8410. ESXi host stuck disconnects frequently.
...
During ping task, while scanning and updating status of all VMs on the host that are stuck in a transitional state
and are missing from the power report, do so only for VMs that are not removed.
2015-04-28 09:15:22 +05:30
86943da26e
Fixed few coverity issues
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
(cherry picked from commit 0a9742f914
2015-04-27 14:43:48 +02:00
bc399b981f
volume-upload: If SSVM is destroyed and started, then partially uploaded volumes/templates remain in
...
inconsistent state (NotUploaded or UploadInProgress) and doesn't transition to any terminal
state (Uploaded, Uploaded). As a result these volumes/templates cannot be removed. Fix is to handle such
volume/template entries correctly.
2015-04-22 19:28:51 +05:30
326bb3e0a4
CLOUDSTACK-8320. Upon a failed migration, a dummy volume is created which remains in 'Expunging' state.
...
Set destination volume path as NULL while duplicating volume during migration.
If migration fails, destination volume will be marked as removed. And if migration succeeds, volume path will be rightly updated.
(cherry picked from commit d30d5644bb
2015-04-17 15:42:02 +02:00
55f2e45d14
CLOUDSTACK-8319. For both 'MigrateVolume' and 'MigrateVMWithVolumes, ensure VM's vconfiguration files are migrated along with VM's root volume.
...
(cherry picked from commit bdd28a45ed
2015-04-17 15:42:02 +02:00
06e353e5c7
vmware: support vmfs as local storage pool type
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 752d784d92
2015-04-16 17:36:52 +05:30
752d784d92
vmware: support vmfs as local storage pool type
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-16 17:10:43 +05:30
b34202a84e
CLOUDSTACK-8387 - Close mgmt server peer socket on failure, without relying on autoclose
2015-04-15 09:50:32 -07:00
42a8253993
CLOUDSTACK-8387 - Close mgmt server peer socket on failure, without relying on autoclose
2015-04-15 09:49:48 -07:00
fde2615c33
CLOUDSTACK-8387 - Close mgmt server peer socket on failure, without relying on autoclose
2015-04-15 08:43:37 -07:00
aab0bfc809
CLOUDSTACK-8387 - Close mgmt server peer socket on failure, without relying on autoclose
2015-04-15 08:43:02 -07:00
cb7bcf23fe
CLOUDSTACK-8387 - Don't autoclose new mgmt server peer connections as soon as they open
2015-04-15 08:18:24 -07:00
5506ec9936
CLOUDSTACK-8387 - Don't autoclose new mgmt server peer connections as soon as they open
2015-04-15 08:16:33 -07:00
30604e973a
CLOUDSTACK-8386: CS is returning sec. storage even if it is full and there are other sec. storage with free space.
2015-04-14 16:10:40 +05:30
a70947f9b1
CLOUDSTACK-7593: in 450to451 upgrade path copy vm_details from template for vmware
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 8e15070780
2015-04-13 15:47:59 +05:30
37820e15f2
CLOUDSTACK-7593: allow nic type to be fetched from vm's details
...
(cherry picked from commit 43db75c319
2015-04-13 15:47:03 +05:30
8e15070780
CLOUDSTACK-7593: in 450to451 upgrade path copy vm_details from template for vmware
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-13 15:44:09 +05:30
43db75c319
CLOUDSTACK-7593: allow nic type to be fetched from vm's details
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-13 15:44:09 +05:30
01864ef77c
CLOUDSTACK-6697: bigswitch networking plugin update
...
1. provide compatibility with the Big Cloud Fabric (BCF) controller
L2 Connectivity Service in both VPC and non-VPC modes
2. virtual network terminology updates: VNS --> BCF_SEGMENT
3. uses HTTPS with trust-always certificate handling
4. topology sync support with BCF controller
5. support multiple (two) BCF controllers with HA
6. support VM migration
7. support Firewall, Static NAT, and Source NAT with NAT enabled option
8. add VifDriver for Indigo Virtual Switch (IVS)
This closes #151
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-09 13:02:02 +05:30
3d22a16c4f
Bump priority stragety is no longer used for redundant virtual routers
...
- With the changes added by the rVPC work, the bump priority became deprecated.
This commit includes a refactor to get it removed from the following resources:
* Java classes
* domain_router table - removing the is_priority_bumpup column
* Fixing unit tests
All changes were tested with:
XenServer 6.2 running under our VMWare zone
CloudStack Management Server running on MacBook Pro
MySql running on MackBook Pro
Storage Type: Local
2015-04-02 21:50:49 +02:00
fa56045665
findbugs: wrapper object comparison (fixed)
2015-03-25 17:12:51 +01:00
caba04d173
engine: add DB upgrade path from 4.4.3 to 4.5.0/4.5.1
...
Upgrade path extends over upgrade path from 4.4.2 to 4.5.0
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit e3e59c544c
2015-03-25 11:38:39 +05:30
e3e59c544c
engine: add DB upgrade path from 4.4.3 to 4.5.0/4.5.1
...
Upgrade path extends over upgrade path from 4.4.2 to 4.5.0
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-25 11:32:51 +05:30
694b723899
CLOUDSTACK-8312: Fix NPE regression, copy template can have NULL volume size
...
The copy command reply can have null size returned, so check and set values
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 53ca0b1861
2015-03-20 17:27:14 +05:30
53ca0b1861
CLOUDSTACK-8312: Fix NPE regression, copy template can have NULL volume size
...
The copy command reply can have null size returned, so check and set values
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-20 17:25:52 +05:30
3c429ee6b5
Merge remote-tracking branch 'sbp/feature/persisten-systemvm-redundant-vpc-REBASE'
...
This closes #118
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-17 15:44:57 +05:30
0a133c06f8
Adding nre method to NetworkDao
...
- listVpcNetworks() to be used for the router check task
2015-03-16 11:40:01 +01:00
e350f1e76f
Turn a single VPC into a redundant VPC
...
- when restarting a VPC, the user can check the option Make Redundant in order to change
the VPC offering and make it redundant
2015-03-16 11:39:57 +01:00
460204fa9f
Fixing CsDhcp.py
...
Fixing assign IPv4 on GuestNetworkGuru.java
Fixing getRouters() on VpcVirtualRouterElement.java
Fixing Fixing paths on keepalived.conf.templ
Refactor on the other files
2015-03-16 11:39:17 +01:00
40eb579115
TK-3135 fixes for VPC restart
...
* removed the "is redundant" flag form the addVpcRouterToGuestNetwork() method
* removed the "is redundant" flag from the removeVpcRouterFromGuestNetwork() method
* changed the path of the master.py file in the keepalived.conf.temp file
* the call to routerDao.addRouterToGuestNetwork() in the VpcRouterDeploymentDefinition is not needed. That step will be performed once a VM is created
- In addition, when restarting a VPC the routers will have the guest net configured, if any exists.
* Pushing the POM.xml as well, to use the old Jetty for now. Could not fix the logging problem. Will replace the POM with master version after VPC is done.
2015-03-16 11:39:17 +01:00
8f9f39fa39
[TK-3119] Fix NPEs and improve exception handling + error messages
2015-03-16 11:39:14 +01:00
09bd847040
Vpc redundancy enabled. Including Vpc & Vpc Offering creation. Marvin tests and UI.
2015-03-16 11:38:05 +01:00
843f6b1691
CLOUDSTACK-5236 : ability to identify where the user is from (ex. LDAP)
...
Added a source column to the user table.
Source now has only two values UNKNOWN,LDAP with UNKNOWN being the
default and is an enum is com.cloud.User.
When the source is UNKNOWN, the old method of authenticating against all
the available authenticators is used. If a source is available, only
that particular authenticator will be used.
added overloaded methods in AccountService to createUserAccount and
createUser with source specified.
(cherry picked from commit 5da733072e
2015-03-16 14:53:53 +05:30
5da733072e
CLOUDSTACK-5236 : ability to identify where the user is from (ex. LDAP)
...
Added a source column to the user table.
Source now has only two values UNKNOWN,LDAP with UNKNOWN being the
default and is an enum is com.cloud.User.
When the source is UNKNOWN, the old method of authenticating against all
the available authenticators is used. If a source is available, only
that particular authenticator will be used.
added overloaded methods in AccountService to createUserAccount and
createUser with source specified.
2015-03-16 12:35:37 +05:30
765622658a
Avoid distributing private key for realhostip.com
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit d94a5720ef
2015-03-13 15:02:27 +05:30
d94a5720ef
Avoid distributing private key for realhostip.com
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-13 13:33:48 +05:30
74f9adbe3e
engine: Add Upgrade path from 4.5.0 to 4.5.1
...
Encrypts:
- Remote access vpn preshared key
- StoragePool's user info
- Keystore's key
This closes #112
(cherry picked from commit cfd4573335
2015-03-12 13:02:45 +05:30
cfd4573335
engine: Add Upgrade path from 4.5.0 to 4.5.1
...
Encrypts:
- Remote access vpn preshared key
- StoragePool's user info
- Keystore's key
This closes #112
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-12 12:13:28 +05:30
c198dfdb7a
Update pom and version usage to 4.5.1-SNAPSHOT
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-12 12:13:18 +05:30
d30d5644bb
CLOUDSTACK-8320. Upon a failed migration, a dummy volume is created which remains in 'Expunging' state.
...
Set destination volume path as NULL while duplicating volume during migration.
If migration fails, destination volume will be marked as removed. And if migration succeeds, volume path will be rightly updated.
2015-03-12 11:57:02 +05:30
bdd28a45ed
CLOUDSTACK-8319. For both 'MigrateVolume' and 'MigrateVMWithVolumes, ensure VM's vconfiguration files are migrated along with VM's root volume.
2015-03-12 11:57:02 +05:30
c27c69438b
hypervisors: add OVM3 plugin that supports OVM 3.2.1/3.3.x
...
This is a plugin that puts in ovm3 support ranging from 3.3.1 to 3.3.2. Basic
functionality is in here, advanced networking etc..
Snapshots only work when a VM is stopped now due to the semantics of OVM's raw
image implementation (so snapshots should work on a storage level underneath the
hypervisor shrug)
This closes #113
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-12 11:33:42 +05:30
5aedeb74f9
CLOUDSTACK-8312: The storage usage of "Primary Storage Allocated" is incorrect.
...
(cherry picked from commit 520d96724a
2015-03-11 13:07:47 +05:30
520d96724a
CLOUDSTACK-8312: The storage usage of "Primary Storage Allocated" is incorrect.
2015-03-10 16:52:25 +05:30
9b669f0648
CLOUDSTACK-7639: make cidr updation more efficient
...
check and update only when required
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit b879916f5c
2015-03-09 16:30:08 +05:30
e1cbe6d18a
CLOUDSTACK-7639: make cidrlist update when updateNetworkAclItem is called
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit b2b9de7fa3
2015-03-09 16:30:08 +05:30
b879916f5c
CLOUDSTACK-7639: make cidr updation more efficient
...
check and update only when required
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-09 16:29:05 +05:30
b2b9de7fa3
CLOUDSTACK-7639: make cidrlist update when updateNetworkAclItem is called
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-09 15:40:32 +05:30
ef99f01e59
Merge remote-tracking branch 'anshul/CLOUDSTACK-6900'
...
This closes #68
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-02 16:40:44 +05:30
43cf1da865
CLOUDSTACK-5238: password checks, NPE fixes and minor fixes
...
- insecure authenticators excluded in configuration
- snapshot response should have zone
- remove vmsnapshots when removing accounts
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 5481485a08
2015-02-27 18:24:46 +05:30
5481485a08
CLOUDSTACK-5238: password checks, NPE fixes and minor fixes
...
- insecure authenticators excluded in configuration
- snapshot response should have zone
- remove vmsnapshots when removing accounts
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-27 18:20:10 +05:30
43a39d1eb0
findbugs: possible nullpointer
2015-02-19 10:27:51 +01:00
0f8a055dff
findbugs: equals() call on Long instead of =-comparison
2015-02-19 10:23:10 +01:00
1a6df6f978
CLOUDSTACK-7908: Add user_id column to vm_instance table
...
Design Document:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Allow+VM+listing+by+User+ID
- Adds column to VMInstance DAO
- Adds column in vm_instance table
- Adds column in the UserVMJoinVO
- Adds default admin user which has UID = 2
- Adds migration path that sets user_id to first user of the accountId that
owns the vm in vm_instance table
- Add arg on list VMs API to query by userId, add support in query layer
- Refactor VMInstanceVO and child classes to accept userId
- Add code to let service layer pass userId if loggedIn user belongs to same
account as the owner executing an API call or use first user from owner account
- In case of CPVM and SSVM use system user ID
- Fix unit tests and spring injections
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-16 15:02:38 +05:30
8ad2e309a4
CLOUDSTACK-8238 handling of retry ping improved
...
Fixed on 4.4 and master but not on 4.5, cherry-picked on 4.5 using commit
fbafc957dc
2015-02-16 11:35:41 +05:30
7e75f339bc
license and format
2015-02-12 14:47:12 +00:00
a9c384fd17
CLOUDSTACK-8238 mocked test to make sure xapi code is called in test for
...
pingtask
2015-02-10 16:15:24 +01:00
8cfd374f04
CLOUDSTACK-8224: Don't try to unlock if template is not locked
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-06 17:43:12 +05:30
78bfaa79cf
Fixed few coverity issues like invalid boxing unboxing issues, resource leaks, null dereferences
...
(cherry picked from commit ef6ec7b276
2015-02-06 16:50:20 +05:30
4ea0dcda9b
CLOUDSTACK-7870: When Vm deployments fail and end in error state volume count should be decremented
...
(cherry picked from commit a8b89bea4f
2015-02-06 16:24:06 +05:30
82eebab0ba
CID-1241966 Fix potential null deref
...
(cherry picked from commit 1c94017ff6
2015-02-05 18:27:09 +05:30
a8f9233377
CLOUDSTACK-8146: close search builder using done()
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit a4d24adfb8
2015-02-05 18:06:15 +05:30
a4d24adfb8
CLOUDSTACK-8146: close search builder using done()
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-05 18:05:25 +05:30
ca0a77088c
Close transaction while fetching recent events
...
(cherry picked from commit 438f90a262
2015-02-05 16:56:20 +05:30
fb1069ace9
agent: don't investigate if host is null, send alert instead
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-05 16:42:56 +05:30
7c41a1184c
agent: don't investigate if host is null, send alert instead
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-05 16:42:13 +05:30
419508b016
orchestration: allow storage migration
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit a2547ed827
2015-02-05 16:39:17 +05:30
a2547ed827
orchestration: allow storage migration
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-05 16:38:53 +05:30
7a397cd4ef
For volumes created from template, do not log offering ID in VOLUME.CREATE in usage_event. Moved offering type to DiskOffering interface
...
(cherry picked from commit 9eb8d538dd
2015-02-05 16:37:59 +05:30
e40b06e9ca
AgentAttache: allow checkonhost command in maintenance, cancel if only allowed
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-05 16:29:44 +05:30
61dfb2d625
AgentAttache: allow checkonhost command in maintenance, cancel if only allowed
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-05 16:29:03 +05:30
c25263ba81
Fixed Coverity Issues
2015-02-05 15:59:29 +05:30
7de7885a54
CLOUDSTACK-8125. VM fails to start on the first attempt after a cold migration.
...
Update volume chain_info to NULL during cold migration.
Otherwise during VM start, CCP will configure and try to power-on the VM with wrong disk information.
(cherry picked from commit 7b32b8a268
2015-02-05 15:30:49 +05:30
01cc1b816d
CLOUDSTACK-7792: Usage Events to be captured based on Volume State Machine
...
(cherry picked from commit 781648fb10
2015-02-05 15:22:21 +05:30
d4663df7c9
Make volume deletion publish event, removed by 781648fb10
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-05 15:01:39 +05:30
8ec6d0471c
CLOUDSTACK-7648: There are new VM State Machine changes introduced which were missed to capture the usage events
...
(cherry picked from commit 50185b7c3a
2015-02-05 14:56:52 +05:30
b586439c9f
CLOUDSTACK-8197 create MinVRVersion config item
2015-02-03 13:18:15 +01:00
0e4d91aa91
CLOUDSTACK-6924. To attach a volume if a volume needs to be moved to another storage
...
pool, the source and destination pools cannot be local and cluster/zone and vice versa.
Cloudstack detects it and throws a exception. However, the end user only sees an
unexpected exception and not the reason for failure. Fixed it by making sure the
reason for the failure is correctly captured and shown to the end user.
(cherry picked from commit cffae8eef0
2015-02-02 14:36:07 +05:30
f00140243c
CLOUDSTACK-8112. CS allows creation of VM's with the same Display name when vm.instancename.flag is set to true.
...
During VM creation, if vm.instancename.flag is set to true and hypervisor type is VMware, check if VM with the same hostname already exists in the zone.
(cherry picked from commit 5f9e4fddf3
2015-02-02 14:30:18 +05:30
0c1172ffe9
Network offering usage event should be logged for UserVms only
...
(cherry picked from commit 42cecbb000
2015-02-02 14:27:24 +05:30
294f5bf331
CLOUDSTACK-8114. Ensure VM stop and then start updates the volume path correctly in the DB.
...
(cherry picked from commit 521258bafb
2015-02-02 14:27:04 +05:30
b9932a0129
CLOUDSTACK-8122. Handle NPE thrown during migration failures.
...
When migration fails instead of returning NULL, throw the exception.
(cherry picked from commit a5a65c7b55
2015-02-02 13:56:43 +05:30
bcbfe3bdee
CLOUDSTACK-8129. Cold migration of VM across VMware DCs leaves the VM behind in the source host.
...
If VM has been cold migrated across different VMware DCs, then unregister the VM from source host.
(cherry picked from commit 15b348632d
2015-02-02 13:51:47 +05:30
45d32234a6
CLOUDSTACK-8112. CS allows creation of VM's with the same Display name when vm.instancename.flag is set to true.
...
Before registering a VM check if a different CS VM with same name exists in vCenter.
(cherry picked from commit 33179cce56
2015-02-02 13:51:22 +05:30
737edd90dc
Fixed few coverity patches
...
NPE in delete firewall rules observed, cherry-picking fix from master.
(cherry picked from commit 31a42d2b7a
2015-02-02 12:48:38 +05:30
6ff8752fd0
volume-upload: gc thread to clean partially uploaded files
...
Fixed multiple issues in the template code path
2015-01-31 17:25:19 +05:30
ae21f44c7b
volume-upload: Volume uploaded using new POST based upload goes to inconsistent state on destroying SSVM
...
Added a check not to cleanup volume related entries when SSVM is destroyed for volumes upload using the POST based upload feature
2015-01-31 17:19:58 +05:30
6598a65dfb
volume-upload: gc thread to clean partially uploaded files
...
Fixed the following:
- Destroying volume in 'UploadAbandoned' state resulted in NPE
- Existing upload volume functionality interfered with this, added proper checks to prevent that
2015-01-31 17:13:22 +05:30
31f67c2b3c
If the HypervisorType of a storage pool is Any, we need to retrieve hosts in the given zone for each HypervisorType.
2015-01-29 19:18:04 -07:00
bd6a89939d
Adding/updating comments around the volume's hypervisor snapshot reserve field
2015-01-29 15:50:42 -07:00
1b51bbbf74
Update hypervisor snapshot reserve for the root volume earlier than when it is currently being set
2015-01-29 13:01:51 -07:00
a710743871
volume upload: persisting into volume store ref only when SSVM is found
2015-01-29 16:55:24 +05:30
b343fb79e3
volume upload: fixed NPE if SSVM is not up
2015-01-29 16:55:16 +05:30
c2330f48dd
Replace synchronized with the use of database locking
2015-01-27 17:36:21 -07:00
e9ce0df5d8
CLOUDSTACK-7316: usage server cannot start due to missing key in /etc/cloudstack/usage/ in Ubuntu setup
...
(cherry picked from commit 6fb9746e5e
2015-01-27 17:39:22 +05:30
c847831662
Do not allow deletion of the snapshot if the snapshot is being copied
2015-01-26 14:57:28 -07:00
abf4e5c646
CLOUDSTACK-8181: Introducing a new allocator called firstfitleastconsumed. The purpose of this allocator is to find hosts/pools with least capacity usage (in terms of percentage) within the cluster and use those resources first before others. This allocator can be used changing vm.allocation.algorithm. For hosts it would decide the least consumed host through the setting host.capacityType.to.order.clusters to base the usage on cpu or ram.
...
Reviewed-by: Prachi
2015-01-26 10:48:06 -08:00
e474454c91
CLOUDSTACK-6485 prevent ipaddress asignment of gateway to gateway-interface on vpc router by setting vpcid to null in network
2015-01-26 16:57:46 +01:00
29aeed71fc
CLOUDSTACK-6485 prevent ipaddress asignment of gateway to gateway-interface on vpc router by setting vpcid to null in network
2015-01-26 16:54:53 +01:00
8204a44890
When creating a template from a managed-storage snapshot, put the snapshot in the Copying state before performing the copy (don't want to do anything with the snapshot until this process has completed)
2015-01-25 23:29:27 -07:00
f9a8111e17
CLOUDSTACK-8151: Add removeRawUsageRecords API to cleanup old cloud_usage data
...
Call removeRawUsageRecords with interval (> 0) and it will clean up cloud_usage
table by removing records older than interval no. of days from today (current date)
and in case it runs when the job exec time is near, it will fail alerting
user to try again after a 15 min window.
There is an issue with async job scheduler, if this API were async it tries
to search and remove job from cloud_usage.async_job table and fails which is
why this API is sync and extends BaseCmd.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-23 19:38:32 +05:30
2094286c8a
Adding support for creating a volume from a snapshot when the snapshot is on managed storage
2015-01-21 13:06:05 -07:00
664186f483
CLOUDSTACK-8160: use preferable protocols
...
(cherry picked from commit debfcdef78
2015-01-21 18:04:45 +05:30
debfcdef78
CLOUDSTACK-8160: use preferable protocols
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-21 18:02:58 +05:30
0f84e042b9
Adding support for creating a volume from a snapshot when the snapshot is on managed storage
2015-01-20 15:24:33 -07:00
9cf05dc842
CLOUDSTACK-7534: ResetVM for VM with attached datadisk fails when enable.ha.storage.migration is false
...
Separate global config to enable/disable Storage Migration during normal deployment
Introduced a configuration parameter named enable.storage.migration
(cherry picked from commit c55bc0b2d1
2015-01-20 14:43:10 +05:30
bf8db0c743
CLOUDSTACK-7571 changing value of cpu/mem.overprovisioning.factor for xen cluster is not affecting total memory at zone level
...
(cherry picked from commit 476733cb92
2015-01-20 14:39:21 +05:30
45108fdbad
CLOUDSTACK-7582: Update Storage Pool API does not update tags correctly
...
(cherry picked from commit fc4dceaa99
2015-01-20 14:38:03 +05:30
4e01d61f87
engine: remove redundant import
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-20 11:45:34 +05:30
ff70ef797c
CLOUDSTACK-8101: volume sync not working as expected - MS restart during upload volume leaves volume in hung state.
...
(cherry picked from commit e559b15b6a
2015-01-20 11:43:36 +05:30
1aeaf4dcc9
CLOUDSTACK-7920: NPE in the payload was causing the ssvm agent to not connect, fix it and also make sure that template/volume sync are robust that exceptions do not cause ssvm agent disconnect issues.
...
(cherry picked from commit 5213401ace
2015-01-20 11:39:34 +05:30
8790b84b20
CLOUDSTACK-7940: Exception printed completely on the UI. Not in a readable format.
...
(cherry picked from commit dda2994936
2015-01-20 11:34:48 +05:30
ad6b7b30cb
Volume upload: sending the nfsstore url in the metadata
...
decoding the metadata and deserialising it on receiving it
2015-01-19 18:04:14 +05:30
d8def3dc0b
CLOUDSTACK-8164: Look for all host to avoid NPE
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit a1a601be5a
2015-01-19 11:30:49 +05:30
a1a601be5a
CLOUDSTACK-8164: Look for all host to avoid NPE
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-19 11:29:51 +05:30
fd0eb6c29e
CLOUDSTACK-3439. [VMWARE] While preparing for migration, include dynamically created nics in case of VMware too.
...
(cherry picked from commit 4b67a48144
2015-01-18 18:19:30 +05:30
1e87f3b80b
Bug-Id: CLOUDSTACK-3439: Include dynamically created nics in Prepare for migration command in KVM
...
(cherry picked from commit f767adfe71
2015-01-18 18:19:24 +05:30
466e6d15a4
CLOUDSTACK-8097: Failed to create volume snapshot after vm live migration across clusters.
...
(cherry picked from commit 0c4128e024
2015-01-18 17:59:31 +05:30
d807bf0a4e
CLOUDSTACK-8107. Failed to create snapshot from volume when the task is performed repeatedly in zone wide primary Storage.
...
While taking a snapshot of a volume, CS chooses the endpoint to perform backup snapshot operation by selecting any host that has the storage containing the volume mounted on it.
Instead, if the volume is attached to a VM, the endpoint chosen by CS should be the host that contains the VM.
(cherry picked from commit a75a431373
2015-01-18 17:51:19 +05:30
a1791cb4a8
CLOUDSTACK-8088: VM scale up is failing in vmware with Unable to execute ScaleVmCommand due to java.lang.NullPointerException
...
(cherry picked from commit 1df0453d27
2015-01-18 17:28:17 +05:30
8676ff26e0
CLOUDSTACK-8066: There is not way to know the size of the snapshot created.
...
(cherry picked from commit 9153b8bede
2015-01-18 17:25:41 +05:30
d9bd235bf6
engine/storage: add NPE check, break if parent snapshot is null
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit c06ca09b54
2015-01-18 17:20:56 +05:30
c06ca09b54
engine/storage: add NPE check, break if parent snapshot is null
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-18 17:20:09 +05:30
053c160b0f
volume upload: management server polling and upload status from agent
...
MS polling logic to query status for templates that are uploaded
2015-01-16 18:03:36 +05:30
91e1881be8
CLOUDSTACK-6900: This fixes volume migration failing after that volume is downloaded.
...
When we download volume then we create entry in volume_store_ref table.
We mark the volume entry to ready state once download_url gets generated.
When we migrate that volume, then again one more entry is created with same volume id.
Its state is marked as allocated. Later we try to list only one dataobject in datastore
for state transition during volume migration. If the listed volume's state is allocated
then migration passes otherwise it fails.
Below fix will remove the randomness and give priority to volume entry which is made for
migration (download_url/extracturl will be null in case of migration). Giving priority to
download volume case is not needed as there will be only one entry in that case so no randomness.
2015-01-16 15:15:14 +05:30
627f5a62dc
volume upload: management server polling and upload status from agent
...
MS polling logic to query status for volumes that are uploaded
2015-01-14 10:19:12 +05:30
94e6b7587d
CID-1256275 regression: resource leak in systemvm update code
...
(cherry picked from commit 06d4458d0a
2015-01-12 20:51:51 +01:00
06d4458d0a
CID-1256275 regression: resource leak in systemvm update code
2015-01-12 20:40:01 +01:00
2720a1b49f
CLOUDSTACK-8146: Resource count of primary storage does not consider the detached volumes
...
(cherry picked from commit b528047fb6
2015-01-12 12:30:09 +01:00
b528047fb6
CLOUDSTACK-8146: Resource count of primary storage does not consider the detached volumes
2015-01-12 12:25:28 +01:00
4b67a48144
CLOUDSTACK-3439. [VMWARE] While preparing for migration, include dynamically created nics in case of VMware too.
2015-01-08 09:50:19 +05:30
f767adfe71
Bug-Id: CLOUDSTACK-3439: Include dynamically created nics in Prepare for migration command in KVM
2015-01-07 14:52:42 +05:30
438f90a262
Close transaction while fetching recent events
2015-01-07 14:14:44 +05:30
9eb8d538dd
For volumes created from template, do not log offering ID in VOLUME.CREATE in usage_event. Moved offering type to DiskOffering interface
2015-01-07 12:31:41 +05:30
42cecbb000
Network offering usage event should be logged for UserVms only
2015-01-07 12:29:11 +05:30
5251fb2dc3
CID-1261670 added null check
2015-01-05 16:01:13 +01:00
251e88c401
CID-1261671 added null check
2015-01-05 15:55:33 +01:00
15b348632d
CLOUDSTACK-8129. Cold migration of VM across VMware DCs leaves the VM behind in the source host.
...
If VM has been cold migrated across different VMware DCs, then unregister the VM from source host.
2014-12-26 11:07:30 +05:30
7b32b8a268
CLOUDSTACK-8125. VM fails to start on the first attempt after a cold migration.
...
Update volume chain_info to NULL during cold migration.
Otherwise during VM start, CCP will configure and try to power-on the VM with wrong disk information.
2014-12-24 14:33:51 +05:30
a5a65c7b55
CLOUDSTACK-8122. Handle NPE thrown during migration failures.
...
When migration fails instead of returning NULL, throw the exception.
2014-12-24 13:33:11 +05:30
521258bafb
CLOUDSTACK-8114. Ensure VM stop and then start updates the volume path correctly in the DB.
2014-12-24 09:56:06 +05:30
5f9e4fddf3
CLOUDSTACK-8112. CS allows creation of VM's with the same Display name when vm.instancename.flag is set to true.
...
During VM creation, if vm.instancename.flag is set to true and hypervisor type is VMware, check if VM with the same hostname already exists in the zone.
2014-12-23 14:00:32 +05:30
33179cce56
CLOUDSTACK-8112. CS allows creation of VM's with the same Display name when vm.instancename.flag is set to true.
...
Before registering a VM check if a different CS VM with same name exists in vCenter.
2014-12-23 13:48:01 +05:30
106ec718fc
Revert "CLOUDSTACK-7872: network getting shutdown inspite of running VM's in the network"
...
This reverts commit 709bf074de
2014-12-23 12:13:51 +05:30
e0c495d357
Revert "CLOUDSTACK-7872: network getting shutdown inspite of running VM's in the network"
...
This reverts commit 0bd34d389f
2014-12-23 11:56:40 +05:30
a75a431373
CLOUDSTACK-8107. Failed to create snapshot from volume when the task is performed repeatedly in zone wide primary Storage.
...
While taking a snapshot of a volume, CS chooses the endpoint to perform backup snapshot operation by selecting any host that has the storage containing the volume mounted on it.
Instead, if the volume is attached to a VM, the endpoint chosen by CS should be the host that contains the VM.
2014-12-23 09:48:35 +05:30
Rafael da Fonseca
Daan Hoogland
Sanjay Tripathi
Daan Hoogland
wilderrodrigues
Rajani Karuturi
Rohit Yadav
Jayapal
Milamber
Koushik Das
Abhinandan Prateek
Devdeep Singh
Mike Tutkowski
Anshul Gangwar
Likitha Shetty
Santhosh Edukulla
MS
KC Wang
Daan Hoogland
Antonio Fornie
Nitin Mehta
Funs
Hugo Trippaers
Kishan Kavala
Damodar
Wei Zhou
Harikrishna Patnala
Bharat Kumar
Saksham Srivastava
Min Chen