b2023d04ba
Simplification on Properties handling
...
- Added method to create properties and load contents from file
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-11-23 19:48:56 +01:00
ca9dd457f9
Stream handling simplification in PropertiesUtil
...
- use resource block instead of finally block
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-11-23 19:48:55 +01:00
9ac93d3e43
CLOUDSTACK-7678:volumes are getting uploaded successfully with wrong url.
2014-11-21 14:36:36 -08:00
f2ccee7a03
name convention adherence
2014-11-18 16:52:46 +01:00
6bc0defa1d
CID-1254832 tyr-with-resource
2014-11-18 15:48:31 +01:00
e1d4a329c4
Package name should reflect the location on the filesystem or viseversa
2014-11-18 14:12:44 +01:00
16de4a7176
Fix for potential NPE
2014-11-18 14:12:14 +01:00
638da54fce
CID-1254833 refactor condition to include null-case
2014-11-18 12:12:00 +01:00
ef6ec7b276
Fixed few coverity issues like invalid boxing unboxing issues, resource leaks, null dereferences
2014-11-13 17:26:24 +05:30
840c2fda85
CLOUDSTACK-7583: Send VmStats to Graphite host when configured
...
This allows external processing of VmStats information without using
the usage server of CloudStack
Statistics are being send to Graphite using UDP and not TCP.
UDP is used to prevent the management server waiting for TCP timeouts
when the Graphite server is unavailable
2014-11-11 13:04:43 +01:00
990da08451
Add check to ensure VR template version matches digit.digit.digit format. Returns version as 0 otherwise
2014-11-10 15:33:50 +05:30
7716989344
SAMLUtils: SAML user id should fit within the UUID VARCHAR(40) column
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 6df0b9f677
2014-10-31 01:24:56 +05:30
4ebaf0a583
Bump master version to 4.6.0-SNAPSHOT after branching 4.5.0-SNAPSHOT
2014-10-29 14:54:23 +01:00
57c4841403
CLOUDSTACK-7814: Fix default passphrase for keystores
...
In upgrade case, the db.properties file is not changed, but the following commit
would require passphrase for keystore in it, thus result in error(NPE in fact
due to there is no such properity).
commit 918c320438
2014-10-28 16:25:52 -07:00
1de0cb7094
restore barematel work after merge
2014-10-17 10:24:01 +02:00
148efbb73f
Merge remote-tracking branch 'origin/4.5' into merge-master
...
Conflicts:
engine/schema/src/com/cloud/upgrade/dao/Upgrade441to450.java
plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalManagerImpl.java
plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalVlanManager.java
plugins/hypervisors/baremetal/src/com/cloud/baremetal/manager/BaremetalVlanManagerImpl.java
plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalKickStartServiceImpl.java
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java
setup/db/db/schema-441to450.sql
test/integration/component/test_deploy_vgpu_vm.py
tools/marvin/marvin/config/test_data.py
2014-10-16 12:29:37 +02:00
50185b7c3a
CLOUDSTACK-7648: There are new VM State Machine changes introduced which were missed to capture the usage events
2014-10-13 14:42:00 +05:30
e43d5b1c7d
CLOUDSTACK-7575: improved performance of cleanString method in StringUtils
...
(cherry picked from commit 7972f53c8d
2014-10-13 00:02:11 -04:00
ac48aa8e0c
cleaning up some from a revert
2014-10-12 23:30:04 -04:00
31a42d2b7a
Fixed few coverity patches
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-10-09 11:45:26 +05:30
7972f53c8d
CLOUDSTACK-7575: improved performance of cleanString method in StringUtils
2014-09-26 14:02:41 +05:30
6f54d48772
CID-1116298 path can be null, make sure that is properly handled
2014-09-19 11:54:21 +02:00
8b89494a35
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-09-18 16:54:37 -07:00
d1d8009c68
Fix a stupid bug i introduced
2014-09-18 16:02:26 +02:00
bd1752811c
CID-1116250: Lock on s_appContextDelegates before calling get in ComponentContext
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-18 11:52:18 +02:00
ec134cf010
CID-1116231: Use implicit lock, synchronize _key in Link
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-18 11:21:57 +02:00
577a2f40b3
Merge branch 'bugfix/CID-116538'
2014-09-17 11:40:55 +02:00
88c6072b4d
CID-1237196: Fix potential NPE in SAMLUtils
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-16 17:10:11 +02:00
de26a7228e
Fix resource leaks on exception paths
...
Make it clear that the server socket isn't a leaked resource
2014-09-16 16:43:32 +02:00
d46e45991d
SAMLUtils: put name id policy on authnrequest
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-12 17:11:06 +02:00
84b0e9e96f
utils: add missing string to the url in generate saml signature method
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-12 16:26:13 +02:00
5a0ed8764b
SAMLUtils: Fix NPE incase signature is generated with a null privateKey
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-12 15:46:44 +02:00
a66127dfb1
utils: add methods to save and load public and private keys
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-09-12 15:40:49 +02:00
d90a2d3962
CLOUDSTACK-7370: Fixed password visible in plain text if password passed is in the end in url
2014-09-12 15:33:24 +05:30
10544e287b
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-09-05 16:28:34 -07:00
dc3f0cbc63
Improve the handling of the findbug exclude files
2014-09-03 10:41:22 +02:00
550762a0dc
SAMLUtils: fix signature, refactor generateRandomX509Certificate
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-30 21:37:55 +02:00
12ad5ba197
SAMLUtilsTest: just test that random secure string has some length
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-30 15:37:52 +02:00
2bff5956a9
cisco-vnmc: Don't create Protocol using deprecated SecureProtocolSocketFactory
...
Latest httpclient library suggests when creating Protocol object for use
with the apache common httpclient class, they should avoid using the
deprecated Protocol signature which takes in SecureProtocolSocketFactory
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-29 14:39:29 +02:00
5e7928bcb9
utils: fix static certificate value string in SAMLUtils
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:27 +02:00
1ed532fb20
SAMLUtils: add unit test for SAMLUtils and method to randomly generate X509 certs
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:26 +02:00
3bf387c882
SAMLUtils: Create new NameID using passed nameId taking just id and session idx
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:26 +02:00
8dc50927f9
saml: use SAML_RESPONSE from SAMLUtils
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:26 +02:00
230e970569
SAMLUtils: add logout request utility for saml slo
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:25 +02:00
8fa9d2c276
utils: fix SAMLUtils's authnrequest maker
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:25 +02:00
8e6cb04480
SAMLUtils: leave bootstrapping to upper layers
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:24 +02:00
1b0f81ec6f
utils: Remove hard coded strings from SAMLUtils
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:23 +02:00
d6ea4ad7e0
utils: refactor and aggregate methods in SAMLUtils
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-28 19:45:22 +02:00
7ada4ad50b
NetUtils: Check for NPE in getDefaultHostIp method when processing nic/mac
...
On hosts or containers where they don't have valid mac address on nic resulting
in null, NetUtils.getNetworkParam can throw NPE.
This was a case found on TravisCI where OpenVZ containers are used. This method
(getDefaultHostIp) is used at several other places within the ACS codebase to
get the host IP and if null is caught we fallback to localhost or 127.0.0.1, so
we therefore set info to null before trying to process network param and if we
fail we return null and expect other layers to use localhost.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-21 11:41:07 +02:00
023811286e
Fixed few coverity issues
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-08-19 22:01:15 +05:30
3b5aa42c6d
CLOUDSTACK-4770: In MacAddress skip macAddress when parsed value is 0x00
...
In MacAddress class, we start by settig macAddress String as null and go through
the output of ifconfig -a and pick the one string that is a valid mac address
but is not 0x00 and 0xff. With each loop we set the macAddress to null so that
it does not pick the last one if everything fails.
Tested on Ubuntu where I had an interface called cloud0 whose mac id was 0x00
and it was skipped to get the next one:
$ java -classpath <path-to-cloud-utils.jar> com.cloud.utils.net.MacAddress
addr in integer is 5071953436
addr in bytes is 0 1 2e 4f de 1c
addr in char is 00:01:2e:4f:de:1c
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-13 15:04:04 +02:00
a22abeb0e7
CLOUDSTACK-7328:[Automation] Register ISO failing with invalid iso
...
format error.
2014-08-12 15:26:50 -07:00
e3564658be
CLOUDSTACK-6940, CLOUDSTACK-7312, CLOUDSTACK-5512: Template/ISO/Volume
...
upload rejects some valid URL formats. Also consolidate URL format check
into one util routine.
2014-08-12 11:43:08 -07:00
bae8f2a8cb
utils: fix pom.xml to have references for javax.servlet api interfaces
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-12 12:01:32 +02:00
315feb0683
utils: refactor HTTP transport stuff to HttpUtils
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-08-12 12:01:31 +02:00
fd96ad02d7
Fixed few coverity reported issues around concurrency, null checks
2014-08-11 16:55:23 +05:30
d28da9d986
CLOUDSTACK-7212: Failed creating LB rule on public port 8081 for VR as LB provider
2014-08-01 15:54:17 +05:30
89017a7d7b
CS-19072: got rid of unneeded type casting when apply pagination to different resources
2014-07-30 10:33:45 -07:00
ca8d3672e8
listNetworks: moved pagination post processing to StringUtils class
2014-07-28 14:43:55 -07:00
47bb175bd4
Partially reverting c61c636ce8. Changing the name if cloud.keystore has bigger impact than just changing the name.
2014-07-28 14:52:41 +02:00
c61c636ce8
CLOUDSTACK-5946: Commit 2774b62d64 changed keystore file along with coverity fixes. Use varible name for keystore filename to keep it in sync
2014-07-25 14:07:46 +05:30
c804660c74
CLOUDSTACK-7168: Revert "Fixed Coverity Issues reported" that broke CI
...
This reverts commit 4523490d44
2014-07-23 11:37:36 -07:00
4523490d44
Fixed Coverity Issues reported
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-07-22 18:03:36 +05:30
58bad41910
Fixed CLOUDSTACK-6983: unable to register lxc template
...
added a check for tar.gz format in checktemplate
2014-07-21 16:57:53 +05:30
51c14106d8
CLOUDSTACK-7123: set the timeout to 60s, when run the file command
2014-07-18 12:07:36 -07:00
b080eaf327
Updates to the way resizing a volume works
2014-07-17 21:09:19 -06:00
aacf8ef77b
Findbugs fixes in cloud-utils project and a few other places
2014-07-15 14:23:17 +05:30
3ddc9e7674
CLOUDSTACK-6278
...
Baremetal Advanced Networking support
2014-07-07 11:40:21 -07:00
a08528cfd9
Polish IPv6 input error information
2014-07-01 15:17:46 -07:00
3268f5bd1f
CLOUDSTACK-6747 test for test to allow all cidrs on other end of a vpc
2014-06-25 17:09:19 +02:00
d90b8d88ed
Revert "CLOUDSTACK-6747 test for test to allow all cidrs on other end of a vpc"
...
This reverts commit 218c4713ae
2014-06-25 17:06:10 +02:00
218c4713ae
CLOUDSTACK-6747 test for test to allow all cidrs on other end of a vpc
2014-06-25 16:58:52 +02:00
cd0ef09344
Fix typo and add the right exception to the error map.
2014-06-25 15:51:28 +02:00
cd3b027f44
findbugs: unit test coverage on the utils package
2014-06-25 15:43:08 +02:00
018b471ad3
CLOUDSTACK-6747 test to allow all cidrs on other end of vpc, public or
...
private
2014-06-25 14:59:14 +02:00
a93a30595d
CLOUDSTACK-6854: Fix inconsistent IPv6 address formats
...
fc00:0003:1373::0002 should be treated the same as fc00:3:1373::2.
2014-06-23 10:54:12 -07:00
1c80185170
Fixed Resource Leaks, null dereferences, invalid value comparisons, invalid result set loop
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-06-21 12:38:46 +02:00
918c320438
CLOUDSTACK-6847.Link.java and console proxy files have hardcoded value
2014-06-20 12:07:50 +02:00
ce3550f333
CLOUDSTACK-6662
...
CLOUDSTACK-6844
exit status delivery might get delayed
Please enter the commit message for your changes. Lines starting
2014-06-18 15:07:50 -07:00
f529823566
Add ReflectionUse annotation for marking up *un-used* methods
2014-06-17 17:31:29 -07:00
8b5ec64842
Small fix for people that have JDK 1.8 installed on MacOSX and don't bother to fix their links
2014-06-05 15:35:05 +02:00
5393387bbd
CLOUDSTACK-6599:
...
1. Adding the missing Template/Volume URLs expiration functionality
2. Improvement - While deleting the volume during expiration use rm -rf as vmware now contains directoy
3. Improvement - Use standard Answer so that the error gets logged in case deletion of expiration link didnt work fine.
4. Improvement - In case of domain change, expire the old urls
2014-05-30 10:48:42 -07:00
15ac47e47b
CLOUDSTACK-6088: Check first bytes of template when downloading to verify format/type
2014-05-28 15:40:57 -06:00
96055058b0
CLOUDSTACK-6785: changed async job param injectedjobid to customjobid and check for unique/uuid
2014-05-27 15:23:12 -06:00
57f3e21317
CLOUDSTACK-6287, CLOUDSTACK-6315 : fixed password visible in plain text in some hyperv request params/json response
2014-04-21 14:10:17 +05:30
c031eb7d38
CLOUDSTACK-6242: exception handling improvements
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-04-15 08:07:15 +02:00
1d0b14673d
CLOUDSTACK-6354 : removing the hard coding of key path in EncryptionSecretKeyChecker
2014-04-10 11:44:18 +05:30
5f800f2d22
Script cleanup
...
- new negative tests
- some copy-paste replacement in the code
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-03-30 23:27:40 +02:00
a7d7fee0cb
findbugs: filter definition
2014-03-28 17:16:05 +01:00
4cfcfd43de
findbugs: array toString()
2014-03-28 15:14:57 +01:00
8b62b2cb92
findbugs: exclude known spiffy hacks a.k.a. false positives
2014-03-28 14:28:10 +01:00
2d5a58d66c
fixed ssh execution log
2014-03-24 15:19:54 -07:00
4402685e11
Update master to 4.5.0-SNAPSHOT
2014-03-14 14:55:26 +01:00
33a0dec965
CLOUDSTACK-6221:
...
Publish first class objects involved in an operation (for now vm uuid) on the event bus . Example - during attach/detachIso along with iso id, vm id should be available as well.
2014-03-10 16:22:34 -07:00
793becf524
CLOUDSTACK-5920: Add some interface methods and constants required by
...
IAM.
2014-03-05 09:40:55 -08:00
ef547108dd
NetUtils testing
...
- Refactor tests:
- Upgrade tests to use jUnit4
- Add hamcrest dependency (contribution of by Laszio Hornyak)
- Break big tests in small unit tests
- Replace assertTrue/False with complex conditions by assertThat with
specific matchers
- Remove dead code:
- Private static method never called locally
- Add test for method that validates cidrs
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-02-25 19:23:13 +01:00
808c6df6d7
Fix and add some Rest unit and IT tests. Fix by adding a missing type of RoutingConfig.
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-19 09:30:57 +01:00
594b51c629
Fixup the license headers in the utils project. All files now use the same license header and this is enforced by the maven-license-check plugin.
2014-02-18 12:08:36 +01:00
a369647bca
Fix license headers
2014-02-18 10:16:31 +01:00
510972abde
Nvp and rest refactoring and more tests
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-02-18 09:51:54 +01:00
Laszlo Hornyak
Min Chen
Daan Hoogland
Hugo Trippaers
Santhosh Edukulla
Wido den Hollander
Kishan Kavala
Rohit Yadav
Sheng Yang
Damodar
Anshul Gangwar
David Nalley
Frank Zhang
Jayapal
Alena Prokharchyk
Kishan Kavala
amoghvk
Rajani Karuturi
Edison Su
Mike Tutkowski
Koushik Das
Daan Hoogland
Upendra Moturi
Anthony Xu
Kelven Yang
Nitin Mehta
Marcus Sorensen
Ding Yuan
miguelaferreira
Antonio Fornie