etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
27,678 Commits 323 Branches 325 Tags 836 MiB
Commit Graph

27678 Commits

Author SHA1 Message Date
Rafael da Fonseca 4eaa613a0b Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warning in Upgrade30xBase.java There was no risk of sql injection here, nor any need to use PreparedStatement, still, this fixes the warning 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #442
 2015-06-15 12:17:49 +03:00
Rafael da Fonseca 869cc0c9f2 Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warning in Upgrade2214to30.java There was no risk of sql injection here, nor any need to use PreparedStatement, still this fixes the warninG 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #441
 2015-06-15 12:17:47 +03:00
Rafael da Fonseca 7a57ce3334 Fix findbugs NS_DANGEROUS_NON_SHORT_CIRCUIT warning in NetworkServiceImpl.java 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #440
 2015-06-15 12:10:10 +03:00
Rafael da Fonseca 3d1dde7a31 Remove accidental ~ character :) 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #439
 2015-06-15 12:10:08 +03:00
Rafael da Fonseca a670f984d8 Fix findbugs warning HE_EQUALS_USE_HASHCODE in Ip4Address.java When overriding equals(), hashCode() must also be overriden do comply with the directive that equal objects must have equal hashcodes Without this implementation, usage of these kinds of objects in hashmaps for example, will be broken 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-06-15 12:10:07 +03:00
Rafael da Fonseca 1bd3286263 Fix 2 findbugs warnings in ApiResponseHelper.java ints were being boxed just to call .toString() 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #438
 2015-06-15 12:10:04 +03:00
Rafael da Fonseca ea7f4bd254 Fix findbugs warning in NetworkServiceImpl.java Integer was being boxed just to call toString() 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #437
 2015-06-15 12:10:02 +03:00
Rafael da Fonseca a4659d009e Fix findbugs warning in Script.java Unnecessary boxing/unboxing of int value 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #436
 2015-06-15 12:10:00 +03:00
Rafael da Fonseca 14f761a976 Fix findbugs warning in NetUtils.java Unnecessary boxing/unboxing of primitive value 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #435
 2015-06-15 12:09:58 +03:00
Rafael da Fonseca ec280189f4 Fix findbugs warning in ProjectManagerImpl.java Unnecessary boxing/unboxing of primitive value 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #434
 2015-06-15 12:09:57 +03:00
Rafael da Fonseca 4d31ed9342 Fix findbugs warning in NetworkUsageManagerImpl.java Unnecessary boxing/unboxing of long value to create Date 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #433
 2015-06-15 12:09:54 +03:00
Rafael da Fonseca d7a27c9572 Fix 2 findbugs warnings in NetworkServiceImpl.java Unnecessary boxing/unboxing of int values 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #432
 2015-06-15 12:09:53 +03:00
Rafael da Fonseca e831fce1b9 Fix findbugs warning in CloudZonesStartupProcessor.java Unnecessary boxing/unboxing of primitive value 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #431
 2015-06-15 12:09:50 +03:00
Rafael da Fonseca 62e78cdea0 Fix findbugs warning in ApiDispatcher.java Unnecessary boxing/unboxing of long value 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #430
 2015-06-15 12:09:48 +03:00
Rafael da Fonseca 9511831f0a Fix 2 findbugs warnings in ElastistorUtil.java Unnecessary boxing/unboxing of long value 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #429
 2015-06-15 12:09:47 +03:00
Rafael da Fonseca ea31a674a4 Fix findbugs warning in ElastistorPrimaryDataStoreLifeCycle.java Unnecessary boxing/unboxing of primitive value 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #428
 2015-06-15 12:09:45 +03:00
Rafael da Fonseca 6f330f7ab6 Fix findbugs warning in PaloAltoResource.java Unnecessary boxing/unboxing of primitive value 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #427
 2015-06-15 12:09:43 +03:00
Rafael da Fonseca 1494487f72 Fix findbugs warning in NetscalerResource.java Unnecessary boxing/unboxing of primitive value 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #426
 2015-06-15 12:09:41 +03:00
Rafael da Fonseca be474f95a1 Fixed 4 findbugs warnings in CitrixResourceBase.java Unnecessary boxing/unboxing of primitive values 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #425
 2015-06-15 12:09:39 +03:00
Rafael da Fonseca 16ddd498d5 Fix findbugs warning in UcsManagerImpl.java Integer was being created to assign value to int 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #424
 2015-06-15 12:09:37 +03:00
Rafael da Fonseca 9ba4e9cb86 Fix findbugs warning in OvmResourceBase.java CreatePrivateTemplateAnswer constructor takes long as physicalSize parameter, Long was being created instead 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #423
 2015-06-15 12:09:36 +03:00
Rafael da Fonseca 9d2fef0de8 Fix findbugs warning in HypervDirectConnectResource.java Two boxed Longs were being created instead of simple long 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #422
 2015-06-15 12:09:34 +03:00
Rafael da Fonseca 30457556f9 Fix findbugs warning in BareMetalResourceBase.java Boxed Integer was being instantiated to assign to an int variable 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #421
 2015-06-15 12:09:32 +03:00
Rafael da Fonseca eeeb2bb31d Fix findbugs warning in ClusterManagerImpl.java ManagementServerHostDao.findByMsid takes long as input, and a boxed Long was being created for it 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #420
 2015-06-15 12:09:29 +03:00
Rafael da Fonseca e409bc3e60 Fix findbugs warning in Upgrade421to430.java Was creating Integer to assign to int 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #419
 2015-06-15 12:09:27 +03:00
Rafael da Fonseca a299674831 Fix 4 findbugs warnings in Upgrade218to22.java Was creating boxed Integers when only int is required 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #418
 2015-06-15 12:09:26 +03:00
Rafael da Fonseca d0a494b71b Fix findbugs DM_BOXED_PRIMITIVE_FOR_PARSING in DeployVMCmd.java Was creating Long to assign to long 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #417
 2015-06-15 12:09:24 +03:00
Rafael da Fonseca 89a07084c5 Fix findbugs DMI_RANDOM_USED_ONLY_ONCE warning in TransportAddress.java Changed to recommended SecureRandom instead of Random 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #416
 2015-06-15 12:09:22 +03:00
Rafael da Fonseca 4e0fe469dd Fix findbugs DMI_RANDOM_USED_ONLY_ONCE warning in ServerTransportProvider.java Changed to recommended SecureRandom instead of Random Moved initializers to constructor 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #415
 2015-06-15 12:09:20 +03:00
Rafael da Fonseca 16baa1289b Remove unused imports to fix checkstyle warnings 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #414
 2015-06-15 12:09:19 +03:00
Rafael da Fonseca 9c4162ac7f Fix 2 findbugs ClassCastExceptions getDetails() isn't called anywhere in the code, either way, implementation is wrong since details is a Map\<String, String\> and not a Map\<String, Map\<String,String\>\> If this piece of could would get run, it would just fail trying to cast String to HashMap\<String,String\> Removed nonsense comment about casting a Collection to a Map obviously giving exception 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-06-15 12:09:18 +03:00
Rafael da Fonseca a7a39a608c Remove unused imports to fix checkstyle warnings 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #413
 2015-06-15 12:09:17 +03:00
Rafael da Fonseca 96d6aaa293 Fix findbugs ClassCastException in UpgradeSystemVMCmd.java getDetails() isn't called anywhere in the code, either way, implementation is wrong since details is a Map<String, String> and not a Map<String, Map<String,String>> If this piece of could would get run, it would just fail trying to cast String to HashMap<String,String> in line 83 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-06-15 12:09:16 +03:00
Rafael da Fonseca 8634fe5cf5 Remove unused imports to fix checkstyle warnings 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #412
 2015-06-15 12:09:15 +03:00
Rafael da Fonseca 31a4f0ad6b Fix findbugs ClassCastException in ScaleSystemVMCmd.java getDetails() isn't called anywhere in the code, either way, implementation is wrong since details is a Map<String, String> and not a Map<String, Map<String,String>> If this piece of could would get run, it would just fail trying to cast String to Map<String,String> 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-06-15 12:09:14 +03:00
Rafael da Fonseca 85ad1b7e0f Fix 3 findbugs encoding warnings in VmwareStorageProcessor.java Ova templates and metadata should be written to file in UTF-8 Fix warning in UUID generation 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #411
 2015-06-15 12:09:13 +03:00
Rafael da Fonseca ccd7d41ee3 Resolve findbugs encoding warning 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #392
 2015-06-15 12:07:55 +03:00
Rafael da Fonseca 980d858c34 Add import statements, remove unused FileReader import 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #393
 2015-06-15 12:07:49 +03:00
Rafael da Fonseca 9ad8c70baa Fix findbugs encoding warning, all .xml files contain only utf-8/us-ascii compatible characters 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-06-15 12:07:49 +03:00
Rafael da Fonseca 967da97f51 Fix 2 findbugs warnings in VmwareStorageManagerImpl.java Template files and metadata should be written to file in UTF-8 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #410
 2015-06-15 12:06:19 +03:00
Rafael da Fonseca 11fec86ba3 Fix 1 findbugs warning in VmwareResource.java 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #409
 2015-06-15 12:06:11 +03:00
Rafael da Fonseca 474065e98b Fix findbugs encoding warning in VmwareServerDiscoverer.java Input string should only contain safe characters, since it's derived from a Long object. This just gets rid of the findbugs warning 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #408
 2015-06-15 12:06:01 +03:00
Rafael da Fonseca aa56faec51 Fix findbugs warning in VmwareHelper.java Disk descriptors should be written in UTF-8 for Vmware 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #407
 2015-06-15 12:05:38 +03:00
Rafael da Fonseca dc64c7e843 Fix findbugs encoding warning ESX responses should be encoded in UTF-8 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #406
 2015-06-15 12:05:30 +03:00
Rafael da Fonseca f03411ca04 Fix 2 findbugs encoding warnings in VmwareContext.java StreamReaders should use encoding specified in the connection object 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #405
 2015-06-15 12:05:16 +03:00
Rafael da Fonseca 00cdd66351 Fix 3 findbugs warnings OVF and VMX descriptor files should be written in UTF-8 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #404
 2015-06-15 12:05:08 +03:00
Rafael da Fonseca 333d0e2069 Fix 3 findbugs encoding warnings Vmdk descriptor files used by ESX should be UTF-8 encoded 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-06-15 12:05:08 +03:00
Rafael da Fonseca f5f93884d1 Fix findbugs encoding warning Vmds files created by ESX are UTF-8 encoded 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #403
 2015-06-15 12:05:01 +03:00
Rafael da Fonseca f8b364b7c7 Was safe either way as this piece of code should only run in linux, this just gets rid of the findbugs warning 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #402
 2015-06-15 12:04:47 +03:00
Rafael da Fonseca 3299f23ea2 Fix findbugs encoding warning in LibvirtCreatePrivateTemplateFromVolumeCommandWrapper Libvirt templates should be written in UTF-8, default was already doing that so this just gets rid of the findbugs warning 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #401
 2015-06-15 12:04:24 +03:00