etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
27,678 Commits 323 Branches 325 Tags 836 MiB
Commit Graph

27678 Commits

Author SHA1 Message Date
Rafael da Fonseca b869a16332 Remove unused import to fix checkstyle warning 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #400
 2015-06-15 12:04:19 +03:00
Rafael da Fonseca 949e97dec6 Fix findbugs warning in LibvirtConsoleProxyLoadCommandWrapper Encoding is now specified in both server and clients for the console proxy getstatus command For some reason, findbugs did not detect unsafe encoding issue in ConsoleProxyResource.java, is properly specified now though... CitrixConsoleProxyLoadCommandWrapper was specifying system default encoding for operation, should be ok because default for xenserver is UTF-8 since it's linux based, but it's best to specify exact encoding set on the server end to be consistent 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
 2015-06-15 12:04:18 +03:00
Rafael da Fonseca 509c83bc74 Fix findbugs encoding warning in JuniperSrxResource All .xml files contain only utf-8/us-ascii compatible characters. If special characters are added to these files in the future, UTF-8 should be used for cross platform compatibility 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #398
 2015-06-15 12:03:56 +03:00
Rafael da Fonseca 438c90d783 Fix findbugs encoding warning in HttpNfcLeaseMO VMWare ovf files are utf-8 encoded. Relying on default encoding in some platforms such as windows would cause erroneous characters from being read on some fields like description, and could also cause the import to fail, depending on the characters. 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #397
 2015-06-15 12:00:02 +03:00
Rafael da Fonseca cc6d28fc98 Fix another findbugs encoding warning in CitrixResourceBase In this case, using default encoding is desired, since the purpose is to read shell command output, which uses the platform's default encoding. This gets rid of the findbugs warning. 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #396
 2015-06-15 11:59:48 +03:00
Rafael da Fonseca faa38ad416 Fix findbugs encoding warning in CitrixResourceBase Output of text files should be UTF-8, this is the default for linux, will now always use the same format for every platform 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #395
 2015-06-15 11:59:38 +03:00
Rafael da Fonseca aeccd8afdf Fix findbugs encoding issue This is done by calling HttpMethodBase's getResponseBodyAsString() which properly lookup the specified encoding in the request's Content-Type header This also avoids instantiation of two extra strings on the println() and return statements 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #394
 2015-06-15 11:59:09 +03:00
pritisarap12 019f246b35 CLOUDSTACK-8555: Skip volume resize operation for HyperV as it's not 
supported

Signed-off-by: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
This closes #391
 2015-06-15 12:49:12 +05:30
Daan Hoogland 14d9c82369 findbugs: String to byt[] conversion 
decodeBase64() can work on String so the unsafe conversion is not needed

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #361
 2015-06-12 14:57:37 +03:00
Kishan Kavala 39d51bc021 CLOUDSTACK-5409: Include projectid during ACL check while listing S2S Vpn gateways 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #374
 2015-06-12 14:54:44 +03:00
Rajani Karuturi 4900d15e6c Merge branch 'CLOUDSTACK-8551' of https://github.com/karuturi/cloudstack 
This closes #388
 2015-06-12 15:53:08 +05:30
pritisarap12 fd1ef5220b CLOUDSTACK-8553: Unable to launch VM from template because of permission issue 
Signed-off-by: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
This closes #387
 2015-06-12 11:54:23 +05:30
pritisarap12 09abb193a1 CLOUDSTACK-8550: Fixed cleanup issue related to VM 
Signed-off-by: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
This closes #385
 2015-06-12 11:47:25 +05:30
Priti Sarap f61723dcfb CLOUDSTACK-8547: Modify hypervisor check in testpath_snapshot_hardning.py 
Signed-off-by: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
This closes #378
 2015-06-12 11:25:03 +05:30
Rajani Karuturi d504305a98 Fixed CLOUDSTACK-8551 findbugs issue in LdapImportUsersCmd.java 
DM_DEFAULT_ENCODING issue. Used UTF-8
 2015-06-11 17:07:03 +05:30
Rajani Karuturi d46b658ec0 Fixed CLOUDSTACK-8551 Findbugs warning in LdapCreateAccountCmd.java 
byte[].toString() would give reference to the array (ex: [B@6c521576 )
but not the original string.  used new String() to get the text.
 2015-06-11 14:05:03 +05:30
Ian Southam 7ba2f2274a Allow test to run on tiny linux templates using busybox 
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>

This closes #381
 2015-06-10 22:00:54 +02:00
Sanjeev Neelarapu de6538c9e7 SKIP vm migration tests on LXC since it is not a supported hypervisor 
This closes #383
 2015-06-10 17:29:18 +05:30
Gaurav Aradhye 54a664730d CLOUDSTACK-8515: Skipping snapshot test cases on HyperV and LXC 
Signed-off-by: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
This closes #376
 2015-06-10 16:11:34 +05:30
Gaurav Aradhye e3cfe89053 CLOUDSTACK-8546: Correcting skip test code in testpath_vMotion_vmware.py 
Signed-off-by: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
This closes #377
 2015-06-10 16:04:10 +05:30
pritisarap12 84bc2e6127 CLOUDSTACK-8549: Update assert statements in testpath_disable_enable_zone.py 
Signed-off-by: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
This closes #382
 2015-06-10 15:59:45 +05:30
Sateesh Chodapuneedi 5e41a830a5 This closes #373 
CLOUDSTACK-3317 - DVS does not support management\storage network

Added support for Management and Storage Network traffic over VMware DVS in CloudStack deployments. Also added support for storage VLAN over dvPortGroup.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>

CLOUDSTACK-3317 - DVS does not support management\storage network

Use non-zero dvport count while updating dvportgroups of system traffic.
Updated configuration compare logic to avoid update dvportgroup operation unless required.
This would help improve speed in vm/network deployment as the update calls would reduce. Also improved logging.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>

Adding unit tests in class HypervisorHostHelperTest

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>

Added license header to new file being added to repo/branch.

Signed-off-by: Sateesh Chodapuneedi <sateesh@apache.org>
 2015-06-10 02:07:40 +05:30
Sanjeev Neelarapu 8f1e0510cd Skipping all unsupported tests on LXC 
This closes #379
 2015-06-10 13:47:28 +05:30
Gaurav Aradhye 6140db50b3 CLOUDSTACK-8542: Correcting test case in test_vpc_on_host_maintenance.py 
Signed-off-by: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
This closes #360
 2015-06-08 13:37:37 +05:30
Daan Hoogland b272d7717e Revert "Fix 2 findbugs high priority warnings" 
This reverts commit 1ca74dac26.
 2015-06-08 10:01:19 +02:00
Rafael da Fonseca c5437d216f Fix malformed closing tag on comments in cisco .xml files 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #369
 2015-06-08 09:41:13 +02:00
Rafael da Fonseca b9b13d764d Fix another case of unnecessary boxing JuniperSrxResource.java:1280, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.network.resource.JuniperSrxResource.removeDestinationNatRules(Long, Map, List) 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #367
 2015-06-08 09:41:07 +02:00
Rafael da Fonseca 039d632ad3 Fix 3 more findbugs performance alerts, creating Long and Integer unnecessarily F5BigIpResource.java:297, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High F5BigIpResource.java:703, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High F5BigIpResource.java:889, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.network.resource.F5BigIpResource 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #366
 2015-06-08 09:40:59 +02:00
Rafael da Fonseca e8c7069f73 Fix findbugs high priority warning VmwareStorageManagerImpl.java:1023, RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE, Priority: High Redundant nullcheck of datastoreVolumePath, which is known to be non-null in com.cloud.hypervisor.vmware.manager.VmwareStorageManagerImpl.getVolumePathInDatastore(DatastoreMO, String) 
Assertion is not used in runtime, correct way is throw and handle exception without killing app

Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #362
 2015-06-08 09:40:50 +02:00
Rafael da Fonseca 9bac84a3f7 Fix last ocurrence of unnecessary boxing detected by findbugs CiscoVnmcResource.java:266, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.network.resource.CiscoVnmcResource.getIpRangeFromCidr(String) 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #368
 2015-06-08 09:39:02 +02:00
Rafael da Fonseca 38c269d71e Fix performance issue reported by findbugs (unnescessary boxing/unboxing) VmwareResource.java:693, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High VmwareResource.java:4769, DM_BOXED_PRIMITIVE_FOR_PARSING, Priority: High Boxing/unboxing to parse a primitive com.cloud.hypervisor.vmware.resource.VmwareResource.getNetworkStats(String) 
Now op is faster and takes up less memory

Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #365
 2015-06-08 09:32:52 +02:00
Rafael da Fonseca 65383fb8fa Fix another findbugs high priority warning JuniperSrxResource.java:2617, ES_COMPARING_STRINGS_WITH_EQ, Priority: High Comparison of String objects using == or != in com.cloud.network.resource.JuniperSrxResource.manageApplication(JuniperSrxResource$SecurityPolicyType, JuniperSrxResource$SrxCommand, JuniperSrxResource$Protocol, int, int) 
This now correctly compares strings

Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #364
 2015-06-08 09:30:38 +02:00
Rafael da Fonseca 1ca74dac26 Fix 2 findbugs high priority warnings 
VmwareResource.java:315, MS_SHOULD_BE_FINAL, Priority: High
com.cloud.hypervisor.vmware.resource.VmwareResource.s_serviceContext isn't final but should be

VmwareResource.java:331, MS_SHOULD_BE_FINAL, Priority: High
com.cloud.hypervisor.vmware.resource.VmwareResource.s_powerStatesTable isn't final but should be

Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #363
 2015-06-08 09:24:07 +02:00
jeff db69c8e82b Allow PropertiesUtil to read from jar files. 
PropertiesUtil has code for reading from jar files, but the
findConfigFile method will prevent it from ever returning a file in a
jar on the classpath since it always wants to have a "file:" URL and
use the File class.

This commit moves the jar file loading attempt from a catch block to
an else clause, executed if a config file:// URL could not be found.

Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #358
 2015-06-08 09:19:21 +02:00
pritisarap12 0326fb3b5c CLOUDSTACK-8308: Updating Disable/enable host testpath as admin user should not be able to deploy vm on disabled host 
Signed-off-by: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
This closes #356
 2015-06-05 14:08:56 +05:30
wilderrodrigues 93845afd53 Using a try-wioth resrouce block as suggested in @DaanHoogland review. 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #355
 2015-06-04 12:34:05 +02:00
wilderrodrigues 7f4e2c7cf0 Renaming the variable from "s" to "script" 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-04 12:34:05 +02:00
wilderrodrigues 6138d9a690 Coverity issue 1116812 - Replacing concatenation with optionsBuffer.append(option.getKey()).append('=').append(option.getValue()).append(','); 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-04 12:34:05 +02:00
wilderrodrigues 9ff38486a1 Coverity issue 1116677 - Avoiding catching only Exception. Makes the code too britle. - Catching the QemuImgException and throwing it to be caught further in the code - Surrounding the output stream with try/catch and throwing it to be further handled in the code. Closing the output stream quietly. 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-04 12:34:05 +02:00
wilderrodrigues 6271663682 Formatting the code - Adding final modifier and indenting the code 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-04 12:34:04 +02:00
wilderrodrigues c3b4c7a9cf Coverity issue 1116509 - Assigning the the new returned ResultSet to the rs variable in order to get it closed in the finally block 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-04 12:34:04 +02:00
wilderrodrigues abe0990259 Formatting the code - Adding final modifier and indenting the code 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-04 12:34:04 +02:00
wilderrodrigues fe78c76691 Coverity issue: 1012179 - Commenting out unused variable. 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-04 12:34:03 +02:00
wilderrodrigues 159d8c2c97 Formatting the code - Adding final modifier to attributes and indenting the code. 
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
 2015-06-04 12:34:03 +02:00
Gaurav Aradhye f92a50363c CLOUDSTACK-8515: Skipping snapshots tests on HyperV and LXC hypervisors 
Signed-off-by: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
This closes #350
 2015-06-04 10:56:28 +05:30
Rafael da Fonseca 00884b3b0b Fixes LB certificate tests failure when the full path has a special character like whitespace or many others. 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #336
 2015-06-04 00:11:09 +02:00
Daan Hoogland 3d4d152753 CID 1302976 Scanner in try-with-resource 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #352
 2015-06-04 00:09:40 +02:00
Daan Hoogland 109b6e94d3 CID 1302974: Scanner in try-with-resource 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #353
 2015-06-04 00:09:16 +02:00
pritisarap12 9c2a1ea81e CLOUDSTACK-8532: Modification in setupClass to skip testcases rather than throwing an exception on "Exceeding connection limit to Netscaler device" 
Signed-off-by: Gaurav Aradhye <gaurav.aradhye@clogeny.com>
This closes #343
 2015-06-03 15:19:04 +05:30
Rajani Karuturi b31b8425df CLOUDSTACK-8525: NPE while updating the state of the volume after deletion 
The volume is already deleted (may be by the cleanup thread) and hence
the NPE. Added a not null check for the volumevo and returning false
from the state transition

This closes #321
 2015-06-03 11:45:02 +05:30