Commit Graph

35059 Commits

Author SHA1 Message Date
Nicolas Vazquez 5435b0abfe
Direct download certificates additions and improvements (#6104)
* Add direct download certificates listing

* Restore class to original project

* Small refactor

* Register API

* Apply suggestions from code review

Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

* Refactor after review

* Fix checkstyle

* Add hosts mapping to API response

* Improvements on revoke certificate

* Refactor revoke certificate API

* Fix condition

* Filter only certificates not revoked for revokeCertificate API

* Improve upload certificate and add provision certificate API

* Improve certificate response output

* Address review comments

* Refactor revoke cert test

* Fix marvin test

* Address review comments

* Fix issues

* Improvements

* Refactor upload template API response

* Fix response

Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
2022-04-11 22:57:23 -03:00
Nicolas Vazquez 177f04839c
UI: Fix protocol reset after changing provider on Add Primary Storage (#6243) 2022-04-11 20:09:45 +02:00
Abhishek Kumar 63a9da9548
ui: use different icon labe for releaseIpAddress action (#6235)
In publicip view, actions disassociateIpAddress and releaseIpAddress actions are shown same which could cause confusion for user.
Added a different icon and label for releaseIpAddress action

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-04-11 11:45:57 -03:00
nvazquez ed55002795
Merge branch '4.16' 2022-04-11 11:20:10 -03:00
Pearl Dsilva b6072fc826
Allow expunging a VM on a deleted host when using host cache and ConfigDrive userdata service (#6234) 2022-04-11 11:19:37 -03:00
Hoang Nguyen 5eb2b693e9
fixes login button not work and Single Sign-On tab disabled after logout (#6197) 2022-04-11 10:45:51 -03:00
José Flauzino 16f2896940
Persistence of VM stats (#5984)
* Add persistence of VM stats

* Fix API 'since' attribute

* Add license

* Address GutoVeronezi's reviews

* Fix the order of VM stats in the API response

* Fix msid in VM stats data

* Fix disk stats and add minor improvements

* Add log message

* Build string using ReflectionToStringBuilderUtils

* Rerun checks

Co-authored-by: joseflauzino <jose@scclouds.com.br>
2022-04-11 10:42:21 -03:00
Rohit Yadav 1b46635947 Merge remote-tracking branch 'origin/4.16' into main 2022-04-11 16:13:56 +05:30
dahn ee2ded8200
potential null pointer in condition; AYAI9l8k5Irk9_td-cXb (#6237)
Co-authored-by: Daan Hoogland <dahn@onecht.net>
2022-04-11 16:07:11 +05:30
Nicolas Vazquez e0ce0228cc
ui: Fix Add secondary storage (#6241)
This PR fixes the Add secondary storage wizard failing due to a missing parameter
Fixes: #6239
2022-04-11 13:46:36 +05:30
Rohit Yadav 8add4df0fa
.github: fix github actions error
Fixes double wrapping of variable
2022-04-08 19:39:31 +05:30
Rohit Yadav 5b617ba3ff Merge remote-tracking branch 'origin/4.16' 2022-04-08 15:28:20 +05:30
Rohit Yadav 4c89f08ebf .github: fix github event/pr username for conflict msg advice
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-08 15:27:58 +05:30
Pearl Dsilva c8ce6c0496
ui: Project owner (normal user) unable to perform any operations in the project (#6233) 2022-04-08 15:26:06 +05:30
Rakesh d2aa13fd78
Display proper gateway length in health check result (#6226)
The output always returns 1 since all gateways are present in one line
but the actual output should be the number of gateways present
in that line

Co-authored-by: Rakesh Venkatesh <rakeshv@apache.org>
2022-04-08 15:25:55 +05:30
Abhishek Kumar e7071ec196
server: increment deviceid while importing vm data volumes (#6123)
Fixes #6121

deviceId for a volume/disk is never used by CloudStack VMware hypervisor plugin. Still it would be correct to increment value for each data volume/disk, behaviour similar to adding data volumes/disks.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-04-08 15:24:10 +05:30
slavkap 2b075ed39e
Storage-based Snapshots for KVM VMs (#3724)
* VM snapshots of running KVM instance using storage providers plugins for disk snapshots

Added new virtual machine snapshot strategy which is using storage providers plugins to take/revert/delete snapshots.
You can take VM snapshot without VM memory on KVM instance, using storage providers implementations for disk snapshots.
Also revert and delete is added as functionality. Added Thaw/Freeze command for KVM instance.
The snapshots will be consistent, because we freeze the VM during the snapshotting. Backup to secondary storage is executed after
thaw of the VM and if it is enabled in global settings.

* Removed duplicated functionality

Set few methods in DefaultVMSnapshotStrategy to protected to reuse them
without duplicating the code. Remove code that is actualy not needed

* Added requirements in global setting kvm.vmstoragesnapshot.enabled

Added more information in kvm.vmstoragesnapshot.enabled global setting,
that it needs installation of:
- qemu version 1.6+
- qemu-guest-agent installed on guest virtual machine

when the option is enabled

* Added Apache license header

* Removed commented code

* If "kvm.vmstoragesnapshot.enabled" is null should be considered as false

* removed unused imports, replaced default template

Removed unused imports which causing failures and replaced template to
CentOS8

* "kvm.vmstoragesnapshot.enabled" set to dynamic

* Getting status of freeze/thaw commands not the return code

Will chacke the status if freeze/thaw of Guest VM succeded, rather than
looking for return code. Code refactoring

* removed "CreatingKVM" VMsnapshot state and events related to it

* renamed AllocatedKVM to AllocatedVM

the states should not be associated to a hypervisor type

* loggin the result of "drive-backup" command

* Check which VM snapshot strategy could handle the vm snapshots

gets the best match of VM snapshot strategy which could handle the vm
snapshots on KVM.
Other storage plugins could integrate with this functionality to support group snapshots

* Added poolId in canHandle for KVM hypervisors

Added poolId into canHandle method used to check if all volumes are on
the same PowerFlex's storage pool

* skip smoke tests if the hypervisor's OS type is CentOS

This PR works with functionality included in qemu-kvm-ev which
does not come by default on CentOS. The smoke tests will be skipped if
the hypervisor OS is CentOS

* Added missed import in smoke test

* Suggested change to use ` org.apache.commons.lang.StringUtils.isNotBlank`

* Fix getting device on Ubuntu

On Ubuntu the device isn't provided and we have to get it from
node-name parameter. For drive-backup command (for Ubuntu) is needed and job-id which
is the value of node-name (this extra param works on Ubuntu and CentOS as well).

* Removed new snapshot states and functionality for NFS

* throw CloudRuntimeException

provide a properer error message when delete VM snapshot fails

* exclude GROUP snapshots when listing snapshots

* Skip tests if there is pool with NFS/Local

* address comments
2022-04-07 21:42:12 -03:00
Pearl Dsilva c1c381fcd1
api: Prevent modifying acl rules order for default ACLs (#6187) 2022-04-07 21:31:29 -03:00
Pearl Dsilva daa7bdb046
upgrade: update minreq.sysvmtemplate.version to the latest template version (#6227) 2022-04-07 21:29:23 -03:00
Rohit Yadav 6bf812cdc9 .github: fix github action workflows
(commiting this directly to main, otherwise the PR will kick the actions
of the PR branch)

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-07 22:48:34 +05:30
Rohit Yadav 5630ca4411 .github: update action tag as per https://issues.apache.org/jira/browse/INFRA-23109
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-07 21:24:43 +05:30
Rohit Yadav 1cdacccdc0
maven: support JaCoCo and other quality checks (#6228)
This enables jacoco, which didn't run before with the -P quality due to
missing passing of jacoco arg line to surefire plugin.

This also adds support for jacoco/quality builds using Github action and
posting of the PR coverage data using a new action step.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-07 20:48:48 +05:30
Hoang Nguyen 676fe31ca9
UI: Fixes removing undesired API parameters on form submit (#6196)
* fixes removing undesired api parameters

* remove comment
2022-04-07 11:00:02 -03:00
Wido den Hollander 68fa9a1061
Allow storage.overprovisioning.factor to be <1 which allows underprovisioning of storage pools (#6218)
By setting the value to 0.5 (example) we can underprovision a storage pool. This is useful in
cases with Ceph where it reports the raw size of the cluster where the replication factor is
not taken into account.

Fixes: ##6205
2022-04-07 09:50:55 -03:00
Rohit Yadav 2b1c4fbe6e
.github: fix workflow settings and allow branch pushes to main by committers (#6225)
This fixes the comment message for merge conflict checker and resets the
github branch protection for main in case of need by the RM.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-07 13:49:03 +05:30
Rohit Yadav 1500e1f70c
.github: add merge conflict checker per RM request (#6221)
* .github: add merge conflict checker per RM request

Adds a merge conflict checker workflow per current RM (Nicolas's)
request.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* Update merge-conflict-checker.yml

* Update merge-conflict-checker.yml
2022-04-06 23:52:55 +05:30
Rohit Yadav 9a8c7b1a8c
.github: fix first PR welcome message by boring-cyborg (#6217)
* .github: fix first PR welcome message

Adds newlines

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* add community slack link

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* add rules for storage label

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* remove semantic yaml which is not needed now

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* disable the strict check to assist RM

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-06 23:52:26 +05:30
JoaoJandre afc819e5c8
Added new field to updateBackupOffering API. (#6190)
* Added new field to updateBackupOffering API.

* Fix some unit tests.

Co-authored-by: João Paraquetti <joao@scclouds.com.br>
Co-authored-by: Joao <JoaoJandre@gitlab.com>
2022-04-06 09:56:35 -03:00
Rohit Yadav 133b195688
Probot integrations (#6211)
* .github: add boring-cyborg integration

This add boring-cyborg bot app added to apache org that provides:
- labeling PRs by file paths
- welcome and first msg for new contributors

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* .github: add semantic title checking app

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-06 16:50:00 +05:30
Daniel Gruno 0cb949451a
[infra] adding back original collaborator 2022-04-06 11:25:39 +02:00
Daniel Gruno 553809b4d6
[Infra] testing adding myself as collaborator 2022-04-06 11:24:22 +02:00
Rohit Yadav e65825c4a1
.asf.yaml: dummy fix to re-kick asf-infra integration (#6210)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-06 14:35:55 +05:30
Nicolas Vazquez 4193109c1d
ui: Logout before login (#6193)
This PR calls the logout API before login, to cleanup any duplicate sessionkey, as it was done on the legacy UI: #4326
Fixes: #6127
2022-04-06 14:33:30 +05:30
Wei Zhou ca8782b703
api: add vpcname to networkacl response (#6207)
This PR fixes the vpc uuid in info card of network acls
2022-04-06 09:33:28 +05:30
Pearl Dsilva 9cc8da2a30
api: Update account type when updating account role (#6156)
* api: Update account type when updating account role

* extract code to validate role change
2022-04-06 00:50:56 -03:00
nvazquez 306baea228
Merge branch '4.16' 2022-04-06 00:19:12 -03:00
Wei Zhou e4b6992def
server: fix list reserved/free public ips in project (#6198) 2022-04-06 00:17:31 -03:00
Wei Zhou c61ea9f96d
VR: Do not add iptables rules for the revoked ip addresses (#6189) 2022-04-06 00:16:47 -03:00
Wei Zhou 47454eca7d
VR: add '-m <protocol>' for tcp or udp protocol (#6188) 2022-04-06 00:16:12 -03:00
Rohit Yadav a66dee4374 .asf.yaml: introduce new .asf.yaml file
As per
https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-04-06 00:20:17 +05:30
Abhishek Kumar 7e6d1f1f85
ui: fix acl rules listing (#6206)
When a rule in the list has start-end port, UI listing was failing.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-04-05 19:40:41 +05:30
Pearl Dsilva 1c8d8cdef2
ui: Fix label for LUN number (#6204) 2022-04-05 12:03:44 +02:00
Wei Zhou 960513aa97
test: update test_kubernetes_clusters.py to support advanced zone with security groups (#6183) 2022-04-05 12:02:18 +02:00
David Jumani 5ab4309298
agent: Detect existing hosts with UEFI support (#6139)
* agent: Pass uefi enabled status as part of ready command

* Cleanup

* Fix checkstyle

* Save uefi status if different
2022-04-04 23:31:54 -03:00
John Bampton f12e1a39d9
Remove duplicate entry from `.gitignore` (#6192) 2022-04-04 14:42:15 -03:00
Pearl Dsilva 022906d9bd
UI: Fix minor UI issues (#6182)
* UI: Fix minor UI issues

* enable add button for acl tags - only when key and value are provided

* fix autosize deprecation warning

* update form variable

* fix issue observed when opening the createVPNConnection form

* list vpn gateway IPs when creating vpn connection

* fix issue when sumitting create vpn customer gateway form

* Fix updateAccount form - Physical Network View ; add confirmation message during update of physical network state

* revert backend change

* fix migrate data form

* fix disk offering form

* 13: remove redundant form entries

* 14: update form field for vpn customer gateway - dead peer detection

* cleanup

* remove newline
2022-04-04 09:54:21 -03:00
Rakesh b88cfc226e
Mount disabled storage pool on host reboot (#6164)
* Mount disabled storage pool on host reboot

Add a global setting so that disabled pools will be mounted
again on host reboot

* fix build error

* Update description

* add cluster-wide support

Co-authored-by: Rakesh Venkatesh <rakeshv@apache.org>
2022-04-01 23:38:32 -03:00
Pearl Dsilva 2c8c476656
CKS: Support deployment of CKS clusters on Advanced zones with security groups (#6132)
* CKS: Support deployment of CKS clusters on Advanced zones with security groups

* use available constant

* address comments -
- Ingress sg rule for port 22 & 6443
- Use constant to define securityGroup Name
- rename variable name from type -> vmType

* unique name for security group + foreign key

* use constants
2022-04-01 13:19:54 -03:00
nvazquez 5f3a392eb5
Merge branch '4.16' 2022-04-01 13:14:09 -03:00
Abhishek Kumar 66a6671e0b
ui,refactor: fix missing label in update network form (#6181)
updateinsequence param for updateNetwork API wasn't have correponding label in UI.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-04-01 13:12:50 -03:00