Commit Graph

356 Commits

Author SHA1 Message Date
Wei Zhou 662b478d45 Replace some profiler.getDuration with profiler.getDurationInMillis after commit 5557ad55 2015-08-21 13:36:27 +02:00
Remi Bergsma 64ff67da55 Merge pull request #654 from DaanHoogland/CLOUDSTACK-8656
Cloudstack 8656: do away with more silently ignoring exceptions.a lot of messages added.
some restructuring for test exception assertions and try-with-resource blocks

* pr/654: (29 commits)
  CLOUDSTACK-8656: more logging instead of sysout
  CLOUDSTACK-8656: use catch block for validation
  CLOUDSTACK-8656: class in json specified not found
  CLOUDSTACK-8656: removed unused classes
  CLOUDSTACK-8656: restructure of tests
  CLOUDSTACK-8656: reorganise sychronized block
  CLOUDSTACK-8656: restructure tests to ensure exception throwing
  CLOUDSTACK-8656: validate the throwing of ServerApiException
  CLOUDSTACK-8656: logging ignored exceptions
  CLOUDSTACK-8656: try-w-r removes need for empty catch block
  CLOUDSTACK-8656: try-w-r instead of clunckey close-except
  CLOUDSTACK-8656: deal with empty SQLException catch block by try-w-r
  CLOUDSTACK-8656: unnecessary close construct removed
  CLOUDSTACK-8656: message about timed buffer logging
  CLOUDSTACK-8656: message about invalid number from store
  CLOUDSTACK-8656: move cli test tool to separate file
  CLOUDSTACK-8656: exception is the rule for some tests
  CLOUDSTACK-8656: network related exception logging
  CLOUDSTACK-8656: reporting ignored exceptions in server
  CLOUDSTACK-8656: log in case we are on a platform not supporting UTF8
  ...

Signed-off-by: Remi Bergsma <github@remi.nl>
2015-08-14 21:38:49 +02:00
Daan Hoogland adcd0c0c0d CLOUDSTACK-8656: use catch block for validation 2015-08-14 17:25:04 +02:00
Daan Hoogland 237f922ff7 CLOUDSTACK-8656: removed unused classes 2015-08-14 16:14:17 +02:00
Daan Hoogland bb8facc37c CLOUDSTACK-8656: restructure of tests 2015-08-14 16:07:12 +02:00
Daan Hoogland 882de20e1c CLOUDSTACK-8656: reorganise sychronized block 2015-08-14 16:03:17 +02:00
Daan Hoogland a3ae8e0645 coverity 1315774: improvement of code to negate false positive 2015-08-12 01:04:06 +02:00
Daan Hoogland ea886910d8 CLOUDSTACK-8656: messages about classloader issues in ipc framwork 2015-08-04 14:06:06 +02:00
Daan Hoogland b060c66096 CLOUDSTACK-8656: dummy main removed 2015-08-04 13:35:30 +02:00
Daan Hoogland e8a00ed989 CLOUDSTACK-8656: try-with-resource in vmsd reader
moved closeable util function up the hierarchy
2015-08-04 11:37:06 +02:00
Daan Hoogland 75093dcd8f CLOUDSTACK-8656: checkstyle no longer used import removed 2015-08-03 21:10:11 +02:00
Daan Hoogland 1f460f4174 CLOUDSTACK-8656: messages on SQL exception in DbUtils! 2015-08-03 20:49:02 +02:00
Daan Hoogland 87ae150159 CLOUDSTACK-8656: replace empty catch block on close by try-with-resource 2015-08-03 19:42:47 +02:00
Daan Hoogland 16330e92da CLOUDSTACK-8656: silent close failure of clustering socket log as info 2015-08-02 19:55:14 +02:00
Daan Hoogland e2b6237464 CLOUDSTACK-8656: debug messages on interupted exceptions 2015-07-30 16:03:10 +02:00
Daan Hoogland 85e002b230 CLOUDSTACK-8656: filling empty catch block with info messages
using regexp "catch\s*\(\s*(Exception|Throwable)\s*\w*\)\s*\{\s*\}"
2015-07-30 15:51:52 +02:00
Daan Hoogland 03b076cd1b coverity 1116668: conditionally close ds provided connection
Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #599
2015-07-17 13:22:43 +02:00
Daan Hoogland f15eaec254 coverity 1116759: possible null-pointer before indexOf-call move the if-block inside the next, guarded one
Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #600
2015-07-17 13:12:26 +02:00
Daan Hoogland 8849d506cb coverity 1116718: neglected jarinputstream when no entry found
Signed-off-by: Daan Hoogland <daan@onecht.net>
2015-07-17 13:12:26 +02:00
Daan Hoogland a1ff7e24f3 coverity 1311707: only sql exception on select would have been caught. passing all runtime exceptions through
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #584
2015-07-14 13:41:09 +02:00
Daan Hoogland b0136c56e7 coverity 1116564: complicated update of sequences fixed
Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #564
2015-07-09 21:30:24 +02:00
Daan Hoogland 4ad178e4b1 rats: licenses added
Signed-off-by: Daan Hoogland <daan@onecht.net>

This closes #535
2015-07-07 13:48:20 +02:00
Daan Hoogland d8ab5f3ab8 findbugs: equals unit tests
Signed-off-by: Daan Hoogland <daan@onecht.net>
2015-07-07 13:48:19 +02:00
Daan Hoogland 34629446b6 findbugs equals(obj) implementations go against the contract these are removed from the call into separate calls
Signed-off-by: Daan Hoogland <daan@onecht.net>
2015-07-07 13:48:19 +02:00
wilderrodrigues 916aead9ab Using Profiler class, from the utils package, instead of System.currentTimeMillis()
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>

This closes #525
2015-06-25 09:14:23 +02:00
wilderrodrigues 212ae884a1 Formatting class ClusterServiceServletImpl
- Splitting format commit from fix commit.

Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
2015-06-25 09:14:23 +02:00
wilderrodrigues e4f7fb74ef Using Profiler class, from the utils package, instead of System.currentTimeMillis()
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>

This closes #524
2015-06-25 09:13:46 +02:00
wilderrodrigues ea1f2eb049 Formatting class ClusterManagerImpl
- Splitting format commit from fix commit.

Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
2015-06-25 09:13:46 +02:00
wilderrodrigues 5557ad5588 Offer a getDurationInMillis() method in the Profiler utility class
- New implementation uses nanoseconds. Due to that, the places where the Profiler is used as a Monitor and/or
     a stopwatch will suffer with the difference in the return
   - Also added a getDuration(), which returns the time in nanoseconds in case someone wants to use it instead
   - Added an extra test to check if the getDuration() works fine with nanoseconds
   - Fixed the test that checks the time in milliseconds: I added an error margin to cover the test better

Signed-off-by: Daan Hoogland <daan@onecht.net>
2015-06-24 09:36:40 +02:00
Rafael da Fonseca 2993291e7c Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warning in AsyncJobDaoImpl.java
Signed-off-by: Rajani Karuturi <rajanikaruturi@gmail.com>

This closes #475
2015-06-18 14:35:52 +05:30
Rafael da Fonseca 441a13252a Re-run travis
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>

This closes #454
2015-06-17 12:15:23 +02:00
Rafael da Fonseca 9f7c379a88 Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in RpcProviderImpl.java Assert isn't used in prod runtime
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
2015-06-17 12:15:23 +02:00
Rafael da Fonseca eeeb2bb31d Fix findbugs warning in ClusterManagerImpl.java ManagementServerHostDao.findByMsid takes long as input, and a boxed Long was being created for it
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #420
2015-06-15 12:09:29 +03:00
Rafael da Fonseca 89a07084c5 Fix findbugs DMI_RANDOM_USED_ONLY_ONCE warning in TransportAddress.java Changed to recommended SecureRandom instead of Random
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #416
2015-06-15 12:09:22 +03:00
Rafael da Fonseca 4e0fe469dd Fix findbugs DMI_RANDOM_USED_ONLY_ONCE warning in ServerTransportProvider.java Changed to recommended SecureRandom instead of Random Moved initializers to constructor
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

This closes #415
2015-06-15 12:09:20 +03:00
Rohit Yadav ab3b3c7fa1 framework: don't use raw SQL statements to save certificate in KeystoreDaoImpl
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit fb88a11f82)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-05-29 18:33:30 +02:00
Daan Hoogland 1c408dec37 Merge branch '4.5' after 4.5.1 vote passes 2015-05-07 16:03:26 +02:00
Rohit Yadav 4ba72a877c Updating pom.xml version numbers for release 4.5.2-SNAPSHOT
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-05-07 15:33:01 +02:00
Rohit Yadav 069aa4e5f3 CLOUDSTACK-8433: remove awsapi db usage and add upgrade cleanup path
- Removes awsapi db properties usage across codebase
- Removes references from spring xmls, test cases and TransactionLegacy
- Adds sql command to drop database cloudbridge in schema-451to460-cleanup.sql

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-05-06 15:22:04 +02:00
Rohit Yadav 0eb4eb2370 Updating pom.xml version numbers for release 4.5.1
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-05-04 12:17:03 +02:00
Koushik Das 6378d37c5e CLOUDSTACK-8425: Job framework: Same internal job can execute simultaneously
The same internal job was simultaneously getting executed by 2 worked threads.
The fix is to ensure that job gets scheduled for execution from a single place.

(cherry picked from commit 6dfb8ab03e)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-29 16:50:40 +02:00
Koushik Das 6dfb8ab03e CLOUDSTACK-8425: Job framework: Same internal job can execute simultaneously
The same internal job was simultaneously getting executed by 2 worked threads.
The fix is to ensure that job gets scheduled for execution from a single place.
2015-04-29 11:15:59 +05:30
Rajani Karuturi 0b8355920e Merge branch 'volume-upload' into master
This closes #206
2015-04-29 11:12:53 +05:30
Santhosh Edukulla 86943da26e Fixed few coverity issues
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
(cherry picked from commit 0a9742f914)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-27 14:43:48 +02:00
KC Wang 01864ef77c CLOUDSTACK-6697: bigswitch networking plugin update
1. provide compatibility with the Big Cloud Fabric (BCF) controller
   L2 Connectivity Service in both VPC and non-VPC modes
2. virtual network terminology updates: VNS --> BCF_SEGMENT
3. uses HTTPS with trust-always certificate handling
4. topology sync support with BCF controller
5. support multiple (two) BCF controllers with HA
6. support VM migration
7. support Firewall, Static NAT, and Source NAT with NAT enabled option
8. add VifDriver for Indigo Virtual Switch (IVS)

This closes #151

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-09 13:02:02 +05:30
Rohit Yadav aada8fe1d5 CLOUDSTACK-8372: Encrypt key column when saving key in keystore table
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 6c5cf04d62)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-08 14:37:14 +05:30
Rohit Yadav 6c5cf04d62 CLOUDSTACK-8372: Encrypt key column when saving key in keystore table
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-08 14:35:17 +05:30
Jayapal 2f1863cae0 Avoid logging password when adding srx device
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit a1cc43fee2876463c2ca65e9e9d7e81be48a136e)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-13 15:02:27 +05:30
Jayapal 32fe64ce1b Avoid logging password when adding srx device
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-03-13 15:01:06 +05:30
Rohit Yadav 74f9adbe3e engine: Add Upgrade path from 4.5.0 to 4.5.1
Encrypts:
- Remote access vpn preshared key
- StoragePool's user info
- Keystore's key

This closes #112

(cherry picked from commit cfd4573335)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Conflicts:
	engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java
2015-03-12 13:02:45 +05:30