reviewed-by: Devdeep
Description:
Incorporating more changes from Alena's review.
Modified the Nexus Enable and Disable commands
to return CiscoNexusVSMResponse instead of
SuccessResponse.
Put event annotations for enable/disable functions
that the enable/disable nexus commands cal into.
reviewed-by: Devdeep
Description:
Removed the vcenter_dc_name and vcenter_ipaddr
fields from the virtual_supervisor_module
table, the CiscoNexusVSMDeviceVO, addClusterCmd,
and all other references to these two fields.
Fixing null pointer exceptions when checking
for nexus related global parameter values in
addClusterCmd.
reviewed-by: sateesh
Description:
Adding an optional flag to the addCluster command,
"addvsmflag". If this is set to true, the API will
throw an exception if any VSM parameter is missed
out. The above bug was running into a DB exception
because the vCenter ipaddress wasn't passed in and
the API didn't catch it.
Description:
Incorporating more changes post review by Alena.
1. Renamed the ListCiscoVSMDetailsCmd command
to ListCiscoNexusVSMsCmd. The command will
return a list of VSMs always, depending on
what parameter is passed to it. If a clusterId
is passed to it, it will return the VSM
associated to that cluster, if present. If
a zoneId is passed in, it will return a list
of all VSMs configured for any clusters of
type VMware within that zone. If neither is
passed, it will return a list of all VSMs
configured in the management server. If no
VSMs are found, it will return an exception
response.
2. Cleaned up miscellaneous code.
-When in add cluster screen, show the add vSwitch fields when
hypervisor == VMware and 'vmware.use.nexus.vswitch' configuration
flag is enabled.
-Remove 'add Nexus vSwitch' checkbox, as the vSwitch fields will
always be shown for VMware if the above config flag is set.
commit 7859d289debae622a15fdb6bda854a8936fd35cb
Author: Pranav Saxena <pranav.saxena@citrix.com>
Date: Tue May 22 23:29:31 2012 +0530
UI does not support RAW format when hypervisor used is OVM in upload volumes
Description:
More changes incorporating Alena's review comments:
1. Changed id to clusterId for better naming.
2. Changed the name of GetCiscoVSMByClusterIdCmd
to ListCiscoVSMDetailsCmd.
3. Removed the GetCiscoVSMDetailsCmd command.
4. Removed catch{} blocks in each of the Nexus
related APIs since the exceptions raised in
the API implementations will be caught in the
command dispatcher.
5. Added ActionEvent annotation to
deleteCiscoNexusVSM() function.
6. Modified each Nexus API command's
getEntityOwnerId() to return
Account.ACCOUNT_ID_SYSTEM.
Description:
Putting in code changes as per Alena's reviews:
Replaced references to CiscoNexusVSMDeviceVO
in GetCiscoVSMByClusterIdCmd to work with an
interface that CiscoNexusVSMDeviceVO instead,
since VO objects should not be directly accessed
in APIs.
Made associated changes in other files.
More commits incorporating Alena's review comments
will follow.
Changes:
- Read the HttpURLConnection responseMessage.
- If not found check if there is "X-Description" header that gives out a message
- if not use a default error string with status code.
Description:
Putting in table creation DMLs in upgrade script
when upgrading from Acton (3.0.2) to Bonita (3.0.3).
Please note that the field names in the tables need
to be changed as per naming conventions. Those changes
will be checked in in an upcoming commit.