Jayapal
140cd7c227
CLOUDSTACK-8324: Fixed config key in multiple places
2015-07-10 09:47:09 +05:30
Jayapal
14d53634a8
CLOUDSTACK-8324: Removed using config drive label from the uservmservice
2015-07-10 09:47:03 +05:30
Jayapal
deb694c201
CLOUDSTACK-8324: Added migration changes for config drive
2015-07-10 09:39:27 +05:30
wilderrodrigues
ea9db195ed
Extracting local variable in order to make the code more readable.
...
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
2015-06-29 09:59:11 +02:00
wilderrodrigues
4690c3d844
Formatting the code of the AgentManagerImpl class
...
Signed-off-by: wilderrodrigues <wrodrigues@schubergphilis.com>
2015-06-29 09:59:10 +02:00
wilderrodrigues
5557ad5588
Offer a getDurationInMillis() method in the Profiler utility class
...
- New implementation uses nanoseconds. Due to that, the places where the Profiler is used as a Monitor and/or
a stopwatch will suffer with the difference in the return
- Also added a getDuration(), which returns the time in nanoseconds in case someone wants to use it instead
- Added an extra test to check if the getDuration() works fine with nanoseconds
- Fixed the test that checks the time in milliseconds: I added an error margin to cover the test better
Signed-off-by: Daan Hoogland <daan@onecht.net>
2015-06-24 09:36:40 +02:00
Daan Hoogland
c45c9bfeef
findbugs UC useless condition not sure what findbugs means yet, but this should at least turn both warnings into one.
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
This closes #490
2015-06-19 15:53:09 +02:00
Rafael da Fonseca
a2129b2940
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VmWorkJobDispatcher.java Assert isn't used in prod runtime, null is properly checked in method
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #446
2015-06-17 12:08:19 +02:00
Rafael da Fonseca
d056c3d279
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in VirtualMachineManagerImpl.java Removed two unnecessary null checks as this piece of code will only run if answer is not null, as satified in condition stated in line #1253
...
Signed-off-by: Daan Hoogland <daan.hoogland@gmail.com>
This closes #445
2015-06-17 12:07:54 +02:00
Rafael da Fonseca
0f4aac7359
Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in AgentManagerImpl.java Assert isn't used in runtime, null is properly checked in method
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closes #444
2015-06-15 12:17:53 +03:00
Abhinandan Prateek
4222364bea
CLOUDSTACK-8491: Host maintenance fails if a vm on it is running a custom service offering VM
2015-05-21 10:56:33 +05:30
Koushik Das
5f66679df3
CLOUDSTACK-8452: Exclude non-routing hosts from getting rebalanced as part of agent LB
...
For agent LB, only routing hosts needs to be considered
2015-05-08 10:48:39 +05:30
Daan Hoogland
1c408dec37
Merge branch '4.5' after 4.5.1 vote passes
2015-05-07 16:03:26 +02:00
Anshul Gangwar
866cc41145
CLOUDSTACK-8423: [Xenserver] Improved the performance for processing of ClusterVMMetaDataSync command which can cause slowness in DB if there are huge number of VMs
...
this closes #204
2015-04-30 14:44:36 +05:30
Likitha Shetty
e1db982d6b
CLOUDSTACK-8410. ESXi host stuck disconnects frequently.
...
During ping task, while scanning and updating status of all VMs on the host that are stuck in a transitional state
and are missing from the power report, do so only for VMs that are not removed.
(cherry picked from commit de7173a0ed )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-29 16:50:40 +02:00
Likitha Shetty
de7173a0ed
CLOUDSTACK-8410. ESXi host stuck disconnects frequently.
...
During ping task, while scanning and updating status of all VMs on the host that are stuck in a transitional state
and are missing from the power report, do so only for VMs that are not removed.
2015-04-28 09:15:22 +05:30
Santhosh Edukulla
86943da26e
Fixed few coverity issues
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
(cherry picked from commit 0a9742f914 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-27 14:43:48 +02:00
MS
b34202a84e
CLOUDSTACK-8387 - Close mgmt server peer socket on failure, without relying on autoclose
2015-04-15 09:50:32 -07:00
MS
42a8253993
CLOUDSTACK-8387 - Close mgmt server peer socket on failure, without relying on autoclose
2015-04-15 09:49:48 -07:00
MS
fde2615c33
CLOUDSTACK-8387 - Close mgmt server peer socket on failure, without relying on autoclose
2015-04-15 08:43:37 -07:00
MS
aab0bfc809
CLOUDSTACK-8387 - Close mgmt server peer socket on failure, without relying on autoclose
2015-04-15 08:43:02 -07:00
MS
cb7bcf23fe
CLOUDSTACK-8387 - Don't autoclose new mgmt server peer connections as soon as they open
2015-04-15 08:18:24 -07:00
MS
5506ec9936
CLOUDSTACK-8387 - Don't autoclose new mgmt server peer connections as soon as they open
2015-04-15 08:16:33 -07:00
Rohit Yadav
37820e15f2
CLOUDSTACK-7593: allow nic type to be fetched from vm's details
...
(cherry picked from commit 43db75c319 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
2015-04-13 15:47:03 +05:30
Rohit Yadav
43db75c319
CLOUDSTACK-7593: allow nic type to be fetched from vm's details
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-04-13 15:44:09 +05:30
Daan Hoogland
fa56045665
findbugs: wrapper object comparison (fixed)
2015-03-25 17:12:51 +01:00
wilderrodrigues
40eb579115
TK-3135 fixes for VPC restart
...
* removed the "is redundant" flag form the addVpcRouterToGuestNetwork() method
* removed the "is redundant" flag from the removeVpcRouterFromGuestNetwork() method
* changed the path of the master.py file in the keepalived.conf.temp file
* the call to routerDao.addRouterToGuestNetwork() in the VpcRouterDeploymentDefinition is not needed. That step will be performed once a VM is created
- In addition, when restarting a VPC the routers will have the guest net configured, if any exists.
* Pushing the POM.xml as well, to use the old Jetty for now. Could not fix the logging problem. Will replace the POM with master version after VPC is done.
2015-03-16 11:39:17 +01:00
wilderrodrigues
8f9f39fa39
[TK-3119] Fix NPEs and improve exception handling + error messages
2015-03-16 11:39:14 +01:00
Daan Hoogland
43a39d1eb0
findbugs: possible nullpointer
2015-02-19 10:27:51 +01:00
Daan Hoogland
0f8a055dff
findbugs: equals() call on Long instead of =-comparison
2015-02-19 10:23:10 +01:00
Daan Hoogland
8ad2e309a4
CLOUDSTACK-8238 handling of retry ping improved
...
Fixed on 4.4 and master but not on 4.5, cherry-picked on 4.5 using commit
fbafc957dc
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
engine/orchestration/src/com/cloud/agent/manager/DirectAgentAttache.java
2015-02-16 11:35:41 +05:30
Santhosh Edukulla
78bfaa79cf
Fixed few coverity issues like invalid boxing unboxing issues, resource leaks, null dereferences
...
(cherry picked from commit ef6ec7b276 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-06 16:50:20 +05:30
Rohit Yadav
fb1069ace9
agent: don't investigate if host is null, send alert instead
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-05 16:42:56 +05:30
Rohit Yadav
7c41a1184c
agent: don't investigate if host is null, send alert instead
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-05 16:42:13 +05:30
Rohit Yadav
e40b06e9ca
AgentAttache: allow checkonhost command in maintenance, cancel if only allowed
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-05 16:29:44 +05:30
Rohit Yadav
61dfb2d625
AgentAttache: allow checkonhost command in maintenance, cancel if only allowed
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-05 16:29:03 +05:30
Santhosh Edukulla
c25263ba81
Fixed Coverity Issues
2015-02-05 15:59:29 +05:30
Devdeep Singh
0e4d91aa91
CLOUDSTACK-6924. To attach a volume if a volume needs to be moved to another storage
...
pool, the source and destination pools cannot be local and cluster/zone and vice versa.
Cloudstack detects it and throws a exception. However, the end user only sees an
unexpected exception and not the reason for failure. Fixed it by making sure the
reason for the failure is correctly captured and shown to the end user.
(cherry picked from commit cffae8eef0 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Conflicts:
server/src/com/cloud/storage/VolumeApiServiceImpl.java
2015-02-02 14:36:07 +05:30
Kishan Kavala
0c1172ffe9
Network offering usage event should be logged for UserVms only
...
(cherry picked from commit 42cecbb000 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-02 14:27:24 +05:30
Likitha Shetty
294f5bf331
CLOUDSTACK-8114. Ensure VM stop and then start updates the volume path correctly in the DB.
...
(cherry picked from commit 521258bafb )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-02 14:27:04 +05:30
Likitha Shetty
bcbfe3bdee
CLOUDSTACK-8129. Cold migration of VM across VMware DCs leaves the VM behind in the source host.
...
If VM has been cold migrated across different VMware DCs, then unregister the VM from source host.
(cherry picked from commit 15b348632d )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-02 13:51:47 +05:30
Likitha Shetty
45d32234a6
CLOUDSTACK-8112. CS allows creation of VM's with the same Display name when vm.instancename.flag is set to true.
...
Before registering a VM check if a different CS VM with same name exists in vCenter.
(cherry picked from commit 33179cce56 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-02 13:51:22 +05:30
Santhosh Edukulla
737edd90dc
Fixed few coverity patches
...
NPE in delete firewall rules observed, cherry-picking fix from master.
(cherry picked from commit 31a42d2b7a )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-02-02 12:48:38 +05:30
Rohit Yadav
664186f483
CLOUDSTACK-8160: use preferable protocols
...
(cherry picked from commit debfcdef78 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-21 18:04:45 +05:30
Rohit Yadav
debfcdef78
CLOUDSTACK-8160: use preferable protocols
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-21 18:02:58 +05:30
Sanjay Tripathi
8790b84b20
CLOUDSTACK-7940: Exception printed completely on the UI. Not in a readable format.
...
(cherry picked from commit dda2994936 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-20 11:34:48 +05:30
Kishan Kavala
1e87f3b80b
Bug-Id: CLOUDSTACK-3439: Include dynamically created nics in Prepare for migration command in KVM
...
(cherry picked from commit f767adfe71 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-18 18:19:24 +05:30
Saksham Srivastava
a1791cb4a8
CLOUDSTACK-8088: VM scale up is failing in vmware with Unable to execute ScaleVmCommand due to java.lang.NullPointerException
...
(cherry picked from commit 1df0453d27 )
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2015-01-18 17:28:17 +05:30
Kishan Kavala
f767adfe71
Bug-Id: CLOUDSTACK-3439: Include dynamically created nics in Prepare for migration command in KVM
2015-01-07 14:52:42 +05:30
Kishan Kavala
42cecbb000
Network offering usage event should be logged for UserVms only
2015-01-07 12:29:11 +05:30