Commit Graph

22031 Commits

Author SHA1 Message Date
Daan Hoogland 9495c68c13 findbugs: removed obfuscating fields 2014-01-27 00:55:19 +01:00
Daan Hoogland 9772693dca findbugs: throw exceptions when found 2014-01-27 00:54:23 +01:00
Daan Hoogland 791b7f8f7f findbugs: nullpointer guards and wrappertype comparisons 2014-01-27 00:23:57 +01:00
Daan Hoogland 20127e09dc findbugs: assign result of string manipulations 2014-01-26 23:49:56 +01:00
Daan Hoogland 0b13f8e59d Findbugs: different issues solved 2014-01-26 23:14:17 +01:00
Daan Hoogland 866a539b06 findbugs: removed fields injected in parent 2014-01-26 16:49:18 +01:00
Daan Hoogland 23a3d99fc0 findbugs: byte[].toString -> Arrays.toString(byte[]) 2014-01-26 16:38:53 +01:00
Daan Hoogland c58e509924 findbugs: null-checks 2014-01-26 16:35:48 +01:00
Daan Hoogland f3b9a7f123 findbugs: retrieve the objects to remove from the collection(s) 2014-01-26 16:07:59 +01:00
Daan Hoogland b40156313a findbugs: serialized class serializable 2014-01-26 16:03:56 +01:00
Daan Hoogland df6f40fe73 Revert "findbugs: remove compatible objects from collection"
This reverts commit 390325c50b.
2014-01-26 15:25:19 +01:00
Daan Hoogland 390325c50b findbugs: remove compatible objects from collection 2014-01-26 15:20:24 +01:00
Daan Hoogland d30ddf6d59 findbugs: null check for gateway and netmask instead of gateway twice 2014-01-26 15:11:56 +01:00
Daan Hoogland 9aced41d70 findbugs fixes for ApiServer, ApiSerializerHelper and ApiXmlDocWriter 2014-01-26 13:27:37 +01:00
Daan Hoogland 9a1b882d0e Findbugs issues in ApiResponseHelper fixes 2014-01-26 12:25:18 +01:00
Ian Duffy 92b4f66d73 Fix findbug issues within LDAP authenticator 2014-01-26 00:34:25 +00:00
Daan Hoogland 437ff438af restored imports 2014-01-26 00:34:41 +01:00
Daan Hoogland f3529a19a9 moved call on static object to synchronized block 2014-01-25 23:46:18 +01:00
Daan Hoogland 43ba36f979 nullpointer dereference guarded 2014-01-25 23:26:53 +01:00
Hugo Trippaers c307de312d Backport findbugs configuration to 4.3 so we can run a findbugs report in jenkins. 2014-01-25 10:52:09 +01:00
Hugo Trippaers 60ac12780b Backport fixed for issues found by Findbugs 2014-01-25 10:52:09 +01:00
Hugo Trippaers f18c5a1910 Findbugs finding : Incorrect use of equality
(cherry picked from commit 10cc5645e8b9713bc7c86d543413d396ce203cc6)
2014-01-25 10:52:09 +01:00
Jessica Wang 81a83b5b31 CLOUDSTACK-5614: UI - Infrastructure > Sockets > listView > (1) split "XenServer" into "XenServer 6.2.0" and "XenServer"(prior to 6.2.0).
(2) change label of Hyperv to Hyper-V.
2014-01-24 18:23:42 -08:00
Devdeep Singh 6d997bd689 CLOUDSTACK-5942: The agent at places logs the password of the user. It should mask the
password from the message string before writing to the log. Made a change to do so.
2014-01-24 15:01:23 +05:30
Santhosh Edukulla d31fa09c7e Added Fix for CLOUDSTACK-5875
Added fix for exception and listing. Mentioned details under bug.
Post the fix, simulator works fine.

Signed-off-by: Santhosh Edukulla <Santhosh.Edukulla@citrix.com>
Signed-off-by: Koushik Das <koushik@apache.org>
2014-01-23 16:53:15 +05:30
Devdeep Singh 8ef47e8ff3 CLOUDSTACK-5936: Hyper-V agent should log to the windows event log. Changed the default
log appender for the agent.
2014-01-23 15:20:21 +05:30
Kelven Yang 29e44b1b67 CLOUDSTACK-5928: Use legacy vmsync logic by default 2014-01-22 14:09:22 -08:00
Alena Prokharchyk f160b31f51 CLOUDSTACK-5930: Changed "authenticate" method to return both - result of authentication, and action to perform when authentication failed - to the accountManagerImpl. Only if authenicators request INCREMENT_INCORRECT_LOGIN_ATTEMPT_COUNT, the incorrect_login_attempts parameter will be increased
Signed-off-by: Alena Prokharchyk <alena.prokharchyk@citrix.com>

Conflicts:
	plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
	plugins/user-authenticators/md5/src/com/cloud/server/auth/MD5UserAuthenticator.java
	plugins/user-authenticators/plain-text/src/com/cloud/server/auth/PlainTextUserAuthenticator.java
	plugins/user-authenticators/sha256salted/src/com/cloud/server/auth/SHA256SaltedUserAuthenticator.java
	server/src/com/cloud/server/auth/UserAuthenticator.java
	server/src/com/cloud/user/AccountManagerImpl.java
2014-01-22 12:53:27 -08:00
Kelven Yang 50f311ed94 CLOUDSTACK-5928: disable host delta sync when new VM sync is enabled 2014-01-22 11:17:25 -08:00
Mike Tutkowski 0679af3434 CLOUDSTACK-5873: [Automation] Failed to attach volume to VM, if the vm is created with option startvm=false 2014-01-22 11:08:57 -07:00
Alex Hitchins 78f62c6347 Added required dependancy to agent setup. 2014-01-22 12:22:38 -05:00
Likitha Shetty 94ea2736f4 CLOUDSTACK-5927. Storage garbage collector is trying to destroy the SSVM/CPVM root disk that is in use.
In case of VMware VM during root volume preparation if we are switching to a new volume, force expunge root disk that was created from the old template.
Because otherwise storage garbage collector will later try to expunge the old disk marked for expunge and fail with 'Cannot delete file' exception
since in VMware the new root vmdk has the same name and is now in use.
2014-01-22 17:32:13 +05:30
Alena Prokharchyk d5e0dcd2a7 Revert "Changed "authenticate" method to return both - result of authentication, and action to perform when authentication failed - to the accountManagerImpl. Only if authenicators request INCREMENT_INCORRECT_LOGIN_ATTEMPT_COUNT, the incorrect_login_attempts parameter will be increased"
This reverts commit 7884bb8aaf.
2014-01-21 19:50:46 -08:00
Animesh Chaturvedi 361aaca794 Pom.xml script updater erroneously removed SNAPSOT from XAPI dependency causing build failure 2014-01-21 19:02:31 -08:00
Alena Prokharchyk 7884bb8aaf Changed "authenticate" method to return both - result of authentication, and action to perform when authentication failed - to the accountManagerImpl. Only if authenicators request INCREMENT_INCORRECT_LOGIN_ATTEMPT_COUNT, the incorrect_login_attempts parameter will be increased
Signed-off-by: Alena Prokharchyk <alena.prokharchyk@citrix.com>

Conflicts:
	plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
	plugins/user-authenticators/md5/src/com/cloud/server/auth/MD5UserAuthenticator.java
	plugins/user-authenticators/plain-text/src/com/cloud/server/auth/PlainTextUserAuthenticator.java
	plugins/user-authenticators/sha256salted/src/com/cloud/server/auth/SHA256SaltedUserAuthenticator.java
	server/src/com/cloud/server/auth/UserAuthenticator.java
	server/src/com/cloud/user/AccountManagerImpl.java
2014-01-21 18:09:15 -08:00
Anthony Xu af5f3d5676 CLOUDSTACK-5923: CS doesn't do master switch for XS any more, CS will depend on XS HA to do master switch, XS HA needs to be enabled. 2014-01-21 17:55:56 -08:00
Animesh Chaturvedi 70ba92fc14 Updating pom.xml version numbers for release 4.3.0
Signed-off-by: Animesh Chaturvedi <animesh@apache.org>
2014-01-21 17:29:51 -08:00
Animesh Chaturvedi 0e79dd7af4 Updating release files for RC build 2014-01-21 17:10:13 -08:00
Min Chen f431266429 CLOUDSTACK-5922:Incorrect handling RHEL guests in Vmware. 2014-01-21 16:07:12 -08:00
Min Chen afb8a79321 CLOUDSTACK-5921: S3 security key is stored in DB unencrypted 2014-01-21 14:17:30 -08:00
Hugo Trippaers 28b5d0a9ed CLOUDSTACK-5883 Convert ovf file to proper format for ESXi
Virtualbox export creates an OVF file that is not compatible with VMware import functions. This causes import errors when the systemvm ova is imported into cloudstack. This patch fixes the issue by using an XSLT transformation to convert the generated ovf into a format this is compatible with vmware.

This is a squashed commit Based on the following commits in master:
794d47c5f2 bf26efc551 5d24843ef5 95a92ad2e3 da8ee45a24 50054fe060 50054fe060 ecf57c368a
2014-01-21 08:18:33 +01:00
Hugo Trippaers 7c4831df92 CLOUDSTACK-5884 make getTargetSwitch(NicTO nicTo) do all the work to select switch name, type and vlan token. Change preference to use the tags set on the physical network. 2014-01-21 08:18:21 +01:00
Mike Tutkowski 413c61b519 CLOUDSTACK-5873: [Automation] Failed to attach volume to VM, if the vm is created with option startvm=false 2014-01-20 23:08:27 -07:00
edison 1b064515ac CLOUDSTACK-5432: potential bugs in case of stop mgt server while template is downloading, template_store_ref has leftover not in ready state, when create vm from that template, the code doesn't check either zone id, nor template_store_ref state. 2014-01-20 17:15:23 -08:00
Kelven Yang 8db0d83d1a CLOUDSTACK-5358: Bring back concurrency control in sync-queue management 2014-01-20 16:53:33 -08:00
Jessica Wang cd8501e263 CLOUDSTACK-5889: UI > Instances > (1) change service offering action: corresonding UI change for new change of scaleVirtualMachine API (that customparameter parameter has been renamed).
(2) detailView: add # of CPU Cores, CPU (in MHz), Memory (in MB).
2014-01-20 16:29:37 -08:00
Min Chen aa2d25bf92 CLOUDSTACK-5913:API rate limiting throws a different error than expected
when Throttle limit hit in the API.
2014-01-20 14:57:48 -08:00
edison 27fd490885 CLOUDSTACK-5329: stupid java box/unbox 2014-01-20 10:43:32 -08:00
Mike Tutkowski 0e053668b8 CLOUDSTACK-5873: [Automation] Failed to attach volume to VM, if the vm is created with option startvm=false 2014-01-18 12:36:53 -07:00
edison 3eca162c26 mischanged default user vm template url for xen 2014-01-17 15:45:58 -08:00