Commit Graph

25626 Commits

Author SHA1 Message Date
Rohit Yadav b539b48a69 FIX2: Allow creation of roles with names of deleted roles
This allows admins to create roles with names of previously deleted
roles.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-07-11 14:06:24 +05:30
Rohit Yadav 9c82452b82 FIX3: Consider overcommit ratios with total/threshold values
Consider the CPU and memory overcommit ratios with total cpu/ram values
or thresholds for host and cluster metrics. This will fix incorrect
notification (cells turning yellow/red) in the metrics view.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-07-11 12:52:48 +05:30
Rohit Yadav 2590c2521a CLOUDSTACK-9983: Hide credentials in listClusters response
This removes username and passwords details from the listClusters
response. The details are usually seen in VMware environments only.
With dynamic roles features, the listClusters API may be provided
to a read-only root-admin user role/type which should not be able to get
the credentials.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-07-05 13:32:45 +05:30
Abhinandan Prateek c5e9e98ab5 FR17-b: Following enhancements are made to FR17
1. Add timeout to the volume stats command
2. When a unknown command is received return a BadCommand from request processor
3. Unit test for checking bad and a good command sent to the agent as json
2017-06-14 08:40:41 +05:30
Rohit Yadav 986497d891 FR20: Allow native CloudStack users to change password from the UI
This allows native CloudStack users to change password from the UI.
Overall changes:
- New 'usersource' key returned in the listUsers API
- Removed ldap specific check from the UI, added checks based on usersource
- Native CloudStack users will be allowed to change password from the UI

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-05-30 14:23:38 +05:30
Rohit Yadav bf7efaa98d cw1314: Fix high CPU deviation issues seen in metrics view
HostStats returns cpu usage in percentage while memory usage in bytes.
This fixes a regression in maximum CPU usage deviation that did not
assume the values to be in percentage and multiple the final ratios
with 100 which leads to 100x the actual deviation value.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-05-10 12:42:12 +05:30
dahn b70140c1bd Merge pull request #30 from shapeblue/nio-logging
logging improvements
2017-05-09 13:55:11 +01:00
Rohit Yadav 5d58f34a4f Merge pull request #36 from shapeblue/cw-1300
CW1300: Fix hyperv log4j transformation
2017-04-27 14:59:58 +05:30
Rohit Yadav 43a1c9e24a CW1300: Fix hyperv log4j transformation
Fixes log4j transformation using replace.properties to translate
@AGENTLOG@ to a valid value during rpm/mvn build.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-04-25 15:21:25 +05:30
Abhinandan Prateek 8c433b2307 Merge pull request #35 from shapeblue/9182
CLOUDSTACK-9182: Some running VMs turned off on manual migration when…
2017-04-25 11:18:01 +05:30
Rohit Yadav f89d06b0f6 Merge pull request #34 from shapeblue/fr19-oobm-plugin-cloudstack
APPLE-333: Oobm plugin for nested-cloudstack environments
2017-04-21 12:26:19 +05:30
Rohit Yadav 8f3cd943b1 APPLE-333: Oobm plugin for nested-cloudstack environments
This implements an out-of-band management plugin for nested-cloudstack
environments where the hypervisor host is a VM in a parent CloudStack environment
that is used as a host in the (testing) CloudStack environment. This plugin
allows power operations to translate into start/stop/reboot of the VM (host).

The out-of-band management configuration accepted are:
- Address: The API URL of the parent CloudStack enviroment
- Port: The uuid of the (host) VM in the parent CloudStack environment
- Username: The apikey of the user account who has ownership on the (host) VM
- Password: The secretkey of the user account who has ownership on the (host) VM

Note: change password of the oobm interface is not support by this plugin

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-04-19 16:58:38 +05:30
Abhinandan Prateek 775e73c38e CLOUDSTACK-9182: Some running VMs turned off on manual migration when auto migration failed while host preparing for maintenance. 2017-04-18 11:25:24 +05:30
Abhinandan Prateek 8f7428837e Merge pull request #33 from shapeblue/fr17
FR17: type conversion fix
2017-03-30 12:40:49 +05:30
Abhinandan Prateek b1c35af8c2 FR17: Metrics fix 2017-03-30 11:59:35 +05:30
Abhinandan Prateek 9b181dbf19 Merge pull request #32 from shapeblue/cw1261
CW1261: Do not reset connection for user managed connections
2017-03-29 22:54:57 +05:30
Abhinandan Prateek 6cab0308d7 Merge pull request #31 from shapeblue/fr17
FR17: list vm physical size, virtual size and utilisation in listvolume API
2017-03-29 16:29:47 +05:30
Abhinandan Prateek 4991d165f3 FR-17: KVM, Xen and VMware support + UI with Marvin test 2017-03-27 09:53:40 +05:30
Abhinandan Prateek b3f6d9136e CW1261: Do not reset connection for user managed connections 2017-03-24 12:42:41 +05:30
Daan Hoogland 0eca48ad86 logging improvements 2017-03-03 07:36:14 +01:00
Rohit Yadav 40f2f6ff45 Merge pull request #29 from shapeblue/metrics-apis-4.5
APPLE-328: Metrics View APIs
2017-02-16 13:53:27 +05:30
Rohit Yadav a00cb07ee0 APPLE-328: Metrics View APIs
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-02-16 13:20:30 +05:30
Rohit Yadav ad19e00d13 Merge pull request #13 from shapeblue/host-ha-4.5
APPLE-165: Host HA and KVM provider
2017-01-18 18:25:05 +05:30
Rohit Yadav 876fc7434d APPLE-165: Host HA management and HA provider for KVM
Host-HA offers investigation, fencing and recovery mechanisms for host that for
any reason are malfunctioning. It uses Activity and Health checks to determine
current host state based on which it may degrade a host or try to recover it. On
failing to recover it, it may try to fence the host.

The core feature is implemented in a hypervisor agnostic way, with two separate
implementations of the driver/provider for Simulator and KVM hypervisors. The
framework also allows for implementation of other hypervisor specific provider
implementation in future.

The Host-HA provider implementation for KVM hypervisor uses the out-of-band
management sub-system to issue IPMI calls to reset (recover) or poweroff (fence)
a host.

The Host-HA provider implementation for Simulator provides a means of testing
and validating the core framework implementation.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2017-01-18 18:18:53 +05:30
Rohit Yadav 2b4cdd6580 Merge pull request #26 from shapeblue/oobm-ui-password-fix
APPLE-320: Bypass password validation for oobm
2016-12-10 01:34:21 +05:30
Rohit Yadav ac70308d9a Merge pull request #23 from shapeblue/apple-313-cw1078-kvmreboot
APPLE-313: Fixes for CW1078
2016-12-10 01:34:08 +05:30
Rohit Yadav e52038ba9e APPLE-313: Fix memory leak in VmwareContextPool
- Fixes synchronization issue
- Uses ConcurrentLinkedQueue

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2016-11-23 13:28:16 +05:30
Rohit Yadav 33f8d48e78 APPLE-320: Bypass password validation for oobm
Allows special character, otherwise not allowed for password fields
throughout cloudstack UI.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2016-11-21 19:00:22 +05:30
Abhinandan Prateek 635aa20058 CLOUDSTACK-9460: For long running transactions, if the connection is
timed out by the mysql server then refresh it
2016-11-21 15:09:50 +05:30
Abhinandan Prateek 066057d7c4 CLOUDSTACK-9571: fence gracefully using clustermanger's notifyNodeIsolated 2016-11-21 15:09:50 +05:30
Abhinandan Prateek 6fdd19fa7e CLOUDSTACK-9571: Fence DB if there are consecutive connection errors. 2016-11-21 15:09:50 +05:30
Rohit Yadav eecd3fb349 APPLE-313: Ulimit fixes for cloudstack-{agent, management}
Increases/sets ulimit for cloudstack agent and management. This would fix
any issues with opening more files than permissible limit (usually 1024-4096).

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2016-11-08 16:20:04 +05:30
Rohit Yadav 6d79c7c5b7 Merge pull request #24 from shapeblue/cve-2016-6813
CLOUDSTACK-9544: Check access on account trying to generate user API keys
2016-10-27 21:55:16 +05:30
Marc-Aurèle Brothier ce02814901 CLOUDSTACK-9544: Check access on account trying to generate user API keys
This fixes CVE-2016-6813

Signed-off-by: Marc-Aurèle Brothier <m@brothier.org>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2016-10-27 15:59:39 +05:30
Rohit Yadav 6f89892274 Merge pull request #22 from shapeblue/apple-base-9551
CLOUDSTACK-9551: Move java tmp dir to cloudstack-agent's path to avoid
2016-10-25 11:18:44 +05:30
Rohit Yadav 25cdb44c65 Merge pull request #21 from shapeblue/metrics-view-context-based-filtering
APPLE-309: Use context to filter items in a metrics view
2016-10-25 10:43:34 +05:30
Rohit Yadav 0841471cef Merge pull request #20 from shapeblue/roles-usage-fix
APPLE-274: Add role_id to cloud_usage.account
2016-10-25 10:42:00 +05:30
Rohit Yadav 860267fee0 Merge pull request #19 from shapeblue/kvm-host-without-storage
APPLE-272: Host Connects Without Storage
2016-10-25 10:41:42 +05:30
Abhinandan Prateek aa093659aa CLOUDSTACK-9551: Move java tmp dir to cloudstack-agent's path to avoid
noexec on /tmp
2016-10-20 12:25:21 +05:30
Rohit Yadav a5d6b55eb4 APPLE-309: Use context to filter items in a metrics view
Use available context to filter a metrics view based on zone, cluster, host
in the context object. This fixes metrics view filtering when metrics view is
viewed via Zone->Compute and Storage-> for a resource.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2016-10-19 11:41:08 +05:30
Rohit Yadav 1c3afb8279 APPLE-274: Add role_id to cloud_usage.account
Fixes usage server blocker which fails to work due to missing role_id
column in cloud_usage.account table.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2016-06-08 11:41:42 +09:00
Rohit Yadav a4848c1435 APPLE-272: Host Connects Without Storage
KVM hosts on shared storage failure was accepted by mgmt server with the
host state as Up, even though there was no primary/shared storage available on
it. This patch offers a quick fix by throwing an exception in the storage monitor
which connects storage pool on host. The failure is trapped by agent manager
that disconnects the agent without any investigation.

Based on Lab tests, KVM agent may take upto 2 minutes to attempt NFS mount when
the storage is inaccessible (firewalled, or shutdown) before returning back with
an error. It is safe to assume that this won't add pressure on mgmt server due to
several reconnection attempts, and KVM agent would retry reconnection every 2
minutes.

For such KVM hosts, where failure happens due to storage issues; they will be
briefly put in Alert state but will be mostly be in Connecting state during which
the KVM host attempts to mount/reconfigure NFS storage pool.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2016-06-08 09:19:57 +09:00
Rohit Yadav 033f87deda CLOUDSTACK-9348: Make NioConnection selector blocking by timeout
Uses timeout based selector blocking. This makes connection handling
aggressive safely.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2016-05-19 16:17:28 +05:30
Rohit Yadav c8e0fc74ae dynamic-roles: remove order by ID
Removes order by id which is not necessary as we already do order by
sort_order. An additional order by seems to have caused mysql errors
in some environment, though it was not reproducible with MySQL 5.5/5.6/5.7
but this can be safely removed as it's not necessary.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2016-05-19 11:15:36 +05:30
Rohit Yadav 5415c06f30 packaging: backup commands.properties when upgrade to dynamic-roles
In case of rpms, the commands.properties file is bundled at
/usr/share/cloudstack-management/webapps/client/WEB-INF/classes/commands.properties

In case of a rpm upgrade, new rpms won't ship with commands.properties file. For
existing installations this copies the commands.properties file to
/etc/cloudstack/management

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2016-05-19 11:14:29 +05:30
Rohit Yadav f12254ef92 Merge pull request #18 from shapeblue/nio-fix-cpu
utils: Fix NioConnection aggressive usage
2016-05-16 08:51:14 +05:30
Rohit Yadav e35e7e4441 utils: Fix NioConnection aggressive usage
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2016-05-16 08:49:46 +05:30
Rohit Yadav 0a6f930a31 Merge pull request #17 from shapeblue/outofbandmanagement-4.5
CLOUDSTACK-9299: Sync changes from upstream oobm PR
2016-05-13 08:36:29 +05:30
Rohit Yadav 0b6f314f6e CLOUDSTACK-9299: Sync changes from upstream oobm PR
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2016-05-12 11:44:30 +05:30
John Burwell 328dbebd96 Merge pull request #8 from shapeblue/cancel-maint
CLOUDSTACK-9323:  Cancelling maintenance when prepare for maintenance…
2016-05-10 08:55:58 -04:00