Commit Graph

34797 Commits

Author SHA1 Message Date
Nicolas Vazquez c39cf4cbde
agent: enable ssl only for kvm agent (not in system vms) (#6371) (#151)
* agent: enable ssl only for kvm agent (not in system vms)

* Revert "agent: enable ssl only for kvm agent (not in system vms)"

This reverts commit b2d76bad2e.

* Revert "KVM: Enable SSL if keystore exists (#6200)"

This reverts commit 4525f8c8e7.

* KVM: Enable SSL if keystore exists in LibvirtComputingResource.java

Co-authored-by: Wei Zhou <weizhou@apache.org>
2022-05-19 00:03:50 -03:00
Abhishek Kumar 07abb808b1
schema: add schema changes for event improvements (#150)
Schema changes needed for Event Improvements functionality to work are being added in 4.16.0 to 4.16.1.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-05-12 12:51:09 +05:30
Abhishek Kumar 92931aeeb8
schema,server,api: events improvement (#127)
Add resource ID and resource type to event.
In UI, adds Events tab in resource view for the supporting resources.

Following SQL changes needed to support events with resource details in DB,
```
 -- Alter event table to add resource_id and resource_type
ALTER TABLE `cloud`.`event`
    ADD COLUMN `resource_id` bigint unsigned COMMENT 'ID of the resource associated with the even' AFTER `domain_id`,
    ADD COLUMN `resource_type` varchar(32) COMMENT 'Account role in the project (Owner or Regular)' AFTER `resource_id`;

DROP VIEW IF EXISTS `cloud`.`event_view`;
CREATE VIEW `cloud`.`event_view` AS
    SELECT
        event.id,
        event.uuid,
        event.type,
        event.state,
        event.description,
        event.resource_id,
        event.resource_type,
        event.created,
        event.level,
        event.parameters,
        event.start_id,
        eve.uuid start_uuid,
        event.user_id,
        event.archived,
        event.display,
        user.username user_name,
        account.id account_id,
        account.uuid account_uuid,
        account.account_name account_name,
        account.type account_type,
        domain.id domain_id,
        domain.uuid domain_uuid,
        domain.name domain_name,
        domain.path domain_path,
        projects.id project_id,
        projects.uuid project_uuid,
        projects.name project_name
    FROM
        `cloud`.`event`
            INNER JOIN
        `cloud`.`account` ON event.account_id = account.id
            INNER JOIN
        `cloud`.`domain` ON event.domain_id = domain.id
            INNER JOIN
        `cloud`.`user` ON event.user_id = user.id
            LEFT JOIN
        `cloud`.`projects` ON projects.project_account_id = event.account_id
            LEFT JOIN
        `cloud`.`event` eve ON event.start_id = eve.id;
```
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-05-05 13:44:33 +05:30
Marcus Sorensen 932f2475c5
maven: Move apache DS dependencies to test scope (#146)
Co-authored-by: Marcus Sorensen <mls@apple.com>
2022-05-04 11:50:37 +05:30
Nicolas Vazquez 395c93957f
KVM: Enable SSL if keystore exists (#6200) (#143)
* KVM: Enable SSL if keystore exists

* Update #6200: add logs if no passphrase or no keystore

Co-authored-by: Wei Zhou <weizhou@apache.org>
2022-04-24 22:25:26 -03:00
Pearl Dsilva df2966b9d6
Allow expunging a VM on a deleted host when using host cache and ConfigDrive userdata service (#141) 2022-04-12 10:51:03 -03:00
Nicolas Vazquez d6b9c65ce6
Backport: Direct download certificates additions and improvements (#6104) (#140)
* Direct download certificates additions and improvements (#6104)

* Add direct download certificates listing

* Restore class to original project

* Small refactor

* Register API

* Apply suggestions from code review

Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

* Refactor after review

* Fix checkstyle

* Add hosts mapping to API response

* Improvements on revoke certificate

* Refactor revoke certificate API

* Fix condition

* Filter only certificates not revoked for revokeCertificate API

* Improve upload certificate and add provision certificate API

* Improve certificate response output

* Address review comments

* Refactor revoke cert test

* Fix marvin test

* Address review comments

* Fix issues

* Improvements

* Refactor upload template API response

* Fix response

Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

* Fix pom version

Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
2022-04-12 10:49:08 -03:00
Marcus Sorensen 58ed95376c
Use base clock when detecting host CPU speed from file, to match lscpu (#131)
* Use base clock when detecting host CPU speed from file, to match lscpu

Allow for manually setting the CPU speed via agent.properties if all else fails

Signed-off-by: Marcus Sorensen <mls@apple.com>

* Update agent/conf/agent.properties

Co-authored-by: dahn <daan.hoogland@gmail.com>

Co-authored-by: Marcus Sorensen <mls@apple.com>
Co-authored-by: Nicolas Vazquez <nicovazquez90@gmail.com>
Co-authored-by: dahn <daan.hoogland@gmail.com>
2022-04-01 12:19:43 -03:00
Nicolas Vazquez dfc1f26762
Ensure configdrive path is edited properly during live migration (#6173) (#138) 2022-03-30 22:42:02 -03:00
Pearl Dsilva 2bd5a5daa7
configDrive: Fix failure to delete (unstarted) VM (#137) 2022-03-30 22:36:09 -03:00
Rohit Yadav 79fc6ca4d9
ui: Fix ui build and lint issue (#129)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-03-14 16:15:11 +05:30
Marcus Sorensen 1abcd327bf
ui: run npm audit to module security updates (#128)
* UI module security updates

* update npm run audit using npm/node@14

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Co-authored-by: Marcus Sorensen <mls@apple.com>
Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2022-03-14 15:16:05 +05:30
Suresh Kumar Anaparti cad9332082
Updating pom.xml version numbers for release 4.16.1.0
Signed-off-by: Suresh Kumar Anaparti <suresh.anaparti@shapeblue.com>
2022-02-25 19:01:16 +05:30
Pearl Dsilva a8cc261143
[vmware, ssvm] Scale down of ssvm (#6042)
* [vmware, ssvm] Scale down of ssvm

* address comments - change variable name
2022-02-25 15:45:10 +05:30
Suresh Kumar Anaparti 027e6030af
[KVM] Disconnect the volumes with the proper storage adaptor. (#6029)
* [KVM] Disconnect the volumes with the proper storage adaptor.

* Improved / Added logs
2022-02-23 22:40:14 +05:30
dahn 19b8da290c
prevent <ctrl>-<enter> handler from <space> from toggling checkboxes (#6027)
* prevent <ctrl>-<enter> handler from <space> from toggling checkboxes

* enter vs ctrl-enter issue remaining: toggles active switch on submit

* some fixes by hook on containing div

* other identified forms

Co-authored-by: Daan Hoogland <dahn@onecht.net>
2022-02-23 21:21:44 +05:30
Wei Zhou ca12ef31ac
ui: add VXLAN network identifiers (VNIs) in message.guest.traffic.in.advanced.zone (#6034) 2022-02-23 18:32:52 +05:30
Wei Zhou 5de1995376
api: update description of internal LB APIs (#6035) 2022-02-23 18:30:16 +05:30
Nicolas Vazquez 36d3f434d1
UI: Reword the setting panel warning (#6020) 2022-02-23 14:15:48 +05:30
Wei Zhou ac794a0c85
ui: minor change with help text on dashboard (#6003) 2022-02-17 21:48:37 -03:00
Wei Zhou c543f5f546
server: reapply checkVmProfileAndHost to check guest os preference (#6000) 2022-02-17 14:25:13 +05:30
Pearl Dsilva e0a5df50ce
CKS Enhancements and SystemVM template upgrade improvements (#5863)
* This PR/commit comprises of the following:
- Support to fallback on the older systemVM template in case of no change in template across ACS versions
- Update core user to cloud in CKS
- Display details of accessing CKS nodes in the UI - K8s Access tab
- Update systemvm template from debian 11 to debian 11.2
- Update letsencrypt cert
- Remove docker dependency as from ACS 4.16 onward k8s has deprecated support for docker - use containerd as container runtime

* support for private registry - containerd

* Enable updating template type (only) for system owned templates via UI

* edit indents

* Address comments and move cmd from patch file to cloud-init runcmd

* temporary change

* update k8s test to use k8s version 1.21.5 (instead of 1.21.3 - due to https://github.com/kubernetes/kubernetes/pull/104530)

* support for private registry - containerd

* Enable updating template type (only) for system owned templates via UI

* smooth upgrade of cks clusters

* update pom file with temp download.cloudstack.org testing links

* fix pom

* add cgroup config for containerd

* add systemd config for kubelet

* add additional info during image registry config

* update to official links
2022-02-15 18:27:14 +05:30
dahn 8db598bc0f
set pod after migration (#5972)
Co-authored-by: Daan Hoogland <dahn@onecht.net>
2022-02-11 18:47:45 +05:30
sureshanaparti 5297b52d98
Improve the guest OS hypervisor mappings addition on upgrade. (#5911)
- This removes the hardcoded guest os ids 305 - 329 in upgrade path 4.14.0 to 4.15.0, and 330 - 349 in upgrade path 4.15.0.0 to 4.15.1.0.
2022-02-10 14:43:03 +01:00
Nicolas Vazquez a3bb84b495
[VMware] Update SCSI controllers for VMs (#5910) 2022-02-10 14:36:34 +01:00
dahn 122b018057
Quota test fixes (#5959)
* fixes and cleanups on quota integration test

* text changes in exception messages

Co-authored-by: Daan Hoogland <dahn@onecht.net>
Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>
2022-02-10 18:57:21 +05:30
davidjumani bc93163eec
ui: Allow domain admin to configure subdomain limits (#5978) 2022-02-10 07:55:45 -03:00
dahn a6d9fa61b9
Role escalation prevention (#5879)
* prevent role access escallation

* hierarchy issue fixed

* create api list in account manager for checking new account access

* full api list check

* strange role restriction removed for BareMetal

* add role check on upfdate account as well

* more selective use of api checkers

* error msg and var name

Co-authored-by: Daan Hoogland <dahn@onecht.net>
2022-02-10 11:50:27 +05:30
slavkap 4ffb949a58
Fix of revert RBD snapshots (#5544)
* Fix of revert RBD snapshots

If snapshot is taken only on Primary storage with the option "snapshot.backup.to.secondary" set to true, when you set this option to false the revert will fail. Added check if the snapshot is not on Secondary to check for it on Primary

* Check if snapshot is on primary storage

Will check first if the snapshot is on Primary storage, if not will
return Image as data store

* Fix unit tests

* removed unused method's params

* Formatted error message and added the snapshot ID to it

* Return to the old logic, the fix will only apply to RBD

* Formatted Exception's messages
2022-02-10 10:22:21 +05:30
Abhishek Kumar f88f934274
api, server: fix add-remove vpn user without vpn owner (#5850)
* api, server: fix add-remove vpn user without vpn owner

Fixes #5711

ACS should not add a new user in Add state when the owner account does not have VPN access.
While removing VPN user ACS should not fail completely when owner account ahs no VPN.

* change , fixes

* remove unused method

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-02-10 10:07:23 +05:30
Pearl Dsilva 640118ce2b
Add disk space in systemVM template registration script (#5956) 2022-02-10 09:50:12 +05:30
PJ Fanning 791d0634f7
[issue-5943] xerces 2.12.2 (#5968) 2022-02-10 09:34:14 +05:30
PJ Fanning b5655c3b77
[issue-5952] upgrade to jetty 9.4.44.v20210927 (#5953)
* [issue-5952] upgrade to maven 9.4.44.v20210927

* Update pom.xml

Co-authored-by: Rohit Yadav <rohityadav89@gmail.com>
2022-02-09 21:53:14 +05:30
dahn 3fc4ef478d
replace Random with SecureRandom (#5966)
Co-authored-by: Daan Hoogland <dahn@onecht.net>
2022-02-09 21:08:33 +05:30
Pearl Dsilva 85ced4447b
API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1) (#5958)
* API: Fix listSSHKeyPairs API when listing all resources (listall=true & projectid=-1)

* fix issue with indexing
2022-02-09 15:25:27 +01:00
dahn 143b72d67e
cleanup: Network Throttling for Additional Networks code in DirectVifDriver.java (#5875) 2022-02-09 10:19:47 +01:00
Hoang Nguyen b275c29709
UI - Add Network: shows "Offering for Isolated networks with no Source Nat service" on Network Offering for normal users (#5904)
* shows "Offering for Isolated networks with no Source Nat service" for normal users

* fixes roles

* fix selected tabs
2022-02-09 14:13:31 +05:30
Wei Zhou ce81a8e708
test: sleep 30s after restarting mgt server in test_kubernetes_supported_versions.py to fix test failures with test_secondary_storage.py (#5962) 2022-02-09 09:37:28 +05:30
davidjumani 453aeb02f0
Add ID search capability to sshkeypairs (#5963) 2022-02-09 09:34:00 +05:30
PJ Fanning c7885f55eb
maven: upgrade bouncycastle due to cve (#5949)
Fixes: #5948
2022-02-09 00:22:28 +05:30
Pearl Dsilva e609aa8e9c
Skip systemVM template registration for Simulator (#5954)
* Skip systemVM template registration for Simulator

* simplify
2022-02-08 19:44:01 +01:00
Wei Zhou 6495bc1a47
packaging: display First Install and Onboarding Message (#5851)
* packaging: display First Install and Onboarding Message

* Update #5851: Update as per Rohit's comments

* Update #5851: display package name in help message

* Update #5851: display links of installed cloudstack version on UI

* Update #5851: fix vue warnings
2022-02-08 16:11:03 +01:00
Rohit Yadav da56a2a806
maven: migrate short-term to reload4j v1.2.18 (#5878)
* maven: migrate short-term to reload4j v1.2.18

This migrate to log4j 1.x fork, reload4j 1.2.18.0 which is drop-in
replacement and addresses some immediate CVE and issues.

* log4j migration to reload4j in pom xmls

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* Exclude log4j from transitive dependencies (#73)

Co-authored-by: Marcus Sorensen <shadowsor@gmail.com>
Co-authored-by: Marcus Sorensen <mls@apple.com>
2022-02-08 15:00:38 +05:30
Abhishek Kumar af58284560
server,config: respect storage.max.volume.size and make it dynamic (#5857)
* server,config: respect storage.max.volume.size and make it dynamic

Fixes #5830

* fix test

* size change

* fix check

* server: donot include ISO size while checking volume sizes

* revert size check

* refactor

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>
2022-02-08 13:29:35 +05:30
PJ Fanning eeaad0bfe7
[issue-5939] upgrade commons-compress to 1.21 (#5942) 2022-02-08 12:47:58 +05:30
jairov4 6c9f0c1f3f
Fix #3448 quota calculation for monthly tariffs (#5517)
* Fix quota calculation for monthly tariffs

* Remove unused parameter
2022-02-07 13:34:37 +01:00
Abhishek Kumar 81b49b835a
ui: fix select networks for template nic (#5933)
* ui: fix select networks for template nic

Fixes #5927

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2022-02-07 16:30:40 +05:30
PJ Fanning 5db6b86200
[issue-5946] upgrade to xstream 1.4.19 (#5947) 2022-02-07 12:05:42 +05:30
PJ Fanning 5adf608f80
mvn: upgrade to xerces 2.12.2 (#5944)
Fixes: #5943
2022-02-07 11:41:33 +05:30
dahn 0f1cd6009d
add logging to deployment planners (#5859)
Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>

Co-authored-by: Daan Hoogland <dahn@onecht.net>
Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
Co-authored-by: sureshanaparti <12028987+sureshanaparti@users.noreply.github.com>
2022-02-04 17:02:32 +01:00