Commit Graph

923 Commits

Author SHA1 Message Date
alena 1a8d9a92a7 Modified all api calls to throw ApiServerException if null object is returned by the manager. 2010-11-15 17:44:51 -08:00
abhishek d5ab597fcf bug 6474,6475: porting over the expunge fixes for port forwarding rules to 2.2
status 6474,6475: resolved fixed
2010-11-15 17:33:05 -08:00
abhishek c115a2e401 bug 7189: returning vmdisplayname if available for all port fwding crud cmds
status 7189: resolved fixed
2010-11-15 14:55:03 -08:00
abhishek 1e8d5675f6 bug 6865: fixing the alerts code which was broken; hence no alerts were being sent out
status 6865: resolved fixed
2010-11-15 14:38:39 -08:00
abhishek d520f0af5b adding a column in user_ip_address table called one_to_one_nat; which is a boolean to tell us if the ip is a nat ip. This is false by default, and is set to true when we nat the ip. Also, this value is returned in the list public ip addrsses api call.
finally, the value is set to false when we delete the ip forwarding rule.
2010-11-15 12:39:24 -08:00
abhishek 6d943abf55 bug 7119: code refactor away from the ms calls, to the share and prepare methods based on alex's recommendations
status 7119: resolved fixed
2010-11-15 11:17:36 -08:00
alena a01aad84ed bug 7162: added search by id to listZones command
status 7162: resolved fixed
2010-11-15 10:48:36 -08:00
alena 050eed742f 1) Removed account/domainId info from deleteSnapshot and deleteSnapshotPolicy commands as we get account info from the snapshot/policy object.
2) Introduced responseObject field in @Implementation for all apis. This field contains information about the response object class, so we can used it for generating API documentation.
2010-11-12 17:36:17 -08:00
abhishek 7327906cdf the pool availability part is done by the sp allocators, hence commenting out the code in here. 2010-11-12 17:19:57 -08:00
Kelven Yang 0653d6d7f6 Improve console access security with random generated hash key 2010-11-12 16:59:58 -08:00
abhishek d8fdcd3815 bug 7088: returning right error msg for assocIp failure 2010-11-12 15:31:30 -08:00
abhishek fc461abed1 bug 6755: adding checks for commands before they hit the ms; to ensure they are valid. Also returning the right error msg if the command is not valid
status 6755: resolved fixed
2010-11-12 13:55:06 -08:00
anthony 2537dc3058 bug 7149: merge from 2.1.x 2010-11-12 13:16:03 -08:00
abhishek c91c977fba bug 6290: we will be returning the service offering details for a root disk in the list volumes cmd, as opposed to the disk offering which was misleading
status 6290: resolved fixed
2010-11-12 11:24:34 -08:00
abhishek 673ddb246a bug 6832: returning the missing api value for destroyed volumes
status 6832: resolved fixed
2010-11-12 10:55:13 -08:00
abhishek 9fb62555af bug 7071: making the config var "hidden" instead of removing it, as there are a lot of references to this var. 2010-11-12 10:06:51 -08:00
abhishek 826e7aac85 bug 7071: We do not want to expose the enable/disable flag for ssvm. Removing this option from the global settings menu presented to the UI.
status 7071: resolved fixed
2010-11-12 09:51:38 -08:00
nit dd8f02589d bug 6837 : UpdateIso and UpdateTemplate API should return ostypename. Removing incorrect domainId creeping in because it was of primitive type.
status 6837: resolved fixed
2010-11-12 18:08:43 +05:30
nit 5215f6f817 bug 7101 : DetachISO API and AttachISO API would start returning an embedded object of virtualmachine so that the UI could use that to update the vm.
status 7101: resolved fixed
2010-11-12 16:40:55 +05:30
nit b42458fa0d Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss 2010-11-12 14:48:11 +05:30
nit ff4250fe89 bug 5360 : USER.DELETE - Adding Started event and refactored the code around it.
status 5360: resolved fixed
2010-11-12 14:47:30 +05:30
alena a6abbe4637 bug 7122: don't return System user in listUsers response
status 7122: resolved fixed
2010-11-11 18:10:08 -08:00
abhishek e79e432807 we were using debug logging without checking ifDebugEnabled(), fixing that 2010-11-11 17:20:57 -08:00
abhishek fcd7f37839 bug 7037: adding more logging to the deletepool cmd
status 7037: resolved fixed
2010-11-11 17:20:57 -08:00
edison f30d3f4839 don't break other people 2010-11-11 17:13:21 -08:00
edison 0db9303bca don't break others 2010-11-11 17:04:10 -08:00
edison 8ca6f1669e start2command fro secondarys storage vm and make it work for KVM 2010-11-11 17:04:10 -08:00
edison 40481cfe6e add start2command for secondarystorage vm 2010-11-11 17:04:10 -08:00
edison 393666feea start2command for secvm 2010-11-11 17:04:10 -08:00
alena 0ad492cc74 bug 7118: fixed deletePod command - 1)remove Pod's resources (private ip adresses) before removing the pod itself. 2) Verify that private ip address pool is not empty before removing it.
status 7118: resolved fixed
2010-11-11 16:55:59 -08:00
abhishek 709fc3686f another fix for a related bug on data volumes I found whilst testing the parent bug 2010-11-11 16:39:15 -08:00
abhishek 968dc0616f bug 7021: data disk wasn't being created for custom sizes. Also, we were having max size checks in GB, whereas disk offerings are in MB. Made the change there as well.The storage allocators were commented out in master, uncommented them.
Status 7021: resolved fixed
2010-11-11 15:45:21 -08:00
alena 6e0b500a83 bug 4964: made listDomainChildren work with "isRecursive" flag
status 4964: resolved fixed
2010-11-11 14:32:36 -08:00
abhishek 05bbd35860 resolving the network manager merge conflict 2010-11-11 13:13:04 -08:00
abhishek 1faaba8fb0 fixed a corner case; also changed the commands to be async and changed the method signatures to conform with the master refactor 2010-11-11 13:07:26 -08:00
abhishek 239942bbe1 refactored all the commands to cater to keshav's needs, and added the new apis. the initial set of testing is complete, will now focus on corner cases 2010-11-11 13:07:26 -08:00
abhishek 26b75fc05d this is a good point to check the code in; have completed a part of the enhancement's code; with create and delete ip forwarding rule commands and the skeleton for port to rule map with associated table 2010-11-11 13:07:26 -08:00
abhishek e5ca5dddf9 renaming the ip forwarding commands to port forwarding commands, and beginning to work on Keshav's request to modify the current 1-1 NAT to be compatible with the Amazon apis 2010-11-11 13:07:26 -08:00
Alex Huang 05ce97f918 Merged in alena's changes 2010-11-11 12:53:19 -08:00
Alex Huang bbdc2b22ff commit for push 2010-11-11 12:53:19 -08:00
Alex Huang 284720bf00 compilation errors fixed 2010-11-11 12:53:19 -08:00
Alex Huang 94250c1330 committing to update 2010-11-11 12:53:19 -08:00
Alex Huang c6033baa78 system vm start and stop added 2010-11-11 12:53:19 -08:00
alena d091bdd886 bug 7126: return true only when assignToLoadBalancer succeeded.
status 7126: resolved fixed
2010-11-11 12:46:21 -08:00
alena 86c8f86a56 bug 6192: use "ipaddress" instead of "publicip" in updatePortForwarding command
status 6192: resolved fixed
2010-11-11 12:12:29 -08:00
alena 5a01335002 bug 7143: vlan parameter is no longer required by createZone command
status 7143: resolved fixed
2010-11-11 10:43:18 -08:00
alena 86e83bc4bd Created new response objects for userVm/domainRouter/systemVm that going to be used by API after network refactorig is in place. 2010-11-11 10:43:18 -08:00
will a69f961bd8 bug 5903: Reworked the entire UI to accomodate the new snapshot policy in 2.2.
- Fixed issues with deleting snapshot policies
- Fixed maxsnaps being set wrong in the DB.
2010-11-10 19:19:18 -08:00
alena b1194e68f7 Fixed the build 2010-11-10 10:14:08 -08:00
nit 0597c0cf4b bug 4177: RegisterIsoCmd and RegisterTemplateCmd API - Added account and domainId params so that one could register them on behalf of other accounts.
status 4177: resolved fixed
2010-11-10 17:47:59 +05:30
alena 3954c7550a bug 6914: return password in deployVirtualMachine/resetVmPassword response.
status 6914: resolved fixed
2010-11-09 11:18:54 -08:00
alena 5fafef9970 More api refactor - build api response is execute() method instead of getResponse method. 2010-11-09 09:58:05 -08:00
nit 3455a0f563 bug 7114: Fix NPE for updateTemplatePermissions when accessed via 8096. This was happening due to accountObj being null in User Context when accessed via 8096. Why we set it to null seems to be a hack to me.
status 7114: resolved fixed
2010-11-09 20:01:13 +05:30
nit 351f98ceef bug 5363: SNAPSHOT.CREATE - Add Started event.
status 5363: resolved fixed
2010-11-09 19:37:01 +05:30
anthony 8df96da0a5 don't delete template if template check fail, give user a chance to check the template manually
use can delete the template though UI
2010-11-08 21:03:59 -08:00
anthony 4646be7587 for recursive snapshot, use UID_SYSTEM instead 2010-11-08 18:08:08 -08:00
anthony 0febfb4938 don't reschedule manual snapshot 2010-11-08 18:08:08 -08:00
anthony 3aad88e94b reschedule all polocies after management server restart, in case some schedules are missing 2010-11-08 18:08:08 -08:00
anthony 71a670defc snapshot code cleanup 2010-11-08 18:08:08 -08:00
anthony 9ee6d69c9f the default delta snapshot number between two full snapshots is 16, it is configurable 2010-11-08 18:08:07 -08:00
abhishek 7262b854a5 bug 7121: made the disk offering id optional, and added a check to ensure we never have both disk offering and snapshot ids to be null
status 7121: resolved fixed
2010-11-08 17:59:26 -08:00
abhishek 11ea13fd7d Added the domain checker code and checks for a host of commands. This replaces the previous mechanism, and provides a way for us to validate the command executor as to whether he has access to the zone. 2010-11-08 17:50:38 -08:00
will 5cc496a78d Not sure why listing of templates was using Integer instead of Long for pagesize but now correcting to keep things consistent. 2010-11-08 14:57:59 -08:00
will 0d27ac2e31 bug 5920: added confirmation dialog before allowing user to delete snapshots
- Fixed a NPE when listing templates.
2010-11-08 14:52:10 -08:00
alena 47e365f5ea bug 7089: return embedded object name in xml response
status 7089: resolved fixed
2010-11-08 13:59:14 -08:00
will 551e7e4b82 bug 6812: fixed default pagesize of all listXXX command to unlimited for now. 2010-11-08 13:15:02 -08:00
Alex Huang c8a3ea3080 merge conflict with alena's changes 2010-11-08 12:40:38 -08:00
Alex Huang 16b6850bea revert console proxy 2010-11-08 12:29:38 -08:00
Alex Huang edf9ddd464 added reservation id to vnet 2010-11-08 12:29:38 -08:00
Alex Huang 734cd0b1b1 fixed some bugs 2010-11-08 12:29:37 -08:00
Alex Huang aca8ef79cd a bunch of other changes for network refactoring 2010-11-08 12:29:37 -08:00
Alex Huang 2be0cd6a95 stop worked again 2010-11-08 12:29:36 -08:00
abhishek cc93e7508c refactoring old code and fixing some regression bugs (UI had an issue listing domains). Also fixed the listing of domain specific zones at vm creation for a domain admin (listing everything upto root in that domain + listing all the children based on a path search) 2010-11-08 12:17:42 -08:00
abhishek 67beda5244 adding the logic to list and search zones and domains based on the user (normal,admin,domain admin) 2010-11-08 12:17:42 -08:00
alena 1c24deda34 1) Refactored current Apis not to use reflection for method invocation. In new version following has to be done:
* Implement callCreate() and execute() methods in apis extending BaseAsyncCreateCmd (example - CreateVolumeCmd)
* Implement execute() method in apis extending BaseCmd and BaseAsyncCmd (example - deleteVolumeCmd and deleteUserCmd)

We no longer need createMethod(), method(), manager() fields in @Implementation annotation, cleanup has to be done.

2) Moved Account/User related methods to AccountManagerImpl. Methods are exposed via AccountService interface.
3) Enhanced exception handing for Api calls.
4) Created ConfigurationService interface, all Api config methods are exposed via it.
2010-11-08 11:27:36 -08:00
nit 70358ac153 bug 6367: registerISO, registerTemplate and createTemplate - can create non-ascii character names.
status 6367: resolved fixed
2010-11-08 20:55:02 +05:30
nit af502b1c4c bug 3384: listVolumes: regular user should be able to make a search by "type".
status 3384: resolved fixed
2010-11-08 14:46:30 +05:30
nit 8215510c19 bug 6055: createDiskOffering: remove domainId parameter.
status 6055: resolved fixed
2010-11-08 13:42:34 +05:30
nit 02781422b5 bug 6055: createDiskOffering: remove domainId parameter.
status 6055: resolved fixed
2010-11-08 13:41:33 +05:30
nit 4dc8837dc8 bug 6952: listISO should return "ispublic" property.
status 6952: resolved fixed
2010-11-08 12:33:23 +05:30
will bd5f1a7de6 Fixed NPE if addVPNUser fails because it was unable to reach the domR. 2010-11-06 16:54:14 -07:00
will 89c717703f Fixed API commands that extend BaseCreateAsyncCmd to return the correct API response of id, and jobid.
Added the default public constructor back in the SuccessResponse to make sure deserialization works from the asyncjob table.
Fixed a issues with the VPN tab.  It should now make use of the corrected API format.
2010-11-06 16:30:08 -07:00
will ca0ce93fde Fixed all sync commands that can possibly return a <success> tag. If success, it will return true, otherwise an HTTP error will be returned. 2010-11-05 21:25:19 -07:00
will 563b45a220 bug 7059: Fixed the async output to use the object name 2010-11-05 20:58:00 -07:00
anthony 224da7e775 several snapshot fixes 2010-11-05 20:55:19 -07:00
will bcb53ec363 bug 7059: Fixing adding primary and secondary storage to use new api output. 2010-11-05 20:30:55 -07:00
will a3dbc34857 bug 7059: refactored the API to now add the single embedded object tag after a response
- Changed networkgroups to security groups
- a whole bunch of other API bugs.  Unfortunately, I may have broken more.
2010-11-05 20:10:57 -07:00
alena b1defdb71d bug 6895: fixed search by id in listDomains command
status 6895: resolved fixed
2010-11-05 17:45:15 -07:00
will 05ab3bf673 bug 7063: AsyncJobResult should now return the correct success and error tags upon the completion of a async job. It should now follow either the format ... jobresult.success or jobresult.errorcode and jobresult.errortext
- Fixed a lot of other Async related packaging issues.  It's not all done but will continue to refactor this later.
2010-11-05 17:30:03 -07:00
Alex Huang 4555fcd73f changed everything back so everyone can test 2010-11-05 16:10:22 -07:00
Alex Huang 4ccf4361d1 Finally domr and instance running again. 2010-11-05 16:10:22 -07:00
Alex Huang 5f90a8adb0 Checking in to do git pull...stupid git 2010-11-05 16:10:22 -07:00
Alex Huang 1fe446002b stop vm is now formalized 2010-11-05 16:10:22 -07:00
Alex Huang d5d1808488 Added reservation context to the network gurus 2010-11-05 16:10:22 -07:00
edison 433c28fb16 bug 7041: fix npe in delete template from storage pool, if the template already marked as removed
status 7041: resolved fixed
2010-11-05 16:02:18 -07:00
alena e2aa4738ec listVirtualMachine api: return "Not created" as a root volume type when volume's storage pool id is NULL 2010-11-05 16:03:37 -07:00
alena c0e2986766 bug 6958: return state for Account api commands
status 6958: resolved fixed
2010-11-05 15:48:05 -07:00
alena a9166929f0 Fixed NPE in listVolumes/listVirtualMachines commands - do searchIncludingRemoved when get diskOffering/serviceOffering info. 2010-11-05 14:46:08 -07:00
abhishek 038a8cd59a did not like the fact that the method was getting big; refactored my logic to a private method to increase readability 2010-11-05 14:29:52 -07:00
abhishek a99cfa58ef bug 7045: blocking the start vm cmds for both ssvms and user vms when the sp is NOT up
status 7045: resolved fixed
2010-11-05 14:24:54 -07:00