Commit Graph

923 Commits

Author SHA1 Message Date
will 111b0a1df1 bug 6943: Correct error message is returned for the parameter, "name" in the API as well as fixing JS to validate this as well. 2010-11-05 13:51:46 -07:00
abhishek 452c7f4d1a bug 7002: adding a check to ensure the account specific vlan added, is within the domain tree of the zone for which the vlan is being added for (whether it is a child domain or not)
status 7002: resolved fixed
2010-11-05 13:24:41 -07:00
Chiradeep Vittal b3c87d8f25 bug 7031 also send down when router state is Starting
status 7031: resolved fixed
2010-11-05 13:17:06 -07:00
Chiradeep Vittal 3c840f910a bug 7031 send down vpn config upon restart 2010-11-05 13:08:14 -07:00
abhishek 1fe8ae4819 7004,7011: fixing the return values issue which showed the same record 2 times; also fixing the checks for deploy vm from the api layer; and also fixing the tree returned to the UI
status 7004,7011: resolved fixed
2010-11-05 12:10:30 -07:00
alena b9ad299ac6 bug 6998: return embedded job result object in queryAsyncJobResult command
status 6998: resolved fixed
2010-11-05 12:03:01 -07:00
edison 1c8f42a001 add hypervisor type for iso, enforcement kvm hosts in the cluster that must have the same os type 2010-11-04 21:29:24 -07:00
will b9fc4137f7 Bug 6988: Fixed issue with queryAsyncJobResult returning jobResults in all String format. This is to mirror the same way that the async commands are being serialized.
- Changed client.war to now include all the thirdparty files
- Fixed addVpnUser command to return a vpnuser instead of the response
- Added vmware jar files to the development build.
2010-11-04 20:56:28 -07:00
will 70b4c4d181 Bug 6988: addVpnUser did not camel case the "username" which resulted in that particular value not being returned. 2010-11-04 20:56:23 -07:00
anthony bd4f3bfaa0 set guid to null when delete secondary storage 2010-11-04 20:41:40 -07:00
abhishek 0b1bddb125 code realignment 2010-11-04 18:42:38 -07:00
abhishek 103278415e bug 7035: allowing cancel maintenance for all sp states except UP
status 7035: resolved fixed
2010-11-04 18:42:38 -07:00
abhishek 364e1e1c4a bug 7034,6869: fixing the storage pools issue, and the npe at load balancer if the router is not found.
status 7034, 6869: resolved fixed
2010-11-04 17:18:58 -07:00
abhishek e9bd0594bd bug 7022: fixing the custom size for volumes bug
status 7022: resolved fixed
2010-11-04 15:51:33 -07:00
Chiradeep Vittal 5695236840 bug 6984: add default value for domain.suffix
status 6984: resolved fixed
2010-11-04 15:40:24 -07:00
Chiradeep Vittal 5c445bd99e bug 6991: add presharedkey to response
status 6991: resolved fixed
2010-11-04 15:40:24 -07:00
abhishek 03ea885dcd making disk offering id mandatory for volume creation 2010-11-04 15:30:23 -07:00
edison 1c7e3649d2 bug 7007: if host is added before, refused to add it
status 7007: resolved fixed
2010-11-04 15:03:04 -07:00
abhishek 9a3d5c3ae3 forgot to throw the serverapiexception in the cancel maintenance cmd 2010-11-04 14:35:36 -07:00
abhishek 52d2111ed3 bug 6972: fixing the ssl cert warning
status 6972: resolved fixed
2010-11-04 14:11:28 -07:00
abhishek baa28d2022 returning serverapiexceptions for prepare and cancel pool maintenance; making it consistent with other pieces of code 2010-11-04 13:40:10 -07:00
abhishek 55e9378f9a don't set state to errorinmaintenance if cancel maintenance encounters a ps with a state !=Maintenance 2010-11-04 13:35:57 -07:00
abhishek d96a1a841d adding logic to prevent commands from being sent to the pool when it is NOT up; also adding better thread safety and db locking, along with a general refactor 2010-11-04 13:35:57 -07:00
Chiradeep Vittal 271f5a5255 fix some unused warnings 2010-11-04 11:54:14 -07:00
Chiradeep Vittal 8b846b07a7 fix some unused warnings" 2010-11-04 11:54:14 -07:00
Chiradeep Vittal 6b33a98573 bug 6981: merge in stuff for bug 6807 from 2.1.x 2010-11-04 11:54:14 -07:00
Chiradeep Vittal 8e2e04a86e bug 6981: merge in stuff for bug 6807 from 2.1.x 2010-11-04 11:54:14 -07:00
abhishek 898990a11d fixing the npe which occurs when we list zones from 8096. this has a null account. 2010-11-04 11:36:08 -07:00
edison 5a173ad363 bug 6932: add create private template from volume command support for KVM
status 6932: resolved fixed
2010-11-04 11:00:29 -07:00
abhishek 89f0c455e3 fixing the vm creation issue 2010-11-04 10:47:59 -07:00
abhishek 137fe40c46 fixing the zone creation bug 2010-11-04 09:47:39 -07:00
nit 7dc7a4838a bug 4286: Fixing the extract functionality for Upload after new API framework. Also added a check to avoid system created templates and ISO's from getting extracted as per Mike.
status 4286: resolved fixed
2010-11-04 19:09:38 +05:30
will 6dea64c63a No clue how someone could have checked in this code since it doesn't compile. <cough> Chiradeep <cough> 2010-11-03 22:24:24 -07:00
will f907e370d1 - Added the rest of the VPN UI feature with the exception of displaying the preshared key.
- AddVpnUserCmd will now return the embedded object.
- Fixed RemoteAccssVpnResponse to return "iprange" instead of "ipRange"
2010-11-03 22:24:22 -07:00
abhishek 84ee08430a making changes to the list zones flow, to add the domain name to the table, and return it 2010-11-03 22:08:32 -07:00
Alex Huang 0fdca8be9a changed back so everyone else can start the old way 2010-11-03 21:18:31 -07:00
Alex Huang 9bb05d3ef8 harmony amongst joins 2010-11-03 21:18:31 -07:00
Alex Huang a0cb58aad2 Harmony amongst gurus 2010-11-03 21:18:31 -07:00
Alex Huang e27bb550fe Harmony among gurus 2010-11-03 21:18:31 -07:00
abhishek 8e54a40b46 fix for the ui to consume for the disk offering 2010-11-03 20:05:37 -07:00
Jessica Wang 3deb7580bb Create Disk Offering - make disksize optional 2010-11-03 19:48:35 -07:00
Kelven Yang d748010da3 Create Template from volume and snapshot for vmware 2010-11-03 19:18:54 -07:00
abhishek 2303afe55c making changes for disk offerings with a new column called customized being added, for the UI to cosume whilst deploying vm with an arbitrary volume size. The UI will use this value to set the right size and the offering will ensure the right tags are taken. 2010-11-03 17:45:52 -07:00
Chiradeep Vittal f182efc279 When starting a remote access VPN, send down all the users as well 2010-11-03 16:40:44 -07:00
alena 2939e90d66 Build response the same way for create/list/update IPForwardingRule. 2010-11-03 15:49:51 -07:00
abhishek 7674df6c7a fixing the merge conflicts 2010-11-03 15:39:16 -07:00
abhishek 46497e3aad making changes for the private/public zones enhancement, for the UI to consume. The list method has been changed to return visible zones based on the user's credentials, or if the domainId for private zone listing is specified. In the update zone cmd, we do not allow updating private zone once it has been associated with a domain. This might change in the coming releases. 2010-11-03 15:39:16 -07:00
alena 6bd87ca161 Return "status" field in StoragePoolResponse. Status can be Up, Maintenance, ErrorInMaintenance 2010-11-03 14:59:00 -07:00
alena 52a8370102 bug 6955: return embedded object for PreparePrimaryStorageForMaintenance
status 6955: resolved fixed
2010-11-03 14:30:35 -07:00
Chiradeep Vittal dd5e26e701 Allow more chars in username, password 2010-11-03 14:02:13 -07:00
Chiradeep Vittal e1cb94831f VPN users feature complete 2010-11-03 14:02:13 -07:00
Chiradeep Vittal 0dd19c197b VPN users API -- WIP 2010-11-03 14:02:13 -07:00
Chiradeep Vittal 14613415e1 VPN users API -- WIP 2010-11-03 14:02:13 -07:00
Chiradeep Vittal b6d3b3c184 users for vpn -- data model 2010-11-03 14:02:12 -07:00
edison 437ca41b27 fix sb's typo 2010-11-03 13:23:59 -07:00
edison f3cc113525 bug 6933: send the snapshot related command to host on which vm created for kvm
status 6933: resolved fixed
2010-11-03 13:03:21 -07:00
alena 4a645cdeb0 Return embedded Volume object for create/attach/detach Volume commands. 2010-11-03 13:07:06 -07:00
alena 15a316484e Fixed deleteZone API - used to return empty response instead of success=true/false 2010-11-03 11:32:45 -07:00
alena 8c0e2fa7ec Fixed updatePod Api to return embedded object instead of "success" response 2010-11-03 11:18:51 -07:00
abhishek 426e445811 bug 6904: during volume creation, we were NOT converting the size of the parent disk offering (which is in MB), to bytes. This is the size used to create the volume. I am adding the appropriate multipliers. Other flows like creating volume from snapshot etc should remain unaffected, as the parent volume created from the disk offering will be set right.
status 6904: resolved fixed
2010-11-03 11:13:06 -07:00
abhishek 703fcaffe6 bug 5190: cosmetic changes for the final result returned back to the UI, for Will to consume 2010-11-03 11:13:05 -07:00
alena 4fc8b7ae0b bug 6892: do account check for disable user command
status 6892: resolved fixed
2010-11-03 10:31:16 -07:00
alena 886fd4e754 More api refactoring - move response building for LoadBalancer/IpAddress commands to ApiResponseHelper. 2010-11-03 10:11:59 -07:00
alena ebdc1f069d 1) Return embedded Host object in PrepareForMaintenance command.
2) Build HostResonse object in ApiResponseHelper for add/reconnect/update/prepareForMaintenance/cancelMaintenance commands
2010-11-02 20:30:41 -07:00
alena abb8f45667 1) Return embedded object for upgradeRouter command
2) Build response objects in ApiResponseHelper for stop/start/reboot/list router/systemVm commands
2010-11-02 19:47:14 -07:00
Alena Prokharchyk 694a8231ef Build responses in ApiResponseHelper for the deploy/start/stop/reboot/recover/listVm create/list snapshot/snapshotPolicies 2010-11-02 18:16:45 -07:00
abhishek c6809f89d4 bug 6890: preventing users from searching for system account details via the list api
status 6890: resolved fixed
2010-11-02 17:59:24 -07:00
Kelven Yang 3c6b3b3e3d Add more volume info to BackupSnapshotCommand, to generalize multi-hypervisor usage 2010-11-02 17:04:07 -07:00
abhishek 473c3d33c3 bug 6870: during updating of pf rules, it is possible one might try to update a non existing rule via the api cmd. hitherto, we were returning a null which was assumed as a success by the cmd api, which failed with a npe. instead, we ought to throw back an error since we did not find any rule to be updated. i am checking in the same change. this also will fix the npe.
status 6870: resolved fixed
2010-11-02 16:07:15 -07:00
alena 571ca42c44 1) Return embedded object for addCfg/updateCfg/listCfg.
2) Fixed NPE in updateCfg command (used to happen when no value was specified)
3) Fixed addCfg command to call correct getName method while setting config name (used to call the method returning the command name)
2010-11-02 15:26:33 -07:00
Alex Huang 5fe5450abc even more refactoring 2010-11-02 15:25:07 -07:00
abhishek d4b33f523d bug 5190: changes from the ui perspective; we upload the entire cert as a string, instead of reading it from a file. Then, we process the cert via ip streams instead of fileinputstreams. Moved the cert validation to before cert persistance, and also added more logging and exception catch blocks to deal with IO exceptions that might arise out of the ip stream processing for the new change. 2010-11-02 14:48:05 -07:00
abhishek 16438f3470 we should not be ignoring case whilst updating account, reverting to .equals instead of .equalsIgnoreCase 2010-11-02 13:45:10 -07:00
abhishek 7354116517 bug 6888: there were multiple issues here. firstly, we were checking against null newaccountnames, whereas that field is a reqd val. Also, we were allowing the same name to exist across multiple accounts in the same domain. I have fixed both these issues.
status 6888: resolved fixed
2010-11-02 13:09:37 -07:00
Alex Huang 560d7a275e Removed InternalErrorException. Renamed the lock methods on the DAO objects to be more understandable. 2010-11-02 12:25:08 -07:00
Alex Huang 3279c26796 Removed a bunch of InternalErrorException 2010-11-02 12:25:08 -07:00
Alex Huang 6311644e08 Successful creation of domr and uservm with all programming done correctly.....yahooo 2010-11-02 12:25:08 -07:00
alena 0c044a10d1 Moved response building for ServiceOffering/ResourceLimit commands to ApiResponseHelper class. 2010-11-02 11:59:10 -07:00
abhishek b6aeb6746c bug 6889: fixing the issue where we were able to create a disk offering of size 0. The check was incorrect, and now we ensure we only create the right sized volumes.
status 6889: resolved fixed
2010-11-02 11:30:43 -07:00
abhishek 85f78d8cb3 bug 6886: fixing the npe which occurs when we try to delete a non existant user. We were trying to return user details for an async job desc assuming the user always existed. Changing that logic to ensure when we don't have such details, we log the apt message
status 6886: resolved fixed
2010-11-02 11:20:52 -07:00
alena 6c3256d1e4 1) Return embedded objects for enable/disable/lock/update Account/User and updateDomain
2) Added "haschild" return parameter to Domain response.
3) Fixed updateDomain command - used to set domainname to "updatedomainnameresponse" value if no name was specified in the request. Added more logging for updateDomain command.
2010-11-01 23:49:57 -07:00
alena 5d4e4be974 1) Created ApiResponseHelper class - all api response objects should be built there.
2) Removed isMirrored tag from the update/create/listDiskOffering commands
2010-11-01 23:49:57 -07:00
abhishek 3bab616478 After discussing with Alex, it was agreed that there is no need to mgmt server level locking using the mgmt_server_id. This makes the code easier, as we have one parent acquire and release mechanism, and the complexity is reduced. In accordance, we do not need to maintain cleanup tasks for mgmt server crashes, as the async mechanism deals with this. Also, the schema becomes a tad simpler as the mgmt_server_id column is not needed anymore 2010-11-01 17:04:28 -07:00
edison d9ba39bd8b enable user to config default hypervisor type as vmware 2010-11-01 15:25:32 -07:00
Alex Huang 394af1b29c more changes on the way 2010-11-01 15:01:28 -07:00
Alex Huang cd1c903260 Better integration between it and virtual machine gurus 2010-11-01 15:01:28 -07:00
Alex Huang 4db0b7d156 Better integration between it and virtual machine gurus 2010-11-01 15:01:28 -07:00
abhishek 8e9d74c7f6 bug 5190: This covers the case of unforseen exceptions (although a corner case), which might pop up. We introduce a finally block which will release the cert db record for other ms to process, in case the owning ms errors out (not crash), whilst running the cert update process 2010-11-01 14:36:13 -07:00
abhishek 45f4499c14 bug 6836: fixing the api responses for disk offerings. We were using the wrong objext name, and were only returning success responses. Now, we are constructing the apt object and returning the entire object back.
status 6836: resolved fixed
2010-11-01 13:24:28 -07:00
Chiradeep Vittal 76c7b54fc5 fix problems after merging in bug fixes from 2.1.x 2010-11-01 12:27:15 -07:00
Chiradeep Vittal 40f15106be when user vm migrates, update rules on destination host 2010-11-01 12:21:56 -07:00
abhishek f70b55daa2 bug 6380: removing the code which returns hostid and hostname, as on a stopped vm, we do not have any association of the vm to the host 2010-11-01 12:16:53 -07:00
root fe46ddfd63 bug 6806: changing the 'iso' to 'ISO' in all the error messages being thrown back from the API
status 6806: resolved fixed
2010-11-01 11:12:03 -07:00
root bee976b5f5 bug 6779: returning the deviceId wherever possible, in the xxxVolume() calls
status 6779: resolved fixed
2010-11-01 11:12:03 -07:00
Chiradeep Vittal ff91abbb86 fix build break 2010-11-01 11:05:22 -07:00
Chiradeep Vittal 1e0eb04442 Add VPN apis, some systemvm changes for vpn 2010-11-01 10:27:49 -07:00
abhishek 71f37ff1c7 This is another improvement over the existing code for custom certs. We should ideally validate the cert for being a valid cert file (X.509 spec), instead of persisting it to the db and then validating it whilst constructing the ssl context. I am adding some validation around the same. 2010-11-01 10:07:53 -07:00
abhishek 9b684443bb bug 5190: Final commit to clean up an unused import, and to merge the changes with the master branch.
status 5190: resolved fixed
2010-11-01 09:09:18 -07:00
abhishek c74fd77730 putting in final comments, so that the code to be checked in is better readable for others trying to understand it 2010-11-01 09:06:32 -07:00
abhishek fbe2d288d7 adding some code comments 2010-11-01 09:06:32 -07:00
abhishek b9cd3e2522 some more fine tuning around corner cases 2010-11-01 09:06:32 -07:00
abhishek f3b4dd8a1c further code modularization, extracting redundant code to common methods 2010-11-01 09:06:32 -07:00
abhishek 362e67d724 adding failover protection case for when the mgmt svr crashes in the middle of executing something; along with custom response for cert 2010-11-01 09:04:51 -07:00
abhishek 7b87aad660 fixed a bug in the listener flow; now handling the application of certs to existing cpvms and new cpvms based on a fork in the logic in the console proxy resource 2010-11-01 09:04:51 -07:00
abhishek abd64eddd1 adding more exception handling and debugging support 2010-11-01 09:04:51 -07:00
root 3752a4eb31 making the logic more robust, testing more corner cases, improving efficiency and changing the schema 2010-11-01 09:04:51 -07:00
abhishek 9c80911e52 more changes 2010-11-01 09:00:58 -07:00
abhishek d9ebb7147c improving efficiency by reducing the number of db lookups, whilst updating the custom certificates across multiple console proxies when the command is issued. Now, we use in memory hashmaps for hosts to get the hostids for cphosts, which eliminates the need to make a db lookup for every cpvm that needs to be rebooted 2010-11-01 09:00:58 -07:00
abhishek 4d2e126ea1 more cpvm refactoring 2010-11-01 09:00:58 -07:00
kishan b08037d22c bug 6851: use specified account properties instead of admin, resourceType enum instead of type
status 6851: resolved fixed
2010-11-01 19:19:33 +05:30
kishan 3a0f30a049 bug 6408: remove security groups/port forwarding service in virtual network case
status 6408: resolved fixed
2010-11-01 14:28:03 +05:30
nit 1b88b0eae4 bug 6748: Correcting secondary storage space utilization on the dashboard. The fix will update the existing db entry and will create a new entry for the first time only.
status 6748: resolved fixed
2010-11-01 12:16:07 +05:30
edison 5c88bb936b Oops, == doesn't work... 2010-10-29 19:51:24 -07:00
edison d0c68cd4a7 add a timeout (5 minutes) to wait for KVM agent host connecting to mgt svr, during adding host->discover 2010-10-29 19:18:07 -07:00
Kris McQueen 24551eea3a Add constants for API command parameter names and for API response parameter names. Update the commands with the new constants rather than custom strings. Update several of the responses with the constants. Not all the responses have been updated, this is still work in progress... 2010-10-29 17:20:40 -07:00
edison f526a92b08 Only allow to attach a volume to a vm, when they are created by the same hypervisor. 2010-10-29 15:48:26 -07:00
Kris McQueen a9349cb815 bug 6857: if the dispatcher recieves an IllegalArgumentException, bubble that up to the response so the caller gets a useful message 2010-10-29 14:07:23 -07:00
Kris McQueen 519633cd38 bug 6763: restore the volume lock when creating a snapshot for the volume to ensure only one thread is creating the snapshot at a time. 2010-10-29 13:53:00 -07:00
Kris McQueen 88dac13bb0 use the API response date format when serializing response objects 2010-10-29 13:23:29 -07:00
will 9cc5aaa978 Fixed listTemplates to use the template type. 2010-10-29 13:17:32 -07:00
Alex Huang 96a4aa6f2b checkin to allow regular code path 2010-10-29 12:16:58 -07:00
Alex Huang 14f80f2e13 domain router up and running...now on to patching through the network between the domain router and the vm 2010-10-29 12:16:58 -07:00
anthony b00a9174e2 always add master first when adding host 2010-10-29 11:07:51 -07:00
kishan ad3c18a46c bug 6789: release router lock after commiting transaction
status 6789: resolved fixed
2010-10-29 16:22:19 +05:30
Kris McQueen ebac4539d0 it's possible createSnapshotDB will return null, handle that case. However, if createSnapshotDB returns null because there was no work to do (empty snapshot) we should probably throw an exception that reports that fact instead of returning null and throwing an internal error 2010-10-28 17:52:37 -07:00
Kris McQueen 642b8a56f4 If the create command returns null for whatever reason, throw an exception so it aborts scheduling the async job to act on the created object 2010-10-28 17:52:37 -07:00
Kris McQueen 640a3dc239 bug 6818: if the userAccount is null, the user is either removed or does not exist. Since we can't log them out in those cases, just skip saving the logout event (and hence avoid the NPE).
status 6818: resolved fixed
2010-10-28 17:52:37 -07:00
Kris McQueen 2f9e91a9ae bug 6738: honor groupid when listing vms (restrict the list to just that group)
status 6738: resolved fixed
2010-10-28 16:27:07 -07:00
Kris McQueen 50a72d7f71 bug 6740: update the group for a VM if a group name is given
status 6740: resolved fixed
2010-10-28 16:27:07 -07:00
Kris McQueen 6435991086 bug 6782: somehow in my testing I missed this exception when creating the event for USER_DELETE. The change is to get the userAccount by 'idIncludingRemoved' just like getting the account. The proper userAccount object is returned and the event is successfully created.
status 6782: resolved fixed
2010-10-28 14:32:13 -07:00
Kris McQueen 7531525252 Add commented code out for the old style (2.1.x) JSON async job responses. The XML responses are still a TODO. In order to get this to fully revert back to 2.1.x style responses, some commands will need to be modified to set the responseName to be something like getResultObjectName(), and there's an example of this in StopVMCmd. 2010-10-28 14:32:13 -07:00
Kris McQueen 9eb851db60 bug 6809, 6712: standardize the domain router response to use guestmacaddress instead of macaddress
status 6809, 6712: resolved fixed
2010-10-28 14:32:13 -07:00
will c5fef26f11 ListTemplates will no longer return any SystemVM templates. I am using a startsWith() string match for now since we used to make this comparision by ID with a single hypervisor. 2010-10-28 13:28:33 -07:00
nit c9069303ce Code clean up for Extract functionality and making it more robust. 2010-10-28 18:45:12 +05:30
will f0a4449ec3 ListTemplates now return the hypervisor type. 2010-10-27 19:50:36 -07:00
Kris McQueen 50c175d6c1 bug 6799: forgot to add the exception response in my commit for this bug... 2010-10-27 18:23:23 -07:00
Kris McQueen 484f334d7a bug 6799: if there's an exception executing the Async command, create an error response with the appropriate information so that queryAsyncJobResult returns the relevant information
status 6799: resolved fixed
2010-10-27 18:23:23 -07:00
Kris McQueen 901f52eb99 bug 6782: incremental checkin for deleting an account. Since there was a change to findById to not find removed objects, these NPEs pop up from time to time where we expected to find the object previously and now it's not found. Since the account is getting deleted, do a findByIdIncludingRemoved to make sure the actual account object is retrieved. 2010-10-27 18:23:23 -07:00
Kris McQueen 9056653e17 Change the API Implementation annotation to use the manager's class rather than an enum. This allows methods for new managers to be added trivially rather than having to modify the dispatcher to load a new manager class. 2010-10-27 12:23:31 -07:00
edison a29b897b7f bug 1974: set memory size from service offering before starting router
status 1974: resolved fixed
2010-10-27 12:00:11 -07:00
Kris McQueen ae9b6d4fe1 bug 6776: for some reason, we checked for zoneId = -1 in registerTemplate and applied it to all zones, but this wasn't done for registerIso. Oh well, make the change for registerIso and things seem happy again
status 6776: resolved fixed
2010-10-26 17:55:00 -07:00
Kris McQueen c9d9a18ace bug 6746: use loadbalancer name rather than the command's name for updating the load balancer; use the load balancer's account id rather than the load balancer id when searching for the load balancer owner
status 6746: resolved fixed
2010-10-26 17:40:29 -07:00
Alex Huang 4f9f249218 make console proxy work again with the new network configuration 2010-10-26 17:37:29 -07:00
Kris McQueen e63d17dd41 bug 6739: stopSystemVm needs to return the appropriate VM instance type. The manager methods were returing VMInstanceVO, which is not sufficient for getting, for example, active viewer sessions from the console proxy object. Make sure the right VO object is returned, and all the data should be available for the API to generate a full response.
status 6739: resolved fixed
2010-10-26 17:33:53 -07:00
Kris McQueen a788d2cb2e bug 6736: rebootSystemVm should return the vm properties, not success true/false.
status 6736: resolved fixed
2010-10-26 17:19:55 -07:00
Kris McQueen 95da86ef1a bug 6733: re-throw ServerApiExceptions when dispatching API commands rather than logging them and throwing a generic INTERNAL_ERROR exception
status 6733: resolved fixed
2010-10-26 16:54:42 -07:00
Kris McQueen 28bcbc3bdd bug 6732: there is no longer a manual policy, so add in special handling for deleting manual snapshots. Also, in the process of deleting the snapshot, the snapshot might need to be retrieved from the database, so be sure to find including removed.
status 6732: resolved fixed
2010-10-26 16:47:21 -07:00
Kris McQueen 8fafc892d3 bug 6730: if a volume was never attached to a VM, then the poolId will be null and this will be flagged as not on shared storage. Since the code was deleting detached volumes only on shared storage, the never-attached volume was in an undeletable state. Instead, allow deletion of any detached volume, regardless of storage pool until some technical reason limits this from happening.
Also, the UI was not allowing volumes to be deleted due to a bug in looking at the vmname property of the volume.  The 'if' conditional always returned true that the volume was attached to a VM to due a boolean logic error.

status 6730: resolved fixed
2010-10-26 14:56:44 -07:00
abhishek a698c0327d adding more logging around successful cert upload 2010-10-26 14:27:26 -07:00
abhishek c6588c0e25 adding some error return handling to api dispatcher, and cleaning up some of the code paths to return the right error messages 2010-10-26 14:27:26 -07:00
root 42f1ff92a9 resolved merge conflicts after git pull --rebase 2010-10-26 14:27:26 -07:00
abhishek f64abad8f5 completed the listener logic. Based on the startup command, we will try and update a cust cert to a new running cpvm, and fail if such a cert doesn't exist in the cert table in our db. 2010-10-26 14:27:26 -07:00
abhishek cb4a80b8ac starting off with the listener logic.This will ensure that every new console proxy vm that starts, will potentially look for any custom certs uploaded to our db. If they exist, we will send a command to the agent, so that the cert is uploaded, and the ssl context is re-initialized. 2010-10-26 14:27:26 -07:00
abhishek 822ee2d899 more changes for the console proxy custom certificate part; some code cleanup as well as event generation with console proxy reboot logic 2010-10-26 14:27:26 -07:00
alena afd79a9b1b Code cleanup 2010-10-26 13:59:11 -07:00
anthony 1b014ec340 master oss management server can start now 2010-10-26 13:47:43 -07:00
Alex Huang 2bc938c3f8 checkins for problems. 2010-10-26 09:35:24 -07:00
Alex Huang 29a5b796d4 deploy vm completed...now for testing 2010-10-26 09:35:24 -07:00
Alex Huang f58063911e deploy vm completed 2010-10-26 09:35:24 -07:00
nit 7f15b8ff57 Adding the accidental deleted code 2010-10-26 19:05:13 +05:30
nit 497c60d63d Extending extract functionlity for volumes to allow download. The
extraction can have two modes FTP_UPLOAD and HTTP_DOWNLOAD. In the former one
the user would provide the ftp url where the entity needs to be uploaded and in
the later the user would be provided a HTTP URL where from he/she can download
the entity. This url would be exposed for a specific time limit and would not
function after the time limit
2010-10-26 18:49:43 +05:30
Kris McQueen b3c7821b44 bug 6752: fix updating resource limits for a domain by looking at the given accountName/domainId parameters rather than looking at the caller's account. If updating limits for an account, e.g. account 'foo' in domain 4, then execute updateResourceLimit&account=foo&domainid=4&..., but if updating the limit for a domain, don't specify the account parameter. When processing the command, if accountName is null, the limit for the domain will be properly updated.
status 6752: resolved fixed
2010-10-25 17:32:28 -07:00
Kris McQueen ef131bbc18 bug 6724: set useVirtualNetwork in the createServiceResponse
status 6724: resolved fixed
2010-10-25 17:08:47 -07:00
Kris McQueen f9c1f12778 bug 6725: use serviceOfferingName rather than the API command name when updating the service offering; set memory in the response for UpdateServiceOffering
status 6725: resolved fixed
2010-10-25 17:08:47 -07:00
Kris McQueen 27cafb2957 bug 6727: ostypename was being set from guest_os.name which seems to be null most of the time. Instead, use guest_os.display_name.
status 6727: resolved fixed
2010-10-25 17:08:47 -07:00
Kris McQueen fcb0ff83ac bug 6712: for router responses, change guestmacaddress -> macaddress to preserve behavior from 2.1.x and before.
status 6712: resolved fixed
2010-10-25 16:37:42 -07:00
Kris McQueen 869f3587c3 bug 6714: add displaytext to SuccessResponse so commands that return success true/false can also return a brief description of what took place.
status 6714: resolved fixed
2010-10-25 16:37:42 -07:00
Kris McQueen 3660d6a3d1 bug 6717: updateDiskOffering is supposed to return success true/false rather than the updated disk offering
status 6717: resolved fixed
2010-10-25 16:37:42 -07:00
Kris McQueen c8e9531842 bug 6720: add 'created' to the ListHosts response
status 6720: resolved fixed
2010-10-25 16:37:42 -07:00
Kris McQueen 83e4922b94 bug 6703, 6704: use the correct method signatures for invoking updateTemplate/updateIso and updateTemplatePermissions/updateIsoPermissions APIs. It's possible that the reflection should just use 'isAssignableFrom' when getting methods since the manager methods were using a base class as the parameter rather than UpdateTemplateCmd/UpdateIsoCmd and UpdateTemplatePermissions/UpdateIsoPermissions, but for now the explicit methods are added for simplicity.
status 6703, 6704: resolved fixed
2010-10-25 15:01:50 -07:00
Kris McQueen d229877cd8 bug 6710: rebootRouter was supposed to return the rebooted router, not success/failure
status 6710: resolved fixed
2010-10-25 15:01:50 -07:00
Kris McQueen 18f6d67121 bug 6705, 6708: use the UserVmResponse for changeServiceForVirtualMachine API (UpgradeVMCmd) since the response is a vm. There was no need for a specific UpgradeVmResponse which had scalars instead of objects and the serializer skips null, but will serialize scalars with their default values, in this case 0 for id and host id.
status 6750, 6708: resolved fixed
2010-10-25 15:01:49 -07:00
abhishek aebf02b707 removing some debug params 2010-10-25 11:52:08 -07:00
root c98b2a7fa2 incremental checkin around the console proxy config enh 2010-10-25 11:52:08 -07:00
abhishek a7b1e0a539 more changes for console proxy 2010-10-25 11:52:08 -07:00
nit 511a095c26 bug 6487: AttachISO API would return an embedded object on success.
status 6487: resolved fixed
2010-10-25 18:26:39 +05:30
nit 5774fd163d bug 6480: detachVolume API would start returning an embedded object, like attachVolume API does.
status 6480: resolved fixed
2010-10-25 17:19:22 +05:30
nit 554e360d21 Fixing a typo in the HostResponse of the word custer.
Fixing the names of the ISO and templates.
2010-10-25 14:54:49 +05:30
nit 035810d60a bug 6481: embedded object returned by attachVolume API would have the "type" property indicating the volume type of the disk volume (ROOT or DATADISK)
status 6481: resolved fixed
2010-10-25 14:14:40 +05:30
kishan 8ae5a70b06 bug 6395: corrected net rule event error description
status 6395: resolved fixed
2010-10-25 13:11:50 +05:30
kishan 3530daf3ff bug 6697: make resourcetype optional
status 6697: resolved fixed
2010-10-25 12:22:06 +05:30
Jessica Wang 958aaaaf87 new UI - instance page - refactor submenu. 2010-10-22 20:23:05 -07:00
Kris McQueen e6f7a480ae bug 6674: Fix VM responses
- ostypeid -> guestosid
 - findRootVolume is now in ApiDBUtils (from mgmt server) since it's for API responses only
 - add rootdeviceid and rootdevicetype to various VM respones (listVirtualMachines, deployVirtualMachine, start/stopVirtualMachine)

status 6674: resolved fixed
2010-10-22 13:57:03 -07:00
Kris McQueen 1728606e51 use the correct account id when saving the event after assigning a port forwarding service 2010-10-22 13:57:03 -07:00
Kris McQueen 4a96e1f633 bug 6662: handle a null ip forwarding rule in the API response as 'the rule already exists' since other errors will result in thrown exceptions. Also, fix up detection of network conflicts and duplicate rules by adding a list of used protocols to the port mappings
status 6662: resolved fixed
2010-10-22 11:47:52 -07:00
anthony da58ade720 fixed addding the secondary storage 2010-10-22 11:06:00 -07:00
Alex Huang 88f446f9d4 checkin for windows 2010-10-22 09:21:47 -07:00
Alex Huang f1a431714c checkin to fix windows 2010-10-22 09:19:53 -07:00
Kelven Yang 1c702a1d69 1) As the lack of dom0 scripting support in vmware hyperviors, domR, and other system VM will fall back to private network interface instead of link local interface, accordingly,
domR scripting will be running directly inside domR and be driven from management server instead of dom0 host
2) firewall/sshd setting changes for #1
2010-10-21 21:46:41 -07:00
anthony 18ffd7e7a8 fixed build 2010-10-21 19:25:52 -07:00
anthony 141250714e fixed the break of adding standalone host 2010-10-21 19:00:11 -07:00
NIKITA 2f70032972 conflict 2010-10-21 17:57:56 -07:00
Alex Huang 25e4ed6997 more changes in the api 2010-10-21 16:53:42 -07:00
abhishek a957a679ed bug 5190: modifying a few minor details in the upload cert part, to conform with the new api refactor design 2010-10-21 15:51:46 -07:00
Kris McQueen 365ac7501f bug 6672: Fix up volume commands. For createVolume, the command is supposed to create a database object, but not assign it to a storage pool until the user first attaches it to a vm instance. That allows the volume to start off hypervisor agnostic. For attachVolume, detachVolume, and listVolumes, the responses had minor issues (sourceType could be null, for example) in either the response generation, or the response handling by the UI.
status 6672: resolved fixed
2010-10-21 15:15:01 -07:00
Alex Huang d5d8f27cad Added more changes to the api 2010-10-21 15:11:49 -07:00
abhishek 3e2c92e0db bug 3386: refining the comments inside the code 2010-10-21 14:29:07 -07:00
root 1c0c753342 bug 3386: final part of the enh for tagging zones with domains. We make the same check for childdomains as exist in the current code, to ensure the right domain permissions are enforced. By default, we will use the domainId passed by the user, if this is not passed, we will try to get the id from the dc. If it exists (private dc), if it doesn't then it is (public dc) 2010-10-21 14:27:07 -07:00
abhishek 9a9146c07b whilst testing my enh, found that this call was using the wrong method name. Checking in the fix for the same. 2010-10-21 11:43:06 -07:00
abhishek 2b9ab00cc2 bug 3386: first part of the checkin, wherein we have an optional param domainId for create and modify zones. If this domain exists in the system, then the zone is tagged with this domain id, so that subsequent calls are checked for sanity against this domain. 2010-10-21 11:43:06 -07:00