b9cd3e2522
some more fine tuning around corner cases
2010-11-01 09:06:32 -07:00
f3b4dd8a1c
further code modularization, extracting redundant code to common methods
2010-11-01 09:06:32 -07:00
362e67d724
adding failover protection case for when the mgmt svr crashes in the middle of executing something; along with custom response for cert
2010-11-01 09:04:51 -07:00
7b87aad660
fixed a bug in the listener flow; now handling the application of certs to existing cpvms and new cpvms based on a fork in the logic in the console proxy resource
2010-11-01 09:04:51 -07:00
abd64eddd1
adding more exception handling and debugging support
2010-11-01 09:04:51 -07:00
3752a4eb31
making the logic more robust, testing more corner cases, improving efficiency and changing the schema
2010-11-01 09:04:51 -07:00
9c80911e52
more changes
2010-11-01 09:00:58 -07:00
d9ebb7147c
improving efficiency by reducing the number of db lookups, whilst updating the custom certificates across multiple console proxies when the command is issued. Now, we use in memory hashmaps for hosts to get the hostids for cphosts, which eliminates the need to make a db lookup for every cpvm that needs to be rebooted
2010-11-01 09:00:58 -07:00
4d2e126ea1
more cpvm refactoring
2010-11-01 09:00:58 -07:00
b08037d22c
bug 6851: use specified account properties instead of admin, resourceType enum instead of type
...
status 6851: resolved fixed
2010-11-01 19:19:33 +05:30
3a0f30a049
bug 6408: remove security groups/port forwarding service in virtual network case
...
status 6408: resolved fixed
2010-11-01 14:28:03 +05:30
1b88b0eae4
bug 6748: Correcting secondary storage space utilization on the dashboard. The fix will update the existing db entry and will create a new entry for the first time only.
...
status 6748: resolved fixed
2010-11-01 12:16:07 +05:30
5c88bb936b
Oops, == doesn't work...
2010-10-29 19:51:24 -07:00
d0c68cd4a7
add a timeout (5 minutes) to wait for KVM agent host connecting to mgt svr, during adding host->discover
2010-10-29 19:18:07 -07:00
24551eea3a
Add constants for API command parameter names and for API response parameter names. Update the commands with the new constants rather than custom strings. Update several of the responses with the constants. Not all the responses have been updated, this is still work in progress...
2010-10-29 17:20:40 -07:00
f526a92b08
Only allow to attach a volume to a vm, when they are created by the same hypervisor.
2010-10-29 15:48:26 -07:00
a9349cb815
bug 6857: if the dispatcher recieves an IllegalArgumentException, bubble that up to the response so the caller gets a useful message
2010-10-29 14:07:23 -07:00
519633cd38
bug 6763: restore the volume lock when creating a snapshot for the volume to ensure only one thread is creating the snapshot at a time.
2010-10-29 13:53:00 -07:00
88dac13bb0
use the API response date format when serializing response objects
2010-10-29 13:23:29 -07:00
9cc5aaa978
Fixed listTemplates to use the template type.
2010-10-29 13:17:32 -07:00
96a4aa6f2b
checkin to allow regular code path
2010-10-29 12:16:58 -07:00
14f80f2e13
domain router up and running...now on to patching through the network between the domain router and the vm
2010-10-29 12:16:58 -07:00
b00a9174e2
always add master first when adding host
2010-10-29 11:07:51 -07:00
ad3c18a46c
bug 6789: release router lock after commiting transaction
...
status 6789: resolved fixed
2010-10-29 16:22:19 +05:30
ebac4539d0
it's possible createSnapshotDB will return null, handle that case. However, if createSnapshotDB returns null because there was no work to do (empty snapshot) we should probably throw an exception that reports that fact instead of returning null and throwing an internal error
2010-10-28 17:52:37 -07:00
642b8a56f4
If the create command returns null for whatever reason, throw an exception so it aborts scheduling the async job to act on the created object
2010-10-28 17:52:37 -07:00
640a3dc239
bug 6818: if the userAccount is null, the user is either removed or does not exist. Since we can't log them out in those cases, just skip saving the logout event (and hence avoid the NPE).
...
status 6818: resolved fixed
2010-10-28 17:52:37 -07:00
2f9e91a9ae
bug 6738: honor groupid when listing vms (restrict the list to just that group)
...
status 6738: resolved fixed
2010-10-28 16:27:07 -07:00
50a72d7f71
bug 6740: update the group for a VM if a group name is given
...
status 6740: resolved fixed
2010-10-28 16:27:07 -07:00
6435991086
bug 6782: somehow in my testing I missed this exception when creating the event for USER_DELETE. The change is to get the userAccount by 'idIncludingRemoved' just like getting the account. The proper userAccount object is returned and the event is successfully created.
...
status 6782: resolved fixed
2010-10-28 14:32:13 -07:00
7531525252
Add commented code out for the old style (2.1.x) JSON async job responses. The XML responses are still a TODO. In order to get this to fully revert back to 2.1.x style responses, some commands will need to be modified to set the responseName to be something like getResultObjectName(), and there's an example of this in StopVMCmd.
2010-10-28 14:32:13 -07:00
9eb851db60
bug 6809, 6712: standardize the domain router response to use guestmacaddress instead of macaddress
...
status 6809, 6712: resolved fixed
2010-10-28 14:32:13 -07:00
c5fef26f11
ListTemplates will no longer return any SystemVM templates. I am using a startsWith() string match for now since we used to make this comparision by ID with a single hypervisor.
2010-10-28 13:28:33 -07:00
c9069303ce
Code clean up for Extract functionality and making it more robust.
2010-10-28 18:45:12 +05:30
f0a4449ec3
ListTemplates now return the hypervisor type.
2010-10-27 19:50:36 -07:00
50c175d6c1
bug 6799: forgot to add the exception response in my commit for this bug...
2010-10-27 18:23:23 -07:00
484f334d7a
bug 6799: if there's an exception executing the Async command, create an error response with the appropriate information so that queryAsyncJobResult returns the relevant information
...
status 6799: resolved fixed
2010-10-27 18:23:23 -07:00
901f52eb99
bug 6782: incremental checkin for deleting an account. Since there was a change to findById to not find removed objects, these NPEs pop up from time to time where we expected to find the object previously and now it's not found. Since the account is getting deleted, do a findByIdIncludingRemoved to make sure the actual account object is retrieved.
2010-10-27 18:23:23 -07:00
9056653e17
Change the API Implementation annotation to use the manager's class rather than an enum. This allows methods for new managers to be added trivially rather than having to modify the dispatcher to load a new manager class.
2010-10-27 12:23:31 -07:00
a29b897b7f
bug 1974: set memory size from service offering before starting router
...
status 1974: resolved fixed
2010-10-27 12:00:11 -07:00
ae9b6d4fe1
bug 6776: for some reason, we checked for zoneId = -1 in registerTemplate and applied it to all zones, but this wasn't done for registerIso. Oh well, make the change for registerIso and things seem happy again
...
status 6776: resolved fixed
2010-10-26 17:55:00 -07:00
c9d9a18ace
bug 6746: use loadbalancer name rather than the command's name for updating the load balancer; use the load balancer's account id rather than the load balancer id when searching for the load balancer owner
...
status 6746: resolved fixed
2010-10-26 17:40:29 -07:00
4f9f249218
make console proxy work again with the new network configuration
2010-10-26 17:37:29 -07:00
e63d17dd41
bug 6739: stopSystemVm needs to return the appropriate VM instance type. The manager methods were returing VMInstanceVO, which is not sufficient for getting, for example, active viewer sessions from the console proxy object. Make sure the right VO object is returned, and all the data should be available for the API to generate a full response.
...
status 6739: resolved fixed
2010-10-26 17:33:53 -07:00
a788d2cb2e
bug 6736: rebootSystemVm should return the vm properties, not success true/false.
...
status 6736: resolved fixed
2010-10-26 17:19:55 -07:00
95da86ef1a
bug 6733: re-throw ServerApiExceptions when dispatching API commands rather than logging them and throwing a generic INTERNAL_ERROR exception
...
status 6733: resolved fixed
2010-10-26 16:54:42 -07:00
28bcbc3bdd
bug 6732: there is no longer a manual policy, so add in special handling for deleting manual snapshots. Also, in the process of deleting the snapshot, the snapshot might need to be retrieved from the database, so be sure to find including removed.
...
status 6732: resolved fixed
2010-10-26 16:47:21 -07:00
8fafc892d3
bug 6730: if a volume was never attached to a VM, then the poolId will be null and this will be flagged as not on shared storage. Since the code was deleting detached volumes only on shared storage, the never-attached volume was in an undeletable state. Instead, allow deletion of any detached volume, regardless of storage pool until some technical reason limits this from happening.
...
Also, the UI was not allowing volumes to be deleted due to a bug in looking at the vmname property of the volume. The 'if' conditional always returned true that the volume was attached to a VM to due a boolean logic error.
status 6730: resolved fixed
2010-10-26 14:56:44 -07:00
a698c0327d
adding more logging around successful cert upload
2010-10-26 14:27:26 -07:00
c6588c0e25
adding some error return handling to api dispatcher, and cleaning up some of the code paths to return the right error messages
2010-10-26 14:27:26 -07:00
42f1ff92a9
resolved merge conflicts after git pull --rebase
2010-10-26 14:27:26 -07:00
f64abad8f5
completed the listener logic. Based on the startup command, we will try and update a cust cert to a new running cpvm, and fail if such a cert doesn't exist in the cert table in our db.
2010-10-26 14:27:26 -07:00
cb4a80b8ac
starting off with the listener logic.This will ensure that every new console proxy vm that starts, will potentially look for any custom certs uploaded to our db. If they exist, we will send a command to the agent, so that the cert is uploaded, and the ssl context is re-initialized.
2010-10-26 14:27:26 -07:00
822ee2d899
more changes for the console proxy custom certificate part; some code cleanup as well as event generation with console proxy reboot logic
2010-10-26 14:27:26 -07:00
afd79a9b1b
Code cleanup
2010-10-26 13:59:11 -07:00
1b014ec340
master oss management server can start now
2010-10-26 13:47:43 -07:00
2bc938c3f8
checkins for problems.
2010-10-26 09:35:24 -07:00
29a5b796d4
deploy vm completed...now for testing
2010-10-26 09:35:24 -07:00
f58063911e
deploy vm completed
2010-10-26 09:35:24 -07:00
7f15b8ff57
Adding the accidental deleted code
2010-10-26 19:05:13 +05:30
497c60d63d
Extending extract functionlity for volumes to allow download. The
...
extraction can have two modes FTP_UPLOAD and HTTP_DOWNLOAD. In the former one
the user would provide the ftp url where the entity needs to be uploaded and in
the later the user would be provided a HTTP URL where from he/she can download
the entity. This url would be exposed for a specific time limit and would not
function after the time limit
2010-10-26 18:49:43 +05:30
b3c7821b44
bug 6752: fix updating resource limits for a domain by looking at the given accountName/domainId parameters rather than looking at the caller's account. If updating limits for an account, e.g. account 'foo' in domain 4, then execute updateResourceLimit&account=foo&domainid=4&..., but if updating the limit for a domain, don't specify the account parameter. When processing the command, if accountName is null, the limit for the domain will be properly updated.
...
status 6752: resolved fixed
2010-10-25 17:32:28 -07:00
ef131bbc18
bug 6724: set useVirtualNetwork in the createServiceResponse
...
status 6724: resolved fixed
2010-10-25 17:08:47 -07:00
f9c1f12778
bug 6725: use serviceOfferingName rather than the API command name when updating the service offering; set memory in the response for UpdateServiceOffering
...
status 6725: resolved fixed
2010-10-25 17:08:47 -07:00
27cafb2957
bug 6727: ostypename was being set from guest_os.name which seems to be null most of the time. Instead, use guest_os.display_name.
...
status 6727: resolved fixed
2010-10-25 17:08:47 -07:00
fcb0ff83ac
bug 6712: for router responses, change guestmacaddress -> macaddress to preserve behavior from 2.1.x and before.
...
status 6712: resolved fixed
2010-10-25 16:37:42 -07:00
869f3587c3
bug 6714: add displaytext to SuccessResponse so commands that return success true/false can also return a brief description of what took place.
...
status 6714: resolved fixed
2010-10-25 16:37:42 -07:00
3660d6a3d1
bug 6717: updateDiskOffering is supposed to return success true/false rather than the updated disk offering
...
status 6717: resolved fixed
2010-10-25 16:37:42 -07:00
c8e9531842
bug 6720: add 'created' to the ListHosts response
...
status 6720: resolved fixed
2010-10-25 16:37:42 -07:00
83e4922b94
bug 6703, 6704: use the correct method signatures for invoking updateTemplate/updateIso and updateTemplatePermissions/updateIsoPermissions APIs. It's possible that the reflection should just use 'isAssignableFrom' when getting methods since the manager methods were using a base class as the parameter rather than UpdateTemplateCmd/UpdateIsoCmd and UpdateTemplatePermissions/UpdateIsoPermissions, but for now the explicit methods are added for simplicity.
...
status 6703, 6704: resolved fixed
2010-10-25 15:01:50 -07:00
d229877cd8
bug 6710: rebootRouter was supposed to return the rebooted router, not success/failure
...
status 6710: resolved fixed
2010-10-25 15:01:50 -07:00
18f6d67121
bug 6705, 6708: use the UserVmResponse for changeServiceForVirtualMachine API (UpgradeVMCmd) since the response is a vm. There was no need for a specific UpgradeVmResponse which had scalars instead of objects and the serializer skips null, but will serialize scalars with their default values, in this case 0 for id and host id.
...
status 6750, 6708: resolved fixed
2010-10-25 15:01:49 -07:00
aebf02b707
removing some debug params
2010-10-25 11:52:08 -07:00
c98b2a7fa2
incremental checkin around the console proxy config enh
2010-10-25 11:52:08 -07:00
a7b1e0a539
more changes for console proxy
2010-10-25 11:52:08 -07:00
511a095c26
bug 6487: AttachISO API would return an embedded object on success.
...
status 6487: resolved fixed
2010-10-25 18:26:39 +05:30
5774fd163d
bug 6480: detachVolume API would start returning an embedded object, like attachVolume API does.
...
status 6480: resolved fixed
2010-10-25 17:19:22 +05:30
554e360d21
Fixing a typo in the HostResponse of the word custer.
...
Fixing the names of the ISO and templates.
2010-10-25 14:54:49 +05:30
035810d60a
bug 6481: embedded object returned by attachVolume API would have the "type" property indicating the volume type of the disk volume (ROOT or DATADISK)
...
status 6481: resolved fixed
2010-10-25 14:14:40 +05:30
8ae5a70b06
bug 6395: corrected net rule event error description
...
status 6395: resolved fixed
2010-10-25 13:11:50 +05:30
3530daf3ff
bug 6697: make resourcetype optional
...
status 6697: resolved fixed
2010-10-25 12:22:06 +05:30
958aaaaf87
new UI - instance page - refactor submenu.
2010-10-22 20:23:05 -07:00
e6f7a480ae
bug 6674: Fix VM responses
...
- ostypeid -> guestosid
- findRootVolume is now in ApiDBUtils (from mgmt server) since it's for API responses only
- add rootdeviceid and rootdevicetype to various VM respones (listVirtualMachines, deployVirtualMachine, start/stopVirtualMachine)
status 6674: resolved fixed
2010-10-22 13:57:03 -07:00
1728606e51
use the correct account id when saving the event after assigning a port forwarding service
2010-10-22 13:57:03 -07:00
4a96e1f633
bug 6662: handle a null ip forwarding rule in the API response as 'the rule already exists' since other errors will result in thrown exceptions. Also, fix up detection of network conflicts and duplicate rules by adding a list of used protocols to the port mappings
...
status 6662: resolved fixed
2010-10-22 11:47:52 -07:00
da58ade720
fixed addding the secondary storage
2010-10-22 11:06:00 -07:00
88f446f9d4
checkin for windows
2010-10-22 09:21:47 -07:00
f1a431714c
checkin to fix windows
2010-10-22 09:19:53 -07:00
1c702a1d69
1) As the lack of dom0 scripting support in vmware hyperviors, domR, and other system VM will fall back to private network interface instead of link local interface, accordingly,
...
domR scripting will be running directly inside domR and be driven from management server instead of dom0 host
2) firewall/sshd setting changes for #1
2010-10-21 21:46:41 -07:00
18ffd7e7a8
fixed build
2010-10-21 19:25:52 -07:00
141250714e
fixed the break of adding standalone host
2010-10-21 19:00:11 -07:00
2f70032972
conflict
2010-10-21 17:57:56 -07:00
25e4ed6997
more changes in the api
2010-10-21 16:53:42 -07:00
a957a679ed
bug 5190: modifying a few minor details in the upload cert part, to conform with the new api refactor design
2010-10-21 15:51:46 -07:00
365ac7501f
bug 6672: Fix up volume commands. For createVolume, the command is supposed to create a database object, but not assign it to a storage pool until the user first attaches it to a vm instance. That allows the volume to start off hypervisor agnostic. For attachVolume, detachVolume, and listVolumes, the responses had minor issues (sourceType could be null, for example) in either the response generation, or the response handling by the UI.
...
status 6672: resolved fixed
2010-10-21 15:15:01 -07:00
d5d8f27cad
Added more changes to the api
2010-10-21 15:11:49 -07:00
3e2c92e0db
bug 3386: refining the comments inside the code
2010-10-21 14:29:07 -07:00
1c0c753342
bug 3386: final part of the enh for tagging zones with domains. We make the same check for childdomains as exist in the current code, to ensure the right domain permissions are enforced. By default, we will use the domainId passed by the user, if this is not passed, we will try to get the id from the dc. If it exists (private dc), if it doesn't then it is (public dc)
2010-10-21 14:27:07 -07:00
9a9146c07b
whilst testing my enh, found that this call was using the wrong method name. Checking in the fix for the same.
2010-10-21 11:43:06 -07:00
2b9ab00cc2
bug 3386: first part of the checkin, wherein we have an optional param domainId for create and modify zones. If this domain exists in the system, then the zone is tagged with this domain id, so that subsequent calls are checked for sanity against this domain.
2010-10-21 11:43:06 -07:00
3260001b65
bug 6665: don't need to send poolEject command for the last host, and mark it as success
...
status 6665: resolved fixed
2010-10-21 10:21:32 -07:00
bec09a4323
bug 6486: added VirtualMachine to stopVm response
...
status 6486: resolved fixed
2010-10-21 14:52:27 +05:30
b7d430cf86
bug 6399: deployVirtualMachine API should return an embedded object (named "virtualmachine").
...
status 6399: resolved fixed
2010-10-21 13:48:29 +05:30
fa4a16cb68
bug 5592: Added configurable domain for hosts.
...
status 5592: resolved fixed
2010-10-21 11:51:09 +05:30
58cc90c10f
1) Modify domain router manager to support vmware
...
2) Add python and shell scripts for domr to support vmware
2010-10-20 18:49:18 -07:00
f4e21787b6
bug 6658: fix managing load balancer instances by removing some of the 'pending' status code.
...
status 6658: resolved fixed
2010-10-20 17:27:08 -07:00
2f8aad2691
The listSnapshots API has changed in 2.2 a bit, so rather than merge my fix for bug 6680 from 2.1.x, just applied it manually...the fix was to apply the domain search to listSnapshots so that domain admins can see snapshots in their domain and all sub domains, but nothing outside their domain hierarchy.
2010-10-20 16:48:20 -07:00
6723549fc7
bug 6399: extending extract functionlity for templates and ISO's to allow download. The extraction can have two modes FTP_UPLOAD and HTTP_DOWNLOAD. In the former one the user would provide the ftp url where the entity needs to be uploaded and in the later the user would be provided a HTTP URL where from he/she can download the entity. This url would be exposed for a specific time limit and would not function after the time limit.
2010-10-20 11:40:03 +05:30
d8a5e84e21
If default hypervisor is vmware, use private network instead of link local network
2010-10-19 16:35:32 -07:00
47e26af419
bug 6643: when configuring vlan IP ranges, account might not be specified (zone wide IP range), so assign the configuration event to the SYSTEM account in those cases.
...
status 6643: resolved fixed
2010-10-19 16:27:08 -07:00
2bd5b6a29e
bug 6654: virtualmachinename should be serialized as vmname, fix handling of the createPortForwardingRule response
...
status 6654: resolved fixed
2010-10-19 15:59:37 -07:00
7c11c04427
reverting the change for bug 6361; this was an accidental push instead of commit
2010-10-19 15:21:01 -07:00
7cc8087fa6
bug 6361: more name changes from network group to security group
2010-10-19 15:21:01 -07:00
523862f571
bug 6361: further name changes from network to security group
2010-10-19 14:35:17 -07:00
6bd7caa9c2
bug 6361: first part of incremental checkin to rename network group to security grou[
2010-10-19 14:35:17 -07:00
0267a306c8
bug 6649: when listing domains, accept -1 as 'list all.' Fix listDomainChildren response to return haschild, handle haschild as a boolean rather than a string.
...
status 6649: resolved fixed
2010-10-19 13:49:00 -07:00
5466e10fa3
simple variable rename
2010-10-19 12:03:40 -07:00
2da8035bd1
more changes for the rewrite
2010-10-19 11:52:02 -07:00
794ca16a65
Added code to start domR
2010-10-19 11:52:01 -07:00
04c8c0f91c
bug 6041: returning the complete embedded reponse for a destroyvm async call
...
status 6041: resolved fixed
2010-10-19 11:46:42 -07:00
f4f00cbe2d
bug 6655: when verifying request signature for API requests that use keys, pass the userId of the requester as a Long to avoid NPEs when converting it to a string. Also set up the UserContext for both normal users and admins.
...
status 6655: resolved fixed
2010-10-19 11:41:09 -07:00
408822e358
bug 6037: last part of the checkin for this bug
...
status 6037: resolved fixed
2010-10-19 11:36:54 -07:00
89e9a85902
bug 6037: adding response obj of type uservmmanager to recovervm response
2010-10-19 11:00:23 -07:00
68eb09114a
there is more than one routing template now (VMWare has its own) so change the listVolumes filter to remove volumes for routing* templates
2010-10-19 10:40:52 -07:00
947c2ca16d
fix problems in api post-refactor
2010-10-19 09:53:51 -07:00
4d37269961
fix local disk for system vms
2010-10-19 09:53:51 -07:00
bb5399c2bc
Fixed PodResponse: endip is all lowercase now.
2010-10-18 14:11:21 -07:00
603874605d
The serialized names for the old VIRTUAL_MACHINE_* constants weren't quite right. Fix these up. This is a good example for why there needs to be a pass through the API commands and responses and constants should be used in the annotations rather than the current strings that are in place.
2010-10-18 14:10:07 -07:00
3be625ca6e
The stopVirtualMachine API should return the vm instance rather than a boolean indicating success. The response for async jobs is now under the jobresult property of the JSON response, handle the start/stop virtual machine responses using data from the jobresult rather than expecting some embedded object.
2010-10-18 11:15:07 -07:00
e41729cc43
fix rpm build
2010-10-16 01:03:31 -07:00
915d29f47b
Skip starting of console proxy when storage pool is not ready
2010-10-15 18:57:28 -07:00
2c919c5c01
Make unique name conforming with the name generated in template installation for routing template, some other minor fixes
2010-10-15 16:36:02 -07:00
d41f7d78d9
DeleteStoragePool command fix
...
1. not delete SR in xenserver side, only delete it in database.
2. remove a storagepool, adding it back fails
2010-10-15 14:15:55 -07:00
8555eb1913
Fix the broken ConsoleProxyServlet after the merge of API refactoring changes
2010-10-15 11:17:27 -07:00
84d2a0c842
reverted back most of my changes to merge in Kris stuff. Thanks much to Anthony who caused my XenServer to reboot all the time which caused me unable to unit test stuff and unlike Kris, I do not check in code untested so now I have to do all this stuff.
2010-10-15 07:10:16 -07:00
bebf9dbc3f
Adding stuff
2010-10-15 06:26:24 -07:00
b3da4cea1b
Forcing me to commit because of stupid git
2010-10-15 06:22:59 -07:00
80090990a6
Fix configuration in light of new API framework. Move code from ConfigurationManager into ConfigurationServer for creating disk/service offerings, pods, and zones. This prevents the ComponentLocator from pulling in a lot of extra DAOs and Managers now that ConfigurationManager has a lot more dependencies due to API changes. Without making this change, there would be a dependency on ClusteredAgentManager in both config-server and mgmt-server, which would try to start two listeners on port 8250, which is bad. Now that the configuration happens in ConfigurationServer, things should be kept simple.
2010-10-14 19:11:22 -07:00
88814d95f0
A zoneId of -1 means all zones, so if zoneId is passed in as -1 just list all zones for registering the template
2010-10-14 19:11:21 -07:00
f6e0d2dd41
Make system VM work on vmware
2010-10-14 17:23:13 -07:00
e168760295
The code implies resource could be null, and yet de-references resource before the null check. As I was experiencing a NPE because if this exact scenario, put the remote agent check inside the check for null to avoid problems. If resource is null we log that we were unable to send ping due to agent disconnected...
2010-10-14 15:02:43 -07:00
39d30b9bf1
only send commands to host which is Up and Connecting
2010-10-14 11:35:48 -07:00
7115aa06bd
send commands to host which is UP and connecting
2010-10-14 11:08:35 -07:00
9b839d749b
only send command to host which is UP
2010-10-14 10:24:52 -07:00
f7ec2ebc48
bug 6521: for add host, return api response, even if the host is in disconnected state
...
status 6521: resolved fixed
2010-10-14 10:20:48 -07:00
d928a6f3d9
If storage pool is null after adding a pool, throw an exception so the user sees a problem adding the pool. This is better than the NPE that was happening...
2010-10-13 16:08:49 -07:00
5960911511
Fix processing of session parameters in logout case
2010-10-12 19:42:53 -07:00
8e086d7a21
resolving merge conflicts between 2.1.refactor and master
2010-10-12 16:28:16 -07:00
0f4a245f0a
resolving merge conflicts before pushing to the remote repository
2010-10-12 15:37:50 -07:00
2740ba6c40
final merge of master->2.1.refactor preparing for merge back into master
2010-10-12 14:46:24 -07:00
ce091de3d2
more changes for refactor
2010-10-12 07:17:47 -07:00
09cefaf3e9
bug 6500: add back the special handle for secodary storage host, it is in the same path of handling xenserver host, it is easy to break that, so I add some comments there
...
status 6500: resolved fixed
2010-10-11 12:05:13 -07:00
fb50fe624c
* Added descriptions for Api command's request and response parameters.
...
* Changed response type for DeleteDomain and DeletePreallocatedLun commands to SuccessResponse
* Implemented small tool (ApiXmlDocReader) for comparing api commands of different product versions.
2010-10-11 09:21:42 -07:00
0c750aa8fa
bug 6462: notifyMonitorsOfConnection of handleDirectConnect may fail, but it still returns the removed attach, and lauch ping task
...
status 6462: resolved fixed
2010-10-09 17:34:36 -07:00
a93d36d81a
should use _hostDao.listByCluster instead of _hostDao.listByPodId in some places
2010-10-08 18:10:15 -07:00
2f39664f94
maybe it was an incorrect merge that snapshot was disabled for KVM
...
Re-enable it.
2010-10-07 18:56:42 -07:00
0d64b460f8
add vmware network configuration variables
2010-10-07 18:23:26 -07:00
3028dab141
fix systemvm template in direct attached mode, guest vm can't get gateway and dns server
2010-10-07 16:32:46 -07:00
2861895a84
bug 6450: list all snapshot for admin
...
status 6450: resolved fixed
2010-10-07 15:35:58 -07:00
9e03518c94
fix return value of stopSystemVm (should be the vm, not a boolean); add the missing disableAccount API in management server to avoid a NoSuchMethod exception when disabling an account
2010-10-07 15:10:03 -07:00
45c611100a
fix NPE when updating a resource limit using the internal API port
2010-10-07 15:10:03 -07:00
55201432f6
createServiceOffering had cpuSpeed passed twice when creating the offering rather than cpuNumber then cpuSpeed...fixed
2010-10-07 15:10:03 -07:00
ea84f3bde2
registerTemplate and registerIso expect the template to be returned, not the template id...fixed
2010-10-07 15:10:02 -07:00
7c4a06a764
fix the method name for listIsos command
2010-10-07 15:10:02 -07:00
e18895f15b
account and domainid are required parameters when disabling an account
2010-10-07 15:09:28 -07:00
bef7998bbf
resolving merge conflicts between the documentation changes and other API refactoring work
2010-10-07 15:07:49 -07:00
335613a8a9
Add the mirrored property to the disk offering response
2010-10-07 15:03:47 -07:00
e7b478f43d
Added descriptions for Api commands and corresponding requrest parameters
2010-10-07 14:46:29 -07:00
fbb5a109cc
Fix return types for resetVmPassword and upgradeVirtualMachine commands. Fix response for resetVmPassword to be a vm rather than success/failure. Make sure the password is a transient variable for the resetVmPassword command so that the new password is returned to the user.
2010-10-06 18:29:27 -07:00
6db9f377a3
use the name of the configuration variable rather than the name of the command
2010-10-06 18:28:12 -07:00
1ae2273871
when updating the account, use the correct name for the updates
2010-10-06 18:27:46 -07:00
ec62ef3cd7
Injection doesn't work on private methods, restore the visibility of the methods so injection works.
2010-10-06 18:25:58 -07:00
48f1264a80
bug 6446: do not pass private, guest, public network in host_detail to CitrixResourceBase.configure
...
status 6446: resolved fixed
2010-10-06 18:16:19 -07:00
d307b86b07
Temporarily add a blank system vm for vmware testing, explcitly check the ticket info in console access URL
2010-10-06 17:36:13 -07:00
9d1270b35f
console proxy started completely and running
2010-10-06 17:22:35 -07:00
0cb11027e9
back port from 2.1.x
2010-10-06 15:18:23 -07:00
b369103a87
reverted back to old console proxy code
2010-10-06 10:18:09 -07:00
94a26d2038
Still needs to add mac address allocation but basically console proxy is started and running
2010-10-06 10:18:09 -07:00
9c593352d0
Fixing events for async jobs so that there's a scheduled event recorded with appropriate type/description whenever the API framework schedules the async command to run. A few miscellaneous fixes as well uncovered during regression testing (router response was not parsed correctly by UI, etc.)
2010-10-05 20:26:18 -07:00
3982bc0558
When storing job record, for domain routers, appoint its owner account in stead of system account
2010-10-05 13:48:09 -07:00
1cd370fc36
hypervisor type for deployvmCmd is optional, only deploying blankvm
...
needs it.
2010-10-05 09:52:06 -07:00
f7f2b5666a
bug 5871: removing the NDC since there is no nested context involved in the audit trail and since its leaking into the management server logs.
2010-10-05 19:51:12 +05:30
00f8de2687
console proxy vm is now started
2010-10-04 17:59:06 -07:00
5f88268ef2
console proxy vm is now started but it is not reading the disk correctly
2010-10-04 17:59:06 -07:00
8db5a1a1e2
add Copyright for new file
2010-10-04 17:05:41 -07:00
aaaa5dc3ad
bug 6379: add ListHypervisors cmd to list all the supported hypervisors.
...
status 6379: resolved fixed
The supported hypervisors are controlled by hypervisor.list in configuration table
2010-10-04 16:55:25 -07:00
73cd402e72
Make queryAsyncJobResult support queries from domain administrators
2010-10-04 16:48:38 -07:00
5f3bb36650
1) Merge following change from 2.1.X
...
Add time stamped ticket to console access URL to make it more secure
2) Fix a problem caused by the inconsistency of using different path seperator between windows platform and linux platform
2010-10-04 15:31:05 -07:00
1877200575
missing to add the new file
2010-10-04 14:57:14 -07:00
d370ae6a32
Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss
2010-10-04 14:48:40 -07:00
3d9f25e903
bug 1974: add upgraderoutercmd to upgrade router vm's service offering
...
status 1974: resolved fixed
It's a synced API, which just update router vm's service offering,
parameter: router id, service offering id,
return: ture on successfull, otherwise false
2010-10-04 14:45:28 -07:00
0d08bb1799
start partially working need boot parameters set
2010-10-04 12:04:59 -07:00
652d86956c
more files checked in
2010-10-04 12:04:59 -07:00
24bd6a39e6
Fix the type of the id attribute in BaseAsyncCmd (it should be Long), deleteNetworkRuleConfig is async command again (this was a regression), misc event and account verification fixes
2010-10-04 10:36:44 -07:00
136060e5cf
1) Finished XmlApiDoc writer. The program gets api classes from commands.properties.in file, and build Command objects with "name"/"description"/"request"/"response" fields. Request and response are represented by the list of arguments, each argument contains "name"/"description"/"isrequired" fields. The commands are being serialized to commands.xml using imported xstream library, and can be desiarialized later - it will help to compare commands from differemt product versions.
...
2) Added description() methods to Implementation and Param annotations.
2010-10-04 09:50:14 -07:00
46a433d750
Incremental checkin for ApiXmlDocBuilder
2010-10-04 09:50:14 -07:00
09768ca751
bug 5363: Adding Scheduled and Started event for SNAPSHOT.CREATE.
...
status 5363: resolved fixed
2010-10-04 19:51:19 +05:30
25b78d962f
bug 5356: Adding Started event for ROUTER.DESTROY when we destroy a domR as a part of account delete.
...
status 5356: resolved fixed
2010-10-04 17:51:41 +05:30
38fd80e522
bug 5871: Introducing audit trail for all the interactions with the cloud stack - User 'X' initiated an action 'Y' on resource 'Z'. The audit will contain http api request along with the contextual parameters (userId, accountId, sessionId). For the response part only log success/failure for all sync api's with the exception of queryAsyncJob where reason code and reason will also be logged. For async api's I will also log the async job id.
2010-10-04 14:27:40 +05:30
3aa34687f5
set hypervisor type to be manadatory for deployvm and registertmplt API
2010-10-01 15:15:01 -07:00
28c421c798
Make external DHCP mode as default for FOSS
2010-10-01 14:47:42 -07:00
3dee56ed91
add virtual networking serviceoffering back
2010-10-01 14:26:50 -07:00
41a16a478a
Fixes required for regressions found running automated tests. (1) method signatures that weren't properly refactored to new API framework (2) API request parameter types should always be specified lest they default to String which may or may not be desired (3) better exception handling with regard to Queued commands and generic exceptions (4) fix eventing to pass the proper accountId where neccessary
2010-10-01 14:11:18 -07:00
f433a4d360
bug 6363:
...
1. delete local storage when delete host
2. delete host detail when delete host
3. allow one host in maintance mode in a cluster instead of in a pod
status 6363: resolved fixed
2010-10-01 10:40:08 -07:00
b441deec94
Need to set all the system vms as read state
2010-09-30 20:39:34 -07:00
4955c97b03
bug 5190: incremental checkin
2010-09-30 18:12:07 -07:00
1f173cc8f3
bug 6359: find the existing pool master
...
status 6359: resolved fixed
2010-09-30 15:19:25 -07:00
5f2acc8cdd
Fixing API responses for user VMs (we need to return ipaddress rather than privateip) and domain routers (guestMacAddress != guestmacaddress for case sensitive string comparison)
2010-09-30 14:22:10 -07:00
26807bc701
bug 6362: Need to call guestos.getDisplayName to the guest os name now.
...
status 6362: resolved fixed
2010-09-30 12:26:37 -07:00
bc2449a69a
If the session in invalidated due to a bad session key, just return to avoid the situation where the session is invalidated twice (which causes IllegalStateException)
2010-09-30 11:39:36 -07:00
f6bd092327
private.network.device may change, always try to find out the real private.network.device
2010-09-29 19:23:37 -07:00
58c430f7d7
add xenserver specific configruation back
2010-09-29 18:48:26 -07:00
7615f569ff
after rebase, fix bugs
2010-09-29 18:41:55 -07:00
ad1ef80459
Now we have multiple routing template and buitin templates now, refactor template download code, that can handle it.
...
Basically, change the meaning of type field in template table: SYSTEM means sytem vm template, BUILIIN means buildin templates.
2010-09-29 18:41:55 -07:00
fb9f43d807
clean up hypervisor.type, actually hypevisor.type may only make sense on the UI in multi-hypervisor.
...
In our java code, we should not write code based on hypervisor.type.
2010-09-29 18:41:54 -07:00
d478bb9d95
don't add the "untagged"
2010-09-29 18:41:54 -07:00
6fc7528809
create data volume is splitted into two stage:
...
1. create a volume entry in the database,
2. when user attaching the volume to a VM, then actually create the volume on storage pool.
2010-09-29 18:41:54 -07:00
abba8398b3
fix add xen-pv-iso, add cloud-guest as the xen.guest.network
2010-09-29 18:41:54 -07:00
964f8f1fe3
fix boot from iso
2010-09-29 18:41:54 -07:00
d98d6cbb9f
fix template download, listguestos type
2010-09-29 18:41:53 -07:00
baeb1af265
fix register template hypervisor type
2010-09-29 18:41:53 -07:00
ea1efa95f6
send guestosdisplay to agent
2010-09-29 18:41:53 -07:00
b8c1d2ea17
set external ipallocator as true by default
2010-09-29 18:40:52 -07:00
9e0f57bc0e
change code for new UI
2010-09-29 18:40:52 -07:00
8943cc6745
create volume
...
Conflicts:
api/src/com/cloud/vm/VmCharacteristics.java
core/src/com/cloud/dc/ClusterVO.java
core/src/com/cloud/server/ManagementServer.java
server/src/com/cloud/network/NetworkManager.java
server/src/com/cloud/storage/allocator/AbstractStoragePoolAllocator.java
2010-09-29 18:40:51 -07:00
86d59bdddd
Implement CreateVolume/AttachVolue for vmware
2010-09-29 18:40:51 -07:00
2337a9d99f
Fix a NPE in AbstractStoragePoolAllocator.java when creating standalone volume
2010-09-29 18:40:51 -07:00
72e8b767fe
Mount secondary storage as a datastore to implement ISO attachment
2010-09-29 18:40:50 -07:00
9db2925b77
Make database config recognize service offering change
2010-09-29 18:40:49 -07:00
6ae1c8fa31
Enable logging for deploydb and add support for hypervisor type in service offering
2010-09-29 18:40:49 -07:00
b3427fc634
don't remove template
2010-09-29 18:40:48 -07:00
7c4fe92a9f
s/VMWare/Vmware
2010-09-29 18:40:48 -07:00
e2282ba800
don't throw exceptions when you can't add host
2010-09-29 18:40:48 -07:00
edb16aa117
change storage allocator policy based on hypervisor
2010-09-29 18:40:47 -07:00
3aef9f408e
step1
2010-09-29 18:40:47 -07:00
211b4c5da2
hybrid
2010-09-29 18:40:47 -07:00
b8c8aacca3
bug 6326: correctly update poolsToAvoid
...
status 6326: resolved fixed
2010-09-29 18:38:01 -07:00
0105aec338
Always set the response type on the command object so that the correct output is generated. Add both Strings and Longs to the login response (domainId and userId will be the Longs). Use the correct method name for ListSystemVMsCmd.
2010-09-29 17:32:19 -07:00
bca96b1079
pass guest OS name instead of guest ID when start system VM
2010-09-29 17:18:27 -07:00
be5fa82229
remove snapshotpolicyRef
2010-09-29 16:24:57 -07:00
9b03017a07
bug 6354: return correct interval
...
status 6354: resolved fixed
2010-09-29 16:09:06 -07:00
5b75f8e03b
bug 6365: find policy from volumeId instead of snapshotID
...
status 6365: resolved fixed
2010-09-29 15:25:46 -07:00
da660f2575
Change session parameters to be their actual type (domainId and userId are saved to the session as Longs and not Strings)
2010-09-29 15:18:43 -07:00
9e2d1f5e70
Refactoring disableUser and disableAccount to new API framework (they are both async commands).
2010-09-29 13:57:26 -07:00
cd42fcc1bf
some code refactoring
2010-09-29 11:17:42 -07:00
153dca3ddf
bug 6195: removed service offering Id for ROOT volumes in usage data
2010-09-29 18:29:07 +05:30
9e87534e42
bug 6216: Added Id to listAlerts response
2010-09-29 15:52:13 +05:30
319d4f1aa0
snapshot redesign
...
1. use full snapshot and delta snapshot, there are maxsnashot/2 of delta snapshot between two full snapshot
2. only support one policy for one volume
3. remove all coleases in secondary storage.
2010-09-28 18:37:46 -07:00
95a7f20a0a
Adding in XML response serializing. Now the new API framework supports both XML and JSON responses the way the old framework did.
2010-09-28 17:36:27 -07:00
848ce60097
Merging master into 2.1.refactor, resolve the merge conflicts as best I can. New commands related to extracting template/iso/volume and related to instance groups were refactored to the new API framework.
2010-09-28 15:47:14 -07:00
e5186bde2b
bug 5190: a part of the enhancement is complete; now we can upload a custom cert using a file from our local machine, into the system. It is stored in the certificate table as a "text" column
2010-09-28 13:52:14 -07:00
0af7ad934b
bug 5190: updating the command list
2010-09-28 11:28:40 -07:00
bbdc135c12
bug 5190: more changes
2010-09-28 11:19:08 -07:00
91340ca8de
bug 5190: incremental checkin with a bunch of vo,dao,schema and upgrade changes
2010-09-28 11:03:12 -07:00
122b15071d
bug 6334: Correcting the syntax of json data when the response is empty.
...
status 6334: resolved fixed
2010-09-28 14:46:44 +05:30
9b10074c2a
Added missing license info to the bunch of files
2010-09-27 19:08:03 -07:00
f1b0e4b811
tweaks for debian system vm
2010-09-27 18:04:49 -07:00
ad4ea90207
bug 5190: enhancing some of the error messages returned to be more intuitive
2010-09-27 17:01:01 -07:00
89cce1a023
bug 5190: adding some more methods for the functionality
2010-09-27 16:54:28 -07:00
677d8894ea
bug 5190: modifying the api calls
2010-09-27 16:49:34 -07:00
1356f5f33a
bug 5190: incremental checkin, code cleanup
2010-09-27 16:46:14 -07:00
060dfc2cf9
bug 5190: incremental checkin
2010-09-27 16:39:32 -07:00
dcea43ba0f
create is now complete
2010-09-27 15:14:38 -07:00
c443867f28
more changes
2010-09-27 15:14:38 -07:00
49143dbe4a
Remove user vm from instance_group when empty string is passed as value for "group" parameter in updateVirtualMachine API.
2010-09-27 14:24:08 -07:00
72243c8382
bug 5191: incremental checkin
2010-09-27 11:10:55 -07:00
27a32380f2
bug 5360: Adding scheduled and started events for USER.DELETE.
...
status 5360: resolved fixed
2010-09-27 20:39:05 +05:30
6c683e733a
bug 5851,6312: fixed start event ids for router start/stop events
...
status 5851,6312: resolved fixed
2010-09-27 18:32:09 +05:30
b857a9b4c8
bug 4177: registerTemplate/registerIso commands would start accepting account/domainId params.
...
status 4177: resolved fixed
2010-09-27 17:24:23 +05:30
ec4755a60e
bug 6123: Include last id in the vlan range
...
status 6123: resolved fixed
2010-09-27 16:57:31 +05:30
6e4fa7fcd1
bug 6176: Included domR name in networkUsage command
...
status 6176: resolved fixed
2010-09-27 16:26:56 +05:30
26fc22160c
bug 5871: Correcting the ostypeid and ostypename returned by the listIsos
2010-09-27 12:10:49 +05:30
7abda2ee2d
bug 6291: generating some events whilst starting vms, wrt volume creation
...
status 6291: resolved fixed
2010-09-24 15:50:33 -07:00
62257d4021
Fix serializing async job responses by writing a custom adapter for ResponseObjects. Improve exception handling when calling async commands (the job still needs to complete, but with FAILED status).
2010-09-24 13:52:35 -07:00
9228088ce3
bug 6103: Made "capacity.skipcounting.hours" to apply only for Stopped vms. Introduced "capacity.skipcounting.destroyed.hours" config value that is used for vms in Destroyed state
...
status 6103: resolved fixed
2010-09-24 11:30:44 -07:00
c48bd7cf63
revert console proxy
2010-09-24 10:33:04 -07:00
42986f43ba
removed service offering from storageallocator
2010-09-24 10:27:02 -07:00
2a4ddac41a
Change getResponse() to return a ResponseObject so that the caller can choose how to serialize. This in in preparation for serializing the async commands to the database with class information and deserializing them into the ResponseObject itself when queryAsyncJobResult is called. Once the ResponseObject is deserialized, the proper string can be returned to the caller.
...
The previous behavior had the JSON response from the command embedded into the queryAsyncJobResult response as a string rather than a JSON object which prevented the client from being able to read the response. With this new behavior an actual JSON object should be returned which can then be parsed on the client side.
2010-09-23 17:34:28 -07:00
c9ae6fd09d
record used byte not available byte
2010-09-23 16:25:17 -07:00
188711c18d
bug 6236: fixing some more api issues, this time with the stopped vm.
...
status 6236: resolved fixed
2010-09-23 16:21:10 -07:00
24dd41f9d0
some api changes to enable vm functioning
2010-09-23 16:09:21 -07:00
eee7c2c97e
bug 6212: returning a whole bunch of new params in the api response
...
status 6212: resolved fixed
2010-09-23 15:36:19 -07:00
320df380c9
bug 6217: incremental fix for the vm api
...
bug 6217: resolved fixed
2010-09-23 14:56:25 -07:00
29f8c5d94c
bug 6217: incremental checkin
2010-09-23 14:55:13 -07:00
e0dcb95511
bug 6217: incremental checkin
2010-09-23 14:55:13 -07:00
5d97c029bf
bug 6217: incremental checkin
2010-09-23 14:55:13 -07:00
99165dc0a1
Fixed search by keyword in listRouters command - deleted displayName parameter from keyword list as it applies for user vms only
2010-09-23 11:09:41 -07:00
0f2f356874
bug 6277: listVirtualMachines with group=-1 would return all vms that don't belong to any group. As a part of the fix, changed Dao layer to be able to make different types of Joins - Inner, Right, Left, etc.
...
status 6277: resolved fixed
2010-09-23 10:43:17 -07:00
703c182f8f
bug 6222: removing non needed attribs
...
status 6222: resolved fixed
2010-09-23 10:32:42 -07:00
2d67815ddf
bug 6239: some changes to the router api
...
status 6239: resolved fixed
2010-09-23 10:23:03 -07:00
29bf0cd718
bug 6238: fixing some api issues with the deploy vm cmd
...
status 6238: resolved fixed
2010-09-23 10:05:56 -07:00
abaa66f6e3
bug 6181: ingore provisioning factor for iscsi primary storage
...
status 6181: resolved fixed
2010-09-22 20:39:57 -07:00
6f92235365
some more modifications to the ip selection logic in direct attached case
2010-09-22 16:12:31 -07:00
32884572b9
bug 6241: incremental checkin
2010-09-22 15:32:42 -07:00
242a55f120
bug 6271: Fixed the issue of us not iterating over all vlans, in the direct attached case. now, we consider all vlan ranges before we error out saying no ip address available
...
status 6271: resolved fixed
2010-09-22 10:58:12 -07:00
91f77b6cc5
revert back console proxy manager for git push
2010-09-22 10:50:00 -07:00
979fcf8b78
finalized guru design
2010-09-22 10:44:00 -07:00
0be5053c56
more changes
2010-09-22 10:43:59 -07:00
c0d8422d69
more changes
2010-09-22 10:43:59 -07:00
22652e7ace
got the vm created
2010-09-22 10:43:59 -07:00
abhishek
root
kishan
nit
edison
Kris McQueen
will
Alex Huang
anthony
alena
Jessica Wang
Kelven Yang
NIKITA
Chiradeep Vittal
Kelven Yang
root