45557cc020
Fixed Coverity Issues Reported
2014-07-31 15:44:41 +05:30
f47cfc6eb1
CLOUDSTACK-7186: Revert "CLOUDSTACK-7182: NPE while trying to deploy VMs in parallel in isolated network"
...
This reverts commit 47d6a64b31
2014-07-28 16:02:21 -07:00
45c9f03e14
Added upgrade path from 4.4.1 to 4.5
2014-07-28 15:49:06 -07:00
d42e20429d
schema: add upgrade path from 4.4.0 to 4.5.0 via 4.4.1
...
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2014-07-29 00:21:39 +02:00
9a94bc26fa
DB upgrade - added a path from 4.4.0 to 4.4.5
2014-07-28 14:43:39 -07:00
330c4ba578
completed the new vmsync TODOs in the code.
...
removed old vmsync logic
2014-07-28 12:51:37 -07:00
67876b215e
CLOUDSTACK-7191:On restartNetwork destroy the VR immediatley, instead of
...
cleanup the rules then destroy
fix adds a provision to specify if cleanup is needed on network on
shutdown. VR is marked as to not to require network rules clean up on
network shutdown as the VR is destroyed and recreated.
ran the simulator tests that test network life cycle
2014-07-28 17:09:42 +05:30
8aeefdc130
Fixed Coverity Issues Reported
2014-07-25 16:46:20 +05:30
7bbe7fc697
Fixed Coverity Issues Reported
2014-07-25 16:41:17 +05:30
2018d7d977
Fixed Coverity Issues Reported
2014-07-25 16:39:16 +05:30
3bb344281a
Fixed Coverity issues Reported
2014-07-25 16:38:15 +05:30
47d6a64b31
CLOUDSTACK-7182: NPE while trying to deploy VMs in parallel in isolated network
...
The following changes are made:
- Check to see if network is implemented changed from 'state == Implementing||Implemented' to 'state == Implemented'.
The earlier check was a hack to prevent the issue described below.
- At the time of implementing network (using implementNetwork() method), if the VR needs to be deployed then
it follows the same path of regular VM deployment. This leads to a nested call to implementNetwork() while
preparing VR nics. This flow creates issues in dealing with network state transitions. The original call
puts network in "Implementing" state and then the nested call again tries to put it into same state resulting
in issues. In order to avoid it, implementNetwork() call for VR is replaced with below code.
2014-07-25 15:17:35 +05:30
676b2d1569
Fix overflow before widening issues reported by Coverity
2014-07-24 13:22:14 +02:00
f275f293bb
Fix CID 1114608 Store virtualsize in the the virtualsize column
2014-07-24 12:21:37 +02:00
da55aff64f
CLOUDSTACK-7158 listCapacity API missing types for certain zones
2014-07-24 14:33:51 +05:30
0f85e649b6
CLOUDSTACK-5999: Virtual Router does not start if Guest VM is rebooted from CloudStack
2014-07-24 10:45:51 +05:30
c804660c74
CLOUDSTACK-7168: Revert "Fixed Coverity Issues reported" that broke CI
...
This reverts commit 4523490d44
2014-07-23 11:37:36 -07:00
4523490d44
Fixed Coverity Issues reported
...
Signed-off-by: Santhosh Edukulla <santhosh.edukulla@gmail.com>
2014-07-22 18:03:36 +05:30
b080eaf327
Updates to the way resizing a volume works
2014-07-17 21:09:19 -06:00
771b53b342
CLOUDSTACK-4725: if storage pool has different path, but the uuid is the same, then treat them as the same storage pool
2014-07-16 16:38:17 -07:00
e78bb1d225
Switch the catch to Throwable. Uncaught exceptions in a scheduled
...
threadpool executor will not report or log uncaught exceptions but will
kill the thread causing unexplained timeouts in CS.
2014-07-16 16:24:55 +02:00
aacf8ef77b
Findbugs fixes in cloud-utils project and a few other places
2014-07-15 14:23:17 +05:30
33d6bc278f
Adding missing modified file
2014-07-14 17:42:27 -07:00
62e63a1bf7
CLOUDSTACK-6358: Missing patches in master for VMware
2014-07-14 16:54:10 -07:00
09069fcc87
CLOUDSTACK-6358: Add missing patches in master for KVM
2014-07-14 16:51:55 -07:00
6831ed4026
CLOUDSTACK-6358: Missing patches in master branch
2014-07-14 15:17:58 -07:00
f275eb1ff9
CLOUDSTACK-7029: listCapacity fails when podid argument is specified.
2014-07-09 12:09:33 +05:30
f4d2034755
CLOUDSTACK-7081: db upgrade fixes - a) added description for cloud.volumes.iso_id field b) removed duplicated unique key "id_2" from cloud.storage_pool table
2014-07-08 14:14:07 -07:00
62c18ca3fa
Fixing an issue in the AbstractStoragePoolAllocator's filter method where zone-wide storage of HypervisorType.Any is skipped
2014-07-07 22:16:58 -06:00
5a96d8ef5c
CLOUDSTACK-7073: Added domainId field to the user table in order to restrict duplicated users creation on the db level
2014-07-07 16:21:38 -07:00
8e112858d3
CLOUDSTACK-7071. Upgrade to CCP 4.2 fails in case a VMware setup has multiple zones mapping to the same VMware datacenter.
...
If 2 or more CloudStack zones map to the same VMware datacenter, mark the zones as legacy zones.
2014-07-07 16:38:56 +05:30
a600d8408e
Fixed Resource Leaks, null dereferences, few other issues reported by coverity
2014-07-04 16:17:58 +05:30
1e72e5a818
CLOUDSTACK-6935 remove iSCSI storage filtering logic for Root volume
...
since there is no reason to filter it out
2014-07-01 19:57:19 -06:00
32ed9d86ec
Revert "Fixing an issue introduced with Review Request 22717"
...
This reverts commit 12e92e10ff
2014-07-01 19:54:11 -06:00
97d296bfbd
Fixed Coverity reported performance issues like inefficient string concatenations, wrong boxing or unboxing types, inefficent map element retrievals
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-07-01 22:06:25 +02:00
12e92e10ff
Fixing an issue introduced with Review Request 22717
2014-06-26 23:56:11 -06:00
80ef915fd5
CLOUDSTACK-7000: ListSnapshotPolicy should list by policyid. Introduce updateSnapshotPolicy command
...
(cherry picked from commit fce21439fa
2014-06-26 11:38:41 -07:00
05b79a127a
Fix the license headers Nitin forgot.
2014-06-25 16:07:00 +02:00
ab0dca0385
Catch possible exceptions in finally so they won't shadow the original exception.
2014-06-25 15:51:29 +02:00
cd0ef09344
Fix typo and add the right exception to the error map.
2014-06-25 15:51:28 +02:00
f756d4aa33
Make job info universally available across management server and resource agents
2014-06-24 16:28:22 -07:00
3d9eaf0753
Fixed some spacing issues from 4d6c682f18
2014-06-24 15:27:06 -06:00
b2283d7a28
Fixed few resource leaks and added secstoragefirewallcfg command support to simulator
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-06-24 23:19:47 +02:00
4d6c682f18
supporting nfs protocol and resize feature for managed storage for xenserver
...
resize feature refactored
Signed-off-by: Mike Tutkowski <mike.tutkowski@solidfire.com>
2014-06-24 15:16:45 -06:00
cb5e8c591f
CLOUDSTACK-6987: Add support for storing metadata for snapshot policy and controlling policy using display flag
...
(cherry picked from commit 5cf8edd7ec
2014-06-24 14:07:39 -07:00
c344693e48
Inform the applicable storage plug-in's life cycle that capacity (bytes and/or IOPS) can be updated
2014-06-24 14:39:57 -06:00
c79ab570b0
Revert "CLOUDSTACK-6967: Initial OVM3 drop"
...
This reverts commit 8a485b9b59
2014-06-24 10:24:01 +02:00
8a485b9b59
CLOUDSTACK-6967: Initial OVM3 drop
...
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
(cherry picked from commit ed47763e25
2014-06-23 12:39:10 +02:00
bbcffbbab0
CLOUDSTACK-6965: fixed the NullPointerException introduced by fix for cloudstack
...
6935 in AbstractStoragePoolAllocator#filter method for Zone Wide storage
2014-06-23 12:17:08 +05:30
1c80185170
Fixed Resource Leaks, null dereferences, invalid value comparisons, invalid result set loop
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-06-21 12:38:46 +02:00
450d890942
CLOUDSTACK-6830: Fixed during VM migration, volumes on zone wide primary store
...
requires storage migration resulting in failure of VM migration. This also improves
the hostsformigration api. Firstly we were trying to list all hosts and then
finding suitable storage pools for all volumes and then we were checking whether
vm migration requires storage migration to that host. Now the process is updated.
We are checking for only those volumes which are not in zone wide primary store.
We are verifying by comparing volumes->poolid->clusterid to host clusterid. If it
uses local or clusterids are different then verifying whether host has suitable
storage pools for the volume of the vm to be migrated too.
2014-06-20 16:32:19 +05:30
318e497e60
CLOUDSTACK-6935 refactor StoragePoolAllocator#filter logic
...
to support IOPS capacity control in a cluster wide storage pool and a
local storage pool
to enable hypervisor type check, storage type check for root volume and
avoid list check
Since original commit(31de58edab
2014-06-18 13:45:52 -06:00
3312394154
CLOUDSTACK-6934: don't try to detach volume from host when volume was never allocated to a primary storage
2014-06-18 12:39:36 -07:00
77e74841a0
Revert "CLOUDSTACK-6935 refactor StoragePoolAllocator#filter logic"
...
This reverts commit 31de58edab
2014-06-18 13:04:39 -06:00
31de58edab
CLOUDSTACK-6935 refactor StoragePoolAllocator#filter logic
...
to support IOPS capacity control in a cluster wide storage pool and a
local storage pool
to enable hypervisor type check, storage type check for root volume and
avoid list check
2014-06-18 11:07:34 -06:00
f529823566
Add ReflectionUse annotation for marking up *un-used* methods
2014-06-17 17:31:29 -07:00
520ff00083
removed closing of out of scope statement
2014-06-16 15:46:42 +02:00
d86b6778ad
Fixed few resource leak issues
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
(cherry picked from commit 3c5f64c97a
2014-06-16 15:12:31 +02:00
f89100ed72
CLOUDSTACK-6793 : Added fix
...
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2014-06-16 17:11:14 +05:30
0c28f36ff1
Fix a number of resource leaks reported by Coverity
2014-06-13 14:42:35 +02:00
aa21cdcd49
CLOUDSTACK-6897: when we try to attach the uploaded/allocated volume to a VM on zwps, then we were passing the podId of VM instead of storage pool to storage allocator. This resulting in use of Clusterscope storage allocator, allocating a storage pool for VM on zwps beacuse of pod id not null. This was resulting in scope conflict later
2014-06-13 14:47:00 +05:30
66d1eb92f0
CLOUDSTACK-6865 , CLOUDSTACK-6868: [hyperv] while attaching the volume we were changing the volume's Image format to hypervisor's default Image format, hence it was failing to find the volume with vhdx format. Now changed the behavior to set Image Format for volume only when it is not set
2014-06-13 13:26:02 +05:30
b666a1f3a5
Fixed issues reported by coverity NPEs, unwritten field access and self assignment
...
Signed-off-by: Koushik Das <koushik@apache.org>
2014-06-10 14:34:47 +05:30
a5902f1db4
CLOUDSTACK-6850: Return cpu cores, cpu speed and memory in listUsageRecords
...
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
2014-06-10 03:11:35 -04:00
a8212d9ef4
Cleanup of Xen and XenServer terms. Cloned xen plugin creating a xenserver plugin, then removed xen plugin
...
Signed-off-by: Tim Mackey <tmackey@gmail.com>
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
2014-06-07 04:50:23 -04:00
3b3f4577b0
CLOUDSTACK-6476: Basic Zone with Multiple Pods Setup: DHCP server doesnt get deployed in the pod where the VM gets deployed
...
Changes:
PodId in which the router should get started was not being saved to the DB due to the VO's setter method not following the setXXX format. So when planner loaded the router from DB, it always got podId as null and that would allow planner to deploy the router in any pod. If the router happens to start in a different pod than the user VM, the Vm fails to start since the Dhcp service check fails.
Fixed the VO's setPodId method, that was causing the DB save operation fail.
2014-06-06 16:15:31 -07:00
39f775c381
try-with-resource to prevent resource leaks
2014-06-06 17:38:18 +02:00
57e66ddaa6
CLOUDSTACK-6676: cleanup ip address details on ip disassoc
2014-06-05 17:36:32 -07:00
2ed9b474d8
CLOUDSTACK-6853: Search for non-removed nics only when check if the running vm belongs to a certain network
2014-06-05 17:09:32 -07:00
d21a15beb2
Fix CID-1212194 Resource like dues to left-open statements and
...
resultsets
2014-06-03 16:52:58 +02:00
fa3bbe9a19
Fixed ResouceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity
...
Fixed another leak which might occur due to outer while loop.
Signed-off-by: Daan Hoogland <daan@onecht.net>
(cherry picked from commit 004e0cbf61
2014-06-03 15:39:28 +02:00
793462e5fa
Fixed Resource leak (RESOURCE_LEAK) 11. overwrite_var: Overwriting "pstmt" in "pstmt = conn.prepareStatement("INSERT INTO `cloud`.`ldap_configuration`(hostname, port) VALUES(?,?)")" leaks the resource that "pstmt" refers to.
...
Signed-off-by: Koushik Das <koushik@apache.org>
2014-06-03 17:19:58 +05:30
2424d9a9e0
Fixed ResouceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-06-03 09:09:55 +02:00
44012ddadf
update vlan uris
...
Conflicts:
engine/schema/src/com/cloud/upgrade/dao/Upgrade430to440.java
2014-06-02 15:57:18 +02:00
81d3a9e3ee
CLOUDSTACK-6599: Add the column in Java upgrade path since 4.2 already has the extract template/volume columns
...
(cherry picked from commit be765ce868
2014-05-30 14:56:05 -07:00
5393387bbd
CLOUDSTACK-6599:
...
1. Adding the missing Template/Volume URLs expiration functionality
2. Improvement - While deleting the volume during expiration use rm -rf as vmware now contains directoy
3. Improvement - Use standard Answer so that the error gets logged in case deletion of expiration link didnt work fine.
4. Improvement - In case of domain change, expire the old urls
2014-05-30 10:48:42 -07:00
7c2b1deb34
CLOUDSTACK-6810: Fix storage migration of a vm with volume on local was failing. When a plan
...
with hostid included was passed to the local storage pool allocator, it returned all the local
storage pools in the cluster, instead of just the local pool on the given host in the plan.
This was happening the search at a host level was happening only for data disk. Fixed this.
Additionally, the query to list the storage pools on a host was failing if the pool did have
tags. Fixed the query too.
CLOUDSTACK-6802: Fix for not being able to attach data disk on local. This issue gets fixed
with the above issue too. The query to list pools on a host was failing if there were no
tags on the storage pool.
2014-05-30 14:46:39 +05:30
e9af5f44ae
CLOUDSTACK-6223. removeNicFromVirtualMachine fails if another instance in another domain has a nic with the same ip and a forwarding rule configured on it
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-05-29 10:18:41 +02:00
b0c797c628
FIXED CLOUDSTACK-6781 [Automation] integration.smoke.test_portable_publicip.TestPortablePublicIPRange.test_createPortablePublicIPRange failing on 4.4
...
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2014-05-28 10:46:55 +05:30
7ce3034299
CLOUDSTACK-6790: Disable PXE ROM for system vm nics
2014-05-27 16:52:26 -06:00
ce6a53e37b
Fixed CLOUDSTACK-6756: usage id is not being returned for an ip in deleted ip range
...
(cherry picked from commit a6ed48fc9c5f68b46f0d2e05adefc7263c4cd0d0)
Conflicts:
setup/db/db/schema-430to440.sql
2014-05-27 10:41:40 +05:30
ba848087f8
Disable IAM feature from 4.4 release.
2014-05-22 18:27:08 -07:00
d5754d9101
CLOUDSTACK-6740: Direct agent command throttling improvements
...
List of changes:
1. Created a separate thread pool for handling cron and ping tasks. The size of the pool is based on direct.agent.pool.size. The existing direct agent pool will run all commands other than cron and ping.
2. For normal tasks (generated as part of user/admin API calls), if throttle limit is reached then tasks get queued up for subsequent execution once threads are available.
3. For cron and ping tasks (internally generated by MS like ping, VM sync etc.), if throttle limit is reached then these gets rejected. Since these are internally generated these can be rejected without any issues.
2014-05-22 14:15:42 +05:30
667c8e7905
CLOUDSTACK-6699: listResouceDetails - enhance it to list by (key,value) pair - allowed to Admin only.
2014-05-18 23:21:37 -07:00
fe279ff3d0
CLOUDSTACK-6686:NetworkACLItemCidrsDaoImpl uses firewallRuleId instead
...
of networkAclItemId
fix uses networkAclItemId instead of firewallRuleId
2014-05-15 16:44:46 +05:30
35cd61c463
CLOUDSTACK-6649: CS is not giving the system-wide capacity for GPU reosurce.
2014-05-14 15:05:28 +05:30
9b6d430171
This patch disallows deleting / modifying system defined guest OS mappings
...
Local env
1. Create user defined mapping
2. Delete / modify user defined mapping. Should pass
3. Delete / modify system defined mapping. Should fail
Signed off by :- Nitin Mehta<nitin.mehta@citrix.com>
2014-05-12 22:45:24 -07:00
ebc2b8b94d
be able to remove vpc as owning entity of a network
2014-05-09 17:16:02 +02:00
5ba5da3696
CLOUDSTACK-6622: After a volume was live migrated, the destination smb storage path was added to
...
the folder column. For an smb share the smb credentials are in the query string of the path.
Before adding the path, smb shares query string should be cleaned up.
2014-05-09 16:31:34 +05:30
c0f72b25c6
CLOUDSTACK-6530: Make Network and Volume implement Displayable interface. Iterate over all first class entities in the context to decide the display property for event display.
2014-05-08 15:37:20 -07:00
245b7f4c39
CLOUDSTACK-6510: Fix gson serialization exception in storage migration. Gson couldn't serialize
...
a map with volume and storagepool objects for logging. Fixed by using volume and storage pool
ids instead of objects in the map.
2014-05-08 12:23:46 +05:30
b8adb96ae1
CLOUDSTACK-6575: Deploy VM failed with NPE while using custom compute offering
2014-05-08 12:16:28 +05:30
66d5ebc657
CLOUDSTACK-6596: UUID and display flag update support for LBStickinessPolicy and LBHealthCheckPolicy
2014-05-07 15:46:18 -07:00
5388d349a4
CLOUDSTACK-6597: Updatevm - root admin should be allowed to change instance name
2014-05-07 14:34:01 -07:00
d57975c7ed
CLOUDSTACK-6582 updated the table network_acl_item_cidrs name in Upgrade430to440
2014-05-07 10:49:02 +05:30
4b89a45e57
CLOUDSTACK-3272 Latest changes to add global configuration parameters to control the publishing of events on the message bus
2014-05-07 10:09:03 +05:30
ee5f5591c7
CLOUDSTACK-6585: added missing metadata support for LBStickiness/LBHealthcheck policies
2014-05-06 17:13:50 -07:00
aae1424f35
CLOUDSTACK-6582: fixed network acl cidr issues
...
Conflicts:
setup/db/db/schema-430to440.sql
2014-05-06 22:54:43 +02:00
067e6b4933
CLOUDSTACK-6582: cidr field removed
2014-05-06 22:49:37 +02:00
c9a09f548c
CLOUDSTACK-6579: used_bytes column of storage_pool table is no longer used and should be removed
...
For now correctly setting used_bytes. Also fixed the corresponding simulator code
2014-05-06 20:27:41 +05:30
Santhosh Edukulla
Sheng Yang
Alena Prokharchyk
Rohit Yadav
Anthony Xu
Murali Reddy
Koushik Das
Hugo Trippaers
Bharat Kumar
Saksham Srivastava
amoghvk
Mike Tutkowski
Edison Su
Sanjay Tripathi
Likitha Shetty
ynojima
Nitin Mehta
Kelven Yang
punith-cloudbyte
Daan Hoogland
Funs
Anshul Gangwar
Daan Hoogland
Rajani Karuturi
Olivier Lemasle
Tim Mackey
Prachi Damle
Devdeep Singh
Upendra Moturi
Marcus Sorensen
Min Chen
Jayapal
root