f89100ed72
CLOUDSTACK-6793 : Added fix
...
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2014-06-16 17:11:14 +05:30
0c28f36ff1
Fix a number of resource leaks reported by Coverity
2014-06-13 14:42:35 +02:00
aa21cdcd49
CLOUDSTACK-6897: when we try to attach the uploaded/allocated volume to a VM on zwps, then we were passing the podId of VM instead of storage pool to storage allocator. This resulting in use of Clusterscope storage allocator, allocating a storage pool for VM on zwps beacuse of pod id not null. This was resulting in scope conflict later
2014-06-13 14:47:00 +05:30
66d1eb92f0
CLOUDSTACK-6865 , CLOUDSTACK-6868: [hyperv] while attaching the volume we were changing the volume's Image format to hypervisor's default Image format, hence it was failing to find the volume with vhdx format. Now changed the behavior to set Image Format for volume only when it is not set
2014-06-13 13:26:02 +05:30
b666a1f3a5
Fixed issues reported by coverity NPEs, unwritten field access and self assignment
...
Signed-off-by: Koushik Das <koushik@apache.org>
2014-06-10 14:34:47 +05:30
a5902f1db4
CLOUDSTACK-6850: Return cpu cores, cpu speed and memory in listUsageRecords
...
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
2014-06-10 03:11:35 -04:00
a8212d9ef4
Cleanup of Xen and XenServer terms. Cloned xen plugin creating a xenserver plugin, then removed xen plugin
...
Signed-off-by: Tim Mackey <tmackey@gmail.com>
Signed-off-by: Sebastien Goasguen <runseb@gmail.com>
2014-06-07 04:50:23 -04:00
3b3f4577b0
CLOUDSTACK-6476: Basic Zone with Multiple Pods Setup: DHCP server doesnt get deployed in the pod where the VM gets deployed
...
Changes:
PodId in which the router should get started was not being saved to the DB due to the VO's setter method not following the setXXX format. So when planner loaded the router from DB, it always got podId as null and that would allow planner to deploy the router in any pod. If the router happens to start in a different pod than the user VM, the Vm fails to start since the Dhcp service check fails.
Fixed the VO's setPodId method, that was causing the DB save operation fail.
2014-06-06 16:15:31 -07:00
39f775c381
try-with-resource to prevent resource leaks
2014-06-06 17:38:18 +02:00
57e66ddaa6
CLOUDSTACK-6676: cleanup ip address details on ip disassoc
2014-06-05 17:36:32 -07:00
2ed9b474d8
CLOUDSTACK-6853: Search for non-removed nics only when check if the running vm belongs to a certain network
2014-06-05 17:09:32 -07:00
d21a15beb2
Fix CID-1212194 Resource like dues to left-open statements and
...
resultsets
2014-06-03 16:52:58 +02:00
fa3bbe9a19
Fixed ResouceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity
...
Fixed another leak which might occur due to outer while loop.
Signed-off-by: Daan Hoogland <daan@onecht.net>
(cherry picked from commit 004e0cbf61
2014-06-03 15:39:28 +02:00
793462e5fa
Fixed Resource leak (RESOURCE_LEAK) 11. overwrite_var: Overwriting "pstmt" in "pstmt = conn.prepareStatement("INSERT INTO `cloud`.`ldap_configuration`(hostname, port) VALUES(?,?)")" leaks the resource that "pstmt" refers to.
...
Signed-off-by: Koushik Das <koushik@apache.org>
2014-06-03 17:19:58 +05:30
2424d9a9e0
Fixed ResouceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity
...
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
2014-06-03 09:09:55 +02:00
44012ddadf
update vlan uris
...
Conflicts:
engine/schema/src/com/cloud/upgrade/dao/Upgrade430to440.java
2014-06-02 15:57:18 +02:00
81d3a9e3ee
CLOUDSTACK-6599: Add the column in Java upgrade path since 4.2 already has the extract template/volume columns
...
(cherry picked from commit be765ce868
2014-05-30 14:56:05 -07:00
5393387bbd
CLOUDSTACK-6599:
...
1. Adding the missing Template/Volume URLs expiration functionality
2. Improvement - While deleting the volume during expiration use rm -rf as vmware now contains directoy
3. Improvement - Use standard Answer so that the error gets logged in case deletion of expiration link didnt work fine.
4. Improvement - In case of domain change, expire the old urls
2014-05-30 10:48:42 -07:00
7c2b1deb34
CLOUDSTACK-6810: Fix storage migration of a vm with volume on local was failing. When a plan
...
with hostid included was passed to the local storage pool allocator, it returned all the local
storage pools in the cluster, instead of just the local pool on the given host in the plan.
This was happening the search at a host level was happening only for data disk. Fixed this.
Additionally, the query to list the storage pools on a host was failing if the pool did have
tags. Fixed the query too.
CLOUDSTACK-6802: Fix for not being able to attach data disk on local. This issue gets fixed
with the above issue too. The query to list pools on a host was failing if there were no
tags on the storage pool.
2014-05-30 14:46:39 +05:30
e9af5f44ae
CLOUDSTACK-6223. removeNicFromVirtualMachine fails if another instance in another domain has a nic with the same ip and a forwarding rule configured on it
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-05-29 10:18:41 +02:00
b0c797c628
FIXED CLOUDSTACK-6781 [Automation] integration.smoke.test_portable_publicip.TestPortablePublicIPRange.test_createPortablePublicIPRange failing on 4.4
...
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
2014-05-28 10:46:55 +05:30
7ce3034299
CLOUDSTACK-6790: Disable PXE ROM for system vm nics
2014-05-27 16:52:26 -06:00
ce6a53e37b
Fixed CLOUDSTACK-6756: usage id is not being returned for an ip in deleted ip range
...
(cherry picked from commit a6ed48fc9c5f68b46f0d2e05adefc7263c4cd0d0)
Conflicts:
setup/db/db/schema-430to440.sql
2014-05-27 10:41:40 +05:30
ba848087f8
Disable IAM feature from 4.4 release.
2014-05-22 18:27:08 -07:00
d5754d9101
CLOUDSTACK-6740: Direct agent command throttling improvements
...
List of changes:
1. Created a separate thread pool for handling cron and ping tasks. The size of the pool is based on direct.agent.pool.size. The existing direct agent pool will run all commands other than cron and ping.
2. For normal tasks (generated as part of user/admin API calls), if throttle limit is reached then tasks get queued up for subsequent execution once threads are available.
3. For cron and ping tasks (internally generated by MS like ping, VM sync etc.), if throttle limit is reached then these gets rejected. Since these are internally generated these can be rejected without any issues.
2014-05-22 14:15:42 +05:30
667c8e7905
CLOUDSTACK-6699: listResouceDetails - enhance it to list by (key,value) pair - allowed to Admin only.
2014-05-18 23:21:37 -07:00
fe279ff3d0
CLOUDSTACK-6686:NetworkACLItemCidrsDaoImpl uses firewallRuleId instead
...
of networkAclItemId
fix uses networkAclItemId instead of firewallRuleId
2014-05-15 16:44:46 +05:30
35cd61c463
CLOUDSTACK-6649: CS is not giving the system-wide capacity for GPU reosurce.
2014-05-14 15:05:28 +05:30
9b6d430171
This patch disallows deleting / modifying system defined guest OS mappings
...
Local env
1. Create user defined mapping
2. Delete / modify user defined mapping. Should pass
3. Delete / modify system defined mapping. Should fail
Signed off by :- Nitin Mehta<nitin.mehta@citrix.com>
2014-05-12 22:45:24 -07:00
ebc2b8b94d
be able to remove vpc as owning entity of a network
2014-05-09 17:16:02 +02:00
5ba5da3696
CLOUDSTACK-6622: After a volume was live migrated, the destination smb storage path was added to
...
the folder column. For an smb share the smb credentials are in the query string of the path.
Before adding the path, smb shares query string should be cleaned up.
2014-05-09 16:31:34 +05:30
c0f72b25c6
CLOUDSTACK-6530: Make Network and Volume implement Displayable interface. Iterate over all first class entities in the context to decide the display property for event display.
2014-05-08 15:37:20 -07:00
245b7f4c39
CLOUDSTACK-6510: Fix gson serialization exception in storage migration. Gson couldn't serialize
...
a map with volume and storagepool objects for logging. Fixed by using volume and storage pool
ids instead of objects in the map.
2014-05-08 12:23:46 +05:30
b8adb96ae1
CLOUDSTACK-6575: Deploy VM failed with NPE while using custom compute offering
2014-05-08 12:16:28 +05:30
66d5ebc657
CLOUDSTACK-6596: UUID and display flag update support for LBStickinessPolicy and LBHealthCheckPolicy
2014-05-07 15:46:18 -07:00
5388d349a4
CLOUDSTACK-6597: Updatevm - root admin should be allowed to change instance name
2014-05-07 14:34:01 -07:00
d57975c7ed
CLOUDSTACK-6582 updated the table network_acl_item_cidrs name in Upgrade430to440
2014-05-07 10:49:02 +05:30
4b89a45e57
CLOUDSTACK-3272 Latest changes to add global configuration parameters to control the publishing of events on the message bus
2014-05-07 10:09:03 +05:30
ee5f5591c7
CLOUDSTACK-6585: added missing metadata support for LBStickiness/LBHealthcheck policies
2014-05-06 17:13:50 -07:00
aae1424f35
CLOUDSTACK-6582: fixed network acl cidr issues
...
Conflicts:
setup/db/db/schema-430to440.sql
2014-05-06 22:54:43 +02:00
067e6b4933
CLOUDSTACK-6582: cidr field removed
2014-05-06 22:49:37 +02:00
c9a09f548c
CLOUDSTACK-6579: used_bytes column of storage_pool table is no longer used and should be removed
...
For now correctly setting used_bytes. Also fixed the corresponding simulator code
2014-05-06 20:27:41 +05:30
db154a0d79
CLOUDSTACK-5976: Typo in "ssh_keypairs" table's foreign key constraints
...
on the Upgraded Setup
2014-05-05 20:32:44 +02:00
99b4cf788e
Cloudstack-5077: reserve cpu and memory only when vmware.reserve.cpu/mem are set to true. Insted of setting the ovecommit values to one on upgrade, we popultate them from the global values.
...
Conflicts:
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java
engine/schema/src/com/cloud/upgrade/dao/Upgrade420to421.java
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
2014-05-05 11:39:10 +05:30
b3491bcbac
removed unused command ClusterSyncCommand
2014-05-01 11:45:19 -07:00
53ee9ae28e
CLOUDSTACK-6549: ommission due to insufficient tests in CLOUDSTACK-6231
2014-05-01 09:41:06 +02:00
6b0c34faee
CLOUDSTACK-6231: network acl item cidrs loaded from a seperate table
...
Conflicts:
setup/db/db/schema-430to440.sql
2014-04-30 15:39:00 +02:00
78c683f568
CLOUDSTACK-6437:
...
Add ability to distinguish between user defined and system defined guest OS and mappings
Add default mappings for XenServer
Local testing with
1. Add new guest OS by API
2. Add new guest OS mapping by API
2014-04-25 13:10:10 -07:00
8e286996c8
CLOUDSTACK-6478: Failed to download Template when having 3 SSVM's in one
...
zone on Vmware.
2014-04-22 20:11:09 -07:00
9c4d20cb68
Revert "Return isolation methods as a part of listPhysicalNetworks call"
...
This reverts commit 316f23ed5f
2014-04-22 18:06:46 -07:00
316f23ed5f
Return isolation methods as a part of listPhysicalNetworks call
2014-04-22 14:57:04 -07:00
ab39739bd8
CLOUDSTACK-6211: Xenserver - HA - SSVM fails to start due to running out of management Ip ranges when testing host down scenarios
...
Signed-off-by: Koushik Das <koushik@apache.org>
2014-04-18 17:52:49 +05:30
6397f1c82e
CLOUDSTACK-6329 [Automation] Changing service offering of VM from medium to small failing with NPE
...
- The hostAllocators were not getting set
2014-04-17 17:55:17 -07:00
7819775bb8
CLOUDSTACK-6330 [Automation] createRemoteAccessVpn call fails with access permission error
...
- Correcting the EntityType for PublicIpAddress entity
- Adding the EntityType in the @APICommand for *IPAddrCmds
2014-04-17 17:54:57 -07:00
eb195d0575
CLOUDSTACK-6151: Local data disk with tag goes to the wrong local storage pool
...
Signed-off-by: Koushik Das <koushik@apache.org>
2014-04-16 16:19:08 +05:30
c031eb7d38
CLOUDSTACK-6242: exception handling improvements
...
Signed-off-by: Daan Hoogland <daan@onecht.net>
2014-04-15 08:07:15 +02:00
5e90b75c98
CLOUDSTACK-6402: Fix StopCommand so that VMs are not removed accidentally as part of vmsync
...
Added a new flag 'checkBeforeCleanup' to StopCommand based on which check is done to see if VM is running in HV host.
If VM is running then in this case it is not stopped and the operation bails out.
Also modified the MS code to call the StopCommand with appropriate value for the flag based on the context.
Currently it is only set to 'true' when called from the new vmsync logic based on powerstate of VM. For rest it
is set to 'false' meaning no change in behaviour.
2014-04-14 16:52:37 +05:30
11f5bdd78d
CLOUDSTACK-6191 Add support for specifying volume provisioning
...
type (thin, sparse, fat) in disk/compute offerings.
Submitted-by: Yoshikazu Nojima <mail@ynojima.net>
Reviewed-by: Marcus Sorensen, Mike Tutowski
2014-04-10 09:23:04 -06:00
a195205d11
CLOUDSTACK-6366: add vgpuTypes details in vgpu_types table.
2014-04-09 18:23:50 +05:30
ecc71518a9
CLOUDSTACK-6253: Optimizing VR alerts getting algorithm In addition to this a new configuration parameter is added router.alerts.check.interval defaulted to 30minutes to check for alerts in Virtual Router
2014-04-09 18:12:20 +05:30
54e9a98e8b
CLOUDSTACK-6362: Parallel VM deployment - direct.agent.thread.cap needs to default to 1.0 (currently 0.1) to allow for parallel Vm deployments.
2014-04-09 12:28:01 +05:30
2ae9da8d47
CLOUDSTACK-6357: Not able to select GPU card in case of GPU-passthrough.
2014-04-08 22:10:09 +05:30
2530bf9658
CLOUDSTACK-6345: Non gpu enabled VMs are getting deployed in gpu enabled Hosts.
2014-04-07 15:43:46 +05:30
b94a982618
CLOUDSTACK-6327: Updated the removeFromLoadBalancerRule and listLoadBalancerRuleInstances API
...
Updated these APIs to use VM primary/secondary details on LB rule.
listLoadBalancerRuleInstances API lists the vm ips which are assigned to lb rule when passed
listlbvmips
removeFromLoadBalancerRule is updated to remove the spcific vm ip entry assinged to LB rule.
Added new param vmidipmap to this API
2014-04-04 18:42:03 +05:30
3a889aa217
CLOUDSTACK-3886: Volume attach/detach implementation for ROOT disk
...
Implemented for Xen hypervisor only by now
Unittests are included
2014-04-03 11:39:56 -07:00
cd8801f6f7
Do app-level iteration to avoid mysql deadlocks
2014-04-02 15:46:50 -07:00
24820d20d3
CLOUDSTACK-6288: Changing default ImageFormat to vhdx for hyper-v and allowing registration of vhdx format templates.
...
Signed-off-by: Devdeep Singh <devdeep@gmail.com>
2014-04-01 14:00:24 +05:30
1577e75a3d
CLOUDSTACK-6170 (VMware root-disk support for managed storage)
2014-03-31 00:13:30 -06:00
25a6234a5b
fix build
2014-03-28 16:24:45 -07:00
7590988dd7
CLOUDSTACK-5329: stupid java box/unbox
...
Conflicts:
engine/schema/src/com/cloud/vm/VMInstanceVO.java
2014-03-28 16:24:22 -07:00
504a6cdee2
CLOUDSTACK-5432:sync vm and storage commands on mgt server for kvm
...
Conflicts:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
server/src/com/cloud/hypervisor/KVMGuru.java
2014-03-28 16:24:07 -07:00
e656201fee
CLOUDSTACK-5395: mark snapshot_store_ref as destroyed in case of backup snapshot failed
...
Conflicts:
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServerStorageProcessor.java
2014-03-28 16:21:22 -07:00
8b62b2cb92
findbugs: exclude known spiffy hacks a.k.a. false positives
2014-03-28 14:28:10 +01:00
6d103e62fe
use correct interval for cleanTask and transitionTask
2014-03-26 14:22:27 -07:00
4ebb92c492
Fixed some warnings about using a deprecated constructor
2014-03-25 16:48:27 -07:00
f445274ed3
Added a config to enable checking whether a db transaction is wrapped around communications with the agent. If it is, an exception is thrown. This assert has actually been there because it is part of CloudStack's design principle to not use db transactions as a way to enforce atomicity in executing things on hardware resources. However, the assert has been ignored since the move to maven which is not good with enabling asserts. Since then, there's been a lot of commands added that actually runs within db transaction. This is a big no no as the problem is that the remote operation may take a long time and the db can actually close the connection, causing a rollback of the transaction. We should not depend on transactions to enforce the atomicity anyways.
2014-03-25 16:35:49 -07:00
e3fc5a4d46
vm meta sync sync xstoolsversion as well
2014-03-24 15:48:21 -07:00
2c4ac5e4d3
removed some redundant Boolean isntantiations
...
Signed-off-by: Laszlo Hornyak <laszlo.hornyak@gmail.com>
2014-03-22 18:34:45 +01:00
b354893393
CLOUDSTACK-6170 (Fixed an issue where custom compute offering and custom storage IOPS were leading to custom storage IOPS that were specified not being used)
2014-03-22 11:09:34 -06:00
7629d6f129
CLOUDSTACK-6170
2014-03-20 23:54:53 -06:00
a1831bc864
Revert "CLOUDSTACK-6170" due to unit test failure.
...
This reverts commit 50b5e2e247
2014-03-20 16:40:45 -07:00
50b5e2e247
CLOUDSTACK-6170
2014-03-20 16:52:52 -06:00
27008216fe
Revert "Issue CS-5825 Part Resolution"
...
This reverts commit 9a615ee7b2
2014-03-20 15:47:13 -04:00
9a615ee7b2
Issue CS-5825 Part Resolution
2014-03-20 13:30:42 -04:00
2b51207510
persist fact that network can span multiple zones, if network offering
...
has strechedL2Subnet capability and return the zones in which
network spans in the networkreponse object
2014-03-20 17:01:33 +05:30
d2d54a9463
region level VPC support
...
introduce 'RegionLevelVpc' as capability of 'Connectivity' service. Add
support for CreateVPCOffering to take the 'regionlevelvpc' as capability
of service 'connectivity'.
introduces new capability 'StretchedL2Subnet' for 'Connectivity'
service. Also add support to createNetworkOffering api to allow
StretchedL2Subnet capablity for the connectivity service.
adds check to ensure 'Connectivity' service provider supports
'StretchedL2Subnet' and 'RegionLevelVpc' capabilities when specified in
createNetworkOffering and createVpcOffering respectivley
enable ovs plug-in to support both StretchedL2Subnet and RegionLevelVpc
capabilities
make zone id optional parameter in createVpc, zone id can be null only
if vpc offfering supports region level VPC
in region level vpc, let the network/tier to be created in any zone of
the region
keep zoneid as required param for createVpc
skip external guest network guru if 'Connectivy' service is present in
network offering
fix build break in contrail manager
permit VM's to be created in different zone that in which network is
created if the network support streched L2 subnet
add integration tests for region level VPC
rebase to master
Conflicts:
setup/db/db/schema-430to440.sql
Conflicts:
api/src/org/apache/cloudstack/api/ApiConstants.java
engine/schema/src/com/cloud/network/vpc/VpcVO.java
setup/db/db/schema-430to440.sql
2014-03-20 16:32:22 +05:30
ce1e53f451
Fix style-check issue after cherry-picks
2014-03-18 17:00:08 -07:00
d9506d2a05
Let VMSync be aware of HA take-over on VM state management.
2014-03-18 16:45:45 -07:00
de252adadf
avoid mysql lock-promotion situation.
2014-03-18 16:45:02 -07:00
5d19a936a2
CLOUDSTACK-6247: Usage Events - hide them when display flag is off in the context of "Ability to have better control over first class objects in CS" feature
...
Work done for network offering.
2014-03-18 14:00:55 -07:00
7442b56fa8
CLOUDSTACK-6247: Usage Events - hide them when display flag is off in the context of "Ability to have better control over first class objects in CS" feature
...
And when the flag is updated on the resource accordingly generate usage events again.
Also when display flag is false in deployvm cmd it should be false for the volumes associated with the vm as well
2014-03-18 14:00:25 -07:00
8b510d2481
checkstyle: unused import
2014-03-18 13:18:57 +01:00
e7e4753979
checkstyle: trailing spaces
2014-03-18 12:35:10 +01:00
ed9ed446c2
CLOUDSTACK-5432: potential bugs in case of stop mgt server while
...
template is downloading, template_store_ref has leftover not in ready
state, when create vm from that template, the code doesn't check either
zone id, nor template_store_ref state.
Conflicts:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
2014-03-18 12:20:14 +01:00
d638d04cbf
CLOUDSTACK-6181: Merge of resize root feature (resize-root branch)
2014-03-14 07:17:33 -06:00
ae1d6a771b
Remove IAMEntityType to use existing VO interface class to annotate
...
entityType.
2014-03-17 17:19:55 -07:00
479986e52b
Fixed compilation error in StorageAllocatorTest.java
2014-03-17 09:58:44 -07:00
d55c4dd804
CLOUDSTACK-6170
2014-03-14 23:47:20 -06:00
5e4a4e8b34
Fix a regression that caused API job to return prematurely.
2014-03-14 17:31:16 -07:00
ec01791936
Fix the missing java imports from automatic merge
2014-03-14 14:22:23 -07:00
Santhosh Edukulla
Hugo Trippaers
Anshul Gangwar
Rajani Karuturi
Olivier Lemasle
Tim Mackey
Prachi Damle
Daan Hoogland
Alena Prokharchyk
Nitin Mehta
Devdeep Singh
Upendra Moturi
Marcus Sorensen
Min Chen
Koushik Das
Murali Reddy
Sanjay Tripathi
Amogh Vasekar
Saksham Srivastava
Jayapal
root
Harikrishna Patnala
Bharat Kumar
Anthony Xu
Ding Yuan
Kelven Yang
Mike Tutkowski
Edison Su
Alex Huang
Laszlo Hornyak
Chris Suich
Alex Hitchins