Commit Graph

1250 Commits

Author SHA1 Message Date
alena 619d378095 Set specifyVlan=true for default Direct network offering 2010-12-06 09:23:15 -08:00
alena 0dbd21fe23 createNetwork command accepts netmask/gateway instead of cidr. Also return start/endIp in the createNetwork response. 2010-12-06 09:18:02 -08:00
nit a38c18220c bug 7410 : listTemplate - Correcting the pagesize use. Putting all the filters in the DB query rather than after execution so that pagesize restriction happens at the end. 2010-12-06 19:47:33 +05:30
nit 39eb645b04 Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss 2010-12-06 14:07:24 +05:30
nit c81f010a21 bug 7422 : Register Template/ISO response would include domain name as well.
status 7422: resolved fixed
2010-12-06 13:30:23 +05:30
Frank Zhang 8fe7d4094d remove wscript_build from client/ and server/ 2010-12-04 23:03:24 -08:00
edison 5c73e46113 bug 7296: add kvm.public.network.device and kvm.private.network.device from UI
status 7296: resolved fixed
2010-12-04 20:01:10 -08:00
Alex Huang 98eb58bf84 callCreate to create 2010-12-04 17:58:16 -08:00
Alex Huang cf032b7a3a more changes 2010-12-04 17:33:02 -08:00
Alex Huang 16cccf4f59 ip address modifications. removed old deploy 2010-12-04 17:32:32 -08:00
Alex Huang 16caf1954b New ip address states and mode 2010-12-04 17:32:32 -08:00
Alex Huang daa9add158 removed router stuff from network manager 2010-12-04 17:32:31 -08:00
edison 3bd089acb5 don't break old code 2010-12-04 16:49:05 -08:00
edison 525cb3dd5d don't break old code 2010-12-04 16:39:10 -08:00
edison e591f56b25 add logs, and don't break old code 2010-12-04 15:02:03 -08:00
edison b7cdae2688 fix for migration 2010-12-04 15:02:03 -08:00
edison d17beeb348 move all the vm's state machine to itmgr->statetransitTO 2010-12-04 15:02:02 -08:00
edison 2e3ef1408c refactor 2010-12-04 14:59:40 -08:00
edison e99cc740e6 add more checks in alloctor 2010-12-04 14:59:39 -08:00
edison f3c7012508 remove capacity 2010-12-04 14:59:39 -08:00
edison 41fdbfc65e new allocator 2010-12-04 14:59:39 -08:00
alena 150d684e05 1) isShared attribute belongs to Network now, not NetworkOffering
2) Added list by networkId support to listVirtualMachines command.
3) Implemented search by zoneId in listNetworks command
2010-12-03 19:07:08 -08:00
Kelven Yang cc7dc5e6be Persist disk chain info when we detach a volume, check disk chain info when we attach a volume, this is required when snapshot operations are involved in vwmare 2010-12-03 18:59:23 -08:00
will 01d937ca5e Removed old service offerings and enabled the new network framework. 2010-12-03 17:40:06 -08:00
abhishek bd89804a18 bug 7406: returning child domains for domain admin user
status 7406: resolved fixed
2010-12-03 16:28:16 -08:00
abhishek f6f5ba5529 bug 5881: fixing the domain name edit, with the updating of path of all the child domains
status 5881: resolved fixed
2010-12-03 15:35:36 -08:00
alena cb605e626a listNetworks api - return only networks belonging to the caller plus Shared networks when command is called without any parameters 2010-12-03 14:15:30 -08:00
alena 2759e422f5 Return type/trafficType in the listNetworks response 2010-12-03 13:48:43 -08:00
alena 9f11f52611 listNetworks - don't return Networks created from systemOnly network offerings 2010-12-03 12:31:30 -08:00
Alex Huang 96ac136b8c changed getAccountId to getEntityOwnerId 2010-12-03 11:59:45 -08:00
anthony 4f2790c09b move db migration to script 2010-12-03 11:24:25 -08:00
root 8a4d170892 correct misspelling 2010-12-03 10:06:48 -08:00
abhishek 4fc18ce760 bug 7414: defaulting startretry to 10 at all references in code 2010-12-03 09:54:21 -08:00
abhishek 286fa7248b bug 7414: changing the start.retry param to 10
status 7414: resolved fixed
2010-12-03 09:49:01 -08:00
Alex Huang 5db9ba61d9 extra comma 2010-12-03 09:47:12 -08:00
abhishek b0abda3c49 some changes to domain specific offerings for the UI to consume 2010-12-03 09:37:02 -08:00
Alex Huang a8b617c596 port forwarding is now in 2010-12-03 08:48:03 -08:00
Alex Huang 3aa19666cf merge with master 2010-12-03 08:48:03 -08:00
Alex Huang b859e103d8 ip nat rule forwarding done 2010-12-03 08:48:03 -08:00
Alex Huang 9a70ee54f0 portforwarding is working 2010-12-03 08:48:03 -08:00
Alex Huang bb78986ddb port forwarding working 2010-12-03 08:48:02 -08:00
Alex Huang 223688d0bf Port forwarding rules and load balancing rules rewrite 2010-12-03 08:48:02 -08:00
nit 94cb30a745 bug 7412 : UpdateTemlate - Adding some fields keeping it consistent with listTemplates
status 7412: resolved fixed
2010-12-03 20:06:16 +05:30
nit b543faeeee bug 7366 : Removing the bootable field from "createTemplate","registerTemplate","listTemplate" and "updateTemplate" commands.
Making some db changes for a successful ant deploydb
status 7366: resolved fixed
2010-12-03 18:31:08 +05:30
nit d7b8e93f22 Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss 2010-12-03 14:32:22 +05:30
nit f5279e74a6 bug 7403 : Correct NPE for ListIso command.
status 7403: resolved fixed
2010-12-03 14:31:38 +05:30
alena f8a687ab23 1) Implemented create/list/deleteNetworkOffering create/delete/listNetwork APIs.
2) Added networkIds parameter to deployVMCmd - accepts list of networks ids separated by coma.
3) Changed domainRouter/systemVm/userVm response to return list of Nics associated with the vm.
2010-12-02 19:30:17 -08:00
anthony 6f1eb4bf44 bug 7144: return snapshotId with jobid
1. manual and recursive snapshot use the same command
2. upgrade from 2.2 beta1 to beta need to execute schema-22beta1to22beta2.sql and data-22beta1to22beta2.sql
3. upgrade from 2.1GA to 2.2GA need to execute schema-21to22.sql and data-21to22.sql

status 7144: resolved fixed
2010-12-02 19:23:34 -08:00
anthony d184c56ef3 cleanup snapshot code 2010-12-02 19:23:33 -08:00
abhishek dd9fd57514 changing the logging and error msgs from 1:1 NAT to static NAT (in accordance with the feature being called static and not 1:1 NAT) 2010-12-02 15:50:04 -08:00
abhishek e353b7ac2d we use 2 different tables for ip/port fwding and load balancer rules respectively. when we create a new static nat rule, this checkin tests against existing records in either of these tables based on the public ip address being mapped. if such a rule exists in either table, we do not permit creation of a static nat rule on this public ip 2010-12-02 15:50:04 -08:00
abhishek 66186ca876 bug 7348: fixing the issue of the static nat rules not being re-programmed on a domr stop/start or a domr reboot
status 7348: resolved fixed
2010-12-02 11:16:33 -08:00
abhishek dc5c82456c bug 7352: implemented security for the list ip fwding rules cmd, to filter results based on user
status 7352: resolved fixed
2010-12-02 09:49:47 -08:00
abhishek d0fc07496f search functionality for ip forwarding rules, with covering of cerner cases 2010-12-02 09:46:32 -08:00
abhishek d28d6894e1 adding security checks for list ip forwarding rules command 2010-12-02 09:46:32 -08:00
nit ad571eef36 Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss 2010-12-02 17:36:26 +05:30
nit 9a3a5b4fa7 bug 7314 : Extract Api - Async Framework takes care of updating the final status no need to update it inside the code.
status 7314: resolved fixed
2010-12-02 17:35:47 +05:30
kishan 794c83f011 bug 7216: show capacity alerts at pod level instead of zone
status 7216: resolved fixed
2010-12-02 15:20:05 +05:30
kishan 0b76c26ce9 bug 7216: show capacity alerts at pod level instead of zone
status 7216: resolved fixed
2010-12-02 14:11:38 +05:30
will cd5afb3d7e bug 6969: Fixed snapshots, templates, isos, routers, volumes, and system vms async commands to make use of the new job id/job status when listing objects with pending jobs. 2010-12-01 16:50:56 -08:00
anthony 17f3239f07 bug 7368: should get volumeVO even if it is removed
status 7368: resolved fixed
2010-12-01 16:11:47 -08:00
abhishek a477d6c33c adding support for updating service and disk offerings, also adding domain and domainid back in the responses to the CRUD methods for both service and disk offerings 2010-12-01 10:40:08 -08:00
abhishek b51a7fec50 adding a security checker whilst creating a volume from a disk offering 2010-12-01 09:53:13 -08:00
abhishek 4387e2ca0a another good point to commit; the basic domain specific disk offering functionality is now in place 2010-12-01 09:53:13 -08:00
abhishek 402baae9fa adding comments for the domain checker, so that the design decision is better understood down the road 2010-12-01 09:53:13 -08:00
abhishek 1dfdcf51cb another good point for checkin, added the domain checker for checks against service offerings, whilst deploying virtual machines 2010-12-01 09:53:13 -08:00
abhishek 9a6eaaf21f this is a good point to commit the code; have the basic domain specific service offering working 2010-12-01 09:53:13 -08:00
will c67d26cec4 bug 6969: First step of now displaying pending async jobs for listXXXCommands. There is a lot more cleanup and fixing to do but all commands acting against VirtualMachines now work. 2010-11-30 19:12:09 -08:00
Kelven Yang 677394c27a Remove retired configuration varable 2010-11-30 16:23:15 -08:00
Kelven Yang 83736a1af5 Add URI component encoding to URI util class to help utilize URL info in hypervisor host address 2010-11-30 16:23:15 -08:00
will de92288e3b Adding xenserver-5.6.0-1.jar to eclipse classpath and removing 5.5 2010-11-30 12:19:49 -08:00
alena 680812f675 bug 7223: page and pagesize parameters must be specified together "list" api commands
status 7223: resolved fixed
2010-11-30 11:31:34 -08:00
nit b5f9ae0ef3 Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss 2010-11-30 23:48:13 +05:30
nit 2f946f6030 bug 7366 : Mark template as removed if create private template from volume fails due to being attached to a non-stopped VM. This allows subsequent creation of a template with the same name.
status 7366: resolved fixed
2010-11-30 23:47:04 +05:30
abhishek 1aee756184 bug 7345: During the expunge operation, we were not calling the deleteipforwardingrule method, for a rule which was static nat. Adding that logic. Also, making a change in the domr script as we do not need to execute a line on deletion of a rule
status 7345: resolved fixed
2010-11-30 10:07:10 -08:00
Kelven Yang 54f177cacc 1) Make generic dao be able to persist UTF-8 string for internationalization support
2) Undo gson Unicode escape in API response object to avoid double escaping which can break Javascript from getting correct text content
3) Correct API layer in dealing with character encoding
4) Remove double escape in cloud.core.js
2010-11-30 09:40:54 -08:00
Kelven Yang fa9c882d8c Add VMWare hypervisor guru 2010-11-30 09:40:53 -08:00
nit 06c61f2fac bug 7325 : We shouldn't allow attaching xen-pv-iso to any hypervisor other than xenserver.
status 7325: resolved fixed
2010-11-30 22:20:33 +05:30
nit a6a774f6c0 bug 7369 : Resolving NPE while creating a private template from detached volume. The instance id is null when it is detached which was the culprit here.
status 7369: resolved fixed
2010-11-30 15:49:29 +05:30
anthony fb0675bbf4 bug 7365: return both physical and virutal size when creating private template
status 7365: resolved fixed
2010-11-29 18:58:48 -08:00
anthony d3325de5ae 1. limit xs-tools in xenserver related java file
2. don't populate xs-tools to template_host_ref
3. introduce a new template type PERHOST, which doesn't need to be populated to secondary storage
2010-11-29 18:21:08 -08:00
abhishek 0273872b34 bug 7362: we were missing the size validation check, when we create a volume from disk offering (the storage.max.volume.size param wasn't being used for validation). Fixed the same, made the validation method name more generic to be applicable to all validations, and changed the param description to denote GB as the unit
status 7362: resolved fixed
2010-11-29 17:23:16 -08:00
anthony bd64f4faa3 remove eclipse error 2010-11-29 16:39:48 -08:00
anthony fff1dd874a fix classpath for xenserver-5.6.0-1 2010-11-29 15:26:07 -08:00
abhishek bdf4426609 fixing the same issue in another command (found whilst checking references) 2010-11-29 13:38:06 -08:00
abhishek 1a0ec2a00f bug 7346: fixing the corner case where list ip forwarding rules is called for a rule, which is yet to be expunged, but the vm is destroyed. if you call list here, an npe results
status 7346: resolved fixed
2010-11-29 13:35:04 -08:00
abhishek dce3f9fa3b bug 7344: preventing enabling of static nat on an ip for more than one instance. Check the nat flag, and error out if set
status 7344: resolved fixed
2010-11-29 11:56:34 -08:00
anthony 385054fccf bug 7338: update template physical size
status 7338: resolved fixed
2010-11-29 11:23:47 -08:00
Alex Huang d40700b286 Changed firewall rule's constructor 2010-11-29 09:38:13 -08:00
anthony 30fa6530f9 bug 6088: track template physical size in template_host_ref table
add migration from 21 to 22
after migration , SSVM needs to stop/start

status 6088: resolved fixed
2010-11-24 20:05:52 -08:00
Kelven Yang 23f274cfd2 Send AttachVolume command even if VM is not in running state under vmware case 2010-11-24 15:17:09 -08:00
Kelven Yang dd9b1634f7 Allow host behind cluster to return real VNC host IP address 2010-11-24 15:17:08 -08:00
Kelven Yang fd1beef28b Someone commited a change in ConsoleProxyManagerImpl that breaks down system VM, let's blame git for now on this 2010-11-24 15:17:07 -08:00
alena aa8aa6027a Modified UserContext - got rid of accountName, domainId fields as we can get this information from Account field. 2010-11-24 14:29:08 -08:00
abhishek 1950bf7a99 changing the nat feature to work with kvm 2010-11-24 10:04:24 -08:00
alena 44737d24c5 bug 7196: fixed response object generation for authorizeNetworkGroupIngress command (response type is Network group response - the way it was in 2.1.x - instead of IngressRule response)
status 7196: resolved fixed

Also fixed revokeNetworkGroup command - didn't work via 8096 port
2010-11-24 09:50:04 -08:00
nit d0530265d7 bug 7046 : Global admins should be allowed to extract all the times.
status 7046: resolved fixed
2010-11-24 19:33:15 +05:30
nit 841044e360 Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss 2010-11-24 18:38:23 +05:30
nit 8ea124ae79 bug 7046 : extracting templates should allow for exclusion of some templates. An attribute "extractable" would be set on templates by the template owner at upload time. It would specify if we allow the template to be extracted from the system. Default would be true ie "allow extraction". If set to false, it would not be possible to extract the template or any derivatives of the template. For example, volumes, snapshots or templates from that template.
status 7046: resolved fixed
2010-11-24 18:37:54 +05:30
kishan f70071dc98 bug 6309: Added event VM.UPDATE along with changed fields
status 6309: resolved fixed
2010-11-24 18:36:35 +05:30
kishan 19dcbb8d8e bug 7246: changed event name to TEMPLATE.CLEANUP when cleaning up templates on sec storage. Usage won't track this event
status 7246: resolved fixed
2010-11-24 17:48:19 +05:30
anthony c39d211a48 merge from 2.1.x 2010-11-23 18:55:23 -08:00
abhishek 5543814f39 blocking the static natting of an ip address, if it is already source natted 2010-11-23 16:39:02 -08:00
abhishek 3d4b8ab4a0 bug 7263: changing the param name. Found a couple of bugs whilst testing this, the validation of vol size whilst cust vol creation was missing. Adding the same.
status 7263: resolved fixed
2010-11-23 16:20:30 -08:00
alena f4908758b3 bug 7234: don't try to delete pod level vlan when it doesn't exist
status 7234: resolved fixed
2010-11-23 15:06:29 -08:00
alena cb74030d01 bug 7298: throw an Exception when invalid job Id is specified in queryAsyncJobResult
status 7298: resolved fixed
2010-11-23 15:06:29 -08:00
abhishek 40c3a0afa2 bug 7249: during volume creation (root and data) for a vm, there was no state being set (we need to set it to ready). Hence, whilst re-attaching a detached vol, we hit a NPE. Fixed the root cause of the state not being set during vm creation, and consequently, fixed this npe
status 7249: resolved fixed
2010-11-23 14:24:29 -08:00
will 90467ab31d merge 7277: Fixed the file separate so Extract Template works on Windows machine. 2010-11-23 11:13:47 -08:00
alena 10fb2a0f39 bug 7292: fixed assignig LB to non-source Nat ip address
status 7292: resolved fixed
2010-11-22 20:54:08 -08:00
will 7205a7507d bug 7277: Fixed the logic to prevent System templates from being downloaded. 2010-11-22 17:13:30 -08:00
alena 3f1abbcbc8 Fixed assignToLoadBalancer command - admin couldn't assing LB rule in behalf of other user 2010-11-22 17:08:51 -08:00
abhishek 8995e5d2f7 changing the event logged to the right type, whilst starting user vms via cancelstoragemaintenance in master (already merged to 2.2.beta1) 2010-11-22 16:20:18 -08:00
alena 1491893bbc bug 7281: throw an exception when fail to get isoPath - happens when Secondary Storage vm is not in UP state in cloud.hosts table.
status 7281: resolved fixed
2010-11-22 15:42:34 -08:00
alena a646745516 bug 7227: applying Alex's fix - different way of desirializing List objects.
status 7227: resolved fixed
2010-11-22 14:08:43 -08:00
alena 6765e97976 Made ApiResponseHelper to use Long instead of long for response parameters to eliminate possible NPEs during building an api response. 2010-11-22 11:27:15 -08:00
alena cdea2d210d Better logging for api exceptions. 2010-11-22 11:27:15 -08:00
abhishek 0979b644ef bug 7230: there was an issue trying to start user vms when the pool state is cancelmaintenance; fixing the same in 2.2RC2
status 7230: resolved fixed
2010-11-22 11:00:43 -08:00
Alex Huang d38f7fd56d Moved DAO to server 2010-11-22 07:40:41 -08:00
Alex Huang 1e44925564 api refactoring 2010-11-21 12:00:21 -08:00
alena 138e0914b6 bug 7245: don't try to set vm name for detached volume during expunge process.
status 7245: resolved fixed

Fixed couple of other problems:
* cleanup corresponding records in load_balancer_vm_map table when loadBalancerRule is removed.
* don't log "java.lang.IllegalStateException: getAttribute: Session already invalidated" exception when UI session expires
2010-11-19 20:08:18 -08:00
alena 6b61caad46 AssignToLoadBalancer - added missing transaction.commit to corresponding NetworkManager method. 2010-11-19 19:14:24 -08:00
alena cec8ebd5cd bug 7236: don't catch AsyncCommandQueued exception in ApiDispatcher
status 7236: resolved fixed
2010-11-19 18:40:32 -08:00
alena 5426b1487c listPortForwardingRules: return empty response instead of throwing exception when ipAddress doesn't have any rules assigned. 2010-11-19 18:40:32 -08:00
abhishek ca162bca11 bug 6936: for some reason, we had a check on pod-wide or account specific vlan creation. This seems to be a left over from legacy code. Removing the same. I tested to make sure both zone wide vlan and account specific vlan creation for direct tagged case works fine
status 6936: resolved fixed
2010-11-19 17:54:57 -08:00
alena e1b74ea99e RegisterTemplateCommand - ignore case in "hypervisor" parameter value - used to complain when "xen" was specified instead of "Xen" 2010-11-19 16:27:05 -08:00
alena fe93821bb1 Fixed editZone command - if dns2 is not specified, keep the old value instead of updating it to NULL 2010-11-19 16:13:45 -08:00
Anthony Xu fa499dadbc bug 7220: the parameter type transfer may cause NPE
status 7220: resolved fixed
2010-11-19 15:56:04 -08:00
alena a5dfaaf31b API exception handling - print api command name to the log. 2010-11-19 15:48:58 -08:00
Alex Huang 5b4a6f27db Changed networkconfigurations to network as per Sheng's suggestion 2010-11-19 15:44:42 -08:00
alena a495f34d4f Fixed enableAccount command - domain permission check was done incorrectly 2010-11-19 15:25:29 -08:00
alena 8362d0feba Reverting back commit e5c137e303 as it wasn't meant to be in 2.2 RC1. 2010-11-19 14:23:39 -08:00
alena e5c137e303 bug 7223: pagesize and page should be specified together in "list" api commands
status 7223: resolved fixed
2010-11-19 14:03:44 -08:00
edison 0c35f2f743 bug 7237: disk size is passed in diskProfile, no need size parameter in createcommand
status 7237: rresolved fixed
2010-11-19 11:55:27 -08:00
Chiradeep Vittal 394554770e Enforce user limit on number of vpn users 2010-11-18 18:38:29 -08:00
alena a0eaf32cad Fixed updateAccount command to work via 8096 port. 2010-11-18 17:35:41 -08:00
alena 0b2b8e31d8 Fixed updateUser command - didn't work correctly via 8096 port (user account info was taken from UserContext instead of User object). 2010-11-18 17:07:20 -08:00
abhishek d222a52ccb bug 7232: resolving the sql exception
status 7232: resolved fixed
2010-11-18 16:47:08 -08:00
abhishek 317554d983 ensuring all the following have api values taken in, in GB (disk offering, service offering, custom vol creation and vm creation from cust disk offering) 2010-11-18 14:32:50 -08:00
Chiradeep Vittal c53e165eaa bug 6971: bring back l2tp port 1701 2010-11-18 14:06:01 -08:00
Chiradeep Vittal a7547846bf bug 6971: Dont confuse PF rules added for VPN to be LB rules 2010-11-18 14:05:28 -08:00
abhishek 6ae21932eb realized that the var name used in response code might be confusing to a new reader. changing the name to be more intuitive 2010-11-18 11:20:01 -08:00
abhishek 18ff23c839 added a list method to list ip forwarding rules, optionally list a rule based on its public ip address 2010-11-18 11:15:13 -08:00
abhishek 020afa6e33 adding a list command for ip forwarding rules for 1:1 nat, to be consumed by the ui 2010-11-18 11:15:13 -08:00
abhishek c4f1b35aef returning the public ip address in the creation of firewall rule, for the UI to consume 2010-11-18 09:42:47 -08:00
alena 829d7482b3 bug 6864: allow domain admin to see only vms belonging to his domain and child domains
status 6864: resolved fixed
2010-11-17 23:09:19 -08:00
alena 91a87f9d8f bug 7155: fixed NPE in AuditTrial which used to happen when logout command was executed when session was already invalidated.
status 7155: resolved fixed
2010-11-17 21:42:51 -08:00
alena 28dd8185dd Fixes for listDomains API command:
* return all domains in the system when command is executed via 8096
* for domain admin return only his domains and subdomains.
2010-11-17 21:28:12 -08:00
alena 6f44238109 Fixed listDomainChildren api - now we can search by name when isRecursive flag set. 2010-11-17 20:40:39 -08:00
alena a95b853a17 bug 6898: updateResourceLimit command requires domainId or account/domainId now if executed via 8096 port
status 6898: resolved fixed
2010-11-17 19:43:06 -08:00
alena 97a8349110 bug 6894: removed "account" request parameter in listAccounts command. Should use "name" if need to make search by account name
status 6894: resolved fixed
2010-11-17 19:21:02 -08:00
Alex Huang a73e3dc9ac new networking can be set by use.new.networking 2010-11-17 17:51:17 -08:00
Chiradeep Vittal 4c7bb302bc bug 6971: Use PSK length configuration
validate global configurations
2010-11-17 16:32:50 -08:00
Kelven Yang 5490577469 1) Remove forwarding between eth1 and eth2 as it does not solve the problem of asymmetic routing
2) correct Eclipse project settings
3) If VM is hosted by vmware hypervisor, give the previous host preference to start on to fit VMware's VM-centric model
2010-11-17 15:55:04 -08:00
alena 9fefa33a36 bug 5701: listNetworkGroups api - apply page size parameter to the NetworkGroup instead of IngressRule.
status 5701: resolved fixed
2010-11-17 15:34:45 -08:00
Chiradeep Vittal 9640f12cce bug 6971: revert some changes 2010-11-17 15:33:10 -08:00
Chiradeep Vittal 31e17b907d bug 6971: ensure no conflicts with portforwarding rules for vpn udp ports
also, do not open up port 1701 -- only used on ppp interface not public interface
also clean up password generator, make it easier to use and more secure
moved some constants to NetUtils
heuristic to determine if an ip is one-to-one nat'ted
2010-11-17 15:32:50 -08:00
alena 2184dd1af2 bug 7195: introduced search by forVirtualNetwork parameter in listVmsCmd. Added "forVirtualNetwork" param to responses for all VM's apis.
status 7195: resolved fixed
2010-11-17 14:11:16 -08:00
abhishek 38292fcd02 bug 6929: we prevent upgrading of a router with a SO different from the type it was created with (eg. prevent a virtual offfering being upgraded to direct)
status 6929: resolved fixed
2010-11-17 12:59:54 -08:00
abhishek 1d1a2fa691 bug 6448: returning an error back from the api on trying to add a pf rule which already exists 2010-11-17 11:50:05 -08:00
alena 59b07f8047 bug 7162: made listZones by id work
status 7162: resolved fixed
2010-11-17 10:46:38 -08:00
alena f2c1291f6d Don't allow to update zone with new guestVlan range if the zone's network type is Basic 2010-11-17 10:46:38 -08:00
Kelven Yang 40e8cb83a6 update eclipse project settings for removal of gsson1.3 2010-11-16 23:00:40 -08:00
alena c229e18a1e Don't try to create guest vlan range for Default zone as it has Basic network type 2010-11-16 18:20:26 -08:00
abhishek 20262803fe added entry for networktype to dbconfig for zone creation 2010-11-16 18:01:39 -08:00
alena dae39942f1 bug 7192: Added networktype parameter for the zone
status 7192: resolved fixed

1) Zone has networktype parameter now, 2 values are supported: Basic and Advanced. "networktype" field is created in data_center table. The parameter is being set at creation time; we don't allow to modify it with updateZone command.
2) Only vlan of Untagged Direct type can be created in Basic network zone; any other vlan except for Untagged Direct can be created in Advanced zone
3) Allow NULL guest vlan range for the zone. Only vlan of Direct type can be created in zone with NULL guest vlan.
4) "Default" zone is Basic by default.
5) Changed "vnet" parameter to "vlan" in updateZone command to be consistent with createZone
2010-11-16 16:54:44 -08:00
abhishek 7575a03663 bug 6861: we were setting the account cleanup flag incorrectly, even for a vol which was never attached to a vm. Fixing the same
status 6861: resolved fixed
2010-11-16 16:11:55 -08:00
abhishek 10cfe07970 bug 6793: returning the right msg to the ui when we try to log in to a locked account 2010-11-16 14:15:08 -08:00
abhishek e5e128545d removing the tags support in the update commands for disk and service offerings 2010-11-16 13:25:25 -08:00
abhishek 0876136dc4 bug 7185: the tags logic in the update disk,service offerings was wrong. once a tag is created, it should not be modified. we should only append to the existing list of tags, adding more tags. fixing the same
status 7185: resolved fixed
2010-11-16 12:51:36 -08:00
alena c5d78a726e Modified exception handing in API. Following exceptions are supported now (location - BaseCmd.java):
* MALFORMED_PARAMETER_ERROR - when type of the request parameter is invalid (String instead of Long for id for example)
* PARAM_ERROR - when invalid parameter value is specified in api request. For example, id of non existing vm for StartVmCmd
* ACCOUNT_RESOURCE_LIMIT_ERROR - when user tries to exceed his resource limits by executing the api command.
* INSUFFICIENT_CAPACITY_ERROR - when resource fails to create/start due to insufficient capacity.
* RESOURCE_UNAVAILABLE_ERROR - when user tries to create a vm when storage is not available.
* RESOURCE_IN_USE_ERROR - when user tries to delete/modify resource while it's in use. For example, when we try to delete a network group when it contains ingress rules.
* NETWORK_RULE_CONFLICT_ERROR - when LB/PF rule to add conflicts with existing rule
* ACCOUNT_ERROR - when user is not authorized to execute operation on the resource.
* INTERNAL_ERROR
2010-11-16 11:56:34 -08:00
abhishek 92e3dc91c4 found a bug in the code where we were not decoding the params sent in eg. "a b" was being stored in the db as 'a%20b'. Fixing the same to have the right val persisted to the db 2010-11-16 11:46:55 -08:00
Alex Huang ed31497188 ComponentLocator changes 2010-11-16 04:28:15 -08:00
Alex Huang 17afeade00 better componentslocator 2010-11-16 04:28:14 -08:00
alena d43a8e983c Fixed authorizeNetworkGroupIngress api command (it stopped working after API refactor) 2010-11-15 17:44:51 -08:00
alena 1a8d9a92a7 Modified all api calls to throw ApiServerException if null object is returned by the manager. 2010-11-15 17:44:51 -08:00
abhishek d5ab597fcf bug 6474,6475: porting over the expunge fixes for port forwarding rules to 2.2
status 6474,6475: resolved fixed
2010-11-15 17:33:05 -08:00
abhishek c115a2e401 bug 7189: returning vmdisplayname if available for all port fwding crud cmds
status 7189: resolved fixed
2010-11-15 14:55:03 -08:00
abhishek 1e8d5675f6 bug 6865: fixing the alerts code which was broken; hence no alerts were being sent out
status 6865: resolved fixed
2010-11-15 14:38:39 -08:00
abhishek d520f0af5b adding a column in user_ip_address table called one_to_one_nat; which is a boolean to tell us if the ip is a nat ip. This is false by default, and is set to true when we nat the ip. Also, this value is returned in the list public ip addrsses api call.
finally, the value is set to false when we delete the ip forwarding rule.
2010-11-15 12:39:24 -08:00
abhishek 6d943abf55 bug 7119: code refactor away from the ms calls, to the share and prepare methods based on alex's recommendations
status 7119: resolved fixed
2010-11-15 11:17:36 -08:00
alena a01aad84ed bug 7162: added search by id to listZones command
status 7162: resolved fixed
2010-11-15 10:48:36 -08:00
alena 050eed742f 1) Removed account/domainId info from deleteSnapshot and deleteSnapshotPolicy commands as we get account info from the snapshot/policy object.
2) Introduced responseObject field in @Implementation for all apis. This field contains information about the response object class, so we can used it for generating API documentation.
2010-11-12 17:36:17 -08:00
abhishek 7327906cdf the pool availability part is done by the sp allocators, hence commenting out the code in here. 2010-11-12 17:19:57 -08:00
Kelven Yang 0653d6d7f6 Improve console access security with random generated hash key 2010-11-12 16:59:58 -08:00
abhishek d8fdcd3815 bug 7088: returning right error msg for assocIp failure 2010-11-12 15:31:30 -08:00
abhishek fc461abed1 bug 6755: adding checks for commands before they hit the ms; to ensure they are valid. Also returning the right error msg if the command is not valid
status 6755: resolved fixed
2010-11-12 13:55:06 -08:00
anthony 2537dc3058 bug 7149: merge from 2.1.x 2010-11-12 13:16:03 -08:00
abhishek c91c977fba bug 6290: we will be returning the service offering details for a root disk in the list volumes cmd, as opposed to the disk offering which was misleading
status 6290: resolved fixed
2010-11-12 11:24:34 -08:00
abhishek 673ddb246a bug 6832: returning the missing api value for destroyed volumes
status 6832: resolved fixed
2010-11-12 10:55:13 -08:00
abhishek 9fb62555af bug 7071: making the config var "hidden" instead of removing it, as there are a lot of references to this var. 2010-11-12 10:06:51 -08:00
abhishek 826e7aac85 bug 7071: We do not want to expose the enable/disable flag for ssvm. Removing this option from the global settings menu presented to the UI.
status 7071: resolved fixed
2010-11-12 09:51:38 -08:00
nit dd8f02589d bug 6837 : UpdateIso and UpdateTemplate API should return ostypename. Removing incorrect domainId creeping in because it was of primitive type.
status 6837: resolved fixed
2010-11-12 18:08:43 +05:30
nit 5215f6f817 bug 7101 : DetachISO API and AttachISO API would start returning an embedded object of virtualmachine so that the UI could use that to update the vm.
status 7101: resolved fixed
2010-11-12 16:40:55 +05:30
nit b42458fa0d Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss 2010-11-12 14:48:11 +05:30
nit ff4250fe89 bug 5360 : USER.DELETE - Adding Started event and refactored the code around it.
status 5360: resolved fixed
2010-11-12 14:47:30 +05:30
alena a6abbe4637 bug 7122: don't return System user in listUsers response
status 7122: resolved fixed
2010-11-11 18:10:08 -08:00
abhishek e79e432807 we were using debug logging without checking ifDebugEnabled(), fixing that 2010-11-11 17:20:57 -08:00
abhishek fcd7f37839 bug 7037: adding more logging to the deletepool cmd
status 7037: resolved fixed
2010-11-11 17:20:57 -08:00
edison f30d3f4839 don't break other people 2010-11-11 17:13:21 -08:00
edison 0db9303bca don't break others 2010-11-11 17:04:10 -08:00
edison 8ca6f1669e start2command fro secondarys storage vm and make it work for KVM 2010-11-11 17:04:10 -08:00
edison 40481cfe6e add start2command for secondarystorage vm 2010-11-11 17:04:10 -08:00
edison 393666feea start2command for secvm 2010-11-11 17:04:10 -08:00
alena 0ad492cc74 bug 7118: fixed deletePod command - 1)remove Pod's resources (private ip adresses) before removing the pod itself. 2) Verify that private ip address pool is not empty before removing it.
status 7118: resolved fixed
2010-11-11 16:55:59 -08:00
abhishek 709fc3686f another fix for a related bug on data volumes I found whilst testing the parent bug 2010-11-11 16:39:15 -08:00
abhishek 968dc0616f bug 7021: data disk wasn't being created for custom sizes. Also, we were having max size checks in GB, whereas disk offerings are in MB. Made the change there as well.The storage allocators were commented out in master, uncommented them.
Status 7021: resolved fixed
2010-11-11 15:45:21 -08:00
alena 6e0b500a83 bug 4964: made listDomainChildren work with "isRecursive" flag
status 4964: resolved fixed
2010-11-11 14:32:36 -08:00
abhishek 05bbd35860 resolving the network manager merge conflict 2010-11-11 13:13:04 -08:00
abhishek 1faaba8fb0 fixed a corner case; also changed the commands to be async and changed the method signatures to conform with the master refactor 2010-11-11 13:07:26 -08:00
abhishek 239942bbe1 refactored all the commands to cater to keshav's needs, and added the new apis. the initial set of testing is complete, will now focus on corner cases 2010-11-11 13:07:26 -08:00
abhishek 26b75fc05d this is a good point to check the code in; have completed a part of the enhancement's code; with create and delete ip forwarding rule commands and the skeleton for port to rule map with associated table 2010-11-11 13:07:26 -08:00
abhishek e5ca5dddf9 renaming the ip forwarding commands to port forwarding commands, and beginning to work on Keshav's request to modify the current 1-1 NAT to be compatible with the Amazon apis 2010-11-11 13:07:26 -08:00
Alex Huang 05ce97f918 Merged in alena's changes 2010-11-11 12:53:19 -08:00
Alex Huang bbdc2b22ff commit for push 2010-11-11 12:53:19 -08:00
Alex Huang 284720bf00 compilation errors fixed 2010-11-11 12:53:19 -08:00
Alex Huang 94250c1330 committing to update 2010-11-11 12:53:19 -08:00
Alex Huang c6033baa78 system vm start and stop added 2010-11-11 12:53:19 -08:00
alena d091bdd886 bug 7126: return true only when assignToLoadBalancer succeeded.
status 7126: resolved fixed
2010-11-11 12:46:21 -08:00
alena 86c8f86a56 bug 6192: use "ipaddress" instead of "publicip" in updatePortForwarding command
status 6192: resolved fixed
2010-11-11 12:12:29 -08:00
Jessica Wang c66cb856f7 fix a bug that 3rd party software xstream-1.3.1.jar is not found. 2010-11-11 12:02:43 -08:00
alena 5a01335002 bug 7143: vlan parameter is no longer required by createZone command
status 7143: resolved fixed
2010-11-11 10:43:18 -08:00
alena 86e83bc4bd Created new response objects for userVm/domainRouter/systemVm that going to be used by API after network refactorig is in place. 2010-11-11 10:43:18 -08:00
will a69f961bd8 bug 5903: Reworked the entire UI to accomodate the new snapshot policy in 2.2.
- Fixed issues with deleting snapshot policies
- Fixed maxsnaps being set wrong in the DB.
2010-11-10 19:19:18 -08:00
alena b1194e68f7 Fixed the build 2010-11-10 10:14:08 -08:00
nit 0597c0cf4b bug 4177: RegisterIsoCmd and RegisterTemplateCmd API - Added account and domainId params so that one could register them on behalf of other accounts.
status 4177: resolved fixed
2010-11-10 17:47:59 +05:30
alena 3954c7550a bug 6914: return password in deployVirtualMachine/resetVmPassword response.
status 6914: resolved fixed
2010-11-09 11:18:54 -08:00
alena 5fafef9970 More api refactor - build api response is execute() method instead of getResponse method. 2010-11-09 09:58:05 -08:00
nit 3455a0f563 bug 7114: Fix NPE for updateTemplatePermissions when accessed via 8096. This was happening due to accountObj being null in User Context when accessed via 8096. Why we set it to null seems to be a hack to me.
status 7114: resolved fixed
2010-11-09 20:01:13 +05:30
nit 351f98ceef bug 5363: SNAPSHOT.CREATE - Add Started event.
status 5363: resolved fixed
2010-11-09 19:37:01 +05:30
anthony 8df96da0a5 don't delete template if template check fail, give user a chance to check the template manually
use can delete the template though UI
2010-11-08 21:03:59 -08:00
anthony 4646be7587 for recursive snapshot, use UID_SYSTEM instead 2010-11-08 18:08:08 -08:00
anthony 0febfb4938 don't reschedule manual snapshot 2010-11-08 18:08:08 -08:00
anthony 3aad88e94b reschedule all polocies after management server restart, in case some schedules are missing 2010-11-08 18:08:08 -08:00
anthony 71a670defc snapshot code cleanup 2010-11-08 18:08:08 -08:00
anthony 9ee6d69c9f the default delta snapshot number between two full snapshots is 16, it is configurable 2010-11-08 18:08:07 -08:00
abhishek 7262b854a5 bug 7121: made the disk offering id optional, and added a check to ensure we never have both disk offering and snapshot ids to be null
status 7121: resolved fixed
2010-11-08 17:59:26 -08:00
abhishek 11ea13fd7d Added the domain checker code and checks for a host of commands. This replaces the previous mechanism, and provides a way for us to validate the command executor as to whether he has access to the zone. 2010-11-08 17:50:38 -08:00
will 5cc496a78d Not sure why listing of templates was using Integer instead of Long for pagesize but now correcting to keep things consistent. 2010-11-08 14:57:59 -08:00
will 0d27ac2e31 bug 5920: added confirmation dialog before allowing user to delete snapshots
- Fixed a NPE when listing templates.
2010-11-08 14:52:10 -08:00
alena 47e365f5ea bug 7089: return embedded object name in xml response
status 7089: resolved fixed
2010-11-08 13:59:14 -08:00
will 551e7e4b82 bug 6812: fixed default pagesize of all listXXX command to unlimited for now. 2010-11-08 13:15:02 -08:00
Alex Huang c8a3ea3080 merge conflict with alena's changes 2010-11-08 12:40:38 -08:00
Alex Huang 16b6850bea revert console proxy 2010-11-08 12:29:38 -08:00
Alex Huang edf9ddd464 added reservation id to vnet 2010-11-08 12:29:38 -08:00
Alex Huang 734cd0b1b1 fixed some bugs 2010-11-08 12:29:37 -08:00
Alex Huang aca8ef79cd a bunch of other changes for network refactoring 2010-11-08 12:29:37 -08:00
Alex Huang 2be0cd6a95 stop worked again 2010-11-08 12:29:36 -08:00
abhishek cc93e7508c refactoring old code and fixing some regression bugs (UI had an issue listing domains). Also fixed the listing of domain specific zones at vm creation for a domain admin (listing everything upto root in that domain + listing all the children based on a path search) 2010-11-08 12:17:42 -08:00
abhishek 67beda5244 adding the logic to list and search zones and domains based on the user (normal,admin,domain admin) 2010-11-08 12:17:42 -08:00
alena 1c24deda34 1) Refactored current Apis not to use reflection for method invocation. In new version following has to be done:
* Implement callCreate() and execute() methods in apis extending BaseAsyncCreateCmd (example - CreateVolumeCmd)
* Implement execute() method in apis extending BaseCmd and BaseAsyncCmd (example - deleteVolumeCmd and deleteUserCmd)

We no longer need createMethod(), method(), manager() fields in @Implementation annotation, cleanup has to be done.

2) Moved Account/User related methods to AccountManagerImpl. Methods are exposed via AccountService interface.
3) Enhanced exception handing for Api calls.
4) Created ConfigurationService interface, all Api config methods are exposed via it.
2010-11-08 11:27:36 -08:00