e353b7ac2d
we use 2 different tables for ip/port fwding and load balancer rules respectively. when we create a new static nat rule, this checkin tests against existing records in either of these tables based on the public ip address being mapped. if such a rule exists in either table, we do not permit creation of a static nat rule on this public ip
2010-12-02 15:50:04 -08:00
66186ca876
bug 7348: fixing the issue of the static nat rules not being re-programmed on a domr stop/start or a domr reboot
...
status 7348: resolved fixed
2010-12-02 11:16:33 -08:00
dc5c82456c
bug 7352: implemented security for the list ip fwding rules cmd, to filter results based on user
...
status 7352: resolved fixed
2010-12-02 09:49:47 -08:00
d0fc07496f
search functionality for ip forwarding rules, with covering of cerner cases
2010-12-02 09:46:32 -08:00
d28d6894e1
adding security checks for list ip forwarding rules command
2010-12-02 09:46:32 -08:00
ad571eef36
Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss
2010-12-02 17:36:26 +05:30
9a3a5b4fa7
bug 7314 : Extract Api - Async Framework takes care of updating the final status no need to update it inside the code.
...
status 7314: resolved fixed
2010-12-02 17:35:47 +05:30
794c83f011
bug 7216: show capacity alerts at pod level instead of zone
...
status 7216: resolved fixed
2010-12-02 15:20:05 +05:30
0b76c26ce9
bug 7216: show capacity alerts at pod level instead of zone
...
status 7216: resolved fixed
2010-12-02 14:11:38 +05:30
cd5afb3d7e
bug 6969: Fixed snapshots, templates, isos, routers, volumes, and system vms async commands to make use of the new job id/job status when listing objects with pending jobs.
2010-12-01 16:50:56 -08:00
17f3239f07
bug 7368: should get volumeVO even if it is removed
...
status 7368: resolved fixed
2010-12-01 16:11:47 -08:00
a477d6c33c
adding support for updating service and disk offerings, also adding domain and domainid back in the responses to the CRUD methods for both service and disk offerings
2010-12-01 10:40:08 -08:00
b51a7fec50
adding a security checker whilst creating a volume from a disk offering
2010-12-01 09:53:13 -08:00
4387e2ca0a
another good point to commit; the basic domain specific disk offering functionality is now in place
2010-12-01 09:53:13 -08:00
402baae9fa
adding comments for the domain checker, so that the design decision is better understood down the road
2010-12-01 09:53:13 -08:00
1dfdcf51cb
another good point for checkin, added the domain checker for checks against service offerings, whilst deploying virtual machines
2010-12-01 09:53:13 -08:00
9a6eaaf21f
this is a good point to commit the code; have the basic domain specific service offering working
2010-12-01 09:53:13 -08:00
c67d26cec4
bug 6969: First step of now displaying pending async jobs for listXXXCommands. There is a lot more cleanup and fixing to do but all commands acting against VirtualMachines now work.
2010-11-30 19:12:09 -08:00
677394c27a
Remove retired configuration varable
2010-11-30 16:23:15 -08:00
83736a1af5
Add URI component encoding to URI util class to help utilize URL info in hypervisor host address
2010-11-30 16:23:15 -08:00
de92288e3b
Adding xenserver-5.6.0-1.jar to eclipse classpath and removing 5.5
2010-11-30 12:19:49 -08:00
680812f675
bug 7223: page and pagesize parameters must be specified together "list" api commands
...
status 7223: resolved fixed
2010-11-30 11:31:34 -08:00
b5f9ae0ef3
Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss
2010-11-30 23:48:13 +05:30
2f946f6030
bug 7366 : Mark template as removed if create private template from volume fails due to being attached to a non-stopped VM. This allows subsequent creation of a template with the same name.
...
status 7366: resolved fixed
2010-11-30 23:47:04 +05:30
1aee756184
bug 7345: During the expunge operation, we were not calling the deleteipforwardingrule method, for a rule which was static nat. Adding that logic. Also, making a change in the domr script as we do not need to execute a line on deletion of a rule
...
status 7345: resolved fixed
2010-11-30 10:07:10 -08:00
54f177cacc
1) Make generic dao be able to persist UTF-8 string for internationalization support
...
2) Undo gson Unicode escape in API response object to avoid double escaping which can break Javascript from getting correct text content
3) Correct API layer in dealing with character encoding
4) Remove double escape in cloud.core.js
2010-11-30 09:40:54 -08:00
fa9c882d8c
Add VMWare hypervisor guru
2010-11-30 09:40:53 -08:00
06c61f2fac
bug 7325 : We shouldn't allow attaching xen-pv-iso to any hypervisor other than xenserver.
...
status 7325: resolved fixed
2010-11-30 22:20:33 +05:30
a6a774f6c0
bug 7369 : Resolving NPE while creating a private template from detached volume. The instance id is null when it is detached which was the culprit here.
...
status 7369: resolved fixed
2010-11-30 15:49:29 +05:30
fb0675bbf4
bug 7365: return both physical and virutal size when creating private template
...
status 7365: resolved fixed
2010-11-29 18:58:48 -08:00
d3325de5ae
1. limit xs-tools in xenserver related java file
...
2. don't populate xs-tools to template_host_ref
3. introduce a new template type PERHOST, which doesn't need to be populated to secondary storage
2010-11-29 18:21:08 -08:00
0273872b34
bug 7362: we were missing the size validation check, when we create a volume from disk offering (the storage.max.volume.size param wasn't being used for validation). Fixed the same, made the validation method name more generic to be applicable to all validations, and changed the param description to denote GB as the unit
...
status 7362: resolved fixed
2010-11-29 17:23:16 -08:00
bd64f4faa3
remove eclipse error
2010-11-29 16:39:48 -08:00
fff1dd874a
fix classpath for xenserver-5.6.0-1
2010-11-29 15:26:07 -08:00
bdf4426609
fixing the same issue in another command (found whilst checking references)
2010-11-29 13:38:06 -08:00
1a0ec2a00f
bug 7346: fixing the corner case where list ip forwarding rules is called for a rule, which is yet to be expunged, but the vm is destroyed. if you call list here, an npe results
...
status 7346: resolved fixed
2010-11-29 13:35:04 -08:00
dce3f9fa3b
bug 7344: preventing enabling of static nat on an ip for more than one instance. Check the nat flag, and error out if set
...
status 7344: resolved fixed
2010-11-29 11:56:34 -08:00
385054fccf
bug 7338: update template physical size
...
status 7338: resolved fixed
2010-11-29 11:23:47 -08:00
d40700b286
Changed firewall rule's constructor
2010-11-29 09:38:13 -08:00
30fa6530f9
bug 6088: track template physical size in template_host_ref table
...
add migration from 21 to 22
after migration , SSVM needs to stop/start
status 6088: resolved fixed
2010-11-24 20:05:52 -08:00
23f274cfd2
Send AttachVolume command even if VM is not in running state under vmware case
2010-11-24 15:17:09 -08:00
dd9b1634f7
Allow host behind cluster to return real VNC host IP address
2010-11-24 15:17:08 -08:00
fd1beef28b
Someone commited a change in ConsoleProxyManagerImpl that breaks down system VM, let's blame git for now on this
2010-11-24 15:17:07 -08:00
aa8aa6027a
Modified UserContext - got rid of accountName, domainId fields as we can get this information from Account field.
2010-11-24 14:29:08 -08:00
1950bf7a99
changing the nat feature to work with kvm
2010-11-24 10:04:24 -08:00
44737d24c5
bug 7196: fixed response object generation for authorizeNetworkGroupIngress command (response type is Network group response - the way it was in 2.1.x - instead of IngressRule response)
...
status 7196: resolved fixed
Also fixed revokeNetworkGroup command - didn't work via 8096 port
2010-11-24 09:50:04 -08:00
d0530265d7
bug 7046 : Global admins should be allowed to extract all the times.
...
status 7046: resolved fixed
2010-11-24 19:33:15 +05:30
841044e360
Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss
2010-11-24 18:38:23 +05:30
8ea124ae79
bug 7046 : extracting templates should allow for exclusion of some templates. An attribute "extractable" would be set on templates by the template owner at upload time. It would specify if we allow the template to be extracted from the system. Default would be true ie "allow extraction". If set to false, it would not be possible to extract the template or any derivatives of the template. For example, volumes, snapshots or templates from that template.
...
status 7046: resolved fixed
2010-11-24 18:37:54 +05:30
f70071dc98
bug 6309: Added event VM.UPDATE along with changed fields
...
status 6309: resolved fixed
2010-11-24 18:36:35 +05:30
19dcbb8d8e
bug 7246: changed event name to TEMPLATE.CLEANUP when cleaning up templates on sec storage. Usage won't track this event
...
status 7246: resolved fixed
2010-11-24 17:48:19 +05:30
c39d211a48
merge from 2.1.x
2010-11-23 18:55:23 -08:00
5543814f39
blocking the static natting of an ip address, if it is already source natted
2010-11-23 16:39:02 -08:00
3d4b8ab4a0
bug 7263: changing the param name. Found a couple of bugs whilst testing this, the validation of vol size whilst cust vol creation was missing. Adding the same.
...
status 7263: resolved fixed
2010-11-23 16:20:30 -08:00
f4908758b3
bug 7234: don't try to delete pod level vlan when it doesn't exist
...
status 7234: resolved fixed
2010-11-23 15:06:29 -08:00
cb74030d01
bug 7298: throw an Exception when invalid job Id is specified in queryAsyncJobResult
...
status 7298: resolved fixed
2010-11-23 15:06:29 -08:00
40c3a0afa2
bug 7249: during volume creation (root and data) for a vm, there was no state being set (we need to set it to ready). Hence, whilst re-attaching a detached vol, we hit a NPE. Fixed the root cause of the state not being set during vm creation, and consequently, fixed this npe
...
status 7249: resolved fixed
2010-11-23 14:24:29 -08:00
90467ab31d
merge 7277: Fixed the file separate so Extract Template works on Windows machine.
2010-11-23 11:13:47 -08:00
10fb2a0f39
bug 7292: fixed assignig LB to non-source Nat ip address
...
status 7292: resolved fixed
2010-11-22 20:54:08 -08:00
7205a7507d
bug 7277: Fixed the logic to prevent System templates from being downloaded.
2010-11-22 17:13:30 -08:00
3f1abbcbc8
Fixed assignToLoadBalancer command - admin couldn't assing LB rule in behalf of other user
2010-11-22 17:08:51 -08:00
8995e5d2f7
changing the event logged to the right type, whilst starting user vms via cancelstoragemaintenance in master (already merged to 2.2.beta1)
2010-11-22 16:20:18 -08:00
1491893bbc
bug 7281: throw an exception when fail to get isoPath - happens when Secondary Storage vm is not in UP state in cloud.hosts table.
...
status 7281: resolved fixed
2010-11-22 15:42:34 -08:00
a646745516
bug 7227: applying Alex's fix - different way of desirializing List objects.
...
status 7227: resolved fixed
2010-11-22 14:08:43 -08:00
6765e97976
Made ApiResponseHelper to use Long instead of long for response parameters to eliminate possible NPEs during building an api response.
2010-11-22 11:27:15 -08:00
cdea2d210d
Better logging for api exceptions.
2010-11-22 11:27:15 -08:00
0979b644ef
bug 7230: there was an issue trying to start user vms when the pool state is cancelmaintenance; fixing the same in 2.2RC2
...
status 7230: resolved fixed
2010-11-22 11:00:43 -08:00
d38f7fd56d
Moved DAO to server
2010-11-22 07:40:41 -08:00
1e44925564
api refactoring
2010-11-21 12:00:21 -08:00
138e0914b6
bug 7245: don't try to set vm name for detached volume during expunge process.
...
status 7245: resolved fixed
Fixed couple of other problems:
* cleanup corresponding records in load_balancer_vm_map table when loadBalancerRule is removed.
* don't log "java.lang.IllegalStateException: getAttribute: Session already invalidated" exception when UI session expires
2010-11-19 20:08:18 -08:00
6b61caad46
AssignToLoadBalancer - added missing transaction.commit to corresponding NetworkManager method.
2010-11-19 19:14:24 -08:00
cec8ebd5cd
bug 7236: don't catch AsyncCommandQueued exception in ApiDispatcher
...
status 7236: resolved fixed
2010-11-19 18:40:32 -08:00
5426b1487c
listPortForwardingRules: return empty response instead of throwing exception when ipAddress doesn't have any rules assigned.
2010-11-19 18:40:32 -08:00
ca162bca11
bug 6936: for some reason, we had a check on pod-wide or account specific vlan creation. This seems to be a left over from legacy code. Removing the same. I tested to make sure both zone wide vlan and account specific vlan creation for direct tagged case works fine
...
status 6936: resolved fixed
2010-11-19 17:54:57 -08:00
e1b74ea99e
RegisterTemplateCommand - ignore case in "hypervisor" parameter value - used to complain when "xen" was specified instead of "Xen"
2010-11-19 16:27:05 -08:00
fe93821bb1
Fixed editZone command - if dns2 is not specified, keep the old value instead of updating it to NULL
2010-11-19 16:13:45 -08:00
fa499dadbc
bug 7220: the parameter type transfer may cause NPE
...
status 7220: resolved fixed
2010-11-19 15:56:04 -08:00
a5dfaaf31b
API exception handling - print api command name to the log.
2010-11-19 15:48:58 -08:00
5b4a6f27db
Changed networkconfigurations to network as per Sheng's suggestion
2010-11-19 15:44:42 -08:00
a495f34d4f
Fixed enableAccount command - domain permission check was done incorrectly
2010-11-19 15:25:29 -08:00
8362d0feba
Reverting back commit e5c137e303 as it wasn't meant to be in 2.2 RC1.
2010-11-19 14:23:39 -08:00
e5c137e303
bug 7223: pagesize and page should be specified together in "list" api commands
...
status 7223: resolved fixed
2010-11-19 14:03:44 -08:00
0c35f2f743
bug 7237: disk size is passed in diskProfile, no need size parameter in createcommand
...
status 7237: rresolved fixed
2010-11-19 11:55:27 -08:00
394554770e
Enforce user limit on number of vpn users
2010-11-18 18:38:29 -08:00
a0eaf32cad
Fixed updateAccount command to work via 8096 port.
2010-11-18 17:35:41 -08:00
0b2b8e31d8
Fixed updateUser command - didn't work correctly via 8096 port (user account info was taken from UserContext instead of User object).
2010-11-18 17:07:20 -08:00
d222a52ccb
bug 7232: resolving the sql exception
...
status 7232: resolved fixed
2010-11-18 16:47:08 -08:00
317554d983
ensuring all the following have api values taken in, in GB (disk offering, service offering, custom vol creation and vm creation from cust disk offering)
2010-11-18 14:32:50 -08:00
c53e165eaa
bug 6971: bring back l2tp port 1701
2010-11-18 14:06:01 -08:00
a7547846bf
bug 6971: Dont confuse PF rules added for VPN to be LB rules
2010-11-18 14:05:28 -08:00
6ae21932eb
realized that the var name used in response code might be confusing to a new reader. changing the name to be more intuitive
2010-11-18 11:20:01 -08:00
18ff23c839
added a list method to list ip forwarding rules, optionally list a rule based on its public ip address
2010-11-18 11:15:13 -08:00
020afa6e33
adding a list command for ip forwarding rules for 1:1 nat, to be consumed by the ui
2010-11-18 11:15:13 -08:00
c4f1b35aef
returning the public ip address in the creation of firewall rule, for the UI to consume
2010-11-18 09:42:47 -08:00
829d7482b3
bug 6864: allow domain admin to see only vms belonging to his domain and child domains
...
status 6864: resolved fixed
2010-11-17 23:09:19 -08:00
91a87f9d8f
bug 7155: fixed NPE in AuditTrial which used to happen when logout command was executed when session was already invalidated.
...
status 7155: resolved fixed
2010-11-17 21:42:51 -08:00
28dd8185dd
Fixes for listDomains API command:
...
* return all domains in the system when command is executed via 8096
* for domain admin return only his domains and subdomains.
2010-11-17 21:28:12 -08:00
6f44238109
Fixed listDomainChildren api - now we can search by name when isRecursive flag set.
2010-11-17 20:40:39 -08:00
a95b853a17
bug 6898: updateResourceLimit command requires domainId or account/domainId now if executed via 8096 port
...
status 6898: resolved fixed
2010-11-17 19:43:06 -08:00
97a8349110
bug 6894: removed "account" request parameter in listAccounts command. Should use "name" if need to make search by account name
...
status 6894: resolved fixed
2010-11-17 19:21:02 -08:00
a73e3dc9ac
new networking can be set by use.new.networking
2010-11-17 17:51:17 -08:00
4c7bb302bc
bug 6971: Use PSK length configuration
...
validate global configurations
2010-11-17 16:32:50 -08:00
5490577469
1) Remove forwarding between eth1 and eth2 as it does not solve the problem of asymmetic routing
...
2) correct Eclipse project settings
3) If VM is hosted by vmware hypervisor, give the previous host preference to start on to fit VMware's VM-centric model
2010-11-17 15:55:04 -08:00
9fefa33a36
bug 5701: listNetworkGroups api - apply page size parameter to the NetworkGroup instead of IngressRule.
...
status 5701: resolved fixed
2010-11-17 15:34:45 -08:00
9640f12cce
bug 6971: revert some changes
2010-11-17 15:33:10 -08:00
31e17b907d
bug 6971: ensure no conflicts with portforwarding rules for vpn udp ports
...
also, do not open up port 1701 -- only used on ppp interface not public interface
also clean up password generator, make it easier to use and more secure
moved some constants to NetUtils
heuristic to determine if an ip is one-to-one nat'ted
2010-11-17 15:32:50 -08:00
2184dd1af2
bug 7195: introduced search by forVirtualNetwork parameter in listVmsCmd. Added "forVirtualNetwork" param to responses for all VM's apis.
...
status 7195: resolved fixed
2010-11-17 14:11:16 -08:00
38292fcd02
bug 6929: we prevent upgrading of a router with a SO different from the type it was created with (eg. prevent a virtual offfering being upgraded to direct)
...
status 6929: resolved fixed
2010-11-17 12:59:54 -08:00
1d1a2fa691
bug 6448: returning an error back from the api on trying to add a pf rule which already exists
2010-11-17 11:50:05 -08:00
59b07f8047
bug 7162: made listZones by id work
...
status 7162: resolved fixed
2010-11-17 10:46:38 -08:00
f2c1291f6d
Don't allow to update zone with new guestVlan range if the zone's network type is Basic
2010-11-17 10:46:38 -08:00
40e8cb83a6
update eclipse project settings for removal of gsson1.3
2010-11-16 23:00:40 -08:00
c229e18a1e
Don't try to create guest vlan range for Default zone as it has Basic network type
2010-11-16 18:20:26 -08:00
20262803fe
added entry for networktype to dbconfig for zone creation
2010-11-16 18:01:39 -08:00
dae39942f1
bug 7192: Added networktype parameter for the zone
...
status 7192: resolved fixed
1) Zone has networktype parameter now, 2 values are supported: Basic and Advanced. "networktype" field is created in data_center table. The parameter is being set at creation time; we don't allow to modify it with updateZone command.
2) Only vlan of Untagged Direct type can be created in Basic network zone; any other vlan except for Untagged Direct can be created in Advanced zone
3) Allow NULL guest vlan range for the zone. Only vlan of Direct type can be created in zone with NULL guest vlan.
4) "Default" zone is Basic by default.
5) Changed "vnet" parameter to "vlan" in updateZone command to be consistent with createZone
2010-11-16 16:54:44 -08:00
7575a03663
bug 6861: we were setting the account cleanup flag incorrectly, even for a vol which was never attached to a vm. Fixing the same
...
status 6861: resolved fixed
2010-11-16 16:11:55 -08:00
10cfe07970
bug 6793: returning the right msg to the ui when we try to log in to a locked account
2010-11-16 14:15:08 -08:00
e5e128545d
removing the tags support in the update commands for disk and service offerings
2010-11-16 13:25:25 -08:00
0876136dc4
bug 7185: the tags logic in the update disk,service offerings was wrong. once a tag is created, it should not be modified. we should only append to the existing list of tags, adding more tags. fixing the same
...
status 7185: resolved fixed
2010-11-16 12:51:36 -08:00
c5d78a726e
Modified exception handing in API. Following exceptions are supported now (location - BaseCmd.java):
...
* MALFORMED_PARAMETER_ERROR - when type of the request parameter is invalid (String instead of Long for id for example)
* PARAM_ERROR - when invalid parameter value is specified in api request. For example, id of non existing vm for StartVmCmd
* ACCOUNT_RESOURCE_LIMIT_ERROR - when user tries to exceed his resource limits by executing the api command.
* INSUFFICIENT_CAPACITY_ERROR - when resource fails to create/start due to insufficient capacity.
* RESOURCE_UNAVAILABLE_ERROR - when user tries to create a vm when storage is not available.
* RESOURCE_IN_USE_ERROR - when user tries to delete/modify resource while it's in use. For example, when we try to delete a network group when it contains ingress rules.
* NETWORK_RULE_CONFLICT_ERROR - when LB/PF rule to add conflicts with existing rule
* ACCOUNT_ERROR - when user is not authorized to execute operation on the resource.
* INTERNAL_ERROR
2010-11-16 11:56:34 -08:00
92e3dc91c4
found a bug in the code where we were not decoding the params sent in eg. "a b" was being stored in the db as 'a%20b'. Fixing the same to have the right val persisted to the db
2010-11-16 11:46:55 -08:00
ed31497188
ComponentLocator changes
2010-11-16 04:28:15 -08:00
17afeade00
better componentslocator
2010-11-16 04:28:14 -08:00
d43a8e983c
Fixed authorizeNetworkGroupIngress api command (it stopped working after API refactor)
2010-11-15 17:44:51 -08:00
1a8d9a92a7
Modified all api calls to throw ApiServerException if null object is returned by the manager.
2010-11-15 17:44:51 -08:00
d5ab597fcf
bug 6474,6475: porting over the expunge fixes for port forwarding rules to 2.2
...
status 6474,6475: resolved fixed
2010-11-15 17:33:05 -08:00
c115a2e401
bug 7189: returning vmdisplayname if available for all port fwding crud cmds
...
status 7189: resolved fixed
2010-11-15 14:55:03 -08:00
1e8d5675f6
bug 6865: fixing the alerts code which was broken; hence no alerts were being sent out
...
status 6865: resolved fixed
2010-11-15 14:38:39 -08:00
d520f0af5b
adding a column in user_ip_address table called one_to_one_nat; which is a boolean to tell us if the ip is a nat ip. This is false by default, and is set to true when we nat the ip. Also, this value is returned in the list public ip addrsses api call.
...
finally, the value is set to false when we delete the ip forwarding rule.
2010-11-15 12:39:24 -08:00
6d943abf55
bug 7119: code refactor away from the ms calls, to the share and prepare methods based on alex's recommendations
...
status 7119: resolved fixed
2010-11-15 11:17:36 -08:00
a01aad84ed
bug 7162: added search by id to listZones command
...
status 7162: resolved fixed
2010-11-15 10:48:36 -08:00
050eed742f
1) Removed account/domainId info from deleteSnapshot and deleteSnapshotPolicy commands as we get account info from the snapshot/policy object.
...
2) Introduced responseObject field in @Implementation for all apis. This field contains information about the response object class, so we can used it for generating API documentation.
2010-11-12 17:36:17 -08:00
7327906cdf
the pool availability part is done by the sp allocators, hence commenting out the code in here.
2010-11-12 17:19:57 -08:00
0653d6d7f6
Improve console access security with random generated hash key
2010-11-12 16:59:58 -08:00
d8fdcd3815
bug 7088: returning right error msg for assocIp failure
2010-11-12 15:31:30 -08:00
fc461abed1
bug 6755: adding checks for commands before they hit the ms; to ensure they are valid. Also returning the right error msg if the command is not valid
...
status 6755: resolved fixed
2010-11-12 13:55:06 -08:00
2537dc3058
bug 7149: merge from 2.1.x
2010-11-12 13:16:03 -08:00
c91c977fba
bug 6290: we will be returning the service offering details for a root disk in the list volumes cmd, as opposed to the disk offering which was misleading
...
status 6290: resolved fixed
2010-11-12 11:24:34 -08:00
673ddb246a
bug 6832: returning the missing api value for destroyed volumes
...
status 6832: resolved fixed
2010-11-12 10:55:13 -08:00
9fb62555af
bug 7071: making the config var "hidden" instead of removing it, as there are a lot of references to this var.
2010-11-12 10:06:51 -08:00
826e7aac85
bug 7071: We do not want to expose the enable/disable flag for ssvm. Removing this option from the global settings menu presented to the UI.
...
status 7071: resolved fixed
2010-11-12 09:51:38 -08:00
dd8f02589d
bug 6837 : UpdateIso and UpdateTemplate API should return ostypename. Removing incorrect domainId creeping in because it was of primitive type.
...
status 6837: resolved fixed
2010-11-12 18:08:43 +05:30
5215f6f817
bug 7101 : DetachISO API and AttachISO API would start returning an embedded object of virtualmachine so that the UI could use that to update the vm.
...
status 7101: resolved fixed
2010-11-12 16:40:55 +05:30
b42458fa0d
Merge branch 'master' of ssh://git.cloud.com/var/lib/git/cloudstack-oss
2010-11-12 14:48:11 +05:30
ff4250fe89
bug 5360 : USER.DELETE - Adding Started event and refactored the code around it.
...
status 5360: resolved fixed
2010-11-12 14:47:30 +05:30
a6abbe4637
bug 7122: don't return System user in listUsers response
...
status 7122: resolved fixed
2010-11-11 18:10:08 -08:00
e79e432807
we were using debug logging without checking ifDebugEnabled(), fixing that
2010-11-11 17:20:57 -08:00
fcd7f37839
bug 7037: adding more logging to the deletepool cmd
...
status 7037: resolved fixed
2010-11-11 17:20:57 -08:00
f30d3f4839
don't break other people
2010-11-11 17:13:21 -08:00
0db9303bca
don't break others
2010-11-11 17:04:10 -08:00
8ca6f1669e
start2command fro secondarys storage vm and make it work for KVM
2010-11-11 17:04:10 -08:00
40481cfe6e
add start2command for secondarystorage vm
2010-11-11 17:04:10 -08:00
393666feea
start2command for secvm
2010-11-11 17:04:10 -08:00
0ad492cc74
bug 7118: fixed deletePod command - 1)remove Pod's resources (private ip adresses) before removing the pod itself. 2) Verify that private ip address pool is not empty before removing it.
...
status 7118: resolved fixed
2010-11-11 16:55:59 -08:00
709fc3686f
another fix for a related bug on data volumes I found whilst testing the parent bug
2010-11-11 16:39:15 -08:00
968dc0616f
bug 7021: data disk wasn't being created for custom sizes. Also, we were having max size checks in GB, whereas disk offerings are in MB. Made the change there as well.The storage allocators were commented out in master, uncommented them.
...
Status 7021: resolved fixed
2010-11-11 15:45:21 -08:00
6e0b500a83
bug 4964: made listDomainChildren work with "isRecursive" flag
...
status 4964: resolved fixed
2010-11-11 14:32:36 -08:00
05bbd35860
resolving the network manager merge conflict
2010-11-11 13:13:04 -08:00
1faaba8fb0
fixed a corner case; also changed the commands to be async and changed the method signatures to conform with the master refactor
2010-11-11 13:07:26 -08:00
239942bbe1
refactored all the commands to cater to keshav's needs, and added the new apis. the initial set of testing is complete, will now focus on corner cases
2010-11-11 13:07:26 -08:00
26b75fc05d
this is a good point to check the code in; have completed a part of the enhancement's code; with create and delete ip forwarding rule commands and the skeleton for port to rule map with associated table
2010-11-11 13:07:26 -08:00
e5ca5dddf9
renaming the ip forwarding commands to port forwarding commands, and beginning to work on Keshav's request to modify the current 1-1 NAT to be compatible with the Amazon apis
2010-11-11 13:07:26 -08:00
05ce97f918
Merged in alena's changes
2010-11-11 12:53:19 -08:00
bbdc2b22ff
commit for push
2010-11-11 12:53:19 -08:00
284720bf00
compilation errors fixed
2010-11-11 12:53:19 -08:00
94250c1330
committing to update
2010-11-11 12:53:19 -08:00
c6033baa78
system vm start and stop added
2010-11-11 12:53:19 -08:00
d091bdd886
bug 7126: return true only when assignToLoadBalancer succeeded.
...
status 7126: resolved fixed
2010-11-11 12:46:21 -08:00
86c8f86a56
bug 6192: use "ipaddress" instead of "publicip" in updatePortForwarding command
...
status 6192: resolved fixed
2010-11-11 12:12:29 -08:00
c66cb856f7
fix a bug that 3rd party software xstream-1.3.1.jar is not found.
2010-11-11 12:02:43 -08:00
5a01335002
bug 7143: vlan parameter is no longer required by createZone command
...
status 7143: resolved fixed
2010-11-11 10:43:18 -08:00
86e83bc4bd
Created new response objects for userVm/domainRouter/systemVm that going to be used by API after network refactorig is in place.
2010-11-11 10:43:18 -08:00
a69f961bd8
bug 5903: Reworked the entire UI to accomodate the new snapshot policy in 2.2.
...
- Fixed issues with deleting snapshot policies
- Fixed maxsnaps being set wrong in the DB.
2010-11-10 19:19:18 -08:00
b1194e68f7
Fixed the build
2010-11-10 10:14:08 -08:00
0597c0cf4b
bug 4177: RegisterIsoCmd and RegisterTemplateCmd API - Added account and domainId params so that one could register them on behalf of other accounts.
...
status 4177: resolved fixed
2010-11-10 17:47:59 +05:30
3954c7550a
bug 6914: return password in deployVirtualMachine/resetVmPassword response.
...
status 6914: resolved fixed
2010-11-09 11:18:54 -08:00
5fafef9970
More api refactor - build api response is execute() method instead of getResponse method.
2010-11-09 09:58:05 -08:00
3455a0f563
bug 7114: Fix NPE for updateTemplatePermissions when accessed via 8096. This was happening due to accountObj being null in User Context when accessed via 8096. Why we set it to null seems to be a hack to me.
...
status 7114: resolved fixed
2010-11-09 20:01:13 +05:30
351f98ceef
bug 5363: SNAPSHOT.CREATE - Add Started event.
...
status 5363: resolved fixed
2010-11-09 19:37:01 +05:30
8df96da0a5
don't delete template if template check fail, give user a chance to check the template manually
...
use can delete the template though UI
2010-11-08 21:03:59 -08:00
4646be7587
for recursive snapshot, use UID_SYSTEM instead
2010-11-08 18:08:08 -08:00
0febfb4938
don't reschedule manual snapshot
2010-11-08 18:08:08 -08:00
3aad88e94b
reschedule all polocies after management server restart, in case some schedules are missing
2010-11-08 18:08:08 -08:00
71a670defc
snapshot code cleanup
2010-11-08 18:08:08 -08:00
9ee6d69c9f
the default delta snapshot number between two full snapshots is 16, it is configurable
2010-11-08 18:08:07 -08:00
7262b854a5
bug 7121: made the disk offering id optional, and added a check to ensure we never have both disk offering and snapshot ids to be null
...
status 7121: resolved fixed
2010-11-08 17:59:26 -08:00
11ea13fd7d
Added the domain checker code and checks for a host of commands. This replaces the previous mechanism, and provides a way for us to validate the command executor as to whether he has access to the zone.
2010-11-08 17:50:38 -08:00
5cc496a78d
Not sure why listing of templates was using Integer instead of Long for pagesize but now correcting to keep things consistent.
2010-11-08 14:57:59 -08:00
0d27ac2e31
bug 5920: added confirmation dialog before allowing user to delete snapshots
...
- Fixed a NPE when listing templates.
2010-11-08 14:52:10 -08:00
47e365f5ea
bug 7089: return embedded object name in xml response
...
status 7089: resolved fixed
2010-11-08 13:59:14 -08:00
551e7e4b82
bug 6812: fixed default pagesize of all listXXX command to unlimited for now.
2010-11-08 13:15:02 -08:00
c8a3ea3080
merge conflict with alena's changes
2010-11-08 12:40:38 -08:00
16b6850bea
revert console proxy
2010-11-08 12:29:38 -08:00
edf9ddd464
added reservation id to vnet
2010-11-08 12:29:38 -08:00
734cd0b1b1
fixed some bugs
2010-11-08 12:29:37 -08:00
aca8ef79cd
a bunch of other changes for network refactoring
2010-11-08 12:29:37 -08:00
2be0cd6a95
stop worked again
2010-11-08 12:29:36 -08:00
cc93e7508c
refactoring old code and fixing some regression bugs (UI had an issue listing domains). Also fixed the listing of domain specific zones at vm creation for a domain admin (listing everything upto root in that domain + listing all the children based on a path search)
2010-11-08 12:17:42 -08:00
67beda5244
adding the logic to list and search zones and domains based on the user (normal,admin,domain admin)
2010-11-08 12:17:42 -08:00
1c24deda34
1) Refactored current Apis not to use reflection for method invocation. In new version following has to be done:
...
* Implement callCreate() and execute() methods in apis extending BaseAsyncCreateCmd (example - CreateVolumeCmd)
* Implement execute() method in apis extending BaseCmd and BaseAsyncCmd (example - deleteVolumeCmd and deleteUserCmd)
We no longer need createMethod(), method(), manager() fields in @Implementation annotation, cleanup has to be done.
2) Moved Account/User related methods to AccountManagerImpl. Methods are exposed via AccountService interface.
3) Enhanced exception handing for Api calls.
4) Created ConfigurationService interface, all Api config methods are exposed via it.
2010-11-08 11:27:36 -08:00
70358ac153
bug 6367: registerISO, registerTemplate and createTemplate - can create non-ascii character names.
...
status 6367: resolved fixed
2010-11-08 20:55:02 +05:30
af502b1c4c
bug 3384: listVolumes: regular user should be able to make a search by "type".
...
status 3384: resolved fixed
2010-11-08 14:46:30 +05:30
8215510c19
bug 6055: createDiskOffering: remove domainId parameter.
...
status 6055: resolved fixed
2010-11-08 13:42:34 +05:30
02781422b5
bug 6055: createDiskOffering: remove domainId parameter.
...
status 6055: resolved fixed
2010-11-08 13:41:33 +05:30
4dc8837dc8
bug 6952: listISO should return "ispublic" property.
...
status 6952: resolved fixed
2010-11-08 12:33:23 +05:30
bd5f1a7de6
Fixed NPE if addVPNUser fails because it was unable to reach the domR.
2010-11-06 16:54:14 -07:00
89c717703f
Fixed API commands that extend BaseCreateAsyncCmd to return the correct API response of id, and jobid.
...
Added the default public constructor back in the SuccessResponse to make sure deserialization works from the asyncjob table.
Fixed a issues with the VPN tab. It should now make use of the corrected API format.
2010-11-06 16:30:08 -07:00
ca0ce93fde
Fixed all sync commands that can possibly return a <success> tag. If success, it will return true, otherwise an HTTP error will be returned.
2010-11-05 21:25:19 -07:00
563b45a220
bug 7059: Fixed the async output to use the object name
2010-11-05 20:58:00 -07:00
224da7e775
several snapshot fixes
2010-11-05 20:55:19 -07:00
bcb53ec363
bug 7059: Fixing adding primary and secondary storage to use new api output.
2010-11-05 20:30:55 -07:00
a3dbc34857
bug 7059: refactored the API to now add the single embedded object tag after a response
...
- Changed networkgroups to security groups
- a whole bunch of other API bugs. Unfortunately, I may have broken more.
2010-11-05 20:10:57 -07:00
b1defdb71d
bug 6895: fixed search by id in listDomains command
...
status 6895: resolved fixed
2010-11-05 17:45:15 -07:00
05ab3bf673
bug 7063: AsyncJobResult should now return the correct success and error tags upon the completion of a async job. It should now follow either the format ... jobresult.success or jobresult.errorcode and jobresult.errortext
...
- Fixed a lot of other Async related packaging issues. It's not all done but will continue to refactor this later.
2010-11-05 17:30:03 -07:00
4555fcd73f
changed everything back so everyone can test
2010-11-05 16:10:22 -07:00
4ccf4361d1
Finally domr and instance running again.
2010-11-05 16:10:22 -07:00
5f90a8adb0
Checking in to do git pull...stupid git
2010-11-05 16:10:22 -07:00
1fe446002b
stop vm is now formalized
2010-11-05 16:10:22 -07:00
d5d1808488
Added reservation context to the network gurus
2010-11-05 16:10:22 -07:00
433c28fb16
bug 7041: fix npe in delete template from storage pool, if the template already marked as removed
...
status 7041: resolved fixed
2010-11-05 16:02:18 -07:00
e2aa4738ec
listVirtualMachine api: return "Not created" as a root volume type when volume's storage pool id is NULL
2010-11-05 16:03:37 -07:00
c0e2986766
bug 6958: return state for Account api commands
...
status 6958: resolved fixed
2010-11-05 15:48:05 -07:00
a9166929f0
Fixed NPE in listVolumes/listVirtualMachines commands - do searchIncludingRemoved when get diskOffering/serviceOffering info.
2010-11-05 14:46:08 -07:00
038a8cd59a
did not like the fact that the method was getting big; refactored my logic to a private method to increase readability
2010-11-05 14:29:52 -07:00
a99cfa58ef
bug 7045: blocking the start vm cmds for both ssvms and user vms when the sp is NOT up
...
status 7045: resolved fixed
2010-11-05 14:24:54 -07:00
111b0a1df1
bug 6943: Correct error message is returned for the parameter, "name" in the API as well as fixing JS to validate this as well.
2010-11-05 13:51:46 -07:00
452c7f4d1a
bug 7002: adding a check to ensure the account specific vlan added, is within the domain tree of the zone for which the vlan is being added for (whether it is a child domain or not)
...
status 7002: resolved fixed
2010-11-05 13:24:41 -07:00
b3c87d8f25
bug 7031 also send down when router state is Starting
...
status 7031: resolved fixed
2010-11-05 13:17:06 -07:00
3c840f910a
bug 7031 send down vpn config upon restart
2010-11-05 13:08:14 -07:00
1fe8ae4819
7004,7011: fixing the return values issue which showed the same record 2 times; also fixing the checks for deploy vm from the api layer; and also fixing the tree returned to the UI
...
status 7004,7011: resolved fixed
2010-11-05 12:10:30 -07:00
b9ad299ac6
bug 6998: return embedded job result object in queryAsyncJobResult command
...
status 6998: resolved fixed
2010-11-05 12:03:01 -07:00
1c8f42a001
add hypervisor type for iso, enforcement kvm hosts in the cluster that must have the same os type
2010-11-04 21:29:24 -07:00
b9fc4137f7
Bug 6988: Fixed issue with queryAsyncJobResult returning jobResults in all String format. This is to mirror the same way that the async commands are being serialized.
...
- Changed client.war to now include all the thirdparty files
- Fixed addVpnUser command to return a vpnuser instead of the response
- Added vmware jar files to the development build.
2010-11-04 20:56:28 -07:00
70b4c4d181
Bug 6988: addVpnUser did not camel case the "username" which resulted in that particular value not being returned.
2010-11-04 20:56:23 -07:00
bd4f3bfaa0
set guid to null when delete secondary storage
2010-11-04 20:41:40 -07:00
0b1bddb125
code realignment
2010-11-04 18:42:38 -07:00
103278415e
bug 7035: allowing cancel maintenance for all sp states except UP
...
status 7035: resolved fixed
2010-11-04 18:42:38 -07:00
364e1e1c4a
bug 7034,6869: fixing the storage pools issue, and the npe at load balancer if the router is not found.
...
status 7034, 6869: resolved fixed
2010-11-04 17:18:58 -07:00
e9bd0594bd
bug 7022: fixing the custom size for volumes bug
...
status 7022: resolved fixed
2010-11-04 15:51:33 -07:00
5695236840
bug 6984: add default value for domain.suffix
...
status 6984: resolved fixed
2010-11-04 15:40:24 -07:00
5c445bd99e
bug 6991: add presharedkey to response
...
status 6991: resolved fixed
2010-11-04 15:40:24 -07:00
03ea885dcd
making disk offering id mandatory for volume creation
2010-11-04 15:30:23 -07:00
1c7e3649d2
bug 7007: if host is added before, refused to add it
...
status 7007: resolved fixed
2010-11-04 15:03:04 -07:00
9a3d5c3ae3
forgot to throw the serverapiexception in the cancel maintenance cmd
2010-11-04 14:35:36 -07:00
52d2111ed3
bug 6972: fixing the ssl cert warning
...
status 6972: resolved fixed
2010-11-04 14:11:28 -07:00
baa28d2022
returning serverapiexceptions for prepare and cancel pool maintenance; making it consistent with other pieces of code
2010-11-04 13:40:10 -07:00
55e9378f9a
don't set state to errorinmaintenance if cancel maintenance encounters a ps with a state !=Maintenance
2010-11-04 13:35:57 -07:00
d96a1a841d
adding logic to prevent commands from being sent to the pool when it is NOT up; also adding better thread safety and db locking, along with a general refactor
2010-11-04 13:35:57 -07:00
271f5a5255
fix some unused warnings
2010-11-04 11:54:14 -07:00
8b846b07a7
fix some unused warnings"
2010-11-04 11:54:14 -07:00
6b33a98573
bug 6981: merge in stuff for bug 6807 from 2.1.x
2010-11-04 11:54:14 -07:00
8e2e04a86e
bug 6981: merge in stuff for bug 6807 from 2.1.x
2010-11-04 11:54:14 -07:00
898990a11d
fixing the npe which occurs when we list zones from 8096. this has a null account.
2010-11-04 11:36:08 -07:00
5a173ad363
bug 6932: add create private template from volume command support for KVM
...
status 6932: resolved fixed
2010-11-04 11:00:29 -07:00
89f0c455e3
fixing the vm creation issue
2010-11-04 10:47:59 -07:00
137fe40c46
fixing the zone creation bug
2010-11-04 09:47:39 -07:00
7dc7a4838a
bug 4286: Fixing the extract functionality for Upload after new API framework. Also added a check to avoid system created templates and ISO's from getting extracted as per Mike.
...
status 4286: resolved fixed
2010-11-04 19:09:38 +05:30
6dea64c63a
No clue how someone could have checked in this code since it doesn't compile. <cough> Chiradeep <cough>
2010-11-03 22:24:24 -07:00
f907e370d1
- Added the rest of the VPN UI feature with the exception of displaying the preshared key.
...
- AddVpnUserCmd will now return the embedded object.
- Fixed RemoteAccssVpnResponse to return "iprange" instead of "ipRange"
2010-11-03 22:24:22 -07:00
84ee08430a
making changes to the list zones flow, to add the domain name to the table, and return it
2010-11-03 22:08:32 -07:00
0fdca8be9a
changed back so everyone else can start the old way
2010-11-03 21:18:31 -07:00
9bb05d3ef8
harmony amongst joins
2010-11-03 21:18:31 -07:00
a0cb58aad2
Harmony amongst gurus
2010-11-03 21:18:31 -07:00
e27bb550fe
Harmony among gurus
2010-11-03 21:18:31 -07:00
8e54a40b46
fix for the ui to consume for the disk offering
2010-11-03 20:05:37 -07:00
3deb7580bb
Create Disk Offering - make disksize optional
2010-11-03 19:48:35 -07:00
d748010da3
Create Template from volume and snapshot for vmware
2010-11-03 19:18:54 -07:00
2303afe55c
making changes for disk offerings with a new column called customized being added, for the UI to cosume whilst deploying vm with an arbitrary volume size. The UI will use this value to set the right size and the offering will ensure the right tags are taken.
2010-11-03 17:45:52 -07:00
f182efc279
When starting a remote access VPN, send down all the users as well
2010-11-03 16:40:44 -07:00
2939e90d66
Build response the same way for create/list/update IPForwardingRule.
2010-11-03 15:49:51 -07:00
7674df6c7a
fixing the merge conflicts
2010-11-03 15:39:16 -07:00
46497e3aad
making changes for the private/public zones enhancement, for the UI to consume. The list method has been changed to return visible zones based on the user's credentials, or if the domainId for private zone listing is specified. In the update zone cmd, we do not allow updating private zone once it has been associated with a domain. This might change in the coming releases.
2010-11-03 15:39:16 -07:00
6bd87ca161
Return "status" field in StoragePoolResponse. Status can be Up, Maintenance, ErrorInMaintenance
2010-11-03 14:59:00 -07:00
52a8370102
bug 6955: return embedded object for PreparePrimaryStorageForMaintenance
...
status 6955: resolved fixed
2010-11-03 14:30:35 -07:00
dd5e26e701
Allow more chars in username, password
2010-11-03 14:02:13 -07:00
e1cb94831f
VPN users feature complete
2010-11-03 14:02:13 -07:00
0dd19c197b
VPN users API -- WIP
2010-11-03 14:02:13 -07:00
14613415e1
VPN users API -- WIP
2010-11-03 14:02:13 -07:00
b6d3b3c184
users for vpn -- data model
2010-11-03 14:02:12 -07:00
437ca41b27
fix sb's typo
2010-11-03 13:23:59 -07:00
f3cc113525
bug 6933: send the snapshot related command to host on which vm created for kvm
...
status 6933: resolved fixed
2010-11-03 13:03:21 -07:00
4a645cdeb0
Return embedded Volume object for create/attach/detach Volume commands.
2010-11-03 13:07:06 -07:00
15a316484e
Fixed deleteZone API - used to return empty response instead of success=true/false
2010-11-03 11:32:45 -07:00
8c0e2fa7ec
Fixed updatePod Api to return embedded object instead of "success" response
2010-11-03 11:18:51 -07:00
426e445811
bug 6904: during volume creation, we were NOT converting the size of the parent disk offering (which is in MB), to bytes. This is the size used to create the volume. I am adding the appropriate multipliers. Other flows like creating volume from snapshot etc should remain unaffected, as the parent volume created from the disk offering will be set right.
...
status 6904: resolved fixed
2010-11-03 11:13:06 -07:00
703fcaffe6
bug 5190: cosmetic changes for the final result returned back to the UI, for Will to consume
2010-11-03 11:13:05 -07:00
4fc8b7ae0b
bug 6892: do account check for disable user command
...
status 6892: resolved fixed
2010-11-03 10:31:16 -07:00
886fd4e754
More api refactoring - move response building for LoadBalancer/IpAddress commands to ApiResponseHelper.
2010-11-03 10:11:59 -07:00
ebdc1f069d
1) Return embedded Host object in PrepareForMaintenance command.
...
2) Build HostResonse object in ApiResponseHelper for add/reconnect/update/prepareForMaintenance/cancelMaintenance commands
2010-11-02 20:30:41 -07:00
abb8f45667
1) Return embedded object for upgradeRouter command
...
2) Build response objects in ApiResponseHelper for stop/start/reboot/list router/systemVm commands
2010-11-02 19:47:14 -07:00
694a8231ef
Build responses in ApiResponseHelper for the deploy/start/stop/reboot/recover/listVm create/list snapshot/snapshotPolicies
2010-11-02 18:16:45 -07:00
c6809f89d4
bug 6890: preventing users from searching for system account details via the list api
...
status 6890: resolved fixed
2010-11-02 17:59:24 -07:00
3c6b3b3e3d
Add more volume info to BackupSnapshotCommand, to generalize multi-hypervisor usage
2010-11-02 17:04:07 -07:00
473c3d33c3
bug 6870: during updating of pf rules, it is possible one might try to update a non existing rule via the api cmd. hitherto, we were returning a null which was assumed as a success by the cmd api, which failed with a npe. instead, we ought to throw back an error since we did not find any rule to be updated. i am checking in the same change. this also will fix the npe.
...
status 6870: resolved fixed
2010-11-02 16:07:15 -07:00
571ca42c44
1) Return embedded object for addCfg/updateCfg/listCfg.
...
2) Fixed NPE in updateCfg command (used to happen when no value was specified)
3) Fixed addCfg command to call correct getName method while setting config name (used to call the method returning the command name)
2010-11-02 15:26:33 -07:00
5fe5450abc
even more refactoring
2010-11-02 15:25:07 -07:00
d4b33f523d
bug 5190: changes from the ui perspective; we upload the entire cert as a string, instead of reading it from a file. Then, we process the cert via ip streams instead of fileinputstreams. Moved the cert validation to before cert persistance, and also added more logging and exception catch blocks to deal with IO exceptions that might arise out of the ip stream processing for the new change.
2010-11-02 14:48:05 -07:00
16438f3470
we should not be ignoring case whilst updating account, reverting to .equals instead of .equalsIgnoreCase
2010-11-02 13:45:10 -07:00
7354116517
bug 6888: there were multiple issues here. firstly, we were checking against null newaccountnames, whereas that field is a reqd val. Also, we were allowing the same name to exist across multiple accounts in the same domain. I have fixed both these issues.
...
status 6888: resolved fixed
2010-11-02 13:09:37 -07:00
560d7a275e
Removed InternalErrorException. Renamed the lock methods on the DAO objects to be more understandable.
2010-11-02 12:25:08 -07:00
abhishek
nit
kishan
will
anthony
Kelven Yang
alena
Alex Huang
Anthony Xu
edison
Chiradeep Vittal
Jessica Wang