Commit Graph

34293 Commits

Author SHA1 Message Date
sureshanaparti f7fdc8a974
Do remove volume only on expunge (#5213) 2021-07-17 12:01:54 +05:30
Spaceman1984 96c9c5a5e2
Added disk provisioning type support for VMWare (#4640)
* Added disk provisioning type support for VMWare

* Review changes

* Fixed unit test

* Review changes

* Added missing licenses

* Review changes

* Update StoragePoolInfo.java

Removed white space

* Review change - Getting disk provisioning strictness setting using the zone id and not the pool id

* Delete __init__.py

* Merge fix

* Fixed failing test

* Added comment about parameters

* Added error log when update fails

* Added exception when using API

* Ordering storage pool selection to prefer thick disk capable pools if available

* Removed unused parameter

* Reordering changes

* Returning storage pool details after update

* Removed multiple pool update, updated marvin test, removed duplicate enum

* Removed comment

* Removed unused import

* Removed for loop

* Added missing return statements for failed checks

* Class name change

* Null pointer

* Added more info when a deployment fails

* Null pointer

* Update api/src/main/java/org/apache/cloudstack/api/BaseListCmd.java

Co-authored-by: dahn <daan.hoogland@gmail.com>

* Small bug fix on API response and added missing bracket

* Removed datastore cluster code

* Removed unused imports, added missing signature

* Removed duplicate config key

* Revert "Added more info when a deployment fails"

This reverts commit 2486db78dc.

Co-authored-by: dahn <daan.hoogland@gmail.com>
2021-07-16 22:37:42 -03:00
Pearl Dsilva 15d3d39cb2
UI: bulk action support for various resources (#5034)
* ui: support bulk action for various resources

* ui: support bulk action for various resources

* Bulk actions support - progress review

* Extract common code + suppress error notification with bulk actions

* cleanup + suppress notification

* add progress view

* Add routes to notification + add async jobs + refactor progress view

* minor tweaks

* fix group action for vpn users

* Refactor code

* Unique row key

* remove redundant cols

* address comments

* Added the following:
1. Make Cancel as default button for bulk actions
2. Add Filter Filter on the Operation status Column - Progress View
3. For Stop and delete bulk operations - add An alert message(in Red) to inform users that it is a destructive operation

* Add dynamism to column filtering
2021-07-16 10:33:04 +02:00
Gregor Riepl ff07fee286
api: Fix deprecation of CIDR_LIST parameter (#5211)
* Revert deprecation of CIDR_LIST parameter in CreateFireWallRule

* Deprecate CIDR_LIST parameter in CreateLoadBalancerRule

* Deprecate CIDR_LIST parameter in CreateIpForwardingRule
2021-07-16 12:11:40 +05:30
Daniel Augusto Veronezi Salvador cbe380a068
Externalize secondary storage capacity threshold (#4790)
* Externalize secondary storage capacity threshold

* Use default value as threshold when config value is lower than 0.0

* Move config to CapacityManager

* Validate config in CapacityManagerImpl

* Use config in StorageOrchestrator

* Change config description

* Remove unused import

Co-authored-by: Daniel Augusto Veronezi Salvador <daniel@scclouds.com.br>
2021-07-16 08:38:36 +02:00
Abhishek Kumar 5ac184edd6 Merge remote-tracking branch 'apache/4.15' into main 2021-07-15 14:02:49 +05:30
Rohit Yadav 5228fae7b8
kvm: pre-add 32 PCI controller for hot-plug issue on ARM64 (#5193)
On newer libvirt/qemu it seems PCI hot-plugging could be an issue as
seen in:

https://www.suse.com/support/kb/doc/?id=000019383
https://bugs.launchpad.net/nova/+bug/1836065

This was found to be true on ARM64/aarch64 platform (tested on
RaspberryPi4). As per the default machine doc, it advises to
pre-allocate PCI controllers on the machine and pcie-to-pci-bridge based
controller for legacy PCI models:
https://libvirt.org/pci-hotplug.html#x86_64-q35

This patch introduces the concept as a workaround until a proper fix is
done (ideally in the upstream libvirt/qemu projects). Until then client
code can add 32 PCI controllers and a pcie-to-pci-bridge controller for
aarch64 platforms.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2021-07-15 13:15:10 +05:30
Gabriel Beims Bräscher 1d831a32a9
kvmk: KVM NFS disk IO driver supporting IO_URING (#5012)
Currently there is no disk IO driver configuration for VMs running on KVM. That's OK for most the cases; however, recently there have been added some quite interesting optimizations with the IO driver io_uring.

Note that IO URING requires:

Qemu >= 5.0, and
Libvirt >= 6.3.0.
By using io_uring we can see a massive I/O performance improvement within Virtual Machines running from Local and/or NFS storage.

This implementation enhances the KVM disk configuration by adding workflow for setting the disk IO drivers. Additionally, if the Qemu and Libvirt versions matches with the required for having io_uring we are going to set it on the VM. If there is no support for such driver we keep it as it is nowadays, without any IO driver configured.

Fixes: #4883
2021-07-15 13:02:44 +05:30
Rohit Yadav cc27c70e5f
systemvmtemplate: use latest LTS kernel from buster-ports (#5073)
* systemvmtemplate: use latest LTS kernel from buster-ports

Use the latest v5.10 Linux kernel (LTS) from buster-ports

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 2dd1650276e7fa31fc3b920b67be8396647c279d)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* Update configure_grub.sh

* changes

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* fix failing build

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

* Update install_systemvm_packages.sh
2021-07-15 13:00:51 +05:30
Abhishek Kumar e0141ab348
server: fix network access for addNicToVirtualMachine API (#5184)
New NICs shouldn't added to VM with network from admin account, same as deployment.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2021-07-15 12:57:37 +05:30
Abhishek Kumar 50a16979c5
refactor: migrate vm with storage (#5030)
* refactor: migrate with storage host capability check

Refactors Boolean HypervisorCapabilitiesDao::isStorageMotionSupported to boolean HypervisorCapabilitiesDao::isStorageMotionSupported for simplifying callers.
Refactors log messages.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* simplify

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* refactor

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* changes

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* review comments addressed

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* var rename

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2021-07-15 12:57:13 +05:30
Abhishek Kumar 757bc2d917
vmware: fix migrate vm with volume (#5170)
* vmware: fix migrate vm with volume

Recent forward merge of 4.15 branch accidentally brought a bug in VM relocation method for VMware while trying to find datastore for the migrated volume.
This PR fixes it by using either of available target or source host.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* Update plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java

Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>

* fix

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
2021-07-15 12:56:26 +05:30
Hoang Nguyen 7123269937
ui: deploy VM - FIX missing custom iops field (#5199)
Fixes #5192
2021-07-15 12:53:50 +05:30
Michael 6b5adb7ed5
ui: register vue component Descriptions (#5197) 2021-07-15 12:53:04 +05:30
Hoang Nguyen 476f77a683
ui: change `edit traffic type` form of VMware (#5178)
Fixes #5177
2021-07-15 12:51:11 +05:30
Wei Zhou cf0f1feb5e
configdrive: fix some failures in tests/component/test_configdrive.py (#5144)
* server: fix failed to apply userdata when enable static nat

* server: fix cannot expunge vm as applyUserdata fails

* configdrive: fix ISO is not recognized when plug a new nic

* configdrive: detach and attach configdrive ISO as it is changed when plug a new nic or migrate vm

* configdrive test: (1) password file does not exists in recreated ISO; (2) vm hostname should be changed after migration

* configdrive: use centos55 template with sshkey and configdrive support

* configdrive: disklabel is 'config-2' for configdrive ISO

* configdrive: use copy for configdrive ISO and move for other template/volume/iso

* configdrive: use public-keys.txt

* configdrive test: fix (1) update_template ; (2) ssh into vm by keypair
2021-07-15 12:49:37 +05:30
davidjumani f98d35d4a4
api: Ensure required parameters are not empty (#5136)
* apiserver : Ensure required parameters are not empty

* supported services are not required as they can be empty

* Removing redudndant validators
2021-07-15 12:48:24 +05:30
Abhishek Kumar 0406e27af3
ui: refactor get api params in forms (#5064)
* ui: refactor get api params in forms

Refactor code getting api params for APIs in UI forms.
Added a new util plugin in plugins.js

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2021-07-15 12:46:54 +05:30
Abhishek Kumar 041948c04f
ui: refactor labels with tooltip in forms (#5133)
* ui: refactor labels with tooltip in forms

Adds new Vue component TooltipLabel for easier re-use

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* changes

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* changes

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* changes

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* changes

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* changes

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* moved component in widgets

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* moved TooltipButton in widgets

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* missing change in previous commit

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* changes

Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>

* fix

Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>

* form improvements

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* tooltip icon class fix

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* Update ui/src/views/storage/UploadLocalVolume.vue

Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>

* Update ui/src/views/storage/CreateVolume.vue

Co-authored-by: davidjumani <dj.davidjumani1994@gmail.com>

* fix

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>
Co-authored-by: davidjumani <dj.davidjumani1994@gmail.com>
2021-07-15 12:45:38 +05:30
Pearl Dsilva 9678c7bd1e
ui: Fix traversal to domain details via domain router-link of a resource (#5182) 2021-07-13 17:37:29 -03:00
Gabriel Beims Bräscher ca78f5b386
Enhance log messages with host name (#4575)
* Enhance log messages with hostName

* Use host.toString() on most of host logs.

* Remove redundant "Host" in logs and enhance logs

* duplicated "for"

* Adopt String.format, and enhance code

* Address reviews enhancing log messages

Update server/src/main/java/com/cloud/resource/ResourceManagerImpl.java
    -- server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
    -- server/src/main/java/com/cloud/resource/RollingMaintenanceManagerImpl.java

Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>

* Fix String.format issue and change log message from debug to warn

* Fix checkstyle issue

* Fix string.format log

* Address review: enhance logs

* Enhance log of hosts in maintenance avoid list

* Remove "VM" on logs as vm.toString() already appends VM-<details>

* Add more details of the VM when postStateTransitionEvent

* Address reviewer and enhance VMInstanceVO.toString()

Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
2021-07-13 17:35:59 -03:00
Pearl Dsilva b5d75352f2
expunge vm: Allow expunging a VM in destroyed state (#5183) 2021-07-13 09:33:40 +02:00
Pearl Dsilva 2e376f2195
marvin: make deployDataCenter.py script py2/py3 compatible (#5139) 2021-07-12 22:52:47 -03:00
Gregor Riepl a8cfb77b2b
Document cidrlist parameter deprecation (#4037)
* Document cidrlist param deprecation in CreatePortForwardingRule and CreateFirewallRule

Co-authored-by: dahn <daan.hoogland@gmail.com>
2021-07-09 22:57:09 +05:30
Pearl Dsilva 3fd92502bb
Prevent starting a VM in destroyed state (or any state but Stopped) (#5165)
* Prevent starting a VM in destroyed state (or any state but Stopped)
2021-07-09 15:11:30 +05:30
Hoang Nguyen f7cc3c9316
UI - zone wizard - fix undefined property when setting RBD primary storage (#5167)
* zone wizard launch: fix undefined property RBD primary storage

* simplycode by #4956
2021-07-09 15:04:18 +05:30
Rohit Yadav 16d0795130 Merge remote-tracking branch 'origin/4.15' into main 2021-07-05 11:55:58 +05:30
Hoang Nguyen 584c1cfbe0
ui: secondary storage - Display text and change the badge color of the Read-only column (#5176)
* change badge color and display text of read-only secondary storage

* change readonly label to access

Fixes #5169
2021-07-05 11:53:38 +05:30
j-porsche 9533054599
ui: Changes of the german translation (#5173) 2021-07-05 11:53:06 +05:30
Wei Zhou f286f01516
kvm: fix VM HA on zone-wide storage pools (#5164) 2021-07-05 11:51:07 +05:30
Pearl Dsilva 665142701d
server: Fix NPE when no recipients configured for sending alerts (#5154)
* Fix NPE when no recipients configured for sending alerts

* Adding logs

* Address comments
2021-07-05 11:50:10 +05:30
Pearl Dsilva 50bf2861c0
server: Fix NPE during destroy VM (#5142) 2021-07-05 11:48:43 +05:30
Rohit Yadav 0a7dafd851 Merge remote-tracking branch 'origin/4.15' into main 2021-07-02 23:00:43 +05:30
Rohit Yadav d916e416ec Updating pom.xml version numbers for release 4.15.2.0-SNAPSHOT
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2021-07-02 22:59:07 +05:30
Rohit Yadav 337e8c7cff Tagging release 4.15.1.0 on branch 4.15.
-----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCgAdFiEEXtHhEi3F6KSkURLCSEJIIQ7j2IQFAmDZnRMACgkQSEJIIQ7j
 2ISW1BAAlD8AhSgaPiD6nDn116DJljSQrw8nDyS18ziXHyv4Ck8rRF8dvJ25fJl7
 XfN4XofpBkYftWh3v2ljyNEbdOClZUz8WFP3MDr5aPjsdZNEKOD07LVGsaMm1da1
 50gTMFT374ZnzqMaxJt1LfunMrLz7fgAhT4KQBqwZJv4SdOw3qnOkUgzi1Z88Ksz
 U7uiiV+xFnMbrHmtNylZnl3fkaXLGBQaS75OZGK7wv1bzhNLlCMbyT3iOJlOMQl7
 +nIGoc45yfbsBusx8xkUvaPPCT3WHOpQFwzbdp8dqtEJHd1D62kPUzt9uPof0LFz
 zoNbX5ghnvFA2K6PvoHuXrc9cx7kwYEOe95RW9eWbNAbVIb0WFdtoQzlyVBdwROp
 Lhp9ZsUwSO/vDrMqcMsdfdBElm3HBSKVaz4IOmAupKXFyCjxRi1vneIeeGftT5Ep
 x9+hcjGDBNLHZZb4xe0YEfThkrRjIoD83i5o7DaSq5S8hsx1jcBe1XzyhAboSUL5
 wWgsJpo0oa14XTk7WFb9ToYIilAiVikQPEMCaeYE3FFLAjXQ0mOVG+mByhTxG4gC
 tpb//D44ZSZEKTnTZ4F9ItMOyYF8o8bmt7V5kW1y+bOmE5vDW9hqFGCs5ZsPgY9e
 tpPRZ0Nl9ptqgCQbnDJ1RcLp0wv8JFrT6W6//1onLGlAztQI+fQ=
 =9Qmm
 -----END PGP SIGNATURE-----

Merge tag '4.15.1.0' into 4.15
2021-07-02 22:55:37 +05:30
Rohit Yadav 6e8c114288 Merge remote-tracking branch 'origin/4.15' into main 2021-07-02 22:54:51 +05:30
sureshanaparti f81d79da8e
Updated some offensive words in kubernetes plugin/service with inclusive words/terms. (#5171) 2021-07-02 13:18:33 +02:00
Pearl Dsilva 293dd4d8ef
volume: Fix deletion of Uploaded volumes (#5125)
Fixes issue with deletion of Uploaded volumes
2021-07-01 19:49:41 +05:30
Abhishek Kumar 5fd970d88f
db, server: refactor host_view to prevent duplicate entries (#4796)
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2021-07-01 11:00:51 -03:00
davidjumani 9ee6a57311
ui: deployvm - Add option to stay on page (#4843)
* ui: deployvm - Add option to stay on page

* Moving option to a dropdown
2021-07-01 12:28:39 +02:00
sureshanaparti 0d72886ee3
Replace the DB properties having master and slave(s), with source and replica(s) respectively, on Upgrade for inclusiveness (#5162)
Updates the DB properties (with strict / full property string search) having master and slave(s), with source and replica(s) respectively on upgrade (for inclusiveness).

Signed-off-by: Suresh Kumar Anaparti <suresh.anaparti@shapeblue.com>
2021-07-01 10:12:59 +05:30
davidjumani 4645863b25
tests: Fix test failures for Local storage and Basic zones (#5106)
tests: Fix test failures for Local storage and Basic (SG) zones

* Skip migrate vm when localstorage enabled
* Fix test_direct_download.py
* Skip test_03_create_network_domain_network_offering in basic zones
* Skip test_03_create_vpc_domain_vpc_offering in basic zones
* Skip test_01_add_primary_storage_disabled_host if localstorageenabled
2021-07-01 09:45:21 +05:30
dahn 7835c08120
tests: formatting and cleanup fixes for test_volumes (#5146)
* (auto) formatting and cleanup fixes

* ssh fail and detach in all cases

* message format and removed overcleaning

Co-authored-by: Daan Hoogland <dahn@onecht.net>
2021-06-29 13:06:08 +05:30
Rakesh 9fd38c4da0
server: Display proper names in error message (#5140)
Display the proper account and other names rather than the
uuid representation of the object
2021-06-29 13:03:31 +05:30
Wei Zhou 9ac3925936
server: list routers by healthchecksfailed (#4886)
* server: list routers by healthchecksfailed

* #4886: fix build error

* #4886: ignore global setting

Co-authored-by: Wei Zhou <weizhou@apache.org>
2021-06-29 12:52:24 +05:30
davidjumani ee2c9cead2
tests: Skip test_persistent_networks if kvm and ovs (#5128)
* tests: Skip test_persistent_networks if kvm and ovs

* Skip if any host has ovs

* addressing comments
2021-06-28 20:07:03 -03:00
Rohit Yadav 379454caae Updating pom.xml version numbers for release 4.15.1.0
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
2021-06-28 15:27:27 +05:30
Rohit Yadav f58b72f6f7 Merge remote-tracking branch 'origin/4.15' 2021-06-27 18:25:46 +05:30
DK101010 53963256d8
server: Bug/false positive success message vm start (#5148)
* add throws statement during the retry process

* Update engine/orchestration/src/main/java/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java

Co-authored-by: dahn <daan.hoogland@gmail.com>

Co-authored-by: DK101010 <dirk.klahre@itelligence.de>
Co-authored-by: dahn <daan.hoogland@gmail.com>
2021-06-27 06:40:30 +05:30
Pearl Dsilva aa809727a8
Fix configuration of ntp server list in systemVMs (#5160) 2021-06-26 18:16:36 +05:30