Commit Graph

38364 Commits

Author SHA1 Message Date
Daan Hoogland fe3dcddfa7 4.22 Health Check, please don't merge this!
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-01-28 09:00:30 +01:00
Abhishek Kumar 1b2ae13df7
ui: add cache for oslogo request using osId (#11422)
When OsLogo component is used in the items of a list having same OS type
it was causing listOsTypes API call multiple time. This change allows
caching request and response value for 30 seconds. Caching behaviour is
controlled using `useCache` flag.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-01-28 12:40:34 +05:30
Abhishek Kumar 276eb8111d
Merge remote-tracking branch 'apache/4.20' into 4.22 2026-01-28 11:32:18 +05:30
Wei Zhou 4761935145
server: add options for kvm.guest.os.machine.type (#12414) 2026-01-28 11:29:31 +05:30
Fabricio Duarte 70d4c9d1ba
Consider secondary storage selectors during cold volume migration (#10957)
The secondary storage selectors allow operators to specify, for instance, that volumes should go to a specific secondary storage A. Thus, when uploading a volume, it will always be downloaded to secondary storage A.

The cold volume migration moves volumes to a secondary storage before moving them to the destination primary storage. This process does not consider the secondary storage selectors. However, some companies want to dedicate specific secondary storages for cold migration.

To address this, this PR makes the cold volume migration process consider the secondary storage selectors.
2026-01-28 11:18:31 +05:30
Wei Zhou 2bfc9cb8eb
CKS: skip default egress policy check for vpc network offerings (#11998)
This PR fixes #11995

Steps to reproduce the issue
- create a vpc
- create a vpc tier with default offering `DefaultIsolatedNetworkOfferingForVpcNetworks`
- register CKS ISO
- create CKS on the vpc tier

expected: succeed
actual: failed with error `Kubernetes service has not been configured properly to provision Kubernetes clusters`
2026-01-28 11:17:14 +05:30
Abhishek Kumar 572aa19564
ui: show usage server restart message on usage config change (#11969)
Fixes #10853

---------

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-01-28 11:01:53 +05:30
Manoj Kumar 21d5c10850
Apply reordered ACL list to VR router (#12525)
This PR address #9398
2026-01-28 10:55:59 +05:30
cheng102e 062b98a51e
fix: clean magic value, and update if-else to switch (#8848)
* fix: clean magic value, and update if-else to switch

* fix: return the (String args[])

* review

---------

Co-authored-by: jiejc1 <jiejc1@lenovo.com>
Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
2026-01-28 10:15:11 +05:30
Edward-x dd0b863e22
sensitive information leak to log (#12018)
* sensitive information leak to log

* Update agent/src/main/java/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java
* Update core/src/main/java/com/cloud/storage/template/HttpTemplateDownloader.java
* Update engine/schema/src/main/java/com/cloud/upgrade/DatabaseCreator.java
* Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalDnsmasqResource.java
* Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalDnsmasqResource.java
* Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalKickStartPxeResource.java
* Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalPingPxeResource.java
* Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalPingPxeResource.java
* Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalPingPxeResource.java
* Update utils/src/main/java/com/cloud/utils/UriUtils.java

Co-authored-by: dahn <daan.hoogland@gmail.com>

* Update plugins/hypervisors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalKickStartPxeResource.java

Co-authored-by: Abhisar Sinha <63767682+abh1sar@users.noreply.github.com>

* Sync with 4.20 and fix conflict in BaremetalPingPxeResource

* Apply suggestions from code review

Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

---------

Co-authored-by: chenyoulong20g@ict.ac.cn <chenyoulong20g@ict.ac.cn>
Co-authored-by: dahn <daan.hoogland@gmail.com>
Co-authored-by: dahn <daan@onecht.net>
Co-authored-by: Abhisar Sinha <63767682+abh1sar@users.noreply.github.com>
Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
2026-01-28 10:11:23 +05:30
Daan Hoogland 75db42bca6 Merge branch '4.20' into 4.22 2026-01-27 15:23:23 +01:00
Wei Zhou 9dee137265
debian/control: remove python2 as dependency of build environment (#12213)
This fixes the issue that ACS cannot be packaged on Ubuntu 24.04 due to unsupported python2
verified by `apt-get build-dep .`
2026-01-27 15:39:08 +02:00
Abhishek Kumar d722c9551a
ui: fix form data double fetch/reset DeployVMFromBackup form data by ownership selection (#11706)
* ui: fix form data double fetch/reset DeployVMFromBackup form data by ownership selection

Related #11705

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

---------

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-01-27 14:46:06 +02:00
Abhisar Sinha 2056c582f1
Fix logging of forwarded IPs in logs (#11854) 2026-01-27 18:01:02 +05:30
Edward-x c0b5358d8e
fix Host Password Exposed in Command-Line Logging (#12016) 2026-01-27 12:55:40 +01:00
Manoj Kumar af9d68630f
Initialize template status='Processing' (#11970)
* Initialize template status='Processing'

* remove else block and fix the error string

* restructure if-else

* standardize register ISO response

* use enum instead of string

* fix smoke test failures

* Add Download Complete status for template
2026-01-27 13:06:52 +02:00
Pearl Dsilva ca5232778d
CKS: Use Zone MTUs when network is created at the time of CKS cluster creation (#12228) 2026-01-27 12:04:18 +01:00
Wei Zhou b6134418ea
server: do not run dhcp and dns check if VR is not provider (#12272) 2026-01-27 12:42:24 +02:00
Abhishek Kumar 5fd5b62570
server: fix remove management server (#12147)
Fixes #12137

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
2026-01-27 15:01:20 +05:30
Fabricio Duarte 0458c5328b
Consider secondary storage selectors during template synchronization (#10956)
* Consider secondary storage selectors during template synchronization

* Fix checkstyle

* Remove unused import
2026-01-27 11:05:09 +02:00
Nicolas Vazquez fce69fbfe0
VM Power state optimization (#12463)
* Publish VM Power state optimization (PowerReportMissing)

* Fix logging
2026-01-27 10:27:43 +02:00
Erik Böck cabd9a98e1
Implemented auto refresh button for VM metrics (#10900)
* added auto refresh button for vm metrics

* refactored getStartDate method and fixed auto refresh date period not being update

* switch variables from var to const
2026-01-27 09:59:12 +02:00
Abhisar Sinha ca07663718
Show backup offerings with userDrivenBackupsAllowed=false to all users (#11889) 2026-01-27 09:53:17 +02:00
Nicolas Vazquez ff0cfc9148
Add ability to filter by version for listHosts and listMgmtServers APIs (#12472)
* Add ability to filter by version for listHosts and listMgmtServers APIs

* Address review comment

* Fix listMgmtServers API
2026-01-27 12:45:46 +05:30
Vitor Hugo Homem Marzarotto f73362ae48
Fix saml bug unable to login (#10868)
* Fix check

* Adds configuration for behaviour, when SAML SSO is disabled for a user

* set default configuration value to false and rename it to enable.login.with.disabled.saml

---------

Co-authored-by: Vitor Hugo Homem Marzarotto <vitor.marzarotto@scclouds.com.br>
Co-authored-by: erikbocks <erik.bock@outlook.com>
2026-01-27 09:13:21 +02:00
GaOrtiga 128dbe2c0b
Refactor configuration SystemVMDefaultHypervisor (#8934)
* refactor configuration SystemVMDefaultHypervisor

* change variable name

---------

Co-authored-by: Gabriel <gabriel.fernandes@scclouds.com.br>
2026-01-27 10:36:59 +05:30
Bernardo De Marco Gonçalves 9b0c28c16d
fix regression in the listBackupSchedules API (#12402) 2026-01-26 15:00:53 -05:00
Pearl Dsilva 5bb5af4c48
4.20: Fix unit test failure (#12520) 2026-01-26 11:33:06 -05:00
dahn fa3dee886e
do not add disk cache mode from an empty string (#12248)
Co-authored-by: Daan Hoogland <dahn@apache.org>
2026-01-26 09:35:17 -05:00
Wei Zhou 63c8b5fc56
api/server: support deploy-as-is template as VNF template (#12499) 2026-01-26 15:23:27 +01:00
Daan Hoogland d50899427a merge forward error 2026-01-26 14:17:38 +01:00
Manoj Kumar 7536516e41
add missing label text for label.aclname (#12511) 2026-01-26 13:42:43 +01:00
Daan Hoogland edb62b490c Merge branch '4.20' into 4.22 2026-01-26 13:30:26 +01:00
Bernardo De Marco Gonçalves bbc23a7468
fix install path for systemvm templates when introducing new sec storage (#11605) 2026-01-26 14:14:40 +02:00
Edward-x 44793da58f
fix Sensitive Data Exposure Through Exception Logging in OVM Hypervis… (#12032)
* fix Sensitive Data Exposure Through Exception Logging in OVM Hypervisor Configuration

* extra ‘)’ in log.

Co-authored-by: Abhisar Sinha <63767682+abh1sar@users.noreply.github.com>

* remove non-descriptive part

Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

---------

Co-authored-by: chenyoulong20g@ict.ac.cn <chenyoulong20g@ict.ac.cn>
Co-authored-by: dahn <daan.hoogland@gmail.com>
Co-authored-by: Abhisar Sinha <63767682+abh1sar@users.noreply.github.com>
Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
2026-01-26 13:22:22 +02:00
Henrique Sato 36edd92e48
Fix snapshot physical size after migration (#12166) 2026-01-26 12:58:42 +02:00
Wei Zhou 097c3a018b
ConfigDrive: use file absolute path instead of canonical path to create ISO (#11623)
* ConfigDrive: use file absolute path instead of canonical path to create ISO

* el8: add xorrisofs as option
2026-01-26 12:56:14 +02:00
Manoj Kumar 63bdc2b990
Add log for null templateVO (#12406) 2026-01-26 12:55:55 +02:00
Rohit Yadav 315cd52fd1
snapshot: fix listSnapshots for volume which got delete and whose storage pool got deleted (#12433)
This fixes the case when the storage pool is removed as well the KVM
host and the subsequent volumes on the host. When that happened, listing
snapshots (for recovery purposes) cause NPE as the pool_id was null, but
last_pool_id for the related destroyed volume wasn't null. This adds a
fallback logic.

Signed-off-by: Rohit Yadav <rohit@yadav.cloud>
2026-01-26 12:53:47 +02:00
Manoj Kumar d010e9fcf2
Notify user if template upgrade is not required (#12483) 2026-01-26 10:33:30 +01:00
Artem Sidorenko 0958dfc138
Fix: proper permissions for systemvm template registrations on hardened systems (#12098)
Related to https://github.com/apache/cloudstack/issues/10029#issuecomment-2531599607

We have umask 0077, so cloud-install-sys-tmplt is creating by default paths like below

```
$ ls -l /mnt/secondary/template/tmpl/
total 16
drwx------. 3 root root 4096 Nov 19 13:58 1
drwxrwxrwx. 7 root root 4096 Oct 31 09:42 2
drwxrwxrwx. 3 root root 4096 Oct 30 15:59 4
drwxr-xr-x. 2 root root 4096 Oct 31 10:21 5
$ ls -l /mnt/secondary/template/tmpl/1/
total 4
drwx------. 2 root root 4096 Nov 19 13:59 3
$ ls -l /mnt/secondary/template/tmpl/1/3/
total 549848
-rw-------. 1 root root 563032576 Nov 19 13:59 d23a1e19-c563-4f69-85ca-8721cf02082c.qcow2
-rw-------. 1 root root       287 Nov 19 13:59 template.properties
```

This results to the permissions problems later on, when trying to access the image

Signed-off-by: Artem Sidorenko <artem.sidorenko@telekom.de>
2026-01-26 11:21:47 +02:00
Pearl Dsilva 4adb719570
Allow modification of user vm details if user.vm.readonly.details is empty (#10456) 2026-01-26 11:18:12 +02:00
Suresh Kumar Anaparti c8cadcb56e
NPE fix while deleting storage pool when pool has detached volumes (#12451)
* NPE fix while deleting storage pool when pool has detached volumes

* review

* unit tests

* Added log for volumes not attached to any VMs

* update filter, log and test

* updated volume dao method names returning non destroyed volumes

* build fix

---------

Co-authored-by: dahn <daan@onecht.net>
2026-01-26 10:31:14 +02:00
Suresh Kumar Anaparti 000919d6e5
Merge branch '4.20' into 4.22 2026-01-26 12:46:09 +05:30
Manoj Kumar 8db065a14e
limit iso filename to have 251 chars at max (#12430) 2026-01-23 16:34:52 +01:00
Daman Arora bce3e54a7e
improve error handling for template upload notifications (#12412)
Co-authored-by: Daman Arora <daman.arora@shapeblue.com>
2026-01-22 15:02:46 +01:00
Nicolas Vazquez 6a9835904c
Fix for zoneids parameters length on updateAPIs (#12440) 2026-01-22 14:57:46 +01:00
Nicolas Vazquez 6846619a6f
Fix update network offering domainids size limitation (#12431) 2026-01-22 14:32:46 +01:00
Vishesh d1eb2822d9
Remove redundant Exceptions from logs for vm schedules (#12428) 2026-01-22 14:29:35 +01:00
Abhisar Sinha cd5bb09d0d
Fix potential leaks in executePipedCommands (#12478) 2026-01-22 10:59:41 +01:00