etan39
/
cloudstack
mirror of https://github.com/apache/cloudstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
23,546 Commits 325 Branches 325 Tags 885 MiB
Commit Graph

23546 Commits

Author SHA1 Message Date
Hugo Trippaers 703febc64b Fix CID-1147052 Use try-with-resources to fix the leak 2014-06-03 17:20:16 +02:00
Hugo Trippaers d21a15beb2 Fix CID-1212194 Resource like dues to left-open statements and 
resultsets
 2014-06-03 16:52:58 +02:00
Hugo Trippaers a59db987f9 Fix CID-1219920 Dereference before null check 2014-06-03 16:39:32 +02:00
Rajani Karuturi fa3bbe9a19 Fixed ResouceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity 
Fixed another leak which might occur due to outer while loop.

Signed-off-by: Daan Hoogland <daan@onecht.net>
(cherry picked from commit 004e0cbf61)
 2014-06-03 15:39:28 +02:00
Rajani Karuturi 793462e5fa Fixed Resource leak (RESOURCE_LEAK) 11. overwrite_var: Overwriting "pstmt" in "pstmt = conn.prepareStatement("INSERT INTO `cloud`.`ldap_configuration`(hostname, port) VALUES(?,?)")" leaks the resource that "pstmt" refers to. 
Signed-off-by: Koushik Das <koushik@apache.org>
 2014-06-03 17:19:58 +05:30
Rajani Karuturi 2424d9a9e0 Fixed ResouceLeak on pstmtCidr in the function Upgrade430to440.moveCidrsToTheirOwnTable as reported by coverity 
Signed-off-by: Hugo Trippaers <htrippaers@schubergphilis.com>
 2014-06-03 09:09:55 +02:00
Nitin Mehta 8b6dc7ce2f CLOUDSTACK-6824: In case there is a failure to delete the soft link of a download url, dont bail out since there can be cases such as destroy ssvm where the soft links do not exist any more. 
(cherry picked from commit 7333016722)
 2014-06-02 17:55:09 -07:00
Rohit Yadav eb8e630f24 AlertGenerator: Fix NPE from CLOUDSTACK-3272 
There was a commit 4b89a45e57 on master which was
added by "root@devcloud.apache.org" with no committer signature so I cannot tell
whom to reach. In the code it looks like they forgot to initialize the static
config dao variable which is causing NPE on master. The fix simply initializes
the s_configDao with injected configDao object.

Signed-off-by: Rohit Yadav <bhaisaab@apache.org>
 2014-06-02 22:43:27 +05:30
Daan Hoogland 44012ddadf update vlan uris 
Conflicts:
	engine/schema/src/com/cloud/upgrade/dao/Upgrade430to440.java
 2014-06-02 15:57:18 +02:00
ynojima ab89eb106f CLOUDSTACK-6816 bugfix: cloudstack-setup-management make /root directory's permission 0777 improperly 2014-05-31 12:54:09 -06:00
Nitin Mehta 81d3a9e3ee CLOUDSTACK-6599: Add the column in Java upgrade path since 4.2 already has the extract template/volume columns 
(cherry picked from commit be765ce868)
 2014-05-30 14:56:05 -07:00
Nitin Mehta 5393387bbd CLOUDSTACK-6599: 
1. Adding the missing Template/Volume URLs expiration functionality
2. Improvement - While deleting the volume during expiration use rm -rf as vmware now contains directoy
3. Improvement - Use standard Answer so that the error gets logged in case deletion of expiration link didnt work fine.
4. Improvement - In case of domain change, expire the old urls
 2014-05-30 10:48:42 -07:00
Rajani Karuturi bdde5335f9 FIXED CLOUDSTACK-6669 Support volume resize in usage server 2014-05-30 15:03:02 +05:30
Rajani Karuturi dbd05e3ff5 FIXED CLOUDSTACK-6808 Need to add Database Information to Alter table statements in a commit to schema-430to440.sql 2014-05-30 15:02:18 +05:30
Devdeep Singh 7c2b1deb34 CLOUDSTACK-6810: Fix storage migration of a vm with volume on local was failing. When a plan 
with hostid included was passed to the local storage pool allocator, it returned all the local
storage pools in the cluster, instead of just the local pool on the given host in the plan.
This was happening the search at a host level was happening only for data disk. Fixed this.
Additionally, the query to list the storage pools on a host was failing if the pool did have
tags. Fixed the query too.

CLOUDSTACK-6802: Fix for not being able to attach data disk on local. This issue gets fixed
with the above issue too. The query to list pools on a host was failing if there were no
tags on the storage pool.
 2014-05-30 14:46:39 +05:30
Brian Federle 0b5163f8cf Tree view: Add event hook on sub-item removal 2014-05-29 14:02:47 -07:00
Jessica Wang 9f4d464640 CLOUDSTACK-6805: UI > create account > fix a bug that account creation failed when password contains # character. 2014-05-29 12:58:47 -07:00
Brian Federle e656fd67a0 Tree view: Add event hook on sub-item creation 2014-05-29 12:53:36 -07:00
Hiroki Ohashi 3256e88623 Allow usaage reporting on removed service offering 2014-05-29 19:12:11 +02:00
monism cdf4047ce8 CLOUDSTACK-6282-Added Autometed test for network APIs after incorporating review comments 2014-05-29 18:03:12 +05:30
Upendra Moturi e9af5f44ae CLOUDSTACK-6223. removeNicFromVirtualMachine fails if another instance in another domain has a nic with the same ip and a forwarding rule configured on it 
Signed-off-by: Daan Hoogland <daan@onecht.net>
 2014-05-29 10:18:41 +02:00
Gaurav Aradhye b105a33e0c CLOUDSTACK-6782: Egress FW rules test cases - Format unicode to string before string matching 2014-05-29 11:10:20 +05:30
Brian Federle 8a6926606e Treeview widget: Fix condition where browser is not present 2014-05-28 14:55:37 -07:00
Marcus Sorensen 15ac47e47b CLOUDSTACK-6088: Check first bytes of template when downloading to verify format/type 2014-05-28 15:40:57 -06:00
Brian Federle 53ba037f86 Detail view: Fix case where view all link referenced wrong details object 2014-05-28 11:41:51 -07:00
Damodar Reddy 8a210b50fb CLOUDSTACK-6702: Move all titles and descriptions to a property file or move to build properties 
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
 2014-05-28 16:10:42 +05:30
Wido den Hollander 84cfb47281 kvm: Use getStoragePool after createStoragePool when we create a libvirt pool 
This removes some redundant code
 2014-05-28 10:34:20 +02:00
rayeesn 5f11c2e0be CLOUDSTACK-6392: system template always create with name master instead of specific branch 
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
 2014-05-28 11:35:57 +05:30
Abhinandan Prateek 9cd6c4f2ae Revert "CLOUDSTACK-6781: Disabling failing test corresponding to this bug" 
This reverts commit 7bc7377a17.
 2014-05-28 10:50:32 +05:30
Rajani Karuturi b0c797c628 FIXED CLOUDSTACK-6781 [Automation] integration.smoke.test_portable_publicip.TestPortablePublicIPRange.test_createPortablePublicIPRange failing on 4.4 
Signed-off-by: Abhinandan Prateek <aprateek@apache.org>
 2014-05-28 10:46:55 +05:30
Marcus Sorensen 7ce3034299 CLOUDSTACK-6790: Disable PXE ROM for system vm nics 2014-05-27 16:52:26 -06:00
Jessica Wang 021a604493 CLOUDSTACK-6789: UI > User page > fix a bug that a domain-admin was unable to delete other domain-admin in the same domain. 2014-05-27 15:45:53 -07:00
Marcus Sorensen f3a0d257b8 CLOUDSTACK-6788: Add agent property to optionally disable kvmclock on guests 2014-05-27 16:16:41 -06:00
Nitin Mehta a8140ff58c CLOUDSTACK-6787: Event Bus - uuids missing in some cases due to various reasons 2014-05-27 15:07:38 -07:00
Marcus Sorensen 20a31b43d6 CLOUDSTACK-6784: Expose data types via API so consumers of API can validate data 2014-05-27 15:23:23 -06:00
Marcus Sorensen 96055058b0 CLOUDSTACK-6785: changed async job param injectedjobid to customjobid and check for unique/uuid 2014-05-27 15:23:12 -06:00
Marcus Sorensen 2a5bf65c78 CLOUDSTACK-6785: Allow async jobs to supply an injectedjobid 2014-05-27 15:23:02 -06:00
rayeesn d0c249bc9e updating cloud-usage.rc file to start cloudstack-usage server with java 1.7 2014-05-27 14:04:38 -07:00
Marcus Sorensen 57110a7f50 Fix devcloud-kvm gateway ip, was somehow pointing to the vmware cfg setting 2014-05-27 13:11:08 -06:00
Jessica Wang af8e83b410 CLOUDSTACK-6744 > UI > zone wizard > baremetal hypervisor > support EIP ELB feature. 
This reverts commit d36c731f79.
 2014-05-27 11:41:11 -07:00
Koushik Das 7bc7377a17 CLOUDSTACK-6781: Disabling failing test corresponding to this bug 
Once the bug is fixed this needs to be enabled back
 2014-05-27 20:37:52 +05:30
Wido den Hollander 48899e4c81 CLOUDSTACK-6783: Return a proper LibvirtStoragePool object after creating the pool 
In situations where libvirt lost the storage pool the KVM Agent will re-create the
storage pool in libvirt.

This could be then libvirt is restarted for example.

The object returned internally was missing essential information like the sourceDir
aka the Ceph pool, the monitor IPs, cephx information and such.

In this case the first operation on this newly created pool would fail. All operations
afterwards would succeed.
 2014-05-27 16:21:07 +02:00
Jayapal d093a8a7b4 CLOUDSTACK-6328: added license header and removed white space 2014-05-27 15:56:47 +05:30
Saurav Lahiri 96b1c6bf3c CLOUDSTACK-6328: run.sh check if an existing java process is running, before spawining new ones 
Signed-off-by: Jayapal <jayapal@apache.org>
 2014-05-27 15:56:25 +05:30
Wido den Hollander 6f244f3eac tools: Various fixes to set guest sshkeys script 
The script would for example overwrite all existing keys in the
authorized_keys file

Some things in the bash script are also simplified
 2014-05-27 12:17:45 +02:00
Wido den Hollander 37874a3fa8 tools: Various fixes to password set script 
The exit status of wget was not checked properly since it would
check the exit status of the 'echo' command.

Also fix some indentation in the script and remove whitespace
 2014-05-27 12:17:45 +02:00
Jayapal 19668713ed CLOUDSTACK-6761: Fixed removing proxy arp rule on deleting static nat or PF rule on ip 
The proxy-arp add/del is done on firewall rule add/del.
 The proxy-arp rule is deleted only when there is no static nat or dest nat rule is not using the ip.

 When there is static nat or PF and firewall rule
   a. Delete firewall rule. It skips delete proxy-arp because the rule is used by static nat rule.
   b. After deleting fw rule if we disable static nat there is no way to delete proxy-arp rule.

   On VM expunge we are deleting firewall rules first then static nat rules. This caused the stale proxy-arp
   rules.

   With this fix adding/deleting proxy arp rule on static nat/PF rule add/del.
 2014-05-27 15:13:54 +05:30
Gaurav Aradhye 0cc826aa53 CLOUDSTACK-5342: Fix for failure in adding network to VM 2014-05-27 14:44:59 +05:30
Gaurav Aradhye fa05cfbc78 CLOUDSTACK-6764: Marvin - Accomodating networkid parameter while deploying VM in advanced zone and account contains mor than one network 2014-05-27 14:41:59 +05:30
Gaurav Aradhye 3e3dc73271 CLOUDSTACK-6726: Fixing BVT test case test_network.py 2014-05-27 14:37:07 +05:30